[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -104,3 +124,27 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message(self): +source = "main.cpp" +program = self.get

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -104,3 +124,27 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message(self): +source = "main.cpp" +program = self.get

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/walter-erquinigo approved this pull request. lgtm. Thank you! I've wanted this feature for a while, tbh, because the user doesn't know if the program terminated successfully or if the debugger crashed. https://github.com/llvm/llvm-project/pull/89405 _

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/73393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

walter-erquinigo wrote: @semensanyok, I've just merged this PR because it's very straightforward. If it breaks the buildbots, I'll just revert it and let the original author fix it. https://github.com/llvm/llvm-project/pull/73393 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb-dap] Fix test_exit_status_message_sigterm test. (PR #90223)

walter-erquinigo wrote: What about trying to use a python builtin like https://docs.python.org/3/library/multiprocessing.html#multiprocessing.active_children? https://github.com/llvm/llvm-project/pull/90223 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] [lldb-dap] Fix test_exit_status_message_sigterm test. (PR #90223)

walter-erquinigo wrote: @JDevlieghere , do you know if it's possible to add python dependencies somewhere for lldb tests? https://github.com/llvm/llvm-project/pull/90223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

https://github.com/walter-erquinigo approved this pull request. lgtm. It would be nice if new UI features could be added in the typescript code of lldb-dap, so that all users benefit from them. https://github.com/llvm/llvm-project/pull/90799 ___ lldb-

[Lldb-commits] [lldb] [lldb-dap] Don't fail when SBProcess::GetMemoryRegionInfo returns error. (PR #87649)

https://github.com/walter-erquinigo approved this pull request. makes sense to me https://github.com/llvm/llvm-project/pull/87649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix dap variable value format issue (PR #90799)

walter-erquinigo wrote: I thought you were meaning UI changes via the fblldb extension, but if you are modying your fork of VSCode, there's nothing to be done then. https://github.com/llvm/llvm-project/pull/90799 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb-dap] Fix a race during shutdown (PR #91591)

https://github.com/walter-erquinigo approved this pull request. This all makes sense to me. Thank you! https://github.com/llvm/llvm-project/pull/91591 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb] Allow env override for LLDB_ARGDUMPER_PATH (PR #91688)

https://github.com/walter-erquinigo approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/91688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2ea3c8a - [formatters] Add a deque formatter for libstdcpp and fix the libcxx one

Author: Walter Erquinigo Date: 2021-12-06T13:42:03-08:00 New Revision: 2ea3c8a50add5436cf939d59c3235408ca0255c1 URL: https://github.com/llvm/llvm-project/commit/2ea3c8a50add5436cf939d59c3235408ca0255c1 DIFF: https://github.com/llvm/llvm-project/commit/2ea3c8a50add5436cf939d59c3235408ca0255c1.di

[Lldb-commits] [lldb] 6622c14 - [formatters] Add a pointer and reference tests for a list and forward_list formatters for libstdcpp and libcxx

Author: Danil Stefaniuc Date: 2021-12-06T13:42:03-08:00 New Revision: 6622c1411339488aa086704ac3fad3b040604dff URL: https://github.com/llvm/llvm-project/commit/6622c1411339488aa086704ac3fad3b040604dff DIFF: https://github.com/llvm/llvm-project/commit/6622c1411339488aa086704ac3fad3b040604dff.dif

[Lldb-commits] [lldb] cfb0750 - Unify libstdcpp and libcxx formatters for `std::optional`

Author: Alisamar Husain Date: 2021-12-09T13:10:43-08:00 New Revision: cfb075089128b2e5918afd0ce21ec10bf455e5ab URL: https://github.com/llvm/llvm-project/commit/cfb075089128b2e5918afd0ce21ec10bf455e5ab DIFF: https://github.com/llvm/llvm-project/commit/cfb075089128b2e5918afd0ce21ec10bf455e5ab.dif

[Lldb-commits] [lldb] 69c8e64 - [formatters] Improve documentation

Author: Walter Erquinigo Date: 2022-01-07T16:27:03-08:00 New Revision: 69c8e64ba6be090d25657ca0fc2bc53797907837 URL: https://github.com/llvm/llvm-project/commit/69c8e64ba6be090d25657ca0fc2bc53797907837 DIFF: https://github.com/llvm/llvm-project/commit/69c8e64ba6be090d25657ca0fc2bc53797907837.di

[Lldb-commits] [lldb] 1f53dd1 - [CODE OWNERS] Add wallace as code owner

Author: Walter Erquinigo Date: 2022-01-12T12:36:30-08:00 New Revision: 1f53dd1f23870a27123c50f4fe955e9c31a19634 URL: https://github.com/llvm/llvm-project/commit/1f53dd1f23870a27123c50f4fe955e9c31a19634 DIFF: https://github.com/llvm/llvm-project/commit/1f53dd1f23870a27123c50f4fe955e9c31a19634.di

[Lldb-commits] [lldb] b8dcd0b - [NFC][lldb][trace] Rename trace session to trace bundle

Author: Walter Erquinigo Date: 2022-06-24T08:41:33-07:00 New Revision: b8dcd0ba26a90166cc76e6d1db23b88656610b2e URL: https://github.com/llvm/llvm-project/commit/b8dcd0ba26a90166cc76e6d1db23b88656610b2e DIFF: https://github.com/llvm/llvm-project/commit/b8dcd0ba26a90166cc76e6d1db23b88656610b2e.di

[Lldb-commits] [lldb] f91d828 - [trace] Improve the TraceCursor iteration API

Author: Walter Erquinigo Date: 2022-06-28T16:50:12-07:00 New Revision: f91d82816ff5a88a59e86b54a4d63547776d4854 URL: https://github.com/llvm/llvm-project/commit/f91d82816ff5a88a59e86b54a4d63547776d4854 DIFF: https://github.com/llvm/llvm-project/commit/f91d82816ff5a88a59e86b54a4d63547776d4854.di

[Lldb-commits] [lldb] 6564ca1 - [trace] Fix errors when handling command arguments

Author: Walter Erquinigo Date: 2022-06-28T17:54:30-07:00 New Revision: 6564ca188a122c79c36ad7e4b3d362fb22fbd0b5 URL: https://github.com/llvm/llvm-project/commit/6564ca188a122c79c36ad7e4b3d362fb22fbd0b5 DIFF: https://github.com/llvm/llvm-project/commit/6564ca188a122c79c36ad7e4b3d362fb22fbd0b5.di

[Lldb-commits] [lldb] a3ec54c - [lldb] Fix unused variable warning in TraceHTR (NFC)

Author: Kevin Cadieux Date: 2022-06-29T21:29:50-07:00 New Revision: a3ec54c660755f9aae5eeb10e662e79f98437670 URL: https://github.com/llvm/llvm-project/commit/a3ec54c660755f9aae5eeb10e662e79f98437670 DIFF: https://github.com/llvm/llvm-project/commit/a3ec54c660755f9aae5eeb10e662e79f98437670.diff

[Lldb-commits] [lldb] ad7bcda - [trace] Add a flag to the decoder to output the instruction type

Author: Walter Erquinigo Date: 2022-07-12T16:23:03-07:00 New Revision: ad7bcda9402d4473c12461a76a2bc27a600a8001 URL: https://github.com/llvm/llvm-project/commit/ad7bcda9402d4473c12461a76a2bc27a600a8001 DIFF: https://github.com/llvm/llvm-project/commit/ad7bcda9402d4473c12461a76a2bc27a600a8001.di

[Lldb-commits] [lldb] dbc0cb0 - [trace] Avoid a crash in the dumper when disassembling fails

Author: Walter Erquinigo Date: 2022-07-12T16:23:03-07:00 New Revision: dbc0cb0198129fbded7ff3be5d080cd12ad91783 URL: https://github.com/llvm/llvm-project/commit/dbc0cb0198129fbded7ff3be5d080cd12ad91783 DIFF: https://github.com/llvm/llvm-project/commit/dbc0cb0198129fbded7ff3be5d080cd12ad91783.di

[Lldb-commits] [lldb] db73a52 - [trace][intel pt] Add a nice parser for the trace size

Author: rnofenko Date: 2022-07-13T10:53:14-07:00 New Revision: db73a52d7b19249670c9cf169c0535b36f388496 URL: https://github.com/llvm/llvm-project/commit/db73a52d7b19249670c9cf169c0535b36f388496 DIFF: https://github.com/llvm/llvm-project/commit/db73a52d7b19249670c9cf169c0535b36f388496.diff LOG:

[Lldb-commits] [lldb] 9f9464e - [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode

Author: Peicong Wu Date: 2022-07-13T11:08:14-07:00 New Revision: 9f9464e02adaeb0a56211db35e8d22929ef3191f URL: https://github.com/llvm/llvm-project/commit/9f9464e02adaeb0a56211db35e8d22929ef3191f DIFF: https://github.com/llvm/llvm-project/commit/9f9464e02adaeb0a56211db35e8d22929ef3191f.diff LO

[Lldb-commits] [lldb] b532dd5 - [trace] Add an option to save a compact trace bundle

Author: Walter Erquinigo Date: 2022-07-13T11:43:28-07:00 New Revision: b532dd545fcd03562b324d99eb28523f8510e821 URL: https://github.com/llvm/llvm-project/commit/b532dd545fcd03562b324d99eb28523f8510e821 DIFF: https://github.com/llvm/llvm-project/commit/b532dd545fcd03562b324d99eb28523f8510e821.di

[Lldb-commits] [lldb] 4a843d9 - [trace][intel pt] Create a CPU change event and expose it in the dumper

Author: Walter Erquinigo Date: 2022-07-13T12:26:11-07:00 New Revision: 4a843d9282754b1c96c8d9fcbbbe45f000b42452 URL: https://github.com/llvm/llvm-project/commit/4a843d9282754b1c96c8d9fcbbbe45f000b42452 DIFF: https://github.com/llvm/llvm-project/commit/4a843d9282754b1c96c8d9fcbbbe45f000b42452.di

[Lldb-commits] [lldb] d30fd5c - [trace][intel pt] Add a cgroup filter

Author: Gaurav Gaur Date: 2022-07-13T12:26:11-07:00 New Revision: d30fd5c3a17b5b8301e3413ae9b398ca7ee1f69c URL: https://github.com/llvm/llvm-project/commit/d30fd5c3a17b5b8301e3413ae9b398ca7ee1f69c DIFF: https://github.com/llvm/llvm-project/commit/d30fd5c3a17b5b8301e3413ae9b398ca7ee1f69c.diff L

[Lldb-commits] [lldb] 0466d1d - [trace][intel pt] Support dumping the trace info in json

Author: ymeng Date: 2022-07-13T12:26:11-07:00 New Revision: 0466d1df23b9157144c32e03f6477ed250991215 URL: https://github.com/llvm/llvm-project/commit/0466d1df23b9157144c32e03f6477ed250991215 DIFF: https://github.com/llvm/llvm-project/commit/0466d1df23b9157144c32e03f6477ed250991215.diff LOG: [t

[Lldb-commits] [lldb] 4f676c2 - [trace][intel pt] Introduce wall clock time for each trace item

Author: Walter Erquinigo Date: 2022-07-26T12:05:23-07:00 New Revision: 4f676c2599eb9c5c57528ebad93269a9ee30d7ca URL: https://github.com/llvm/llvm-project/commit/4f676c2599eb9c5c57528ebad93269a9ee30d7ca DIFF: https://github.com/llvm/llvm-project/commit/4f676c2599eb9c5c57528ebad93269a9ee30d7ca.di

[Lldb-commits] [lldb] 0538e54 - Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

Author: Walter Erquinigo Date: 2022-07-26T12:05:23-07:00 New Revision: 0538e5431afdb1fa05bdcedf70ee502ccfcd112a URL: https://github.com/llvm/llvm-project/commit/0538e5431afdb1fa05bdcedf70ee502ccfcd112a DIFF: https://github.com/llvm/llvm-project/commit/0538e5431afdb1fa05bdcedf70ee502ccfcd112a.di

[Lldb-commits] [lldb] d8602bc - fix f9b4ea0ce9efb4132a75551c40b2efc049e5b9f7

Author: Walter Erquinigo Date: 2022-08-02T19:23:28-07:00 New Revision: d8602bcdfa653d1beef1070a8ce7bb8a77bb316e URL: https://github.com/llvm/llvm-project/commit/d8602bcdfa653d1beef1070a8ce7bb8a77bb316e DIFF: https://github.com/llvm/llvm-project/commit/d8602bcdfa653d1beef1070a8ce7bb8a77bb316e.di

[Lldb-commits] [lldb] d179ea1 - [NFC][trace] format source files

Author: Walter Erquinigo Date: 2022-08-02T21:16:31-07:00 New Revision: d179ea12fd3186690cb9c630be03ab98b42c5448 URL: https://github.com/llvm/llvm-project/commit/d179ea12fd3186690cb9c630be03ab98b42c5448 DIFF: https://github.com/llvm/llvm-project/commit/d179ea12fd3186690cb9c630be03ab98b42c5448.di

[Lldb-commits] [lldb] 3716107 - [NFC][intel pt] Improve troubleshooting message

Author: Walter Erquinigo Date: 2022-08-03T11:34:03-07:00 New Revision: 371610793491fcd1c9af114a0de0cdda9a4408b0 URL: https://github.com/llvm/llvm-project/commit/371610793491fcd1c9af114a0de0cdda9a4408b0 DIFF: https://github.com/llvm/llvm-project/commit/371610793491fcd1c9af114a0de0cdda9a4408b0.di

[Lldb-commits] [lldb] 6fb744b - [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

Author: Walter Erquinigo Date: 2022-08-04T17:15:08-07:00 New Revision: 6fb744be76704f075a4edc753916e0e475d10f20 URL: https://github.com/llvm/llvm-project/commit/6fb744be76704f075a4edc753916e0e475d10f20 DIFF: https://github.com/llvm/llvm-project/commit/6fb744be76704f075a4edc753916e0e475d10f20.di

[Lldb-commits] [lldb] ddd576a - [lldb] Prevent race condition when fetching /proc/cpuinfo

Author: Walter Erquinigo Date: 2022-08-08T12:31:42-07:00 New Revision: ddd576ab87a16eb7fb06531da8040ac2ece0c9a3 URL: https://github.com/llvm/llvm-project/commit/ddd576ab87a16eb7fb06531da8040ac2ece0c9a3 DIFF: https://github.com/llvm/llvm-project/commit/ddd576ab87a16eb7fb06531da8040ac2ece0c9a3.di

[Lldb-commits] [lldb] c4fb631 - [NFC][lldb][trace] Fix formatting of tracing files

Author: Walter Erquinigo Date: 2022-08-11T11:00:26-07:00 New Revision: c4fb631ceeeff2a292cc9cf5232b491afe09744d URL: https://github.com/llvm/llvm-project/commit/c4fb631ceeeff2a292cc9cf5232b491afe09744d DIFF: https://github.com/llvm/llvm-project/commit/c4fb631ceeeff2a292cc9cf5232b491afe09744d.di

[Lldb-commits] [lldb] e17cae0 - [trace][intel pt] Fix per-psb packet decoding

Author: Walter Erquinigo Date: 2022-08-12T15:13:48-07:00 New Revision: e17cae076c4727b99017927c3e8746db5bec6db7 URL: https://github.com/llvm/llvm-project/commit/e17cae076c4727b99017927c3e8746db5bec6db7 DIFF: https://github.com/llvm/llvm-project/commit/e17cae076c4727b99017927c3e8746db5bec6db7.di

[Lldb-commits] [lldb] 4025a8a - [NFC][trace][intel pt] add simple documentation line

Author: Walter Erquinigo Date: 2022-08-15T00:56:12-07:00 New Revision: 4025a8ae934f77ec21558c40aa82937bfe74a7c3 URL: https://github.com/llvm/llvm-project/commit/4025a8ae934f77ec21558c40aa82937bfe74a7c3 DIFF: https://github.com/llvm/llvm-project/commit/4025a8ae934f77ec21558c40aa82937bfe74a7c3.di

[Lldb-commits] [lldb] [llvm] [lldb] Add LLDB_BUG_REPORT_URL macro to allow a different URL for lldb bug reporting. (PR #78210)

walter-erquinigo wrote: nice! https://github.com/llvm/llvm-project/pull/78210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/78005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() { return llvm::json::Value(std::move(scopes)); } -ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, - std::string &text) { +static std::string

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -395,43 +402,56 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, case ReplMode::Command: return ExpressionContext::Command; case ReplMode::Auto: -// If the frame is invalid then there is no variables to complete, assume -// this is an

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

https://github.com/walter-erquinigo commented: This makes a lot of sense. Just a few comments https://github.com/llvm/llvm-project/pull/78005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -380,12 +380,19 @@ llvm::json::Value DAP::CreateTopLevelScopes() { return llvm::json::Value(std::move(scopes)); } -ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame &frame, - std::string &text) { +static std::string

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/78005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/78005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

@@ -1125,21 +1126,33 @@ void request_completions(const llvm::json::Object &request) { } llvm::json::Array targets; - if (g_dap.DetectExpressionContext(frame, text) == - ExpressionContext::Variable) { -char command[] = "expression -- "; -text = command + text

[Lldb-commits] [lldb] [lldb-dap] Add a CMake variable for defining a welcome message (PR #78811)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/78811 lldb-dap instances managed by other extensions benefit from having a welcome message with, for example, a basic user guide or a troubleshooting message. This PR adds a cmake variable for defining such me

[Lldb-commits] [lldb] [lldb-dap] Add a CMake variable for defining a welcome message (PR #78811)

walter-erquinigo wrote: Merging this innocuous PR very quickly due to time constraints, but very happy to apply any feedback in a subsequent PR. https://github.com/llvm/llvm-project/pull/78811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Add a CMake variable for defining a welcome message (PR #78811)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/78811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add a CMake variable for defining a welcome message (PR #78811)

@@ -655,6 +663,8 @@ void request_attach(const llvm::json::Object &request) { g_dap.SetFrameFormat(GetString(arguments, "customFrameFormat")); g_dap.SetThreadFormat(GetString(arguments, "customThreadFormat")); + PrintWelcomeMessage(); walter-erquinigo wrot

[Lldb-commits] [lldb] [lldb-dap] Add a CMake variable for defining a welcome message (PR #78811)

@@ -664,7 +674,7 @@ void request_attach(const llvm::json::Object &request) { // Run any initialize LLDB commands the user specified in the launch.json if (llvm::Error err = g_dap.RunInitCommands()) { -response["success"] = false; + response["success"] = false;

[Lldb-commits] [lldb] [lldb] Include SBFormat.h in LLDB.h (PR #79194)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/79194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [WIP][lldb-dap] Add support for data breakpoint. (PR #81541)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/81541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [WIP][lldb-dap] Add support for data breakpoint. (PR #81541)

https://github.com/walter-erquinigo commented: This looks great overall! Could you split this PR into two? One with the refactoring and another one with the new features? That would make reviewing easier https://github.com/llvm/llvm-project/pull/81541 ___

[Lldb-commits] [lldb] [llvm] [WIP][lldb-dap] Add support for data breakpoint. (PR #81541)

@@ -895,6 +906,32 @@ def request_setFunctionBreakpoints(self, names, condition=None, hitCondition=Non } return self.send_recv(command_dict) +def request_dataBreakpointInfo(self, variablesReference, name): +args_dict = {"variablesReference": variabl

[Lldb-commits] [lldb] [llvm] [lldb-dap][NFC] Add Breakpoint struct to share common logic. (PR #80753)

https://github.com/walter-erquinigo approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/80753 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [WIP][lldb-dap] Add support for data breakpoint. (PR #81541)

walter-erquinigo wrote: just ping me when this PR is rebased https://github.com/llvm/llvm-project/pull/81541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/81541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

https://github.com/walter-erquinigo commented: Amazing stuff! I've been wanting this for a while. I left some minor comments. https://github.com/llvm/llvm-project/pull/81541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

@@ -2591,6 +2594,248 @@ void request_setFunctionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "DataBreakpointInfoRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +/

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

@@ -2591,6 +2594,248 @@ void request_setFunctionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "DataBreakpointInfoRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +/

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/81541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb-dap] Add support for data breakpoint. (PR #81541)

walter-erquinigo wrote: I think using @ is fine, but we can revisit it later if we see any issues. https://github.com/llvm/llvm-project/pull/81541 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] b7d525a - [trace][intelpt] fix some test failures

Author: Walter Erquinigo Date: 2022-03-18T10:35:34-07:00 New Revision: b7d525ad38a9378c1669a22b9f92e5548db9b409 URL: https://github.com/llvm/llvm-project/commit/b7d525ad38a9378c1669a22b9f92e5548db9b409 DIFF: https://github.com/llvm/llvm-project/commit/b7d525ad38a9378c1669a22b9f92e5548db9b409.di

[Lldb-commits] [lldb] 15c2d9c - [simple] fix formatting in the intel-pt doc

Author: Walter Erquinigo Date: 2022-03-21T15:56:55-07:00 New Revision: 15c2d9cd790cac143fdd2a206304d245d65fb4e1 URL: https://github.com/llvm/llvm-project/commit/15c2d9cd790cac143fdd2a206304d245d65fb4e1 DIFF: https://github.com/llvm/llvm-project/commit/15c2d9cd790cac143fdd2a206304d245d65fb4e1.di

[Lldb-commits] [lldb] 31e44c0 - [trace] Use vector instead of ArrayRef when reading data

Author: Walter Erquinigo Date: 2022-03-21T16:03:37-07:00 New Revision: 31e44c01e3b5cc2cc7a9f1dc49806b3f050efb82 URL: https://github.com/llvm/llvm-project/commit/31e44c01e3b5cc2cc7a9f1dc49806b3f050efb82 DIFF: https://github.com/llvm/llvm-project/commit/31e44c01e3b5cc2cc7a9f1dc49806b3f050efb82.di

[Lldb-commits] [lldb] a80c6c7 - [trace] clear any existing tracing sessions before relaunching the binary

Author: Walter Erquinigo Date: 2022-03-21T16:03:37-07:00 New Revision: a80c6c7d36d25999a28cfad32e1f461db95ba4dc URL: https://github.com/llvm/llvm-project/commit/a80c6c7d36d25999a28cfad32e1f461db95ba4dc DIFF: https://github.com/llvm/llvm-project/commit/a80c6c7d36d25999a28cfad32e1f461db95ba4dc.di

[Lldb-commits] [lldb] bcf1978 - [intelpt] Refactoring instruction decoding for flexibility

Author: Alisamar Husain Date: 2022-03-26T11:34:47-07:00 New Revision: bcf1978a871535e297c965195afe467134164413 URL: https://github.com/llvm/llvm-project/commit/bcf1978a871535e297c965195afe467134164413 DIFF: https://github.com/llvm/llvm-project/commit/bcf1978a871535e297c965195afe467134164413.dif

[Lldb-commits] [lldb] 1e5083a - [trace][intel pt] Handle better tsc in the decoder

Author: Walter Erquinigo Date: 2022-04-02T11:06:26-07:00 New Revision: 1e5083a563f8aca294feda60dcb4a814623ba321 URL: https://github.com/llvm/llvm-project/commit/1e5083a563f8aca294feda60dcb4a814623ba321 DIFF: https://github.com/llvm/llvm-project/commit/1e5083a563f8aca294feda60dcb4a814623ba321.di

[Lldb-commits] [lldb] 9bcaf6d - [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

Author: Walter Erquinigo Date: 2022-04-05T11:54:03-07:00 New Revision: 9bcaf6ddfe34943e6ae6a319097524c117908913 URL: https://github.com/llvm/llvm-project/commit/9bcaf6ddfe34943e6ae6a319097524c117908913 DIFF: https://github.com/llvm/llvm-project/commit/9bcaf6ddfe34943e6ae6a319097524c117908913.di

[Lldb-commits] [lldb] 05b4bf2 - [trace][intelpt] Introduce instruction Ids

Author: Walter Erquinigo Date: 2022-04-06T12:19:36-07:00 New Revision: 05b4bf2571244da2cef438e907036b35a0e1f99a URL: https://github.com/llvm/llvm-project/commit/05b4bf2571244da2cef438e907036b35a0e1f99a DIFF: https://github.com/llvm/llvm-project/commit/05b4bf2571244da2cef438e907036b35a0e1f99a.di

[Lldb-commits] [lldb] 6795f37 - [NFC][trace][intelpt] Remove unneeded import

Author: Walter Erquinigo Date: 2022-04-06T13:34:11-07:00 New Revision: 6795f37c1481d702e60e17b9d8e0b98faab979ca URL: https://github.com/llvm/llvm-project/commit/6795f37c1481d702e60e17b9d8e0b98faab979ca DIFF: https://github.com/llvm/llvm-project/commit/6795f37c1481d702e60e17b9d8e0b98faab979ca.di

[Lldb-commits] [lldb] e0cfe20 - [trace][intel pt] Create a common accessor for live and postmortem data

Author: Walter Erquinigo Date: 2022-04-07T15:58:44-07:00 New Revision: e0cfe20ad2fb8c7aab3d6e82c42649eacf595d9f URL: https://github.com/llvm/llvm-project/commit/e0cfe20ad2fb8c7aab3d6e82c42649eacf595d9f DIFF: https://github.com/llvm/llvm-project/commit/e0cfe20ad2fb8c7aab3d6e82c42649eacf595d9f.di

[Lldb-commits] [lldb] 6423b50 - [trace][intel pt] Create a class for the libipt decoder wrapper

Author: Walter Erquinigo Date: 2022-04-07T15:58:34-07:00 New Revision: 6423b50235212db4c3a2e673b2b59fa5f6e07ec0 URL: https://github.com/llvm/llvm-project/commit/6423b50235212db4c3a2e673b2b59fa5f6e07ec0 DIFF: https://github.com/llvm/llvm-project/commit/6423b50235212db4c3a2e673b2b59fa5f6e07ec0.di

[Lldb-commits] [lldb] bdf3e7e - [trace][intelpt] Add task timer classes

Author: Walter Erquinigo Date: 2022-04-12T13:08:03-07:00 New Revision: bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9 URL: https://github.com/llvm/llvm-project/commit/bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9 DIFF: https://github.com/llvm/llvm-project/commit/bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9.di

[Lldb-commits] [lldb] 44103c9 - [trace][intelpt] Remove code smell when printing the raw trace size

Author: Walter Erquinigo Date: 2022-04-12T13:08:03-07:00 New Revision: 44103c96fa6b00e7824319de1b10ce26781e3852 URL: https://github.com/llvm/llvm-project/commit/44103c96fa6b00e7824319de1b10ce26781e3852 DIFF: https://github.com/llvm/llvm-project/commit/44103c96fa6b00e7824319de1b10ce26781e3852.di

[Lldb-commits] [lldb] 059f39d - [trace][intel pt] Support events

Author: Walter Erquinigo Date: 2022-04-25T19:01:23-07:00 New Revision: 059f39d2f44503862cb9c752c28a3a77275b0e51 URL: https://github.com/llvm/llvm-project/commit/059f39d2f44503862cb9c752c28a3a77275b0e51 DIFF: https://github.com/llvm/llvm-project/commit/059f39d2f44503862cb9c752c28a3a77275b0e51.di

[Lldb-commits] [lldb] 35e60f5 - [NFC][trace] simplify the instruction dumper

Author: Walter Erquinigo Date: 2022-04-25T20:02:48-07:00 New Revision: 35e60f5de180aea55ed478298f4b40f04dcc57d1 URL: https://github.com/llvm/llvm-project/commit/35e60f5de180aea55ed478298f4b40f04dcc57d1 DIFF: https://github.com/llvm/llvm-project/commit/35e60f5de180aea55ed478298f4b40f04dcc57d1.di

[Lldb-commits] [lldb] 5de0a3e - [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

Author: Walter Erquinigo Date: 2022-05-02T08:48:49-07:00 New Revision: 5de0a3e9da721189dd648a90e87829d375c5d17f URL: https://github.com/llvm/llvm-project/commit/5de0a3e9da721189dd648a90e87829d375c5d17f DIFF: https://github.com/llvm/llvm-project/commit/5de0a3e9da721189dd648a90e87829d375c5d17f.di

[Lldb-commits] [lldb] b8d1776 - [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

Author: Walter Erquinigo Date: 2022-05-09T16:05:26-07:00 New Revision: b8d1776fc58d56af30d446386788e377d25dd512 URL: https://github.com/llvm/llvm-project/commit/b8d1776fc58d56af30d446386788e377d25dd512 DIFF: https://github.com/llvm/llvm-project/commit/b8d1776fc58d56af30d446386788e377d25dd512.di

[Lldb-commits] [lldb] 7b73de9 - [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

Author: Walter Erquinigo Date: 2022-05-09T16:05:26-07:00 New Revision: 7b73de9ec2b19df040c919d3004dfbead9b6ac59 URL: https://github.com/llvm/llvm-project/commit/7b73de9ec2b19df040c919d3004dfbead9b6ac59 DIFF: https://github.com/llvm/llvm-project/commit/7b73de9ec2b19df040c919d3004dfbead9b6ac59.di

[Lldb-commits] [lldb] 909a2e3 - [lldb] Fix 7b73de9ec2b19df040c919d3004dfbead9b6ac59

Author: Walter Erquinigo Date: 2022-05-09T21:02:40-07:00 New Revision: 909a2e3c8822f0826234aa320794003c7066fada URL: https://github.com/llvm/llvm-project/commit/909a2e3c8822f0826234aa320794003c7066fada DIFF: https://github.com/llvm/llvm-project/commit/909a2e3c8822f0826234aa320794003c7066fada.di

[Lldb-commits] [lldb] c4172c7 - [lldb] Fix 7b73de9ec2b19df040c919d3004dfbead9b6ac59

Author: Walter Erquinigo Date: 2022-05-09T21:12:11-07:00 New Revision: c4172c751a39313efd9c7588a103482c3648987e URL: https://github.com/llvm/llvm-project/commit/c4172c751a39313efd9c7588a103482c3648987e DIFF: https://github.com/llvm/llvm-project/commit/c4172c751a39313efd9c7588a103482c3648987e.di

[Lldb-commits] [lldb] b6bb9e7 - [lldb] Fix 7b73de9ec2b19df040c919d3004dfbead9b6ac59

Author: Walter Erquinigo Date: 2022-05-09T21:29:00-07:00 New Revision: b6bb9e7d61fd84caf1221eeb09a743e8393fb43f URL: https://github.com/llvm/llvm-project/commit/b6bb9e7d61fd84caf1221eeb09a743e8393fb43f DIFF: https://github.com/llvm/llvm-project/commit/b6bb9e7d61fd84caf1221eeb09a743e8393fb43f.di

[Lldb-commits] [lldb] 9d2dd6d - [NFC][lldb][trace] Use uint64_t when decoding and enconding json

Author: Walter Erquinigo Date: 2022-05-09T21:55:43-07:00 New Revision: 9d2dd6d7622335ba9c19b55ac7d463cf662cab0d URL: https://github.com/llvm/llvm-project/commit/9d2dd6d7622335ba9c19b55ac7d463cf662cab0d DIFF: https://github.com/llvm/llvm-project/commit/9d2dd6d7622335ba9c19b55ac7d463cf662cab0d.di

[Lldb-commits] [lldb] 285b39a - Revert "[NFC][lldb][trace] Use uint64_t when decoding and enconding json"

Author: Walter Erquinigo Date: 2022-05-09T22:47:05-07:00 New Revision: 285b39a31ec63a0253fa88c3c61f447712e2f131 URL: https://github.com/llvm/llvm-project/commit/285b39a31ec63a0253fa88c3c61f447712e2f131 DIFF: https://github.com/llvm/llvm-project/commit/285b39a31ec63a0253fa88c3c61f447712e2f131.di

[Lldb-commits] [lldb] be738c9 - [lldb-vscode] Fix data race in lldb-vscode when running with ThreadSanitizer

Author: Walter Erquinigo Date: 2022-05-17T09:11:45-07:00 New Revision: be738c9d1c1612f5cb0a84227f5ced2726ae609e URL: https://github.com/llvm/llvm-project/commit/be738c9d1c1612f5cb0a84227f5ced2726ae609e DIFF: https://github.com/llvm/llvm-project/commit/be738c9d1c1612f5cb0a84227f5ced2726ae609e.di

[Lldb-commits] [lldb] 26d83a4 - [NFC][lldb][trace] Use uint64_t when decoding and enconding json

Author: Walter Erquinigo Date: 2022-05-17T11:08:04-07:00 New Revision: 26d83a431ecbc79d227b0f3b92b0fb2166a7c7d7 URL: https://github.com/llvm/llvm-project/commit/26d83a431ecbc79d227b0f3b92b0fb2166a7c7d7 DIFF: https://github.com/llvm/llvm-project/commit/26d83a431ecbc79d227b0f3b92b0fb2166a7c7d7.di

[Lldb-commits] [lldb] 1f49714 - [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

Author: Walter Erquinigo Date: 2022-05-17T12:46:54-07:00 New Revision: 1f49714d3e19502753fcea7ad8378a194222328f URL: https://github.com/llvm/llvm-project/commit/1f49714d3e19502753fcea7ad8378a194222328f DIFF: https://github.com/llvm/llvm-project/commit/1f49714d3e19502753fcea7ad8378a194222328f.di

[Lldb-commits] [lldb] 1637545 - [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

Author: Walter Erquinigo Date: 2022-05-17T12:46:54-07:00 New Revision: 1637545f689b8c4ef888ca385de75982a6a932e3 URL: https://github.com/llvm/llvm-project/commit/1637545f689b8c4ef888ca385de75982a6a932e3 DIFF: https://github.com/llvm/llvm-project/commit/1637545f689b8c4ef888ca385de75982a6a932e3.di

[Lldb-commits] [lldb] 1188faa - [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

Author: Walter Erquinigo Date: 2022-05-17T12:46:54-07:00 New Revision: 1188faa7ab4b005e3ee28f30055de2f76e210eb8 URL: https://github.com/llvm/llvm-project/commit/1188faa7ab4b005e3ee28f30055de2f76e210eb8 DIFF: https://github.com/llvm/llvm-project/commit/1188faa7ab4b005e3ee28f30055de2f76e210eb8.di

[Lldb-commits] [lldb] 1f56f7f - [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

Author: Walter Erquinigo Date: 2022-06-15T12:07:59-07:00 New Revision: 1f56f7fc16bcb9966d508e462e0f408080fdb362 URL: https://github.com/llvm/llvm-project/commit/1f56f7fc16bcb9966d508e462e0f408080fdb362 DIFF: https://github.com/llvm/llvm-project/commit/1f56f7fc16bcb9966d508e462e0f408080fdb362.di

<    1   2   3   4   5   6   7   8   9   10   >