[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I've run the tests and it's the same with and without this diff :) https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. F2469236: before.txt F2469237: after.txt These are the output from running the tests. Btw, this was failing before because it was reading the export table incorrectly, but I updated it and it shoul

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. pingping https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r284422 - [lldb] Read modules from memory when a local copy is not available

Author: wallace Date: Mon Oct 17 15:28:19 2016 New Revision: 284422 URL: http://llvm.org/viewvc/llvm-project?rev=284422&view=rev Log: [lldb] Read modules from memory when a local copy is not available Summary: When the local lldb doesn't have access to a copy of the modules in the target, e.g. w

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

This revision was automatically updated to reflect the committed changes. Closed by commit rL284422: [lldb] Read modules from memory when a local copy is not available (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D24284?vs=72597&id=74895#toc Repository: rL LLVM h

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. oh, thank you, first time i'm sending lldb diffs Repository: rL LLVM https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. This fixes some issues with arm architectures (where this was unsetting the thumbv7 and was fallbacking to thumb). This is also needed for https://reviews.llvm.org/D24284, where the objet file requires a correct architecture inferred from the machine arch Repository:

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace created this revision. wallace added reviewers: zturner, sas. wallace added a subscriber: LLDB. wallace set the repository for this revision to rL LLVM. wallace added a project: LLDB. When the local lldb doesn't have access to a copy of the modules in the target, e.g. winphone, with this

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace updated this revision to Diff 71226. wallace updated the summary for this revision. wallace added a comment. rebase https://reviews.llvm.org/D24283 Files: source/Core/ArchSpec.cpp Index: source/Core/ArchSpec.cpp === ---

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. I've run the tests and saw that two tests have been fixed before: Test Methods: 1829 Reruns:0 Success:1061 Expected Failure:113 Failure: 0 Error: 7 Exceptional Exit: 0 Unexpected Succ

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. Hey, apparently this change doesn't affect the test coverage, there are at least two flaky tests that sometimes produce unexpected success: test_step_over_dwo, test_process_interrupt_dwo I repeatedly ran the tests with and without my change it the flakiness was quite c

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. btw, i don't have commit access? can you commit it or should i request access? https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. thanks! https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71265. wallace updated the summary for this revision. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71407. wallace added a comment. fix pointers https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h ===

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71409. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. ping https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. ping https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I'm obliged, your grace https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71853. wallace added a comment. s/NULL/nullptr/ https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71855. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace added a comment. I was using this patch as well https://reviews.llvm.org/D24530, which might be the reason why it fails on your side. I'll double check, but I'm pretty sure it's just that https://reviews.llvm.org/D24284 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 71995. wallace added a comment. rebase https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72596. wallace added a comment. This time I'm calculating the address of the exports header correctly because it is an RVA address. https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/P

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72597. wallace added a comment. minor nits https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h =

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/97675 CommandObjectBreakpoint has a harcoded list of languages for which exception breakpoints can be enabled. I'm making this a bit more generic so that my Mojo plugin can get this feature. Basically, I'm ad

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/97675 >From 5d1a7254d1e1a541a7b901be0d3a84eab42474b2 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 4 Jul 2024 00:34:14 -0400 Subject: [PATCH 1/2] [LLDB] Support exception breakpoints for plugin-pr

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

@@ -319,6 +316,12 @@ class CommandObjectBreakpointSet : public CommandObjectParsed { error_context = "Unknown language type for exception breakpoint"; break; default: + if (Language *languagePlugin = Language::FindPlugin(language)) { --

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

walter-erquinigo wrote: > And does this list include languages that are not plugin provided? The hardcoded list in the file being changes includes C++ and Objc in its various variants. > I was wondering why only Objective C changed, but if the rest are not plugins > then this makes sense. Th

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/97675 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3bfc516 - [lldb-dap][NFC] Minor rename

Author: walter erquinigo Date: 2024-07-05T13:12:13-04:00 New Revision: 3bfc5167d9e49b9a53e364e8d8853fce543cca0f URL: https://github.com/llvm/llvm-project/commit/3bfc5167d9e49b9a53e364e8d8853fce543cca0f DIFF: https://github.com/llvm/llvm-project/commit/3bfc5167d9e49b9a53e364e8d8853fce543cca0f.di

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/97871 …lly registered languages First of all, this is done to support exceptions for the Mojo language, but it's done in a way that will benefit any other plugin language. 1. I added a new lldb-dap CLI argum

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

walter-erquinigo wrote: This is a screenshot of how it's looking for me on VSCode.  https://github.com/llvm/llvm-project/pull/97871 ___ lldb-commits mail

[Lldb-commits] [lldb] [LLDB] Support exception breakpoints for plugin-provided languages (PR #97675)

walter-erquinigo wrote: > Exception Breakpoints are created by the static method > LanguageRuntime::CreateExceptionBreakpoint. So they don't require a process. Indeed, but let me elaborate. What I need is a method that doesn't require a process that could tell me if a certain language can sup

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

@@ -58,10 +58,17 @@ DAP::DAP() DAP::~DAP() = default; +/// Return string with first character capitalized. +static std::string capitalize(llvm::StringRef str) { + if (str.empty()) +return ""; + return ((llvm::Twine)llvm::toUpper(str[0]) + str.drop_front()).str(); +} +

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/97871 >From aa2ad3b675f67581dde07a476725d2574fc6e7da Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 5 Jul 2024 20:30:44 -0400 Subject: [PATCH] [lldb-dap] Support throw and catch exception breakpoin

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

walter-erquinigo wrote: This is a very benign change, so I'll be merging it. Happy to make change post-merge if anyone provides any feedback. https://github.com/llvm/llvm-project/pull/97871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/97871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support single stopped event in lldb-dap (PR #98568)

@@ -0,0 +1,91 @@ +""" +Test lldb-dap setBreakpoints request +""" + +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +import lldbdap_testcase +from lldbsuite.test import lldbutil + + +class TestDAP_stopEvents(lldbdap_testcase.DAPTestCaseBase): +@s

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/98703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/98703 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add lldb version into initialize response lldb-dap (PR #98703)

@@ -1710,6 +1710,8 @@ void request_initialize(const llvm::json::Object &request) { body.try_emplace("supportsLogPoints", true); // The debug adapter supports data watchpoints. body.try_emplace("supportsDataBreakpoints", true); + // Putting version string. Note: this is

[Lldb-commits] [lldb] 27b2f4f - [LLDB] Revert #98351 and #98344

Author: walter erquinigo Date: 2024-07-15T23:00:17-04:00 New Revision: 27b2f4f861b8aeeabc4eb1a97649062de8fa3992 URL: https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992 DIFF: https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992.di

[Lldb-commits] [lldb] [lldb] DebugInfoD tests & fixes (but with dwp testing disabled) (PR #98344)

walter-erquinigo wrote: @kevinfrei , I'm so sorry to tell you that I have reverted this patch. The revert commit is 27b2f4f861b8aeeabc4eb1a97649062de8fa3992 and I left some notes there, which I also copy here: The patch #98344 causes a crash in LLDB when parsing some files like `numpy.libs/l

[Lldb-commits] [lldb] [lldb] DebugInfoD tests & fixes (but with dwp testing disabled) (PR #98344)

walter-erquinigo wrote: @kevinfrei , I'm glad I can be of help to you! Let me know if you want me to try out your next iteration of this PR on my device. https://github.com/llvm/llvm-project/pull/98344 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

walter-erquinigo wrote: This LGTM, although I'd rather have someone like @clayborg taking a look https://github.com/llvm/llvm-project/pull/99362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

walter-erquinigo wrote: This is very exciting! https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Include npm install in the extension installation steps (PR #92028)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/92028 Otherwise the build step fails due to missing dependencies. >From b065234db18dd726b4e39a98ac0c360e052fe438 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 13 May 2024 22:39:47 +0200 Subject:

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -335,6 +335,37 @@ def cleanup(): response["success"], "attach failed (%s)" % (response["message"]) ) +def attach_by_port( walter-erquinigo wrote: could you just extend the `def attach` function? Having a totally new entry

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -0,0 +1,137 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +import lldbdap_testcase +import os +import shutil +impor

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -762,9 +765,31 @@ void request_attach(const llvm::json::Object &request) { // Disable async events so the attach will be successful when we return from // the launch call and the launch will happen synchronously g_dap.debugger.SetAsync(false); -if (core_file

[Lldb-commits] [lldb] [lldb-dap] Correctly detect alias commands with arguments in repl (PR #92137)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/92137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

walter-erquinigo wrote: I don't think anything has changed on VSCode proper. I've just verified I have the same experience as you. Given what you said, I'm in favor of reverting this or at least gating this feature under a json initialization option until the original author can look at this.

[Lldb-commits] [lldb] [lldb-dap] Include npm install in the extension installation steps (PR #92028)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/92028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support publishing to the VSCode market place (PR #92320)

https://github.com/walter-erquinigo approved this pull request. lgtm! https://github.com/llvm/llvm-project/pull/92320 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed an invalid error message in the DAP disconnect response (PR #92345)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/92345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92398)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/92398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -0,0 +1,146 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -1572,6 +1572,15 @@ def findBuiltClang(self): return os.environ["CC"] +def getBuiltinServerTool(self, server_tool): +# Tries to find simulation/lldb-server/gdbserver tool at the same folder as the lldb. +lldb_dir = os.path.dirname(lldbtest_conf

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -676,6 +676,8 @@ void request_attach(const llvm::json::Object &request) { auto arguments = request.getObject("arguments"); const lldb::pid_t pid = GetUnsigned(arguments, "pid", LLDB_INVALID_PROCESS_ID); + const auto port = GetUnsigned(arguments, "port", LLDB_INVAL

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -0,0 +1,146 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -0,0 +1,146 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/92416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Separate user and developer documentation (PR #92428)

https://github.com/walter-erquinigo approved this pull request. beautiful https://github.com/llvm/llvm-project/pull/92428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed the DAP tests in case of a remote target (PR #92416)

walter-erquinigo wrote: That's a great idea. There's no such `dap` category at the moment, but it would be nice if such category is created as part of the ongoing lldb-dap test fixes. https://github.com/llvm/llvm-project/pull/92416 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

walter-erquinigo wrote: I'm okay with anything that ensures hovering is fast. https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

walter-erquinigo wrote: Thanks, @labath , for chiming in. I actually agree with all your points. https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb-dap] Don't send expanded descriptions for "hover" expressions (PR #92726)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/92726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change GetChildCompilerTypeAtIndex to return Expected (NFC) (PR #92979)

https://github.com/walter-erquinigo approved this pull request. Pretty nice! This will be useful for Mojo as well https://github.com/llvm/llvm-project/pull/92979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [lldb] Fixed the TestDebuggerAPI test on x86_64 Windows host (PR #90580)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/90580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Don't call GetNumChildren on non-indexed synthetic variables (PR #93534)

https://github.com/walter-erquinigo approved this pull request. Thanks for doing this. Btw, that was a clever way of testing this functionality. https://github.com/llvm/llvm-project/pull/93534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

@@ -103,7 +103,9 @@ void DAP::SendJSON(const llvm::json::Value &json) { SendJSON(json_str); if (log) { -*log << "<-- " << std::endl +auto now = std::chrono::duration( +std::chrono::system_clock::now().time_since_epoch()); walter-erquinigo w

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

https://github.com/walter-erquinigo approved this pull request. sounds good then! https://github.com/llvm/llvm-project/pull/93540 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -749,9 +752,30 @@ void request_attach(const llvm::json::Object &request) { // Disable async events so the attach will be successful when we return from // the launch call and the launch will happen synchronously g_dap.debugger.SetAsync(false); -if (core_file

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

@@ -0,0 +1,142 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/94494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

walter-erquinigo wrote: Jonas' suggestion is pretty good. Please do that. Probably something like this would work ` def collect_console(timeout_secs=10, check_interval_secs=1): ... ` Then you can just update every caller of this function to just do `collect_console()` https://github.com/llv

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -467,5 +467,5 @@ def test_terminate_commands(self): # Once it's disconnected the console should contain the # "terminateCommands" self.dap_server.request_disconnect(terminateDebuggee=True) -output = self.collect_console(duration=1.0) +

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -75,6 +75,6 @@ def test_command_directive_abort_on_error_attach_commands(self): attachCommands=["?!" + command_quiet, "!" + command_abort_on_error], expectFailure=True, ) -full_output = self.collect_console(duration=1.0) +ful

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -47,7 +47,7 @@ def do_test_abort_on_error( postRunCommands=commands if use_post_run_commands else None, expectFailure=True, ) -full_output = self.collect_console(duration=1.0) +full_output = self.collect_console(timeout_secs=1.

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -235,5 +235,5 @@ def test_terminate_commands(self): # Once it's disconnected the console should contain the # "terminateCommands" self.dap_server.request_disconnect(terminateDebuggee=True) -output = self.collect_console(duration=1.0) +

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -200,7 +200,7 @@ def test_commands(self): # Get output from the console. This should contain both the # "exitCommands" that were run after the second breakpoint was hit # and the "terminateCommands" due to the debugging session ending -output

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -337,7 +337,7 @@ def test_commands(self): # Get output from the console. This should contain both the # "exitCommands" that were run after the second breakpoint was hit # and the "terminateCommands" due to the debugging session ending -output

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

walter-erquinigo wrote: @mbucko , could you request commit access to Chris Latner? ``` We grant commit access to contributors with a track record of submitting high quality patches. If you would like commit access, please send an email to [Chris](mailto:clattner%40llvm.org) with your GitHub u

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

walter-erquinigo wrote: I'll review this today or tomorrow. Thanks for all the activity! https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

https://github.com/walter-erquinigo approved this pull request. This LGTM https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

walter-erquinigo wrote: I second everything that Pavel says. I think this would be the best approach. The existing frame var implementation is not that "smart", so it should be practical to fully replace it with the new DIL in its first stage. An additional consideration is that lldb-dap, whic

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

walter-erquinigo wrote: > FYI @walter-erquinigo: There is a proposal under discussion to add > first-class support for `declarationLocation` (and also `valueLocation`) to > the debug adapter protocol. See > [microsoft/debug-adapter-protocol#343](https://github.com/microsoft/debug-adapter-proto

[Lldb-commits] [lldb] [LLDB][OSX] Add a fallback support exe directory (PR #103458)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/103458 LLDB on OSX is looking at a `bin` directory sibling to the `lib` one that contains liblldb for its supporting executables. This works well for CMake, however, for other build systems like bazel, it's n

[Lldb-commits] [lldb] [LLDB][OSX] Add a fallback support exe directory (PR #103458)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/103458 >From 656486aa0854db82ace6bee0639ca1d94f7b4fc5 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Tue, 13 Aug 2024 17:09:38 -0400 Subject: [PATCH] [LLDB][OSX] Add a fallback support exe directory LL

[Lldb-commits] [lldb] [LLDB][OSX] Add a fallback support exe directory (PR #103458)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/103458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

walter-erquinigo wrote: @vogelsgesang , Mr. Bird, I'm swamped this week with work, but I'll look into this before saturday for sure. https://github.com/llvm/llvm-project/pull/102928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] [lldb-dap] Expose log path in extension settings (PR #103482)

https://github.com/walter-erquinigo approved this pull request. nice! https://github.com/llvm/llvm-project/pull/103482 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

walter-erquinigo wrote: @clayborg you'll be happy to review this https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

walter-erquinigo wrote: @vogelsgesang can you share a screenshot? https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][OSX] Removed semi colon generating a warning during build (PR #104398)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/104398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][OSX] Removed semi colon generating a warning during build (PR #104398)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/104398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][OSX] Removed semi colon generating a warning during build (PR #104398)

walter-erquinigo wrote: Thank you! https://github.com/llvm/llvm-project/pull/104398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

walter-erquinigo wrote: This seems pretty cool! Question: what would happen if the top frame (the one with the PC) gets filtered out by the recognizer? https://github.com/llvm/llvm-project/pull/104523 ___ lldb-commits mailing list lldb-commits@lists.

  1   2   3   4   5   6   7   8   9   10   >