[Lldb-commits] [lldb] Revert "[lldb] Store SupportFile in FileEntry (NFC)" (PR #85885)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#85468 because @slackito reports this broke stepping in one of their tests [1] and this patch was meant to be NFC. [1] https://github.com/llvm/llvm-project/commit/d5a277d3

[Lldb-commits] [lldb] Revert "[lldb] Store SupportFile in FileEntry (NFC)" (PR #85885)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e2fa90fa0a4b7950dd0d7fae6933e89c075d0af0 719069e6b7e191e338bbb17e9e18b7974b5acef0 --

[Lldb-commits] [lldb] 1232964 - [lldb] Omit --show-globals in `help target var` (#85855)

Author: Felipe de Azevedo Piovezan Date: 2024-03-20T07:03:24-07:00 New Revision: 12329648e2c3f8651228f17d3619b1e1ddab80f0 URL: https://github.com/llvm/llvm-project/commit/12329648e2c3f8651228f17d3619b1e1ddab80f0 DIFF: https://github.com/llvm/llvm-project/commit/12329648e2c3f8651228f17d3619b1e1d

[Lldb-commits] [lldb] 66a2ed5 - [lldb] Remove process restart prompt from TestSourceManager (#85861)

Author: Alex Langford Date: 2024-03-20T10:43:40-07:00 New Revision: 66a2ed50ccb6de64fdf82957ca0d4b55ef76f3cd URL: https://github.com/llvm/llvm-project/commit/66a2ed50ccb6de64fdf82957ca0d4b55ef76f3cd DIFF: https://github.com/llvm/llvm-project/commit/66a2ed50ccb6de64fdf82957ca0d4b55ef76f3cd.diff

[Lldb-commits] [lldb] 10b0e35 - [lldb] Invert relationship between Process and AddressableBits (#85858)

Author: Alex Langford Date: 2024-03-20T10:46:06-07:00 New Revision: 10b0e355372fab1f4d58536525545eef8523 URL: https://github.com/llvm/llvm-project/commit/10b0e355372fab1f4d58536525545eef8523 DIFF: https://github.com/llvm/llvm-project/commit/10b0e355372fab1f4d58536525545eef8523.diff

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The Doxygen comments for the `details` field of a progress report currently does not specify that this field will act as the initial set of details for a progress report that gets updated with `Pro

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC) (PR #85892)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This is another step towards supporting DWARF5 checksums and inline source code in LLDB. This is a reland of #85468 but without the functional change of storing the support file from the line table (

[Lldb-commits] [lldb] 556fe5f - [lldb] Reland: Store SupportFile in FileEntry (NFC) (#85892)

Author: Jonas Devlieghere Date: 2024-03-21T08:40:08-07:00 New Revision: 556fe5f290ea88dcbb7ced16b0f057dcebce1fd0 URL: https://github.com/llvm/llvm-project/commit/556fe5f290ea88dcbb7ced16b0f057dcebce1fd0 DIFF: https://github.com/llvm/llvm-project/commit/556fe5f290ea88dcbb7ced16b0f057dcebce1fd0.d

[Lldb-commits] [lldb] 6317c78 - [lldb][progress][NFC] Clarify Doxygen comments for `details` field (#86002)

Author: Chelsea Cassanova Date: 2024-03-21T08:49:43-07:00 New Revision: 6317c780d81327bd06701a6aa374fc92aa3d73ad URL: https://github.com/llvm/llvm-project/commit/6317c780d81327bd06701a6aa374fc92aa3d73ad DIFF: https://github.com/llvm/llvm-project/commit/6317c780d81327bd06701a6aa374fc92aa3d73ad.d

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch sets the necessary `ASTContext` flag to ensure that the various ASTs (i.e., symbolfile-backed ASTs, scratch AST and the expression AST) in LLDB are dumped using syntax highlighting (i.e., whenev

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 0572dabb71147fdc156d90a3ecd036d1652c2006...16b8dfab53008c657c82b0ae35510c7050481bdb lldb

[Lldb-commits] [lldb] 6d939a6 - DebugInfoD tests + fixing issues exposed by tests (#85693)

Author: Kevin Frei Date: 2024-03-21T13:09:04-07:00 New Revision: 6d939a6ec69adf284cdbef2034b49fd02ba503fc URL: https://github.com/llvm/llvm-project/commit/6d939a6ec69adf284cdbef2034b49fd02ba503fc DIFF: https://github.com/llvm/llvm-project/commit/6d939a6ec69adf284cdbef2034b49fd02ba503fc.diff LO

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

@@ -44,6 +44,25 @@ llvm::StringRef SymbolVendorELF::GetPluginDescriptionStatic() { "executables."; } +// If this is needed elsewhere, it can be exported/moved. +static bool IsDwpSymbolFile(const lldb::ModuleSP &module_sp, +const FileSpec &

[Lldb-commits] [lldb] [lldb] Handle clang::Language::CIR (PR #86234)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes commit e66b670f3bf9312f696e66c31152ae535207d6bb Author: Nathan Lanza Date: Thu Mar 21 19:53:48 2024 -0400 triggers: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang

[Lldb-commits] [lldb] 40beb9b - [lldb] Handle clang::Language::CIR (#86234)

Author: Kazu Hirata Date: 2024-03-21T20:14:18-07:00 New Revision: 40beb9b001a3c67c60b98fae9e999dcaa2d88717 URL: https://github.com/llvm/llvm-project/commit/40beb9b001a3c67c60b98fae9e999dcaa2d88717 DIFF: https://github.com/llvm/llvm-project/commit/40beb9b001a3c67c60b98fae9e999dcaa2d88717.diff L

[Lldb-commits] [lldb] Missed a null-ptr check in previous PR for Debuginfod testing (PR #86292)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes @GeorgeHuyubo noticed an unchecked shared pointer result in https://github.com/llvm/llvm-project/pull/85693/. This is the fix for that issue. --- Full diff: https://github.com/llvm/llvm-project/pull/86292.di

[Lldb-commits] [lldb] Missed a null-ptr check in previous PR for Debuginfod testing (PR #86292)

https://github.com/GeorgeHuyubo approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/86292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

llvmbot wrote: @llvm/pr-subscribers-clangd @llvm/pr-subscribers-lldb Author: None (ldrumm) Changes Historically, we've not automatically enforced how git tracks line endings, but there are many, many commits that "undo" unintended CRLFs getting into history. `git log --pretty=oneline --g

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (ldrumm) Changes Historically, we've not automatically enforced how git tracks line endings, but there are many, many commits that "undo" unintended CRLFs getting into history. `git log --pretty=oneline --grep=CRLF` shows nearl

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: I'm sure there are lots of people that will want to look at this, so please bring in reviewers at will https://github.com/llvm/llvm-project/pull/86318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cd8286a667d568c4319b09baa63ba899e3101a19 2dfda2e4b11c7ea0a81dd4dcd43aa426039d1e0a --

[Lldb-commits] [lldb] b1575f9 - Missed a null-ptr check in previous PR for Debuginfod testing (#86292)

Author: Kevin Frei Date: 2024-03-22T11:22:09-07:00 New Revision: b1575f9082071702bd6aaa2600ce9fe011a091e9 URL: https://github.com/llvm/llvm-project/commit/b1575f9082071702bd6aaa2600ce9fe011a091e9 DIFF: https://github.com/llvm/llvm-project/commit/b1575f9082071702bd6aaa2600ce9fe011a091e9.diff LO

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: > So, is there a way to do CRLF -> LF on checkin, but do nothing on checkout? To be clear, this *may* do nothing on checkout if a user has set a config option. The point of the present policy is not to control local preferences as far as the filetype isn't *reqired* to have a spe

[Lldb-commits] [lldb] [lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory (PR #86359)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes It is possible to gather code coverage in a firmware environment, where the __LLVM_COV segment will not be mapped in memory but does exist in the binary, see https://llvm.org/devmtg/2020-09/slides/Phipp

[Lldb-commits] [lldb] [lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory (PR #86359)

github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86359 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory (PR #86359)

github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86359 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: > LGTM overall, but the CI failure looks real. ``` Failed Tests (3): Clang :: CXX/drs/dr23xx.cpp Clang :: CXX/drs/dr6xx.cpp Clang :: Lexer/raw-string-dlim-invalid.cpp ``` None of these files are in the diffstat, and none of them include any headers. I'm a bit stumped. Is it

[Lldb-commits] [lldb] [LLDB] Add FreeBSD kernel coredump matching check. (PR #80785)

aokblast wrote: I think this feature is work now in FreeBSD. If you don't find any other problem. Please help me merge this patch. Thanks! https://github.com/llvm/llvm-project/pull/80785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: On Mon Mar 25, 2024 at 1:48 PM GMT, Tobias Hieta wrote: > > I think .natvis files should be CRLF (those are used with Visual Studio for > > debug visualizers). > > Agreed, Visual Studio should handle this correctly, but who knows > 🤷🏼 > Thanks. I'll add a rule and update https:

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: > Should we come up with an expected filename format that we can use with > gitattributes and rename the existing files rather than just listing each > file that has special needs by itself? Either way, the author has to do or know *something*. I'm not a fan of "magic" like this

[Lldb-commits] [lldb] [lldb][TypeSystem] Enable colored AST dump (PR #86159)

jimingham wrote: You can't get from a TypeSystem to a Target directly, because TypeSystem's live in Modules and Modules live outside any particular target in the global module cache. Maybe you need to pass this in to the call to dump the functions. The command-line will always have a current

[Lldb-commits] [lldb] [lldb][Dwarf] Fix dwarf parse time for line table and .debug_abbrev. (PR #86568)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Zequan Wu (ZequanWu) Changes `ParseLineTable` not only parses .debug_line but also constructs `LineTable`. This moves `m_parse_time` into the the function body of `ParseLLVMLineTable` to more accurately reflect parsing time on .debug_line.

[Lldb-commits] [lldb] [lldb][Dwarf] Fix dwarf parse time for line table and .debug_abbrev. (PR #86568)

github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb][Dwarf] Fix dwarf parse time for line table and .debug_abbrev. (PR #86568)

github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: > I don't have a strong opinion, but fundamentally I would prefer if the source > control system stored exactly the files I have in my checkout, not mess with > them in any way. I understand there are practical concerns, but a linter for > unexpected CRLF would maybe be an option

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

ldrumm wrote: > > That wish is fine until you start working with others. > > Do we actually have that little faith in developers that we think they will > check in a 50k line diff? depending on their diff settings, or the web interface they use, it may not show until they actually look at a h

[Lldb-commits] [lldb] 930f646 - [lldb] Implement coalescing of disjoint progress events (#84854)

Author: Jonas Devlieghere Date: 2024-03-25T14:50:58-07:00 New Revision: 930f64689c1fb487714c3836ffa43e49e46aa488 URL: https://github.com/llvm/llvm-project/commit/930f64689c1fb487714c3836ffa43e49e46aa488 DIFF: https://github.com/llvm/llvm-project/commit/930f64689c1fb487714c3836ffa43e49e46aa488.d

[Lldb-commits] [lldb] 765d4c4 - [lldb] [ObjectFileMachO] LLVM_COV is not mapped into firmware memory (#86359)

Author: Jason Molenda Date: 2024-03-25T15:00:36-07:00 New Revision: 765d4c402fe2ff614a15a762bb7cefe7289663b4 URL: https://github.com/llvm/llvm-project/commit/765d4c402fe2ff614a15a762bb7cefe7289663b4 DIFF: https://github.com/llvm/llvm-project/commit/765d4c402fe2ff614a15a762bb7cefe7289663b4.diff

[Lldb-commits] [lldb] 2c76e88 - Add register lookup as another fallback computation for address-expressions (#85492)

Author: jimingham Date: 2024-03-25T15:17:23-07:00 New Revision: 2c76e88e9eb284d17cf409851fb01f1d583bb22a URL: https://github.com/llvm/llvm-project/commit/2c76e88e9eb284d17cf409851fb01f1d583bb22a DIFF: https://github.com/llvm/llvm-project/commit/2c76e88e9eb284d17cf409851fb01f1d583bb22a.diff LOG

[Lldb-commits] [lldb] Add register lookup as another fallback computation for address-expressions (PR #85492)

https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/85492 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make the correct (5 argument) form of the command definition be the primary one suggested in the docs (PR #86593)

https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/86593 This has been available for years now, so it should be safe to always use it. >From 1886d705aee10cf608b4c452bea6ea3e47c4b25d Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Mon, 25 Mar 2024 15:31:50 -0700 Subj

[Lldb-commits] [lldb] Make the correct (5 argument) form of the command definition be the primary one suggested in the docs (PR #86593)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This has been available for years now, so it should be safe to always use it. --- Full diff: https://github.com/llvm/llvm-project/pull/86593.diff 1 Files Affected: - (modified) lldb/docs/use/python-reference.rst

[Lldb-commits] [lldb] Make the correct (5 argument) form of the command definition be the primary one suggested in the docs (PR #86593)

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/86593 >From 1886d705aee10cf608b4c452bea6ea3e47c4b25d Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Mon, 25 Mar 2024 15:31:50 -0700 Subject: [PATCH 1/2] Make the correct (5 argument) form of the command definition

[Lldb-commits] [lldb] Make the correct (5 argument) form of the command definition be the primary one suggested in the docs (PR #86593)

https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/86593 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b6dfaf4 - Make the correct (5 argument) form of the command definition be the primary one suggested in the docs (#86593)

Author: jimingham Date: 2024-03-25T16:06:51-07:00 New Revision: b6dfaf4c291ee186481f6c1dcab03874d931c307 URL: https://github.com/llvm/llvm-project/commit/b6dfaf4c291ee186481f6c1dcab03874d931c307 DIFF: https://github.com/llvm/llvm-project/commit/b6dfaf4c291ee186481f6c1dcab03874d931c307.diff LOG

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/86623 None >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/3] Fix strcmp build error on buildbot --- lldb/test/A

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 93f9fb2c825dba48db64d5f726b54bcbd4766009...b2dfdb546808c495779e5781c6619fcadb752b00 lldb/

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 93f9fb2c825dba48db64d5f726b54bcbd4766009 b2dfdb546808c495779e5781c6619fcadb752b00 --

[Lldb-commits] [lldb] 2f63718 - [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (#86603)

Author: Jason Molenda Date: 2024-03-26T09:07:15-07:00 New Revision: 2f63718f8567413a1c596bda803663eb58d6da5a URL: https://github.com/llvm/llvm-project/commit/2f63718f8567413a1c596bda803663eb58d6da5a DIFF: https://github.com/llvm/llvm-project/commit/2f63718f8567413a1c596bda803663eb58d6da5a.diff

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/86623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/86623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This patch provides the initial implementation for the "Step Into Specific/Step In Targets" feature in VSCode DAP. The implementation disassembles all the call instructions in step range and try to resolve ope

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/86623 >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/4] Fix strcmp build error on buildbot --- lldb/test/API/fun

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/86623 >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/5] Fix strcmp build error on buildbot --- lldb/test/API/fun

[Lldb-commits] [lldb] [lldb][nfc] Delete unused variable (PR #86740)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This was made unused by d9ec4b24a84addb8bd77b5d9dd990181351cf84c. --- Full diff: https://github.com/llvm/llvm-project/pull/86740.diff 1 Files Affected: - (modified) lldb/source/Target/S

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/86623 >From 6cccde22723157260e7c0b19bf8372aae8d1afaa Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Wed, 6 Mar 2024 12:07:03 -0800 Subject: [PATCH 1/6] Fix strcmp build error on buildbot --- lldb/test/API/fun

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -3180,14 +3180,159 @@ void request_stepIn(const llvm::json::Object &request) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

jimingham wrote: > This patch provides the initial implementation for the "Step Into > Specific/Step In Targets" feature in VSCode DAP. > > The implementation disassembles all the call instructions in step range and > try to resolve operand name (assuming one operand) using debug info. Later,

[Lldb-commits] [lldb] [lldb] Revive shell test after updating UnwindTable (PR #86770)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In commit 2f63718f8567413a1c596bda803663eb58d6da5a Author: Jason Molenda Date: Tue Mar 26 09:07:15 2024 -0700 [lldb] Don't clear a Module's UnwindTable when adding a Symb

[Lldb-commits] [lldb] 2cb7ea1 - [lldb][nfc] Delete unused variable (#86740)

Author: Felipe de Azevedo Piovezan Date: 2024-03-27T07:02:12-07:00 New Revision: 2cb7ea1553a5c7be81bee4ed3c51b7727b9d2ee8 URL: https://github.com/llvm/llvm-project/commit/2cb7ea1553a5c7be81bee4ed3c51b7727b9d2ee8 DIFF: https://github.com/llvm/llvm-project/commit/2cb7ea1553a5c7be81bee4ed3c51b7727

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

llvmbot wrote: @llvm/pr-subscribers-libcxx @llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang @llvm/pr-subscribers-mlir Author: None (AngryLoki) Changes This fixes "SyntaxWarning: invalid escape sequence" and "SyntaxWarning: "is" with 'int' literal", exce

[Lldb-commits] [lldb] 9f84594 - [lldb][Dwarf] Add missing timer when parsing .debug_abbrev. (#86568)

Author: Zequan Wu Date: 2024-03-27T10:33:25-04:00 New Revision: 9f84594e4ef87a50d1599814ba99fb735da76826 URL: https://github.com/llvm/llvm-project/commit/9f84594e4ef87a50d1599814ba99fb735da76826 DIFF: https://github.com/llvm/llvm-project/commit/9f84594e4ef87a50d1599814ba99fb735da76826.diff LOG

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e82765bf07a978674c0e75c8b2e20f154ae24a4c...c7d6289573379be760ca9d691d62e0f87ba0ee8a .gith

[Lldb-commits] [lldb] DebugInfoD issues, take 2 (PR #86812)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kevin Frei (kevinfrei) Changes The previous diff (and it's subsequent fix) were reverted as the tests didn't work properly on the AArch64 & ARM LLDB buildbots. I made a couple more minor changes to tests (from @clayborg's feedback) and dis

[Lldb-commits] [lldb] 6a0ec8e - [lldb] Revive shell test after updating UnwindTable (#86770)

Author: Jason Molenda Date: 2024-03-27T09:25:46-07:00 New Revision: 6a0ec8e25cba9d398cf525889c53835cf40247a3 URL: https://github.com/llvm/llvm-project/commit/6a0ec8e25cba9d398cf525889c53835cf40247a3 DIFF: https://github.com/llvm/llvm-project/commit/6a0ec8e25cba9d398cf525889c53835cf40247a3.diff

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

AngryLoki wrote: But automatic replacement is not possible, because `"\n" != r"\n"`. But I checked carefully that all changed places with `\n` and `\t` are regexps, and in regexps it is semantically the same. ``` >>> '\n' in 'test \n test' True >>> r'\n' in 't

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/86862 This adds the ability to create a Scalar from an APFloat, and to create an APFloat from an APSInt or another APFloat. >From 03ef6db02f49ab4cc4f63b32553015b4f3801b5b Mon Sep 17 00:00:00 2001 From: Caroline Tice D

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes This adds the ability to create a Scalar from an APFloat, and to create an APFloat from an APSInt or another APFloat. --- Full diff: https://github.com/llvm/llvm-project/pull/86862.diff 2 Files Affected: - (modifie

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dcd0f2b6103072b74b446c2d1e9ecec60001a28c 03ef6db02f49ab4cc4f63b32553015b4f3801b5b --

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/86862 >From 03ef6db02f49ab4cc4f63b32553015b4f3801b5b Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Wed, 27 Mar 2024 10:09:45 -0700 Subject: [PATCH 1/2] [LLDB] Add APFloat helper functions to Scalar class. This add

[Lldb-commits] [lldb] c7d947f - [lldb] [ObjC runtime] Don't cast to signed when left shifting (#86605)

Author: Jason Molenda Date: 2024-03-27T13:59:35-07:00 New Revision: c7d947f5e6c966bdba4db26097c3b433fcbe7841 URL: https://github.com/llvm/llvm-project/commit/c7d947f5e6c966bdba4db26097c3b433fcbe7841 DIFF: https://github.com/llvm/llvm-project/commit/c7d947f5e6c966bdba4db26097c3b433fcbe7841.diff

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry { lldb::SBAddress GetEndAddress() const; + lldb::SBAddress + GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const; + jeffreytan81 wrote: @clayborg, right, I know I can do that but I did n

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object &request) { llvm::json::Object response; FillResponse(request, response); auto arguments = request.getObject("arguments"); + + std::string step_in_target; + uint64_t target_id = GetUnsigned(arguments

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

jeffreytan81 wrote: @jimingham, thanks for detailed comment. "Step in targets" or "Step Into Specific" is an IDE feature that works in two steps: 1. Show a list of call sites before stepping to allow users specify which call to step into 2. Perform step into with user choosing call site funct

[Lldb-commits] [lldb] Initial step in targets DAP support (PR #86623)

jimingham wrote: > @jimingham, thanks for detailed comment. > > "Step in targets" or "Step Into Specific" is an IDE feature that works in two > steps: > > 1. Show a list of call sites before stepping to allow users specify which > call to step into > 2. Perform step into with user choosing ca

[Lldb-commits] [lldb] [lldb] Avoid deadlock by unlocking before invoking callbacks (PR #86888)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Avoid deadlocks in the Alarm class by releasing the lock before invoking callbacks. This deadlock manifested itself in the ProgressManager: 1. On the main thread, the ProgressManager acquires its

[Lldb-commits] [lldb] b76fd1e - [lldb] Avoid deadlock by unlocking before invoking callbacks (#86888)

Author: Jonas Devlieghere Date: 2024-03-27T16:37:00-07:00 New Revision: b76fd1eddbafaa02a533245d574048c5ad9e38fa URL: https://github.com/llvm/llvm-project/commit/b76fd1eddbafaa02a533245d574048c5ad9e38fa DIFF: https://github.com/llvm/llvm-project/commit/b76fd1eddbafaa02a533245d574048c5ad9e38fa.d

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

@@ -101,7 +101,7 @@ def extract_result_types(comment): def strip_doxygen(comment): -"""Returns the given comment without \-escaped words.""" +"""Returns the given comment without \\-escaped words.""" AngryLoki wrote: No, `'''\-'''` is still SyntaxWar

[Lldb-commits] [lldb] [lldb] Remove cmake check for pexpect with LLDB_TEST_USE_VENDOR_PACKAGES (PR #86962)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes The commit 8bed754c2f965c8cbbb050be6f650b78f7fd78a6 was intended to support the use case where users want to run all the LLDB tests in an environment where pexpect is not installed. Those users can buil

[Lldb-commits] [lldb] a834076 - [lldb] Remove cmake check for pexpect with LLDB_TEST_USE_VENDOR_PACKAGES (#86962)

Author: Jordan Rupprecht Date: 2024-03-28T15:57:09-05:00 New Revision: a8340767de71b8c7d10de74019622592b39e3704 URL: https://github.com/llvm/llvm-project/commit/a8340767de71b8c7d10de74019622592b39e3704 DIFF: https://github.com/llvm/llvm-project/commit/a8340767de71b8c7d10de74019622592b39e3704.di

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/86862 >From 03ef6db02f49ab4cc4f63b32553015b4f3801b5b Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Wed, 27 Mar 2024 10:09:45 -0700 Subject: [PATCH 1/4] [LLDB] Add APFloat helper functions to Scalar class. This add

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

cmtice wrote: > Could you add a test for these new methods in > `unittests/Utility/ScalarTest.cpp`? Done. :-) https://github.com/llvm/llvm-project/pull/86862 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] ba6b2d2 - [LLDB] Add APFloat helper functions to Scalar class. (#86862)

Author: cmtice Date: 2024-03-28T21:39:58-07:00 New Revision: ba6b2d22af177a72b132cdb8e9350a708f282d2c URL: https://github.com/llvm/llvm-project/commit/ba6b2d22af177a72b132cdb8e9350a708f282d2c DIFF: https://github.com/llvm/llvm-project/commit/ba6b2d22af177a72b132cdb8e9350a708f282d2c.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Add APFloat helper functions to Scalar class. (PR #86862)

https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/86862 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix DWARF locations when we have large .dwp files. (PR #87164)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes We have the ability to load .dwp files with a .debug_info.dwo section that exceeds 4GB. There were 4 locations that were using 32 bit offsets and lengths to extract variable locations, and if a DIE was over

[Lldb-commits] [lldb] Fix DWARF locations when we have large .dwp files. (PR #87164)

https://github.com/kusmour approved this pull request. Looks straight forward. Tried the patch locally and it worked! https://github.com/llvm/llvm-project/pull/87164 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Fix type lookup in DWARF .o files via debug map (PR #87177)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Fix type lookup in DWARF .o files via debug map (PR #87177)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pablo Busse (pabusse) Changes An inverted condition causes `SymbolFileDWARFDebugMap::FindTypes` to bail out after inspecting the first .o file in each module. The same kind of bug is found in `SymbolFileDWARFDebugMap::ParseDeclsForContext

[Lldb-commits] [lldb] [lldb] Fix type lookup in DWARF .o files via debug map (PR #87177)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a67b9326cd0448072a1192951f12f3927f31af8c...70938a5d70d3d1e861fd8439bd01ebf737252329 lldb/

[Lldb-commits] [lldb] 154cea4 - [lldb] Fix type lookup in DWARF .o files via debug map (#87177)

Author: Pablo Busse Date: 2024-03-31T17:17:32+01:00 New Revision: 154cea46732f4014bb409f1bcac9b39ac56df193 URL: https://github.com/llvm/llvm-project/commit/154cea46732f4014bb409f1bcac9b39ac56df193 DIFF: https://github.com/llvm/llvm-project/commit/154cea46732f4014bb409f1bcac9b39ac56df193.diff L

[Lldb-commits] [lldb] [lldb] Fix type lookup in DWARF .o files via debug map (PR #87177)

github-actions[bot] wrote: @pabusse Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/87197 Create additional helper functions for the ValueObject class, for: - returning the value as an APSInt or APFloat - additional type casting options - additional ways to create ValueObjects from various types o

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes Create additional helper functions for the ValueObject class, for: - returning the value as an APSInt or APFloat - additional type casting options - additional ways to create ValueObjects from various types of dat

[Lldb-commits] [lldb] 75f7d53 - Fix DWARF locations when we have large .dwp files. (#87164)

Author: Greg Clayton Date: 2024-03-31T12:08:59-07:00 New Revision: 75f7d53f0ba5d77920ea895021b330f261e808cd URL: https://github.com/llvm/llvm-project/commit/75f7d53f0ba5d77920ea895021b330f261e808cd DIFF: https://github.com/llvm/llvm-project/commit/75f7d53f0ba5d77920ea895021b330f261e808cd.diff

[Lldb-commits] [lldb] [lldb] Don't crash when attempting to parse breakpoint id `N.` as `N.*` (PR #87263)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes We check if the next character after `N.` is `*` before we check its length. Using `split` on the string is cleaner and less error prone than using indices with `find` and `substr`. Note: this does not

[Lldb-commits] [lldb] [lldb] Don't crash when attempting to parse breakpoint id `N.` as `N.*` (PR #87263)

https://github.com/jimingham approved this pull request. LGMT https://github.com/llvm/llvm-project/pull/87263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -441,6 +441,19 @@ class ValueObject { virtual int64_t GetValueAsSigned(int64_t fail_value, bool *success = nullptr); + llvm::APSInt GetValueAsAPSInt(); jimingham wrote: Not all SBValues are representable as Int's or Floats, Bool's etc. But I don't s

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -618,6 +631,24 @@ class ValueObject { virtual lldb::ValueObjectSP CastPointerType(const char *name, lldb::TypeSP &type_sp); + /// Return the target load address assocaited with this value object. + lldb::addr_t GetLoadAddres

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP jimingham wrote: Given target

<    33   34   35   36   37   38   39   40   41   42   >