https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/67470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
50abfc4298980fc219c7d70ca2567c61e856b614..5e8b4a44bf48216785f5ecb412e145a7ac4d3a55
lldb/t
https://github.com/pizzud resolved
https://github.com/llvm/llvm-project/pull/66139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/66139
>From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 12 Sep 2023 13:24:48 -0700
Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents
chec
https://github.com/pizzud resolved
https://github.com/llvm/llvm-project/pull/66139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
pizzud wrote:
After looking at the various comments (thanks all!) it feels like the consensus
was:
- don't suggest fixes (done)
- move shared_ptr out to its own check (done in #67467 )
- be more precise in both language and implementation
Is there a reasonable way to detect expensive moves? Loo
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/67470
>From 5e8b4a44bf48216785f5ecb412e145a7ac4d3a55 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 26 Sep 2023 11:04:08 -0700
Subject: [PATCH 1/2] Implement thread local storage for linux
---
lldb/inclu
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the foll
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 1/4] [libc++] Implement ranges::contains_subrange
---
libcxx/i
https://github.com/ZijunZhaoCCK resolved
https://github.com/llvm/llvm-project/pull/66963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2f2319cf2406d9830a331cbf015881c55ae78806
5f33fa63e76b5d0c066773113447749c3428aa99 --
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/67470
>From 5e8b4a44bf48216785f5ecb412e145a7ac4d3a55 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 26 Sep 2023 11:04:08 -0700
Subject: [PATCH 1/3] Implement thread local storage for linux
---
lldb/inclu
https://github.com/aokblast resolved
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aokblast updated
https://github.com/llvm/llvm-project/pull/67106
>From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001
From: aokblast
Date: Fri, 22 Sep 2023 18:11:07 +0800
Subject: [PATCH 1/4] feat: add DynamicLoaderFreeBSDKernel
---
.../Plugins/DynamicLoa
@@ -0,0 +1,172 @@
+//===-- DynamicLoaderFreeBSDKernel.h
+//--===//
aokblast wrote:
Fix it
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commi
https://github.com/aokblast updated
https://github.com/llvm/llvm-project/pull/67106
>From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001
From: aokblast
Date: Fri, 22 Sep 2023 18:11:07 +0800
Subject: [PATCH 1/5] feat: add DynamicLoaderFreeBSDKernel
---
.../Plugins/DynamicLoa
https://github.com/aokblast resolved
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aokblast wrote:
Excuse me. If the code works well now, I want to ask if I need to modify the
commit message by myself so the message looks tidy, or let somebody landing
this pull request modify the message?
https://github.com/llvm/llvm-project/pull/67106
___
Author: jeffreytan81
Date: 2023-09-27T09:14:40-07:00
New Revision: e8ea47602bdb74a88c707d289fc241f7670e1483
URL:
https://github.com/llvm/llvm-project/commit/e8ea47602bdb74a88c707d289fc241f7670e1483
DIFF:
https://github.com/llvm/llvm-project/commit/e8ea47602bdb74a88c707d289fc241f7670e1483.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/67470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aokblast wrote:
Thanks, maybe aokblast is more suitable. XD
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all
the DW_FORM values that have been parsed but are unsupported or otherwise
unknown. AFAICT this functionality does not exist in LLVM at all. Since my
primary goa
jimingham wrote:
First off, note that the case of std::strings is slightly orthogonal to what
you are doing here, because the thing that provides the "semantic" value for a
std::string is the std::string Summary Formatter. std::string doesn't actually
have a synthetic front end provider. So
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
jimingham wrote:
We try to only add really frequently used aliases to the default lldb set. In
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Add the ability to get a C++ vtable ValueObject from another ValueObject.
This patch adds the ability to ask a ValueObject for a ValueObject that
represents the virtual function table for a C++ class. If the ValueObject is
not a C++ class
@@ -374,6 +374,34 @@ class LLDB_API SBValue {
lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write,
SBError &error);
+ /// If this value represents a C++ class that has a vtable, return an value
+ /// that represent
@@ -374,6 +374,34 @@ class LLDB_API SBValue {
lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write,
SBError &error);
+ /// If this value represents a C++ class that has a vtable, return an value
+ /// that represent
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jeffreytan81 wrote:
Looks good in general to me.
Several scenarios to test:
* Make sure command works when the vtable symbol can be found but the vtable
exists in another binary which do not have any symbols/debug info (which we
have seen failure from lldb before)
* Is vtable pointer guarante
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
jimingham wrote:
This is an oft-requested feature so thanks for doing this!
My only real complaint is that the code that determines the C++ "dynamic type"
does much of the work that the ValueObjectVTable has to do to find the vtable
pointer, and it's enough code that it seems a shame to have t
jimingham wrote:
It might also be good to write a test that scribbles on the VTable and make
sure that we present that usefully. That is a significant use case for this
feature.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailin
@@ -1696,6 +1696,40 @@ TEST(Support, ReplacePathPrefix) {
EXPECT_EQ(Path, "C:\\old/foo\\bar");
}
+TEST(Support, FindProgramName) {
+ StringRef WindowsProgName =
+ path::program_name("C:\\Test\\foo.exe", path::Style::windows);
+ EXPECT_EQ(WindowsProgName, "foo");
+
+
https://github.com/jimingham resolved
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> > This is an oft-requested feature so thanks for doing this!
> > My only real complaint is that the code that determines the C++ "dynamic
> > type" does much of the work that the ValueObjectVTable has to do to find
> > the vtable pointer, and it's enough code that it seems a
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/67621
We just forget to check for interrupt while waiting for the answer to the
prompt. But if we are in the interrupt state then the lower layers of the
EditLine code just eat all characters so we never get out of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
We just forget to check for interrupt while waiting for the answer to the
prompt. But if we are in the interrupt state then the lower layers of the
EditLine code just eat all characters so we never get out of the query prompt.
You're prett
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
22433cc541ff706d9e845774ef1c8c959dc67799..fab5e1f67433a29a5d54198d83960d7e608dc480
lldb/t
jimingham wrote:
> LGTM, thanks!
>
> Please fix the python formatting before landing.
Seriously, we're enforcing "" vrs. ''? This is silly.
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
jimingham wrote:
I pushed this from the repro, going through the PR hoops was too much work just
for uglification...
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
LLDB_EXPORT_ALL_SYMBOLS is useful when building out-of-tree plugins and
extensions that rely on LLDB's internal symbols. For example, this is how the
Mojo language provides its REPL and debugger support.
Supporting this on windows is kind
https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812
>From 5f5e57a5c01088e7f0b9276ed02dd436a3f9cc0a Mon Sep 17 00:00:00 2001
From: Dan McGregor
Date: Mon, 14 Aug 2023 18:44:08 -0600
Subject: [PATCH 1/3] Support: hoist lld's executable name code to Path
Instead of usi
https://github.com/dankm resolved
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812
>From 5f5e57a5c01088e7f0b9276ed02dd436a3f9cc0a Mon Sep 17 00:00:00 2001
From: Dan McGregor
Date: Mon, 14 Aug 2023 18:44:08 -0600
Subject: [PATCH 1/4] Support: hoist lld's executable name code to Path
Instead of usi
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/jimingham approved this pull request.
Other than
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +39,37 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/67019
_
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +39,37 @@ Status CommandOptionsProcessLaun
Author: Alex Langford
Date: 2023-09-28T12:18:08-07:00
New Revision: 36a518317fdaab377830f8d18ead9301b06e9e8d
URL:
https://github.com/llvm/llvm-project/commit/36a518317fdaab377830f8d18ead9301b06e9e8d
DIFF:
https://github.com/llvm/llvm-project/commit/36a518317fdaab377830f8d18ead9301b06e9e8d.diff
https://github.com/jimingham resolved
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,298 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -54,134 +54,182 @@ bool
ItaniumABILanguageRuntime::CouldHaveDynamicValue(ValueObject &in_value) {
check_objc);
}
-TypeAndOrName ItaniumABILanguageRuntime::GetTypeInfoFromVTableAddress(
-ValueObject &in_value, ll
https://github.com/jimingham commented:
This is much nicer looking!
I had a couple small comments about apportioning duties between the
ValueObjectVTable::Update and the GetVTableInfo in the comments.
It doesn't look like you handled corrupted tables yet? Are you still intending
to do that?
@@ -0,0 +1,298 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -374,6 +374,34 @@ class LLDB_API SBValue {
lldb::SBWatchpoint WatchPointee(bool resolve_location, bool read, bool write,
SBError &error);
+ /// If this value represents a C++ class that has a vtable, return an value
+ /// that represent
@@ -54,134 +54,182 @@ bool
ItaniumABILanguageRuntime::CouldHaveDynamicValue(ValueObject &in_value) {
check_objc);
}
-TypeAndOrName ItaniumABILanguageRuntime::GetTypeInfoFromVTableAddress(
-ValueObject &in_value, ll
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jeffreytan81 commented:
Oops, I found my old comments from yesterday did not go out. Still need to
learn the new UI.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
> > * Can we test this during multiple inheritance? Should we print multiple
> > vtables?
> [Greg] I can add a test for this and make sure things works when dynamic
> typing is on and off. We won't print multiple vtables, as each class has only
> 1 vtable, it will just inc
aokblast wrote:
As my mentor Li-Wen Hsu suggest, It is better to separate this patch into two
commits. One for DynamicLoaderFreeBSDKernel class, and another for the
modification about ObjectFile.cpp. Should I use 1 commits to include both of
these change or separate it as two?
https://github.
https://github.com/aokblast updated
https://github.com/llvm/llvm-project/pull/67106
>From 17cad831181b07c4397aa78039ede79fc8b20513 Mon Sep 17 00:00:00 2001
From: aokblast
Date: Fri, 29 Sep 2023 15:27:42 +0800
Subject: [PATCH] Add DynamicLoader Plugin Fore FreeBSD Kernel coredump
This patch add
aokblast wrote:
OK, I have modified the commit message.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
9284b03e87df5153fe425b6b81b8402f666deb18..433d3973716cc46e1ffd7044898189f845e536f6
lldb/
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/huixie90 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,145 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jimingham wrote:
This seems like a somewhat limited way to poke a character into the value if
the string has more than one character already in it.
If you are trying to do more fancy setting of the contents of an SBValue, then
it would be more straightforward to get the SBData for the value wi
@@ -231,23 +244,39 @@ def cleanup():
"frame variable is",
substrs=[
multimap,
-"size=4",
-'[0] = (first = 1, second = "is")',
-'[1] = (first = 2, second = "smart")',
-'[2] =
jimingham wrote:
To clear up terminology... Strings had data formatters before AND after this
change. The difference is that you've switched from a "Summary Provider" data
formatter to a "Synthetic Child Provider" data formatter.
It looks like you've made the printing of std::strings less sp
https://github.com/aokblast updated
https://github.com/llvm/llvm-project/pull/67106
>From df60e39a644ddf0973c87f14b784a69b78c359f9 Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Sat, 30 Sep 2023 00:14:08 +0800
Subject: [PATCH 1/2] [clangd] Allow --query-driver to match a dot-normalized
form o
https://github.com/aokblast updated
https://github.com/llvm/llvm-project/pull/67106
>From a05c9b5c082395d0bade0bdef3faf7f00035c96d Mon Sep 17 00:00:00 2001
From: SHENG-YI HONG
Date: Sat, 30 Sep 2023 00:28:38 +0800
Subject: [PATCH] Add DynamicLoader Plugin Fore FreeBSD Kernel coredump This
patc
jimingham wrote:
BTW, I have no problem with the general direction of this change. It makes a
lot more sense to ask a synthetic child provider to change a value - since it
does represent the value of the ValueObject - rather than the summary which is
just some free-form text. And being able
https://github.com/shraiysh updated
https://github.com/llvm/llvm-project/pull/67723
>From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001
From: Shraiysh Vaishay
Date: Thu, 28 Sep 2023 13:35:07 -0500
Subject: [PATCH] [OpenMPIRBuilder] Remove wrapper function in `createTask`
Th
Author: River Riddle
Date: 2023-09-29T10:33:11-07:00
New Revision: a514c30a7cf6ea99e5398b695601235b41a43939
URL:
https://github.com/llvm/llvm-project/commit/a514c30a7cf6ea99e5398b695601235b41a43939
DIFF:
https://github.com/llvm/llvm-project/commit/a514c30a7cf6ea99e5398b695601235b41a43939.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Daniil Kovalev (kovdan01)
Changes
Currently, for x86 and x86_64 triples, "+sse" and "+sse2" are appended to
`Features` vector of `TargetOptions` unconditionally. This vector is later
reset in `TargetInfo::CreateTargetInfo` and filled using
Author: John Harrison
Date: 2024-02-20T09:35:15-08:00
New Revision: ae8facc1f8e8a2d04b5a3519fc1901db110fe452
URL:
https://github.com/llvm/llvm-project/commit/ae8facc1f8e8a2d04b5a3519fc1901db110fe452
DIFF:
https://github.com/llvm/llvm-project/commit/ae8facc1f8e8a2d04b5a3519fc1901db110fe452.diff
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/82428
This is a follow-on to:
https://github.com/llvm/llvm-project/pull/82085
The completer for register names was missing from the argument table. I
somehow missed that the only register completer test was x86_64
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
This is a follow-on to:
https://github.com/llvm/llvm-project/pull/82085
The completer for register names was missing from the argument table. I
somehow missed that the only register completer test was x86_64, so
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5a20a208037d32d52f0c626ea3b199278ff0df0a
9a430ce7c8065f21abef474d233a6b41937563ac --
Author: jimingham
Date: 2024-02-20T14:18:03-08:00
New Revision: 563ef306017a47d387f1c36dd562b172c1ad0626
URL:
https://github.com/llvm/llvm-project/commit/563ef306017a47d387f1c36dd562b172c1ad0626
DIFF:
https://github.com/llvm/llvm-project/commit/563ef306017a47d387f1c36dd562b172c1ad0626.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/82428
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
I believe the concern regarding standardizing the methods for locating debug
information files is valid. Based on my experience, the only reliable approach
to achieving this is either documenting it in a well-agreed spec, document, or
website, or enforcing all symbolication
https://github.com/jeffreytan81 approved this pull request.
https://github.com/llvm/llvm-project/pull/81067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
3301 - 3400 of 103459 matches
Mail list logo
