[Lldb-commits] [lldb] [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (PR #65555)

2023-09-06 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/6 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/wenzhi-cui created https://github.com/llvm/llvm-project/pull/65583: None >From 76107e6a14ca1f496d29bc2f7cb752f39f2665bf Mon Sep 17 00:00:00 2001 From: wenzhi-cui Date: Thu, 7 Sep 2023 11:13:45 +0800 Subject: [PATCH 1/2] Fix AtomicInterfacesTdFiles missing deps/typos in Bazel

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/wenzhi-cui review_requested https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-07 Thread via lldb-commits
@@ -93,4 +93,4 @@ // RUN: not %clang_cc1 -triple riscv64 -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE-RISCV64 // TUNE-RISCV64: error: unknown target CPU 'not-a-cpu' -// TUNE-RISCV64-NEXT: note: valid target CPU values are: generic-rv64, rocket

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
@@ -258,3 +263,302 @@ then ``lldb B`` to trigger ``lldb-server B`` to go into that code and hit the breakpoint. ``lldb-server A`` is only here to let us debug ``lldb-server B`` remotely. +Debugging The Remote Protocol +- + +LLDB mostly follows the

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
https://github.com/bulbazord approved this pull request. All are excellent tips. Thanks for working on this, this is amazing! 😄 https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] 140f616 - [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (#65555)

2023-09-07 Thread via lldb-commits
Author: Alex Date: 2023-09-07T10:16:55-07:00 New Revision: 140f6167b885b4e0d6672a7f41c2b2b551c0204d URL: https://github.com/llvm/llvm-project/commit/140f6167b885b4e0d6672a7f41c2b2b551c0204d DIFF: https://github.com/llvm/llvm-project/commit/140f6167b885b4e0d6672a7f41c2b2b551c0204d.diff LOG: [ll

[Lldb-commits] [lldb] [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (PR #65555)

2023-09-07 Thread via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/6 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (PR #65555)

2023-09-07 Thread via lldb-commits
https://github.com/jimingham commented: A good change, Value is a pretty loaded word in lldb, and doesn't seem directly relevant here. https://github.com/llvm/llvm-project/pull/6 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3398744 - [lldb][Docs] Additions to debuging LLDB page (#65635)

2023-09-08 Thread via lldb-commits
Author: David Spickett Date: 2023-09-08T10:05:16+01:00 New Revision: 3398744a6106c83993611bd3c5e79ec6b94417dc URL: https://github.com/llvm/llvm-project/commit/3398744a6106c83993611bd3c5e79ec6b94417dc DIFF: https://github.com/llvm/llvm-project/commit/3398744a6106c83993611bd3c5e79ec6b94417dc.diff

[Lldb-commits] [lldb] [lldb] Add test to document alias tab completion behaviour (PR #65760)

2023-09-08 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add test to document alias tab completion behaviour (PR #65760)

2023-09-08 Thread via lldb-commits
jimingham wrote: The test is okay, but this seems like confusing behavior to me. Most people who use lldb don't set up command aliases and aren't really aware of which commands are aliases and which are built-in commands. So treating them differently seems wrong to me. If you have a `br` al

[Lldb-commits] [lldb] 0f1a018 - [lldb] Add test to document alias tab completion behaviour (#65760)

2023-09-08 Thread via lldb-commits
Author: David Spickett Date: 2023-09-08T17:08:02+01:00 New Revision: 0f1a01807c137736236fcb9ea4253804e5ec7cf8 URL: https://github.com/llvm/llvm-project/commit/0f1a01807c137736236fcb9ea4253804e5ec7cf8 DIFF: https://github.com/llvm/llvm-project/commit/0f1a01807c137736236fcb9ea4253804e5ec7cf8.diff

[Lldb-commits] [lldb] [lldb] Add test to document alias tab completion behaviour (PR #65760)

2023-09-08 Thread via lldb-commits
jimingham wrote: Just to make sure there's no confusion... The reason that `b` completes to `__regex_break` is that we always prefer exact matches in completion. Since we did: `command alias b __regex_break ` then `b` should only complete to the `b` alias. That makes sense, since executin

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/jimingham review_requested https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/jimingham review_requested https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/jimingham review_requested https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/65822: The problem is that the when the "attach" command is initiated, the ExecutionContext for the command has a process - it's the exited one from the previour run. But the `attach wait` creates a new process for

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/jimingham review_requested https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -2996,10 +2996,22 @@ void CommandInterpreter::FindCommandsForApropos(llvm::StringRef search_word, m_alias_dict); } -ExecutionContext CommandInterpreter::GetExecutionContext() const { - return !m_overriden_exe_contexts.empty() - ? m_o

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -127,3 +128,61 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -127,3 +128,61 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/bulbazord commented: Idea seems good to me. I have similar concerns to Adrian but overall I think I'm on board with this idea. I'm kind of confused why we don't destroy the old Process object after it's exited though, wouldn't properly cleaning up after ourselves solve a lot

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -2996,10 +2996,22 @@ void CommandInterpreter::FindCommandsForApropos(llvm::StringRef search_word, m_alias_dict); } -ExecutionContext CommandInterpreter::GetExecutionContext() const { - return !m_overriden_exe_contexts.empty() - ? m_o

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -127,3 +128,61 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -3156,23 +3156,22 @@ Status Process::Halt(bool clear_thread_plans, bool use_run_lock) { // case it was already set and some thread plan logic calls halt on its own. m_clear_thread_plans_on_stop |= clear_thread_plans; - ListenerSP halt_listener_sp( - Listener::Mak

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -12,10 +12,13 @@ int main(int argc, char const *argv[]) { // Waiting to be attached by the debugger. temp = 0; +if (argc > 1 && argv[1][0] == 'q') + return 0; + while (temp < 30) { -std::this_thread::sleep_for(std::chrono::seconds(2)); // Wa

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/65822: >From e98672b9f4b02c2baac5ed5dcd94afa9a78e35b6 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Fri, 8 Sep 2023 16:18:48 -0700 Subject: [PATCH 1/2] Fix a bug with cancelling "attach -w" after you have run a pr

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -127,3 +128,61 @@ def tearDown(self): # Call super's tearDown(). TestBase.tearDown(self) + +def test_run_then_attach_wait_interrupt(self): +# Test that having run one process doesn't cause us to be unable +# to interrupt a

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -12,10 +12,13 @@ int main(int argc, char const *argv[]) { // Waiting to be attached by the debugger. temp = 0; +if (argc > 1 && argv[1][0] == 'q') + return 0; + while (temp < 30) { -std::this_thread::sleep_for(std::chrono::seconds(2)); // Wa

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -3156,23 +3156,22 @@ Status Process::Halt(bool clear_thread_plans, bool use_run_lock) { // case it was already set and some thread plan logic calls halt on its own. m_clear_thread_plans_on_stop |= clear_thread_plans; - ListenerSP halt_listener_sp( - Listener::Mak

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
jimingham wrote: > After a process exits you might still want to ask it what its exit status was. Plus there might be other system accounting we've gathered for that process. So until you replace it with another process, you very well might want to ask questions of it. So we can't just de

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -12,10 +12,13 @@ int main(int argc, char const *argv[]) { // Waiting to be attached by the debugger. temp = 0; +if (argc > 1 && argv[1][0] == 'q') + return 0; + while (temp < 30) { -std::this_thread::sleep_for(std::chrono::seconds(2)); // Wa

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/bulbazord resolved https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
bulbazord wrote: > This is in reply to Alex's comment about why we keep the process around, but > the quote this reply didn't seem to work... > > After a process exits you might still want to ask it what its exit status > was. Plus there might be other system accounting we've gathered for that

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
@@ -3156,23 +3156,22 @@ Status Process::Halt(bool clear_thread_plans, bool use_run_lock) { // case it was already set and some thread plan logic calls halt on its own. m_clear_thread_plans_on_stop |= clear_thread_plans; - ListenerSP halt_listener_sp( - Listener::Mak

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-08 Thread via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [MC][RISCV] Add assembly syntax highlighting for RISCV (PR #65853)

2023-09-10 Thread via lldb-commits
=?utf-8?q?Björn_Schäpers?= ,Mehdi Amini ,Vitaly Buka ,Vitaly Buka ,Vitaly Buka ,Mehdi Amini ,Shilei Tian ,"Kazushi (Jam) Marukawa" ,Fabian Mora ,Kazushi Marukawa ,Jonas Devlieghere ,Jan Svoboda ,Jan Svoboda ,Alex Brachet ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Fan

[Lldb-commits] [lldb] [MC][RISCV] Add assembly syntax highlighting for RISCV (PR #65853)

2023-09-10 Thread via lldb-commits
=?utf-8?q?Björn_Schäpers?= ,Mehdi Amini ,Vitaly Buka ,Vitaly Buka ,Vitaly Buka ,Mehdi Amini ,Shilei Tian ,"Kazushi (Jam) Marukawa" ,Fabian Mora ,Kazushi Marukawa ,Jonas Devlieghere ,Jan Svoboda ,Jan Svoboda ,Alex Brachet ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Fan

[Lldb-commits] [lldb] [MC][RISCV] Add assembly syntax highlighting for RISCV (PR #65853)

2023-09-10 Thread via lldb-commits
=?utf-8?q?Björn_Schäpers?= ,Mehdi Amini ,Vitaly Buka ,Vitaly Buka ,Vitaly Buka ,Mehdi Amini ,Shilei Tian ,"Kazushi (Jam) Marukawa" ,Fabian Mora ,Kazushi Marukawa ,Jonas Devlieghere ,Jan Svoboda ,Jan Svoboda ,Alex Brachet ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Fan

[Lldb-commits] [lldb] [MC][RISCV] Add assembly syntax highlighting for RISCV (PR #65853)

2023-09-10 Thread via lldb-commits
=?utf-8?q?Björn_Schäpers?= ,Mehdi Amini ,Vitaly Buka ,Vitaly Buka ,Vitaly Buka ,Mehdi Amini ,Shilei Tian ,"Kazushi (Jam) Marukawa" ,Fabian Mora ,Kazushi Marukawa ,Jonas Devlieghere ,Jan Svoboda ,Jan Svoboda ,Alex Brachet ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Fan

[Lldb-commits] [lldb] [MC][RISCV] Add assembly syntax highlighting for RISCV (PR #65853)

2023-09-10 Thread via lldb-commits
=?utf-8?q?Björn_Schäpers?= ,Mehdi Amini ,Vitaly Buka ,Vitaly Buka ,Vitaly Buka ,Mehdi Amini ,Shilei Tian ,"Kazushi (Jam) Marukawa" ,Fabian Mora ,Kazushi Marukawa ,Jonas Devlieghere ,Jan Svoboda ,Jan Svoboda ,Alex Brachet ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Jan Svoboda ,Fan

[Lldb-commits] [lldb] [lldb] Correctly invalidate unloaded image tokens (PR #65945)

2023-09-11 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65945 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correctly invalidate unloaded image tokens (PR #65945)

2023-09-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Some functions in Process were using LLDB_INVALID_ADDRESS instead of LLDB_INVALID_TOKEN. The only visible effect of this appears to be that "process unload " would complete to 0 even after the image was unloaded. Since the command is checking

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-11 Thread via lldb-commits
jimingham wrote: It seems a bit weird to have an Execution context with a thread and a stack frame but not the process they belong to. I think it's easier to deal with it when we hand them out. Jim > On Sep 9, 2023, at 11:57 AM, Greg Clayton ***@***.***> wrote: > > > @clayborg commented

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes * Assert no completions for tests that should not find completions. * Remove regex mode from complete_from_to, which was unused. This exposed bugs in 2 of the tests, target stop-hook and process unload. These were fixed in previous commits but

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Previously we would check all built-ins first for suggestions, then check built-ins and aliases. This meant that if you had an alias brkpt -> breakpoint, "br" would complete to "breakpoint". Instead of giving you the choice of "brkpt" or "break

[Lldb-commits] [lldb] 3125bd4 - [lldb] Correctly invalidate unloaded image tokens (#65945)

2023-09-11 Thread via lldb-commits
Author: David Spickett Date: 2023-09-11T17:12:09+01:00 New Revision: 3125bd4bc7367a05ddf5477793a1ee51cecc3046 URL: https://github.com/llvm/llvm-project/commit/3125bd4bc7367a05ddf5477793a1ee51cecc3046 DIFF: https://github.com/llvm/llvm-project/commit/3125bd4bc7367a05ddf5477793a1ee51cecc3046.diff

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-11 Thread via lldb-commits
jimingham wrote: > > This is in reply to Alex's comment about why we keep the process around, > > but the quote this reply didn't seem to work... > > After a process exits you might still want to ask it what its exit status > > was. Plus there might be other system accounting we've gathered for

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format more Python files with black (PR #65979)

2023-09-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes By running this from lldb/ $ black --exclude "third_party/|scripts/|utils/" ./ -- Patch is 21.03 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/65979.diff 9 Files Affected: - (modified) lldb/bindi

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham commented: This looks right to me, but I'm worried about why you had to change the "h" completion test to "he"? https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/65973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Other than that tiny quibble, this looks fine to me. https://github.com/llvm/llvm-project/pull/65973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] Improve completion tests (PR #65973)

2023-09-11 Thread via lldb-commits
@@ -2254,21 +2251,18 @@ def complete_from_to(self, str_input, patterns, turn_off_re_match=False): for idx in range(1, num_matches + 1): compare_string += match_strings.GetStringAtIndex(idx) + "\n" +# If the singular pattern is the

[Lldb-commits] [lldb] 2378ba6 - [lldb] Improve completion tests (#65973)

2023-09-11 Thread via lldb-commits
Author: David Spickett Date: 2023-09-11T18:26:51+01:00 New Revision: 2378ba632e5cdc761584a4154449833ac0f86384 URL: https://github.com/llvm/llvm-project/commit/2378ba632e5cdc761584a4154449833ac0f86384 DIFF: https://github.com/llvm/llvm-project/commit/2378ba632e5cdc761584a4154449833ac0f86384.diff

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self): self.assertTrue(result.Succeeded()) self.assertEqual("apropos script", result.GetOutput()) -command_interpreter.ResolveCommand("h", result) +command_interpreter.ResolveCommand("

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-11 Thread via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/66001: Instead of creating a copy of the vector, we should just pass a reference along. The only method that calls this Ctor also holds onto a non-mutable reference to the vector of strings, so this should just make

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-11 Thread via lldb-commits
https://github.com/bulbazord review_requested https://github.com/llvm/llvm-project/pull/66001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-11 Thread via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/66001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-11 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Instead of creating a copy of the vector, we should just pass a reference along. The only method that calls this Ctor also holds onto a non-mutable reference to the vector of strings so a copy should be unnecessary. -- Full diff: https://githu

[Lldb-commits] [lldb] a2a9918 - [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (#65687)

2023-09-11 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-09-11T17:00:01-04:00 New Revision: a2a9918a8524f3f7675297b75daa2a80bc0790ff URL: https://github.com/llvm/llvm-project/commit/a2a9918a8524f3f7675297b75daa2a80bc0790ff DIFF: https://github.com/llvm/llvm-project/commit/a2a9918a8524f3f7675297b75daa2a80bc0790ff.di

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Makes sense https://github.com/llvm/llvm-project/pull/66001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham resolved https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

2023-09-11 Thread via lldb-commits
https://github.com/jimingham resolved https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc][libm][GPU] Added missing vendor entry points to `libm` for GPUs (PR #66031)

2023-09-11 Thread via lldb-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=, Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar <1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song ,Razvan Lupusoru ,Walter Erquinigo ,"Yaxun (Sam) Liu" ,Nico Weber ,Stella Laurenzo ,Lang Hames ,Matthias Braun ,Arthur

[Lldb-commits] [lldb] [libc][libm][GPU] Added missing vendor entry points to `libm` for GPUs (PR #66031)

2023-09-11 Thread via lldb-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=, Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar <1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song ,Razvan Lupusoru ,Walter Erquinigo ,"Yaxun (Sam) Liu" ,Nico Weber ,Stella Laurenzo ,Lang Hames ,Matthias Braun ,Arthur

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-11 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66035 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Summary: Add a new command ``` target modules dump separate-debug-info [ ...] ``` or ``` image dump separate-debug-info [ ...] ``` (since `image` is an alias for `target modules`). This lists the separate debug info files and their current sta

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-11 Thread via lldb-commits
jimingham wrote: I don't think the lldb command line dumps raw JSON anywhere as a command result. Can we make something a little more human readable? https://github.com/llvm/llvm-project/pull/66035 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-11 Thread via lldb-commits
jimingham wrote: BTW, the idea seems useful to me, but particularly if you're doing OSO you can get a whole lot of these so a space efficient presentation where you can scan the names easily, etc, will be important as well. https://github.com/llvm/llvm-project/pull/66035 __

[Lldb-commits] [lldb] c8387a3 - [lldb] Format more Python files with black (#65979)

2023-09-12 Thread via lldb-commits
Author: David Spickett Date: 2023-09-12T08:46:34+01:00 New Revision: c8387a31a4adfa9c29a578cf67321f756d3b4ac1 URL: https://github.com/llvm/llvm-project/commit/c8387a31a4adfa9c29a578cf67321f756d3b4ac1 DIFF: https://github.com/llvm/llvm-project/commit/c8387a31a4adfa9c29a578cf67321f756d3b4ac1.diff

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Using: black --exclude "third_party/" ./lldb/ -- Patch is 108.25 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/66053.diff 17 Files Affected: - (modified) lldb/scripts/analyze-project-deps.py (+42-

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-12 Thread via lldb-commits
jimingham wrote: Excellent, thanks for chasing that logic down. This is the correct solution, since we really do want `h` to mean `help` not just accidentally. https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

2023-09-12 Thread via lldb-commits
jimingham wrote: I don't see where you approve a PR in this UI but this is approved. https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread via lldb-commits
jimingham wrote: > > I don't think the lldb command line dumps raw JSON anywhere as a command > > result. Can we make something a little more human readable? > > It was my idea to make this JSON. The problem is each debug info (.dwo and > DWARF in .o files for Mac) has very different fields an

[Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

2023-09-12 Thread via lldb-commits
@@ -2005,9 +2021,10 @@ class CommandObjectTargetModulesDumpSymtab result.GetOutputStream().EOL(); result.GetOutputStream().EOL(); } - if (INTERRUPT_REQUESTED(GetDebugger(), + if (INTERRUPT_REQUESTED(GetDebugger(), ---

[Lldb-commits] [lldb] [AMDGPU] Port AMDGPURewriteUndefForPHI to new pass manager (PR #66008)

2023-09-12 Thread via lldb-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/66008: >From c68ad692f9d4c657f5dfaeb5d8c52c5331ebbb64 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Mon, 11 Sep 2023 15:25:42 -0500 Subject: [PATCH 1/2] [AMDGPU] Port AMDGPURewriteUndefForPHI to new pass manager T

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-12 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes This exposes the `eBroadcastBitSymbolChange` bit to the SB API to show when a symbol change event has been broadcast as this wasn't being done before. Also refactors `eBroadcastSymbolChange` to `eBroadcastBitSymbolChange` to matc

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-09-12 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/10] [libc++] Implement ranges::contains Differential Revisio

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-09-12 Thread via lldb-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] 6412258 - [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (#66001)

2023-09-12 Thread via lldb-commits
Author: Alex Date: 2023-09-12T15:32:06-07:00 New Revision: 64122580c0809fc6fc15bd955fea4e9ace80a135 URL: https://github.com/llvm/llvm-project/commit/64122580c0809fc6fc15bd955fea4e9ace80a135 DIFF: https://github.com/llvm/llvm-project/commit/64122580c0809fc6fc15bd955fea4e9ace80a135.diff LOG: [ll

[Lldb-commits] [lldb] [lldb][NFCI] BreakpointResolverName ctor shouldn't unnecessarily copy data (PR #66001)

2023-09-12 Thread via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/66001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-12 Thread via lldb-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/66139: >From b699129b21c95571410a809d16fdf8cfcf1526c5 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 12 Sep 2023 13:24:48 -0700 Subject: [PATCH 1/2] [clang-tidy] Add performance-move-smart-pointer-contents che

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

2023-09-12 Thread via lldb-commits
@@ -0,0 +1,80 @@ +//===--- MoveSmartPointerContentsCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

<    26   27   28   29   30   31   32   33   34   35   >