zturner added a comment.
Is this necessary because of a standalone build, or for some other reason? If
this is to get Standalone build working, then it seems like this isn't really a
complete solution, because standalone build still wouldn't work on Windows
since it would still be trying to in
zturner added a comment.
What if we added a function to `llvm/DebugInfo/PDB/PDB.h` called
`isDiaSupported()`, and in the implementation it returns `true` if the
definition is present and `false` otherwise. Then instead of using the
pre-processor to decide whether to run the test, we run all of
Author: zturner
Date: Wed Nov 2 11:59:42 2016
New Revision: 285834
URL: http://llvm.org/viewvc/llvm-project?rev=285834&view=rev
Log:
Fix some warnings compiling with clang-cl on Windows.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
lldb/trunk/source
zturner added a comment.
That sounds reasonable.
https://reviews.llvm.org/D26249
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Nice improvement. I assume you ran the test suite and everything passed?
Repository:
rL LLVM
https://reviews.llvm.org/D26233
___
lldb-commi
Me too, just wanted to make sure with such a large change. Anyway LGTM
On Wed, Nov 2, 2016 at 10:43 AM Malcolm Parsons
wrote:
> malcolm.parsons added a comment.
>
> In https://reviews.llvm.org/D26233#586005, @zturner wrote:
>
> > Nice improvement. I assume you ran the test suite and everything
Author: zturner
Date: Wed Nov 2 12:42:12 2016
New Revision: 285843
URL: http://llvm.org/viewvc/llvm-project?rev=285843&view=rev
Log:
Fix crash in PseudoTerminal on Windows.
Patch by Rudy Pons
Differential Revision: https://reviews.llvm.org/D25681
Modified:
lldb/trunk/source/Utility/PseudoTe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285843: Fix crash in PseudoTerminal on Windows. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D25681?vs=75426&id=76742#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
looks good, sorry for the delay was busy with the LLVM dev conference.
Comment at: unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:33-36
+#if defined(_MSC_VER)
+#includ
zturner created this revision.
zturner added reviewers: beanz, jingham.
zturner added a subscriber: lldb-commits.
It was pretty difficult to understand the logic of this function. I think this
re-write makes it easier. It also continues the effort of moving more
functions to take `StringRef` i
Author: zturner
Date: Sun Nov 6 18:07:25 2016
New Revision: 286088
URL: http://llvm.org/viewvc/llvm-project?rev=286088&view=rev
Log:
Convert some helper functions to use StringRef.
I will probably submit a lot of small trivial changes
like this over the coming weeks. The end goal is to
convert
Why not? Just because llvm isn't building support for targeting some
architecture doesn't mean lldb shouldn't be able to debug those
architectures. We could add a similar LLDB specific define, but using
llvm's seems wrong
On Sun, Nov 6, 2016 at 6:13 PM Vedant Kumar via lldb-commits <
lldb-commits@l
Just to be clear, if the unit test depends on functionality that isn't
present when this target isn't defined, then your original patch sounds
correct.
On Mon, Nov 7, 2016 at 11:06 AM Vedant Kumar wrote:
>
> > On Nov 7, 2016, at 8:20 AM, Zachary Turner wrote:
> >
>
Author: zturner
Date: Mon Nov 7 22:12:42 2016
New Revision: 286204
URL: http://llvm.org/viewvc/llvm-project?rev=286204&view=rev
Log:
Rewrite OutputFormattedHelpText in terms of StringRef.
This makes the logic easier to follow and also propagates
StringRef up to the API boundary, which is necessa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286204: Rewrite OutputFormattedHelpText in terms of
StringRef. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26325?vs=76970&id=77138#toc
Repository:
rL LLVM
https://revie
Author: zturner
Date: Mon Nov 7 22:52:16 2016
New Revision: 286208
URL: http://llvm.org/viewvc/llvm-project?rev=286208&view=rev
Log:
Convert some Expression parser functions to StringRef.
Modified:
lldb/trunk/include/lldb/Core/RegularExpression.h
lldb/trunk/include/lldb/Expression/Expres
On Sun, Oct 30, 2016 at 9:57 PM Chris Bieneman via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=285542&r1=285541&r2=28554
Was just about to comment on this. Thanks!
On Tue, Nov 8, 2016 at 10:24 AM Chris Bieneman via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Tue Nov 8 12:14:42 2016
> New Revision: 286258
>
> URL: http://llvm.org/viewvc/llvm-project?rev=286258&view=rev
> Log:
> [
Author: zturner
Date: Tue Nov 8 16:23:50 2016
New Revision: 286303
URL: http://llvm.org/viewvc/llvm-project?rev=286303&view=rev
Log:
Fix some cases where we were printf'ing StringRefs.
Modified:
lldb/trunk/source/Interpreter/Args.cpp
Modified: lldb/trunk/source/Interpreter/Args.cpp
URL:
ht
Maybe just inline the initializations so we don't have to repeat code
across multiple constructors? i.e.
bool m_is_resolved = false;
in the header file.
On Thu, Nov 10, 2016 at 8:54 PM Sam McCall via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> sammccall created this revision.
> sammcc
Yea, I agree doing it for a whole class at a time should be the standard
On Fri, Nov 11, 2016 at 9:10 AM Jim Ingham wrote:
>
> > On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >
> > Maybe just inline the initi
;
> > On Nov 11, 2016, at 9:11 AM, Zachary Turner wrote:
> >
> > Yea, I agree doing it for a whole class at a time should be the standard
> > On Fri, Nov 11, 2016 at 9:10 AM Jim Ingham wrote:
> >
> > > On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-
Author: zturner
Date: Sat Nov 12 10:56:13 2016
New Revision: 286722
URL: http://llvm.org/viewvc/llvm-project?rev=286722&view=rev
Log:
Disable sanitizer tests on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/deco
Author: zturner
Date: Sat Nov 12 10:56:47 2016
New Revision: 286723
URL: http://llvm.org/viewvc/llvm-project?rev=286723&view=rev
Log:
Make Options::SetOptionValue take a StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/Options.h
lldb/trunk/include/lldb/Target/Process.h
lldb/tr
Author: zturner
Date: Sat Nov 12 12:17:36 2016
New Revision: 286726
URL: http://llvm.org/viewvc/llvm-project?rev=286726&view=rev
Log:
Make ValueObjectMemory::Create accept StringRefs.
Modified:
lldb/trunk/include/lldb/Core/ValueObjectMemory.h
lldb/trunk/source/Breakpoint/Watchpoint.cpp
Author: zturner
Date: Sat Nov 12 12:47:11 2016
New Revision: 286728
URL: http://llvm.org/viewvc/llvm-project?rev=286728&view=rev
Log:
Make CommandReturnObject methods accept StringRefs.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandReturnObject.h
lldb/trunk/source/Interpreter/Comma
Author: zturner
Date: Sat Nov 12 13:12:56 2016
New Revision: 286730
URL: http://llvm.org/viewvc/llvm-project?rev=286730&view=rev
Log:
Make DiagnosticsManager functions take StringRefs.
Modified:
lldb/trunk/include/lldb/Expression/DiagnosticManager.h
lldb/trunk/source/Expression/Diagnostic
Author: zturner
Date: Sat Nov 12 14:41:02 2016
New Revision: 286731
URL: http://llvm.org/viewvc/llvm-project?rev=286731&view=rev
Log:
Make CommandObject help getters/setters use StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandAlias.h
lldb/trunk/include/lldb/Interpreter/Com
Author: zturner
Date: Sat Nov 12 20:08:22 2016
New Revision: 286740
URL: http://llvm.org/viewvc/llvm-project?rev=286740&view=rev
Log:
Change ArgumentHelpCallbackFunction to return a StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandObject.h
lldb/trunk/source/Interpreter/Comm
Author: zturner
Date: Sat Nov 12 20:50:32 2016
New Revision: 286742
URL: http://llvm.org/viewvc/llvm-project?rev=286742&view=rev
Log:
Change some more CommandObject functions to StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandObject.h
lldb/trunk/include/lldb/Interpreter/Co
Author: zturner
Date: Sat Nov 12 21:05:58 2016
New Revision: 286743
URL: http://llvm.org/viewvc/llvm-project?rev=286743&view=rev
Log:
Change IOHandlerConfirm to use StringRefs.
Modified:
lldb/trunk/include/lldb/Core/IOHandler.h
lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h
Author: zturner
Date: Sat Nov 12 21:29:46 2016
New Revision: 286744
URL: http://llvm.org/viewvc/llvm-project?rev=286744&view=rev
Log:
Change ValueObject creation functions to take StringRefs.
Modified:
lldb/trunk/include/lldb/Core/ValueObject.h
lldb/trunk/include/lldb/DataFormatters/TypeS
Author: zturner
Date: Sat Nov 12 21:36:01 2016
New Revision: 286745
URL: http://llvm.org/viewvc/llvm-project?rev=286745&view=rev
Log:
Fix some use-after-frees that my last CL introduced.
Modified:
lldb/trunk/include/lldb/Host/XML.h
lldb/trunk/source/Host/common/XML.cpp
Modified: lldb/tru
Author: zturner
Date: Sat Nov 12 22:24:38 2016
New Revision: 286747
URL: http://llvm.org/viewvc/llvm-project?rev=286747&view=rev
Log:
Make OptionParser::Parse() take StringRef.
Modified:
lldb/trunk/include/lldb/Host/OptionParser.h
lldb/trunk/source/Host/common/OptionParser.cpp
lldb/tr
ctly called the default constructor). To me this seems part and parcel
> of using in-class initializers consistently, but LMK if I should revert
> that.
>
> On Fri, Nov 11, 2016 at 6:11 PM, Zachary Turner
> wrote:
>
> Yea, I agree doing it for a whole class at a time should be the
zturner created this revision.
zturner added reviewers: tfiala, beanz.
zturner added a subscriber: lldb-commits.
I have locally a a very large patch which removes the method of `StreamString`
that returns a reference to the underlying `std::string` buffer, and instead
returns a `StringRef`. The
Author: zturner
Date: Mon Nov 14 17:23:31 2016
New Revision: 286906
URL: http://llvm.org/viewvc/llvm-project?rev=286906&view=rev
Log:
Fix some StringRef Printf warnings.
Modified:
lldb/trunk/source/Commands/CommandObjectMultiword.cpp
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Author: zturner
Date: Mon Nov 14 18:45:18 2016
New Revision: 286915
URL: http://llvm.org/viewvc/llvm-project?rev=286915&view=rev
Log:
Fix some more StringRef printf warnings.
Modified:
lldb/trunk/source/Commands/CommandObjectPlatform.cpp
lldb/trunk/source/Commands/CommandObjectThread.cpp
Author: zturner
Date: Mon Nov 14 18:45:23 2016
New Revision: 286916
URL: http://llvm.org/viewvc/llvm-project?rev=286916&view=rev
Log:
Fix some more Printf warnings.
Modified:
lldb/trunk/source/Interpreter/CommandAlias.cpp
Modified: lldb/trunk/source/Interpreter/CommandAlias.cpp
URL:
http://
Author: zturner
Date: Tue Nov 15 14:11:01 2016
New Revision: 287016
URL: http://llvm.org/viewvc/llvm-project?rev=287016&view=rev
Log:
One more fix for Printf. Apparently I fail at incremental builds.
Modified:
lldb/trunk/source/Commands/CommandObjectSyntax.cpp
Modified: lldb/trunk/source/Co
Author: zturner
Date: Tue Nov 15 14:13:14 2016
New Revision: 287017
URL: http://llvm.org/viewvc/llvm-project?rev=287017&view=rev
Log:
Make some code not manipulate the underlying string of a StreamString.
Differential Revision: https://reviews.llvm.org/D26618
Modified:
lldb/trunk/source/Plug
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287017: Make some code not manipulate the underlying string
of a StreamString. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26618?vs=77830&id=78050#toc
Repository:
rL LLV
Author: zturner
Date: Tue Nov 15 17:36:43 2016
New Revision: 287055
URL: http://llvm.org/viewvc/llvm-project?rev=287055&view=rev
Log:
Change Property::GetName() and GetDescription() to return StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/OptionValueProperties.h
lldb/trunk/inclu
zturner created this revision.
zturner added reviewers: beanz, tfiala.
zturner added a subscriber: lldb-commits.
As per the title. beanz@, could you specifically look over my usage of
`llvm::Twine`? This is the first time I've used this class, and I'm not sure
if I'm using it correctly / effic
Thanks for working on this! I love seeing code get deleted almost as much
as I love seeing it get added :)
On Wed, Nov 16, 2016 at 3:04 AM Pavel Labath wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL287096: Remove TimeValue class (authore
Either way is fine, I think you might have hit a merge conflict if you
stacked them, but if you've already worked through it, then no big deal.
On Wed, Nov 16, 2016 at 11:30 AM Todd Fiala wrote:
> tfiala added a comment.
>
> I'm going to test this one now, stacked on top of the final macOS-worki
Sweet. Glad to see that such a large patch had only minor implications.
Thanks for the help!
On Wed, Nov 16, 2016 at 11:28 AM Todd Fiala wrote:
> tfiala accepted this revision.
> tfiala added a comment.
> This revision is now accepted and ready to land.
>
> Here is the adjusted patch that fixes
BTW, I would still like to get Chris to take a look at my usage of
llvm::Twine. Even if it works, I'm not sure if I used it correctly.
On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner wrote:
> Either way is fine, I think you might have hit a merge conflict if you
> stacked them, bu
is applied on a
clean repo? So ToT > ::my original patch:: > ::your set of fixes::, and
just give me your set of fixes?
On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner wrote:
> Sweet. Glad to see that such a large patch had only minor implications.
> Thanks for the help!
>
> On W
(A full patch works too if it's easier, as long as it applies cleanly on
ToT)
On Wed, Nov 16, 2016 at 11:46 AM Zachary Turner wrote:
> What revision should I apply this on top of? It doesn't apply cleanly for
> me at tip. I think it's my fault because of the original
I got it applied, comitting shortly.
On Wed, Nov 16, 2016 at 11:48 AM Zachary Turner wrote:
> (A full patch works too if it's easier, as long as it applies cleanly on
> ToT)
>
> On Wed, Nov 16, 2016 at 11:46 AM Zachary Turner
> wrote:
>
> What revision should I
Author: zturner
Date: Wed Nov 16 15:34:22 2016
New Revision: 287155
URL: http://llvm.org/viewvc/llvm-project?rev=287155&view=rev
Log:
Update GenerateAdditionalHelpAvenues to take StringRef.
Modified:
lldb/trunk/source/Commands/CommandObjectCommands.cpp
lldb/trunk/source/Commands/CommandOb
Author: zturner
Date: Wed Nov 16 15:45:04 2016
New Revision: 287157
URL: http://llvm.org/viewvc/llvm-project?rev=287157&view=rev
Log:
Make Apropos functions accept StringRefs.
Modified:
lldb/trunk/include/lldb/Core/UserSettingsController.h
lldb/trunk/include/lldb/Interpreter/CommandInterp
Author: zturner
Date: Wed Nov 16 15:45:11 2016
New Revision: 287158
URL: http://llvm.org/viewvc/llvm-project?rev=287158&view=rev
Log:
Fix some unit test compilation failures.
Modified:
lldb/trunk/unittests/Core/TimerTest.cpp
lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsT
Todd Fiala wrote:
> Yep - I followed that. I'm just doing the "build + test" verification on
> macOS.
>
>
> On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner
> wrote:
>
> BTW, I would still like to get Chris to take a look at my usage of
> llvm::Twine. E
try it at home on macOS, but I don't think you need to hold up
> with the aforementioned caveat on running the Linux tests.
>
>
> On Wednesday, November 16, 2016, Zachary Turner
> wrote:
>
> Hey Todd, Did you run the tests earlier? If so what was the result? No
&
ov 16, 2016 at 3:41 PM, Zachary Turner
> wrote:
>
> It's no problem, I actually found a few functions I forgot to convert, so
> I'm making some additional changes. Nothing that requires additional
> testing, but at the very least I won't be able to get this in un
Author: zturner
Date: Wed Nov 16 19:37:42 2016
New Revision: 287188
URL: http://llvm.org/viewvc/llvm-project?rev=287188&view=rev
Log:
Convert AutoComplete related code to StringRef.
Differential Revision: https://reviews.llvm.org/D26721
Modified:
lldb/trunk/include/lldb/Core/ArchSpec.h
l
Author: zturner
Date: Wed Nov 16 19:37:52 2016
New Revision: 287189
URL: http://llvm.org/viewvc/llvm-project?rev=287189&view=rev
Log:
Make GetValueForVariableExpression use StringRef.
Also significantly reduced the indentation level by use of
early returns, and simplified some of the logic by usi
Author: zturner
Date: Wed Nov 16 19:38:02 2016
New Revision: 287190
URL: http://llvm.org/viewvc/llvm-project?rev=287190&view=rev
Log:
Convert UriParser to use StringRef.
Modified:
lldb/trunk/include/lldb/Core/UUID.h
lldb/trunk/source/Core/UUID.cpp
lldb/trunk/source/Interpreter/OptionV
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287188: Convert AutoComplete related code to StringRef.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D26721?vs=78110&id=78299#toc
Repository:
rL LLVM
https://reviews.llvm
Looks like this broke some bots, i can fix it up in about 30 minutes
On Wed, Nov 16, 2016 at 5:47 PM Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: zturner
> Date: Wed Nov 16 19:38:02 2016
> New Revision: 287190
>
> URL: http://llvm.org/vi
Author: zturner
Date: Wed Nov 16 23:14:32 2016
New Revision: 287208
URL: http://llvm.org/viewvc/llvm-project?rev=287208&view=rev
Log:
Fix warnings and errors introduced with UUID changes.
Modified:
lldb/trunk/source/Interpreter/OptionValueUUID.cpp
lldb/trunk/source/Target/StackFrame.cpp
Author: zturner
Date: Thu Nov 17 00:13:54 2016
New Revision: 287212
URL: http://llvm.org/viewvc/llvm-project?rev=287212&view=rev
Log:
Fix one more build error with lldb-server.
Modified:
lldb/trunk/tools/lldb-server/Acceptor.cpp
Modified: lldb/trunk/tools/lldb-server/Acceptor.cpp
URL:
http:
Author: zturner
Date: Thu Nov 17 12:08:12 2016
New Revision: 287242
URL: http://llvm.org/viewvc/llvm-project?rev=287242&view=rev
Log:
Rewrite all Property related functions in terms of StringRef.
This was a bit tricky, especially for things like
OptionValueArray and OptionValueDictionary since th
Author: zturner
Date: Thu Nov 17 15:15:14 2016
New Revision: 287259
URL: http://llvm.org/viewvc/llvm-project?rev=287259&view=rev
Log:
Convert Platform, Process, and Connection functions to StringRef.
All tests pass on Linux and Windows.
Modified:
lldb/trunk/include/lldb/Core/Connection.h
Author: zturner
Date: Thu Nov 17 15:54:37 2016
New Revision: 287266
URL: http://llvm.org/viewvc/llvm-project?rev=287266&view=rev
Log:
Make GetRegisterByName() take a StringRef.
This one is fairly trivial and only really involves changing
function signatures and a few simple call-sites.
Modified:
Author: zturner
Date: Thu Nov 17 17:05:28 2016
New Revision: 287279
URL: http://llvm.org/viewvc/llvm-project?rev=287279&view=rev
Log:
Change RegisterValue getters / setters to use StringRef.
In the process, found some functions that were duplicates of
existing StringRef member functions. So dele
Author: zturner
Date: Thu Nov 17 17:32:26 2016
New Revision: 287281
URL: http://llvm.org/viewvc/llvm-project?rev=287281&view=rev
Log:
Revert "Change RegisterValue getters / setters to use StringRef."
This reverts commit r287279, which breaks some register
tests on Linux.
Modified:
lldb/trunk
Author: zturner
Date: Thu Nov 17 17:47:31 2016
New Revision: 287282
URL: http://llvm.org/viewvc/llvm-project?rev=287282&view=rev
Log:
Resubmit "Change RegisterValue getters / setters to use StringRef."
This resubmits r287279 with a fix for the original issue, which
was a trivial typo.
Modified:
Author: zturner
Date: Thu Nov 17 21:51:19 2016
New Revision: 287307
URL: http://llvm.org/viewvc/llvm-project?rev=287307&view=rev
Log:
Remove some dead code in ValueObject.
Originally I converted this entire function and all dependents
to use StringRef, but there were some test failures that
were
Author: zturner
Date: Thu Nov 17 22:30:47 2016
New Revision: 287308
URL: http://llvm.org/viewvc/llvm-project?rev=287308&view=rev
Log:
Delete more dead code in ValueObject.
Apparently these two enormous functions were dead. Which is
good, since one was largely a copy of another function with
only
Author: zturner
Date: Thu Nov 17 23:45:41 2016
New Revision: 287315
URL: http://llvm.org/viewvc/llvm-project?rev=287315&view=rev
Log:
Remove an out param from ValueObject::GetValueForExpressionPath.
This argument was only used in one place in the codebase, and
it was in a non-critical log stateme
Author: zturner
Date: Fri Nov 18 00:34:45 2016
New Revision: 287320
URL: http://llvm.org/viewvc/llvm-project?rev=287320&view=rev
Log:
Revert "Remove an out param from ValueObject::GetValueForExpressionPath."
This reverts commit r287315, as it introduces a bug that breaks
many things.
Modified:
Author: zturner
Date: Fri Nov 18 11:55:04 2016
New Revision: 287354
URL: http://llvm.org/viewvc/llvm-project?rev=287354&view=rev
Log:
Resubmit "Remove an output-parameter from Variable function".
The scanning algorithm had a few little subtleties that I
overlooked, but this patch should fix every
Author: zturner
Date: Fri Nov 18 13:23:39 2016
New Revision: 287367
URL: http://llvm.org/viewvc/llvm-project?rev=287367&view=rev
Log:
Re-add the StringRef interface changes for Variable.
This concludes the changes I originally tried to make and then
had to back out. This way if anything is still
ght have been one that the owner of this code was
> planning to do something with. Anyway, this seems to go beyond purely
> formal changes and so should have been discussed. My apologies if I just
> missed the review.
>
> Jim
>
> > On Nov 18, 2016, at 9:55 AM, Zachary Turne
Author: zturner
Date: Fri Nov 18 14:44:46 2016
New Revision: 287376
URL: http://llvm.org/viewvc/llvm-project?rev=287376&view=rev
Log:
Change CreateTarget and dependents to accept StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/OptionGroupArchitecture.h
lldb/trunk/include/lldb/Tar
Author: zturner
Date: Fri Nov 18 17:22:42 2016
New Revision: 287401
URL: http://llvm.org/viewvc/llvm-project?rev=287401&view=rev
Log:
Convert CommandHistory functions to StringRef.
Modified:
lldb/trunk/include/lldb/Interpreter/CommandHistory.h
lldb/trunk/source/Interpreter/CommandHistory.
Author: zturner
Date: Fri Nov 18 17:32:37 2016
New Revision: 287409
URL: http://llvm.org/viewvc/llvm-project?rev=287409&view=rev
Log:
Fix some build errors.
Modified:
lldb/trunk/source/Interpreter/CommandHistory.cpp
Modified: lldb/trunk/source/Interpreter/CommandHistory.cpp
URL:
http://llvm
Author: zturner
Date: Fri Nov 18 18:50:29 2016
New Revision: 287412
URL: http://llvm.org/viewvc/llvm-project?rev=287412&view=rev
Log:
Fix some accidental Prints of StringRefs that snuck in.
Modified:
lldb/trunk/source/Symbol/Variable.cpp
lldb/trunk/source/Target/TargetList.cpp
Modified:
zturner created this revision.
zturner added reviewers: jingham, beanz, clayborg, labath.
zturner added a subscriber: lldb-commits.
The purpose of this patch is to demonstrate my proposed new API to the `Args`
class. There are a couple of things I'm trying to demonstrate here:
1. range-based fo
The quote char is only exposed as a means to not break existing code which
depends on it (most of which, not surprisingly, is in the Args class itself.
We could try to come up with a way to kill it, but that seems like a
separate refactor (and perhaps quite difficult since different platforms
have
Assuming we do that, what interface do you think would be simpler? We still
need easy access to both a StringRef and a c_str(), since StringRef::data
is not guaranteed to be null terminated, so the entry thing is still nice.
On Sat, Nov 19, 2016 at 5:44 AM Zachary Turner wrote:
> The quote c
Zachary Turner wrote:
> Assuming we do that, what interface do you think would be simpler? We
> still need easy access to both a StringRef and a c_str(), since
> StringRef::data is not guaranteed to be null terminated, so the entry thing
> is still nice.
> On Sat, Nov 19, 2016 at
The main user of the c_str() is printf calls. It's in the commit message :)
On Sat, Nov 19, 2016 at 7:14 AM Pavel Labath wrote:
> labath added a comment.
>
> > Assuming we do that, what interface do you think would be simpler? We
> still
> > need easy access to both a StringRef and a c_str(), si
The reason we store the quote char, btw, is so that we can use the same
exact quoting as the user typed at command line. A general algorithm
wouldn't be able to reproduce exactly what the user typed
On Sat, Nov 19, 2016 at 9:43 AM Zachary Turner wrote:
> The main user of the c_str() i
zturner added a comment.
Instead of storing the quote char, I think we could just store two
`StringRef`s. `str` and `quoted_str`, where `str =
quoted_str.trim(quote_char);`, and if there is no quote char, then they are
equal. I'd rather do that in a followup since this `ArgEntry` class has
a
Author: zturner
Date: Mon Nov 21 17:18:07 2016
New Revision: 287597
URL: http://llvm.org/viewvc/llvm-project?rev=287597&view=rev
Log:
Add the new Args / entry-access API.
The long-term goal here is to get rid of the functions
GetArgumentAtIndex() and GetQuoteCharAtIndex(), instead
replacing them
Author: zturner
Date: Mon Nov 21 17:18:13 2016
New Revision: 287598
URL: http://llvm.org/viewvc/llvm-project?rev=287598&view=rev
Log:
Fix a bug caught by adding LLVM_NODISCARD to StringRef.
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/StackFrame.cpp
UR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287597: Add the new Args / entry-access API. (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D26883?vs=78617&id=78796#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26883
with similar errors.
On 22 November 2016 at 09:26, Ed Maste via lldb-commits
wrote:
> On 21 November 2016 at 18:18, Zachary Turner via lldb-commits
> wrote:
>> Author: zturner
>> Date: Mon Nov 21 17:18:07 2016
>> New Revision: 287597
>>
>> URL: http://llvm.or
Author: zturner
Date: Tue Nov 22 11:10:15 2016
New Revision: 287647
URL: http://llvm.org/viewvc/llvm-project?rev=287647&view=rev
Log:
Re-add "demonstrate new Args API"
This fixes the build breakage due to the use of C++14.
Modified:
lldb/trunk/include/lldb/Interpreter/Args.h
lldb/trunk/s
zturner added a comment.
In https://reviews.llvm.org/D26971#602738, @clayborg wrote:
> It would be nice if we can find a way to be able to use any time units we
> want when specifying the timeout. I would rather not have everyone have to
> convert their times to microseconds. Maybe we just add
zturner added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56
-response,
-
std::chrono::duration_cast(kInterruptTimeout)
-.count(),
I think we should all be willing to agree that `using namespa
Not going to block the CL over this, but consider using
llvm::StringSwitch<> for improving the readability of this rather large if
/ else block.
On Mon, Nov 28, 2016 at 6:14 PM Anna Zaks via Phabricator via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> zaks.anna added a comment.
>
> Here i
Lgtm, and as we start untangling the mess of dependencies in liblldb id
like for us to take the same approach there too (as llvm does)
On Tue, Nov 29, 2016 at 3:08 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> Any thoughts on this?
>
>
> https://r
Author: zturner
Date: Wed Dec 7 18:54:24 2016
New Revision: 289009
URL: http://llvm.org/viewvc/llvm-project?rev=289009&view=rev
Log:
Work around a bogus warning on MSVC.
Modified:
lldb/trunk/include/lldb/Target/Target.h
Modified: lldb/trunk/include/lldb/Target/Target.h
URL:
http://llvm.org
Author: zturner
Date: Wed Dec 7 19:31:04 2016
New Revision: 289012
URL: http://llvm.org/viewvc/llvm-project?rev=289012&view=rev
Log:
Convert CommandObjectCommands to entry-based Args access.
Modified:
lldb/trunk/source/Commands/CommandObjectCommands.cpp
Modified: lldb/trunk/source/Commands/
Author: zturner
Date: Wed Dec 7 20:02:09 2016
New Revision: 289015
URL: http://llvm.org/viewvc/llvm-project?rev=289015&view=rev
Log:
Convert CommandObjectFrame to entry-based Args access.
In the process, discovered a bug related to the use of an
uninitialized-pointer, and fixed as suggested by E
601 - 700 of 3010 matches
Mail list logo
