[Lldb-commits] [lldb] r352557 - Fix some warnings in building LLDB.

Author: zturner Date: Tue Jan 29 14:55:21 2019 New Revision: 352557 URL: http://llvm.org/viewvc/llvm-project?rev=352557&view=rev Log: Fix some warnings in building LLDB. Differential Revision: https://reviews.llvm.org/D57413 Modified: lldb/trunk/source/Commands/CommandObjectReproducer.cpp

Re: [Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

Oh I guess because one of them has const values? Oh well, ignore my suggestion then :) On Wed, Jan 30, 2019 at 10:50 AM Davide Italiano via Phabricator < revi...@reviews.llvm.org> wrote: > davide marked an inline comment as done. > davide added inline comments. > > > > Comment a

Re: [Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

Yes, clang tries to find the visual studio installation, because that is how it can find headers and libs. Can you make a separate patch with the changes to build.py and upload that? On Tue, Feb 5, 2019 at 2:34 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.ur

Re: [Lldb-commits] [PATCH] D57809: [build.py] Add `VCINSTALLDIR` to default variables

Lgtm! On Mon, Feb 11, 2019 at 12:11 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Zachary, can you take a look? please? > > > Repository: > rLLDB LLDB > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D57809/new/ > > https

Re: [Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

lgtm! On Mon, Feb 11, 2019 at 7:19 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Thanks for the help with the tests, it looks like they are ok now! So can > we proceed with this patch? > > > Repository: > rLLDB LLDB > > CHANGES SI

Re: [Lldb-commits] [PATCH] D58219: [dotest] Fix compiler version number comparison

Try `import distutils.LooseVersion` and use that to do the comparison. On Wed, Feb 13, 2019 at 4:49 PM Frederic Riss via Phabricator < revi...@reviews.llvm.org> wrote: > friss created this revision. > friss added reviewers: zturner, labath. > Herald added a reviewer: serge-sans-paille. > Herald ad

[Lldb-commits] [lldb] r354168 - Don't include UnixSignals.h from Host.

Author: zturner Date: Fri Feb 15 12:43:56 2019 New Revision: 354168 URL: http://llvm.org/viewvc/llvm-project?rev=354168&view=rev Log: Don't include UnixSignals.h from Host. Host had a function to get the UnixSignals instance corresponding to the current host architecture. This means that Host ha

Re: [Lldb-commits] [lldb] r354711 - Revert r354706 - lit touched my thigh

While it’s a good chuckle, can you elaborate on what exactly the commit message means? On Fri, Feb 22, 2019 at 5:07 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Fri Feb 22 17:08:17 2019 > New Revision: 354711 > > URL: http://llvm.org/viewvc/llvm-pr

[Lldb-commits] [lldb] r355037 - Remove dependency from Host -> Core.

Author: zturner Date: Wed Feb 27 13:53:08 2019 New Revision: 355037 URL: http://llvm.org/viewvc/llvm-project?rev=355037&view=rev Log: Remove dependency from Host -> Core. I wasn't actually trying to eliminate this one, but looks like it happened as a side effect of moving Symbols out of Host. Mo

[Lldb-commits] [lldb] r355329 - Fix Windows build after UserIDResolver patch.

Author: zturner Date: Mon Mar 4 11:57:04 2019 New Revision: 355329 URL: http://llvm.org/viewvc/llvm-project?rev=355329&view=rev Log: Fix Windows build after UserIDResolver patch. That patch added a function to HostInfo that returns an instance of UserIDResolver, but this function was unimplement

[Lldb-commits] [lldb] r355342 - Move ProcessInfo from Host to Utility.

Author: zturner Date: Mon Mar 4 13:51:03 2019 New Revision: 355342 URL: http://llvm.org/viewvc/llvm-project?rev=355342&view=rev Log: Move ProcessInfo from Host to Utility. There are set of classes in Target that describe the parameters of a process - e.g. it's PID, name, user id, and similar. Ho

Re: [Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

How about SerializationFormats? On Tue, Mar 5, 2019 at 12:22 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > FileFormats wouldn't be generic enough to capture the gdb-remote or > debug-info-server protocol code. However, even calling gdb-remote prot

[Lldb-commits] [lldb] r355528 - Resubmit "Don't include UnixSignals.h from Host."

Author: zturner Date: Wed Mar 6 10:20:23 2019 New Revision: 355528 URL: http://llvm.org/viewvc/llvm-project?rev=355528&view=rev Log: Resubmit "Don't include UnixSignals.h from Host." This was reverted because it breaks the GreenDragon bot, but the reason for the breakage is lost, so I'm resubmit

[Lldb-commits] [lldb] r355531 - Try to fix OSX compilation failure.

Author: zturner Date: Wed Mar 6 10:44:27 2019 New Revision: 355531 URL: http://llvm.org/viewvc/llvm-project?rev=355531&view=rev Log: Try to fix OSX compilation failure. Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Modified: lldb/trunk/source/Plugins/Process/MacOS

[Lldb-commits] [lldb] r355536 - Try again to fix OSX compilation failure.

Author: zturner Date: Wed Mar 6 11:14:41 2019 New Revision: 355536 URL: http://llvm.org/viewvc/llvm-project?rev=355536&view=rev Log: Try again to fix OSX compilation failure. Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp Modified: lldb/trunk/source/Plugins/S

[Lldb-commits] [lldb] r355557 - [lldb-vscode] Correctly propagate errors back to VS Code.

Author: zturner Date: Wed Mar 6 14:30:06 2019 New Revision: 37 URL: http://llvm.org/viewvc/llvm-project?rev=37&view=rev Log: [lldb-vscode] Correctly propagate errors back to VS Code. Modified: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp Modified: lldb/trunk/tools/lldb-vscode/lldb-v

[Lldb-commits] [lldb] r355559 - Pass /bigobj for SBReproducer.cpp with MSVC

Author: zturner Date: Wed Mar 6 14:42:34 2019 New Revision: 39 URL: http://llvm.org/viewvc/llvm-project?rev=39&view=rev Log: Pass /bigobj for SBReproducer.cpp with MSVC /BIGOBJ is used to bypass certain COFF file format limitations and is used with, unsurprisingly, very big object files.

[Lldb-commits] [lldb] r355637 - [lldb-vscode] Support running in server mode on Windows.

Author: zturner Date: Thu Mar 7 13:23:21 2019 New Revision: 355637 URL: http://llvm.org/viewvc/llvm-project?rev=355637&view=rev Log: [lldb-vscode] Support running in server mode on Windows. Windows can't use standard i/o system calls such as read and write to work with sockets, it instead needs

[Lldb-commits] [lldb] r355656 - [lldb-vscode] Report an error if an invalid program is specified.

Author: zturner Date: Thu Mar 7 16:11:27 2019 New Revision: 355656 URL: http://llvm.org/viewvc/llvm-project?rev=355656&view=rev Log: [lldb-vscode] Report an error if an invalid program is specified. Previously if an invalid program was specified, there was a bug which, when we attempted to launc

[Lldb-commits] [lldb] r355730 - Remove dependency edges from Host to Target/Core.

Author: zturner Date: Fri Mar 8 12:56:10 2019 New Revision: 355730 URL: http://llvm.org/viewvc/llvm-project?rev=355730&view=rev Log: Remove dependency edges from Host to Target/Core. After recent changes, Host is now dependency-free. Modified: lldb/trunk/source/Host/CMakeLists.txt lldb/

Re: [Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

Yes, it’s not the case here but even it were, just because the Python interface exposes this api doesn’t mean we have to use it internally. Regardless, this particular class is completely private and has no analogue in the SB API On Fri, Mar 8, 2019 at 4:53 PM Adrian Prantl via Phabricator < revi.

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

On Mon, Mar 11, 2019 at 4:15 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Just to be precise: TypeImpl stores a TypePair for the static type and a > CompilerType for the dynamic type. These two have different meanings. > There's no assumption about the relationship betwe

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

Fair enough, a FIXME sounds reasonable. On Tue, Mar 12, 2019 at 10:33 AM Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added inline comments. > > > > Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 >uint64_t length

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

+1. I’ve seen some of the changes in llvm that have changed asserts to return a default value. IMHO these should be changed to return Expected instead On Tue, Mar 12, 2019 at 1:16 PM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > In D59235#

[Lldb-commits] [lldb] r355973 - Move ElaboratingDIEIterator into implementation file.

Author: zturner Date: Tue Mar 12 13:50:29 2019 New Revision: 355973 URL: http://llvm.org/viewvc/llvm-project?rev=355973&view=rev Log: Move ElaboratingDIEIterator into implementation file. This is not used outside of the private implementation of the class, so hiding in the implementation file is

[Lldb-commits] [lldb] r355974 - Remove DWARFDIECollection.

Author: zturner Date: Tue Mar 12 13:50:46 2019 New Revision: 355974 URL: http://llvm.org/viewvc/llvm-project?rev=355974&view=rev Log: Remove DWARFDIECollection. This is a very thin wrapper over a std::vector and does not seem to provide any real value over just using a container directly. Differ

[Lldb-commits] [lldb] r355975 - Remove support for DWARF64.

Author: zturner Date: Tue Mar 12 13:51:05 2019 New Revision: 355975 URL: http://llvm.org/viewvc/llvm-project?rev=355975&view=rev Log: Remove support for DWARF64. LLVM doesn't produce DWARF64, and neither does GCC. LLDB's support for DWARF64 is only partial, and if enabled appears to also not wor

Re: [Lldb-commits] [lldb] r356171 - [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.

Make sure to run the test suite after these kinds of changes. You might be surprised. On Thu, Mar 14, 2019 at 10:21 AM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: davide > Date: Thu Mar 14 10:23:08 2019 > New Revision: 356171 > > URL: http://llvm.org/viewvc/l

[Lldb-commits] [lldb] r356190 - Return llvm::Error and llvm::Expected from DWARF parsing code.

Author: zturner Date: Thu Mar 14 12:05:55 2019 New Revision: 356190 URL: http://llvm.org/viewvc/llvm-project?rev=356190&view=rev Log: Return llvm::Error and llvm::Expected from DWARF parsing code. The goal here is to improve our error handling and error recovery while parsing DWARF, while at the

Re: [Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

On Thu, Mar 14, 2019 at 11:48 AM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg accepted this revision. > clayborg added a comment. > This revision is now accepted and ready to land. > > As long as there is not a large performance regress when parsing large > DWARF file

[Lldb-commits] [lldb] r356278 - Return Error and Expected from more DWARF interfaces.

Author: zturner Date: Fri Mar 15 10:32:05 2019 New Revision: 356278 URL: http://llvm.org/viewvc/llvm-project?rev=356278&view=rev Log: Return Error and Expected from more DWARF interfaces. This continues the work of introducing Error and Expected into the DWARF parsing interfaces, this time for th

[Lldb-commits] [lldb] r356284 - Abbreviation declarations are required to have non-null tags.

Author: zturner Date: Fri Mar 15 11:00:43 2019 New Revision: 356284 URL: http://llvm.org/viewvc/llvm-project?rev=356284&view=rev Log: Abbreviation declarations are required to have non-null tags. Treat a null tag as an error. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFAbbrevia

[Lldb-commits] [lldb] r356469 - Remove a couple of log statements.

Author: zturner Date: Tue Mar 19 09:26:08 2019 New Revision: 356469 URL: http://llvm.org/viewvc/llvm-project?rev=356469&view=rev Log: Remove a couple of log statements. These log statements have questionable value, and hinder the effort of separating the high and low level DWARF parsing interface

[Lldb-commits] [lldb] r356490 - Delete dead code.

Author: zturner Date: Tue Mar 19 11:06:32 2019 New Revision: 356490 URL: http://llvm.org/viewvc/llvm-project?rev=356490&view=rev Log: Delete dead code. Most of these are Dump functions that are never called, but there is one instance of entire unused classes (DWARFDebugMacinfo and DWARFDebugMacin

[Lldb-commits] [lldb] r356495 - Remove some dead DWARF enum -> string conversion functions.

Author: zturner Date: Tue Mar 19 11:32:43 2019 New Revision: 356495 URL: http://llvm.org/viewvc/llvm-project?rev=356495&view=rev Log: Remove some dead DWARF enum -> string conversion functions. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plugins

[Lldb-commits] [lldb] r356509 - Delete more dead code.

Author: zturner Date: Tue Mar 19 13:08:56 2019 New Revision: 356509 URL: http://llvm.org/viewvc/llvm-project?rev=356509&view=rev Log: Delete more dead code. All of this is code that is unreferenced. Removing as much of this as possible makes it more easy to determine what functionality is missin

[Lldb-commits] [lldb] r356612 - Introduce DWARFContext.

Author: zturner Date: Wed Mar 20 13:49:25 2019 New Revision: 356612 URL: http://llvm.org/viewvc/llvm-project?rev=356612&view=rev Log: Introduce DWARFContext. LLVM's DWARF parsing library has a class called DWARFContext which holds all of the various DWARF data sections and lots of other informati

[Lldb-commits] [lldb] r356682 - Move the rest of the sections over to DWARFContext.

Author: zturner Date: Thu Mar 21 09:34:58 2019 New Revision: 356682 URL: http://llvm.org/viewvc/llvm-project?rev=356682&view=rev Log: Move the rest of the sections over to DWARFContext. This is mostly mechanical, and just moves the remaining non-DWO related sections over to DWARFContext. Differe

[Lldb-commits] [lldb] r357513 - [NativePDB] Don't fail on import modules.

Author: zturner Date: Tue Apr 2 12:39:45 2019 New Revision: 357513 URL: http://llvm.org/viewvc/llvm-project?rev=357513&view=rev Log: [NativePDB] Don't fail on import modules. A recent patch to LLD started emitting information about import modules. These are represented as compile units in the PD

Re: [Lldb-commits] [lldb] r283324 - xfailing minidump tests again ... :(

If all the tests are being xfailed you should probably just revert the original patch until the tests are fixed On Wed, Oct 5, 2016 at 8:09 AM Dimitar Vlahovski via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: dvlahovski > Date: Wed Oct 5 10:00:29 2016 > New Revision: 283324 > > U

Re: [Lldb-commits] [PATCH] D25246: Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used

Just fyi, I'm planning to submit as-is for now. We can treat disabling specific warnings all the time orthogonally, since we would need to discuss what warnings specifically etc. In any case, in a Werror build turning everything off seems the most prudent. On Tue, Oct 4, 2016 at 1:20 PM Za

[Lldb-commits] [lldb] r283343 - Disable warnings in LLDBWrapPython.cpp with -Werror.

Author: zturner Date: Wed Oct 5 12:07:16 2016 New Revision: 283343 URL: http://llvm.org/viewvc/llvm-project?rev=283343&view=rev Log: Disable warnings in LLDBWrapPython.cpp with -Werror. When -Werror is used, we don't have control over the generated code from SWIG, and it often has warnings. Jus

[Lldb-commits] [PATCH] D25246: Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL283343: Disable warnings in LLDBWrapPython.cpp with -Werror. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D25246?vs=73510&id=73665#toc Repository: rL LLVM https://reviews

[Lldb-commits] [lldb] r283345 - Convert some breakpoint code to use StringRef.

Author: zturner Date: Wed Oct 5 12:07:47 2016 New Revision: 283345 URL: http://llvm.org/viewvc/llvm-project?rev=283345&view=rev Log: Convert some breakpoint code to use StringRef. Differential revision: https://reviews.llvm.org/D25158 Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointI

[Lldb-commits] [lldb] r283344 - Make lldb -Werror clean on Windows.

Author: zturner Date: Wed Oct 5 12:07:34 2016 New Revision: 283344 URL: http://llvm.org/viewvc/llvm-project?rev=283344&view=rev Log: Make lldb -Werror clean on Windows. Differential Revision: https://reviews.llvm.org/D25247 Modified: lldb/trunk/include/lldb/Host/windows/HostProcessWindows.h

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL283345: Convert some breakpoint code to use StringRef. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D25158?vs=73554&id=73667#toc Repository: rL LLVM https://reviews.llvm.

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

This revision was automatically updated to reflect the committed changes. zturner marked an inline comment as done. Closed by commit rL283344: Make lldb -Werror clean on Windows. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D25247?vs=73515&id=73666#toc Repository:

Re: [Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

It looks like there was a problem with this after all. Are your OSX buildbots failing? I only got notification from Linux buildbots. I'm pretty sure everything passes, but I'm going to test again real quick to confirm. On Wed, Oct 5, 2016 at 10:17 AM Zachary Turner wrote: > This

[Lldb-commits] [lldb] r283351 - Try to fix Android build.

Author: zturner Date: Wed Oct 5 12:58:46 2016 New Revision: 283351 URL: http://llvm.org/viewvc/llvm-project?rev=283351&view=rev Log: Try to fix Android build. Seems it doesn't like the implicit conversion from StringRef[] to ArrayRef. Modified: lldb/trunk/source/Breakpoint/BreakpointID.cpp

Re: [Lldb-commits] [lldb] r283351 - Try to fix Android build.

; reject a piece of syntax that other compilers gleefully handle > > On Oct 5, 2016, at 10:58 AM, Zachary Turner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > Author: zturner > Date: Wed Oct 5 12:58:46 2016 > New Revision: 283351 > > URL: http://llvm.o

[Lldb-commits] [lldb] r283358 - Fix some test failures due to the recent Breakpoint patch.

Author: zturner Date: Wed Oct 5 13:40:51 2016 New Revision: 283358 URL: http://llvm.org/viewvc/llvm-project?rev=283358&view=rev Log: Fix some test failures due to the recent Breakpoint patch. Modified: lldb/trunk/source/Breakpoint/BreakpointIDList.cpp Modified: lldb/trunk/source/Breakpoint/

[Lldb-commits] [lldb] r283370 - Convert various CommandInterpreter functions to StringRef.

Author: zturner Date: Wed Oct 5 15:03:37 2016 New Revision: 283370 URL: http://llvm.org/viewvc/llvm-project?rev=283370&view=rev Log: Convert various CommandInterpreter functions to StringRef. Modified: lldb/trunk/include/lldb/Interpreter/Args.h lldb/trunk/include/lldb/Interpreter/Command

[Lldb-commits] [lldb] r283380 - Fixup the xfail situation on Windows.

Author: zturner Date: Wed Oct 5 15:47:17 2016 New Revision: 283380 URL: http://llvm.org/viewvc/llvm-project?rev=283380&view=rev Log: Fixup the xfail situation on Windows. Xfails added and/or removed to reflect the current state of Windows. Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r283384 - Convert CommandObject constructors to StringRef.

Author: zturner Date: Wed Oct 5 16:14:38 2016 New Revision: 283384 URL: http://llvm.org/viewvc/llvm-project?rev=283384&view=rev Log: Convert CommandObject constructors to StringRef. Modified: lldb/trunk/include/lldb/Core/Stream.h lldb/trunk/include/lldb/Interpreter/Args.h lldb/trunk/

[Lldb-commits] [lldb] r283385 - Update some command aliasing functions to use StringRef.

Author: zturner Date: Wed Oct 5 16:14:49 2016 New Revision: 283385 URL: http://llvm.org/viewvc/llvm-project?rev=283385&view=rev Log: Update some command aliasing functions to use StringRef. Modified: lldb/trunk/include/lldb/Interpreter/CommandAlias.h lldb/trunk/include/lldb/Interpreter/C

[Lldb-commits] [lldb] r283386 - Convert some more aliasing and CI functions to StringRef.

Author: zturner Date: Wed Oct 5 16:14:56 2016 New Revision: 283386 URL: http://llvm.org/viewvc/llvm-project?rev=283386&view=rev Log: Convert some more aliasing and CI functions to StringRef. Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h lldb/trunk/source/API/SBComman

[Lldb-commits] [lldb] r283413 - Convert some Args index-based iteration to range-style iteration.

Author: zturner Date: Wed Oct 5 18:40:23 2016 New Revision: 283413 URL: http://llvm.org/viewvc/llvm-project?rev=283413&view=rev Log: Convert some Args index-based iteration to range-style iteration. This is better for a number of reasons. Mostly style, but also: 1) Signed-unsigned comparison w

[Lldb-commits] [lldb] r283414 - Fix build error on Android again.

Author: zturner Date: Wed Oct 5 18:51:13 2016 New Revision: 283414 URL: http://llvm.org/viewvc/llvm-project?rev=283414&view=rev Log: Fix build error on Android again. This one was my fault since I can't compile Android. Modified: lldb/trunk/source/Host/linux/ProcessLauncherLinux.cpp Modifi

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

That's strange. Are you synced to tip of trunk on clang, llvm, and lldb? Can you paste the output of "ninja -nv check-lldb" and the summary results of "ninja check-lldb"? On Wed, Oct 5, 2016 at 10:11 AM walter erquinigo wrote: > wallace added a comment. > > I've run the tests and it's the same w

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

Can you use llvm:raw_string_ostream instead of std::stringstream? After that this looks fine On Thu, Oct 6, 2016 at 8:51 AM Pavel Labath wrote: > labath accepted this revision. > labath added a comment. > This revision is now accepted and ready to land. > > lgtm. > > At one point I'd like to cha

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

zturner added inline comments. > CrashReason.cpp:38 > + stream << ")"; > + str += stream.str(); > +} Actually I'm not sure this is correct. Since you initialize the stream with `str`, as soon as you call `stream.str()` it will flush everything to the underlying string. Now `str` will conta

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

Seems like this has caused this buildbot failure: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/12936/steps/ninja%20build%20local/logs/stdio On Thu, Oct 6, 2016 at 11:14 AM Valentina Giusti wrote: > This revision was automatically updated to reflect the committed changes.

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

wrote: > Ok, I will look into it. Thanks for the link to the logs. I didn’t know > that there was a FreeBSD builder, why isn’t it linked on the Build page ( > http://lldb.llvm.org/build.html)? Is there another page that lists all > available builders? > > > > *From:* Z

[Lldb-commits] [lldb] r283494 - Convert UniqueCStringMap to use StringRef.

Author: zturner Date: Thu Oct 6 16:22:44 2016 New Revision: 283494 URL: http://llvm.org/viewvc/llvm-project?rev=283494&view=rev Log: Convert UniqueCStringMap to use StringRef. Modified: lldb/trunk/include/lldb/Core/Stream.h lldb/trunk/include/lldb/Core/UniqueCStringMap.h lldb/trunk/s

[Lldb-commits] [lldb] r283603 - Remove unused variable.

Author: zturner Date: Fri Oct 7 16:23:31 2016 New Revision: 283603 URL: http://llvm.org/viewvc/llvm-project?rev=283603&view=rev Log: Remove unused variable. Modified: lldb/trunk/source/Interpreter/OptionValueEnumeration.cpp Modified: lldb/trunk/source/Interpreter/OptionValueEnumeration.cpp

[Lldb-commits] [lldb] r283607 - Fix a few warnings caught by clang.

Author: zturner Date: Fri Oct 7 16:32:16 2016 New Revision: 283607 URL: http://llvm.org/viewvc/llvm-project?rev=283607&view=rev Log: Fix a few warnings caught by clang. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/trunk/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [PATCH] D25393: Remove IntervalTimer class

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. If it's dead code, probably don't even need to ask. https://reviews.llvm.org/D25393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

zturner added inline comments. Comment at: include/lldb/Host/FileSystem.h:69-71 + static std::chrono::time_point + GetModificationTime(const FileSpec &file_spec); I wonder if it would be worth defining some typedefs in LLVM's `Chrono.h` that Mehdi is adding to

[Lldb-commits] [PATCH] D25391: Remove usages of TimeValue from gdb-remote process plugin

zturner added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:192 +packet_result = ReadPacket( +response, std::chrono::duration_cast( + GetPacketTimeout()) `using namespace std` is generally

Re: [Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

Yea let's just duration_cast before calling to_time_t On Sat, Oct 8, 2016 at 4:23 PM Pavel Labath wrote: > labath added inline comments. > > > > Comment at: include/lldb/Host/TimeValue.h:37-38 >explicit TimeValue(uint32_t seconds, uint64_t nanos = 0); > + TimeValue(std::chro

Re: [Lldb-commits] [lldb] r283847 - Add a first unit test for the arm64 instruction profiled unwind

On Mon, Oct 10, 2016 at 7:33 PM Jason Molenda via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > +if (process_sp->GetTarget().ReadMemory( > > +range.GetBaseAddress(), prefer_file_cache, > function_text.data(), > > +range.GetByteSize(), error) != range.GetByteSiz

Re: [Lldb-commits] [lldb] r283849 - Add a second, more complicated, arm64 example program to

On Mon, Oct 10, 2016 at 8:53 PM Jason Molenda via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jmolenda > > Date: Mon Oct 10 22:44:48 2016 > > New Revision: 283849 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=283849&view=rev > > Log: > > Add a second, more complicated, arm6

Re: [Lldb-commits] [PATCH] D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

I must have forgotten to add a doxygen comment on it. Will do today On Tue, Oct 11, 2016 at 7:09 AM Richard Chamberlain via lldb-commits < lldb-commits@lists.llvm.org> wrote: > rnchamberlain added a comment. > > Thanks, that's nicer. I did have a look for a 'contains()' method, but it > has not ma

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Heh. It just occurred to me that this is probably the reason why all of the `lldb-mi` tests fail on Windows. Because `.exe` is not appended. I'm not ready to turn that on and deal with al

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. If you wanted to get really fancy, you could actually locate the system include directory and set the default to that. But that's up to you, just an idea. https://reviews.llvm.org/D25487

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

zturner accepted this revision. zturner added inline comments. This revision is now accepted and ready to land. Comment at: test/CMakeLists.txt:12 +DEPENDS ${LLDB_TEST_DEPS} +USES_TERMINAL ) OMG. I've been looking for this magic for forever. Praise

[Lldb-commits] [PATCH] D25569: Minidump plugin: functions parsing memory structures and filtering module list

zturner added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:242 + + for (const auto &module : modules) { +name = GetMinidumpString(module.module_name_rva); I don't know how big the minidumps you're working with are or if per

Re: [Lldb-commits] [PATCH] unittests: Specify types in a bunch of unittest EXPECT's

looks fine, thanks On Mon, Oct 17, 2016 at 10:37 AM Justin Bogner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Today I checked out lldb to check that r284364 wouldn't cause any > trouble, but there were a few warnings that fired when I tried to build > it, breaking my -Werror build. >

Re: [Lldb-commits] [lldb] r284362 - Interpreter: Don't return StringRef from functions whose return value is never used

lgtm On Mon, Oct 17, 2016 at 10:37 AM Justin Bogner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: bogner > Date: Mon Oct 17 01:17:56 2016 > New Revision: 284362 > > URL: http://llvm.org/viewvc/llvm-project?rev=284362&view=rev > Log: > Interpreter: Don't return StringRef from fu

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. This looks fine now. Sorry for the delay, I had forgotten about it. I think you still don't have commit access right? Now would be a good time to request it

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

I don't think you need to go out of your way to account for this, but Microsoft recently shipped bash on Windows in a full ubuntu environment. I can't check right this second, but I don't think it has sh, only bash. What about a fallback? Try bash, if you can't find it try sh. Thoughts? On Tue, Oct

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

ndows has > implemented an AppleScript drivable Terminal.app behind our backs we don't > need to work this problem that hard... > > Jim > > > On Oct 18, 2016, at 4:43 PM, Zachary Turner wrote: > > > > I don't think you need to go out of your way to account

Re: [Lldb-commits] [lldb] r284601 - Simplify GetGlobalProperties functions of Thread/Process/Target

This was using call_once because msvc didn't support function local static thread safe initialization. But it does now in msvc 2015. Can you fix HostInfoBase `g_flags` while you're at it? On Wed, Oct 19, 2016 at 8:21 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author:

Re: [Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

It will return true in this case. Should it be returning false to indicate failure? On Tue, Oct 18, 2016 at 11:26 PM Carlo Kok wrote: > fwiw this looks good to me, a much better fix than I had. but it'z > zturner who objected to my approach. > > On 2016-10-17 17:51, Rudy Pons via lldb-commits wro

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner created this revision. zturner added reviewers: clayborg, beanz, EugeneBi. zturner added a subscriber: lldb-commits. The original motivation for this came from https://reviews.llvm.org/D25712, in which Eugene pointed out that `File::Read()` does not correctly handle short reads. However

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added a comment. In https://reviews.llvm.org/D25783#574679, @labath wrote: > I am not sure the "append" thing is actually a "fix". I consider it more like > a feature of the append mode. It's also nice that it guarantees atomicity of > writes even if two processes are writing to the sam

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added a comment. Also, for the record, if you specify the threadsafe logging option, it already does put this in a mutex, so there should be no issue. https://reviews.llvm.org/D25783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added a comment. In https://reviews.llvm.org/D25783#574699, @labath wrote: > In https://reviews.llvm.org/D25783#574684, @zturner wrote: > > > There are many other problems with this code if we want to deal with > > atomicity. For example, the whole point of this patch was to handle shor

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added a comment. Also you are right that I misspoke about the append case. But still, I just think that if writing to the same file from multiple processes is something we care about, we should support it "for real" instead of just pretending to. That means some kind of cross-process

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added inline comments. Comment at: source/Host/common/File.cpp:405 -if (bytes_read == 0) { - if (::feof(m_stream)) -error.SetErrorString("feof"); - else if (::ferror(m_stream)) -error.SetErrorString("ferror"); - num_bytes = 0; -} e

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added a comment. In https://reviews.llvm.org/D25783#574860, @labath wrote: > > This can happen with any number of bytes and at any time. `write`, `read`, > > and all other related functions will return a non-negative value indicating > > the number of bytes successfully read/written, w

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

zturner added a comment. Incidentally, this patch actually makes all platforms behave consistently when the `Write` overload with offset is used with `O_APPEND`, so there's probably some value in having that consistency. https://reviews.llvm.org/D25783 __

Re: [Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

Actually ignore that last comment , the behavior is the same as before, but linux will still behave differently than other platforms On Wed, Oct 19, 2016 at 3:17 PM Zachary Turner wrote: > zturner added a comment. > > Incidentally, this patch actually makes all platforms behave con

[Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. LGTM as long as you've run the test suite and confirmed everything works. https://reviews.llvm.org/D25681 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D25886: [Test Suite] Properly respect --framework option

zturner added a comment. Maybe put that function `lldbplatformutil`? https://reviews.llvm.org/D25886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r285393 - Add a couple of fun unit tests for FileSpec::Equal

Instead of #if 0'ing them, I believe you can add _Disabled to the end of the name. A common pattern is something like this: #if LLVM_ON_WIN32 #define TestFunBlackslashes_Maybe TestFunBlackslashes_Disabled #else #define TestFunBlackslashes_Maybe TestFunBlackslashes #endif TEST_F(FileSpecTest, Te

Re: [Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

Can I have some background? What is the linking problem? On Tue, Nov 1, 2016 at 8:16 AM Todd Fiala wrote: > tfiala added a comment. > > I'll let Greg comment on the public ABI expansion (i.e. including llvm of > a specific version, which may differ from LLDB.framework clients that > contain diffe

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

zturner added a comment. On Windows if you have a DLL (.so) that links against a .lib (.a), and an EXE links against both the DLL and the .lib, then both the DLL and the EXE will each get their own private copy of the symbols in the lib, and the linker won't try to merge them. Do I understand

[Lldb-commits] [PATCH] D26188: [RFC] Solve linking inconsistency, proposal one

zturner added a comment. BTW, in general static linking on Windows is "bad", but as long as no SBI API header directly or indirectly includes an LLVM header, and there is no LLVM usage on the API boundary, it should be ok IIUC. https://reviews.llvm.org/D26188 ___

[Lldb-commits] [lldb] r285749 - Add missing #include.

Author: zturner Date: Tue Nov 1 16:08:34 2016 New Revision: 285749 URL: http://llvm.org/viewvc/llvm-project?rev=285749&view=rev Log: Add missing #include. Modified: lldb/trunk/include/lldb/Host/FileSpec.h Modified: lldb/trunk/include/lldb/Host/FileSpec.h URL: http://llvm.org/viewvc/llvm-pr

<    1   2   3   4   5   6   7   8   9   10   >