On Wed, Sep 21, 2016 at 5:00 PM Greg Clayton wrote:
> Please submit a change requests when doing these kinds of things and let
> people comment on the changes before committing such things.
>
> We deleted functions that were correctly using "const char *" like:
>
> bool Execute(llvm::StringRef
If you like I can also go through and point out all the places where I
*removed* copies.
On Wed, Sep 21, 2016 at 5:14 PM Zachary Turner wrote:
> On Wed, Sep 21, 2016 at 5:00 PM Greg Clayton wrote:
>
> Please submit a change requests when doing these kinds of things and let
> peopl
rt and
> end pointer. I would just like to avoid making string copies for no reason.
> I don't have anything against using StringRef as long as we do it
> efficiently.
> >
> > Greg
> >
> >
> >> On Sep 21, 2016, at 5:13 PM, Greg Clayton via lldb-commit
On Wed, Sep 21, 2016 at 5:13 PM Greg Clayton wrote:
>
> > On Sep 21, 2016, at 4:43 PM, Zachary Turner wrote:
> >
> > You need to duplicate something on the heap once when you execute the
> regex. And in turn you save tens or hundreds or copies on the way there
> be
version is in
progress, but there's also some that are removed such as in the above
examples. I'm not worried too much about the temporary ones because in the
long run the net effect will be a huge reduction in number of copies and
strlens.
On Wed, Sep 21, 2016 at 5:23 PM Greg Clayton
nk that justifies making MacOS builds different.
>
> If it really bothered us we could go get a more modern regex engine from
> somewhere (rip it out of Tcl or something like that...)
>
> Jim
>
>
> >
> > Greg
> >
> >> On Sep 21, 2016, at 5:19 PM, Zachary Turner
Are there platforms we care about that
> don't have a maintained version of exactly the same code?
>
> Jim
>
>
> > On Sep 21, 2016, at 5:42 PM, Zachary Turner wrote:
> >
> > I'll try to address the Regex issue this week (by making everything use
> llvm exte
e one that is supported on that platform
> if it is available? They are going to get much wider testing, fixes and
> even "ENHANCE"ments...
>
> Jim
>
> > On Sep 21, 2016, at 6:07 PM, Zachary Turner wrote:
> >
> > Windows :)
> >
> > But that
ot;I got this
> source at some point and use it for some things, but don't rigorously test
> it" version of regcomp & friends. Can we hold off on that change till we
> have nothing else better to do?
>
> Jim
> > On Sep 21, 2016, at 6:27 PM, Zachary Turner wrote:
&g
s certainly not something I want to
> take on unless I'm getting a very strong benefit from it.
>
> Jim
>
> > On Sep 21, 2016, at 6:36 PM, Zachary Turner wrote:
> >
> > I suppose, but at the same time if it's good enough for llvm it seems
> good enough for u
+1. One of the points I outlined on my list was to use llvm streams. So
that also solves the problem
On Thu, Sep 22, 2016 at 4:54 AM Pavel Labath wrote:
> On 22 September 2016 at 01:00, Greg Clayton via lldb-commits
> wrote:
> > If you use a StringRef in printf, please use "%*s" and then put the
Thanks for the test. Is there any practical difference between "ARGS=" and
"ARGS"?
On Thu, Sep 22, 2016 at 9:08 AM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Thu Sep 22 11:00:01 2016
> New Revision: 282171
>
> URL: http://llvm.org/viewvc/llvm-proje
with trailing
> nothingness. On the Xcode side, we use a ton of environment variables.
>
> As to whether there is a difference between ARG1=\0 and ARG1\0, I'm not
> sure.
>
> On Thu, Sep 22, 2016 at 9:12 AM, Zachary Turner
> wrote:
>
> Thanks for the test. Is the
Author: zturner
Date: Thu Sep 22 16:06:13 2016
New Revision: 282195
URL: http://llvm.org/viewvc/llvm-project?rev=282195&view=rev
Log:
Try to fix build errors on Android.
It doesn't like the implicit conversion from T[] to ArrayRef
so I'm using `llvm::makeArrayRef()`. Hopefully I got everything.
At the end of the day though, lldb DOES need to link against libclang. Is
it still doing this?
On Thu, Sep 22, 2016 at 2:17 PM Chris Bieneman via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Thu Sep 22 16:08:27 2016
> New Revision: 282196
>
> URL: http://llvm.o
Ok, cool!
On Thu, Sep 22, 2016 at 2:23 PM Chris Bieneman wrote:
> Calls to add_dependencies don’t setup linkage, they just setup build
> order, so changing this has no impact on what is linked or how.
>
> -Chris
>
> On Sep 22, 2016, at 2:21 PM, Zachary Turner wrote:
>
&g
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
As before, some copies are removed, a few are introduced. When I get to
Option::SetValue, those that are introduced should go away.
https://reviews.llvm.org/D24847
Files:
include/lldb
zturner added a comment.
Should this be sunk into a common llvm function instead of copying from clang?
I don't have a strong opinion, but are you one of the main CMake maintainers in
LLVM, so whatever you think is best.
https://reviews.llvm.org/D24846
_
OptionValueString is actually the next item on my list. I tried it before
this and it was a very big CL, But maybe with this done it will be smaller.
I can try again but if the cl grows too large i think it's better to do it
in a followup. If nothing else so that if a buildbot fails it's easier to
I'll try the 2 additional string ref changes first and see how bad it is
On Thu, Sep 22, 2016 at 3:36 PM Zachary Turner wrote:
> OptionValueString is actually the next item on my list. I tried it before
> this and it was a very big CL, But maybe with this done it will be smaller.
&g
I took a quick glance, now I remember. It uses a validator, so the
validator has to either update its signature or make a copy. It's also
called by SetValueFromCString, so that has to be updated or make a copy.
Then it spirals out from there.
So yea, the copy is still going to be there, just in a
Ok that's fine then
On Thu, Sep 22, 2016 at 3:59 PM Greg Clayton wrote:
> clayborg added a comment.
>
> You can still leave the "const char *" versions in there for now until you
> get to the cleanup. No spiral if you do that.
>
>
> https://reviews.llvm.org/D24847
>
>
>
>
If it's non trivial then then can go in first, that's fine. I'm ooo for the
rest of the day, so let me test it out on Windows first
On Thu, Sep 22, 2016 at 4:36 PM Chris Bieneman wrote:
> beanz added a comment.
>
> Putting this in LLVM would be ideal, but I think doing that requires a
> larger re
Author: zturner
Date: Thu Sep 22 21:54:26 2016
New Revision: 282226
URL: http://llvm.org/viewvc/llvm-project?rev=282226&view=rev
Log:
Fix windows build caused by mixing enum and enum class.
Modified:
lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h
lldb/trunk/include/lldb/Target/Thr
Fixed in r282226, thanks for the tip.
On Thu, Sep 22, 2016 at 5:15 PM Andrew Ford via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> andrewford added a comment.
>
> BTW, I don't have commit access, would appreciate if someone could submit
> for me assuming this is acceptable :)
>
>
> https:
zturner updated this revision to Diff 72234.
zturner added a comment.
Updated the two requested functions. I still had to make a few more changes to
catch the implicit conversions into each of these functions, but it wasn't too
bad.
https://reviews.llvm.org/D24847
Files:
include/lldb/Inter
Author: zturner
Date: Fri Sep 23 12:48:13 2016
New Revision: 282265
URL: http://llvm.org/viewvc/llvm-project?rev=282265&view=rev
Log:
Update OptionGroup::SetValue to take StringRef.
Then deal with all the fallout.
Differential Revision: https://reviews.llvm.org/D24847
Modified:
lldb/trunk/i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282265: Update OptionGroup::SetValue to take StringRef.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D24847?vs=72234&id=72310#toc
Repository:
rL LLVM
https://reviews.llvm
Author: zturner
Date: Fri Sep 23 13:06:53 2016
New Revision: 282269
URL: http://llvm.org/viewvc/llvm-project?rev=282269&view=rev
Log:
Update the prompt related functions to use StringRefs.
Modified:
lldb/trunk/include/lldb/Core/Debugger.h
lldb/trunk/include/lldb/Core/Event.h
lldb/trun
Author: zturner
Date: Fri Sep 23 13:11:03 2016
New Revision: 282270
URL: http://llvm.org/viewvc/llvm-project?rev=282270&view=rev
Log:
Try to fix failing TestDataFormatterSkipSummary test case.
Modified:
lldb/trunk/source/Interpreter/OptionGroupValueObjectDisplay.cpp
Modified: lldb/trunk/sour
Author: zturner
Date: Fri Sep 23 13:13:18 2016
New Revision: 282271
URL: http://llvm.org/viewvc/llvm-project?rev=282271&view=rev
Log:
Try again to match the logic of the code before re-writing.
Modified:
lldb/trunk/source/Interpreter/OptionGroupValueObjectDisplay.cpp
Modified: lldb/trunk/sou
be set, so no dependency will be setup.
>
> That same concern came up in a similar patch I submitted to Swift.
>
> -Chris
>
> On Sep 22, 2016, at 2:23 PM, Zachary Turner wrote:
>
> Ok, cool!
>
> On Thu, Sep 22, 2016 at 2:23 PM Chris Bieneman wrote:
>
> Calls to add
Author: zturner
Date: Fri Sep 23 13:42:38 2016
New Revision: 282277
URL: http://llvm.org/viewvc/llvm-project?rev=282277&view=rev
Log:
Change Module::RemapPath to use StringRef.
Modified:
lldb/trunk/include/lldb/Core/Module.h
lldb/trunk/include/lldb/Target/PathMappingList.h
lldb/trunk/
Author: zturner
Date: Fri Sep 23 17:11:51 2016
New Revision: 282306
URL: http://llvm.org/viewvc/llvm-project?rev=282306&view=rev
Log:
Change FileAction::GetPath() to return a StringRef.
Modified:
lldb/trunk/include/lldb/Target/FileAction.h
lldb/trunk/include/lldb/Target/Target.h
lldb/
Author: zturner
Date: Fri Sep 23 17:27:03 2016
New Revision: 282309
URL: http://llvm.org/viewvc/llvm-project?rev=282309&view=rev
Log:
Fix build on Ubuntu.
This was in some code that was #ifdef'd out on Windows, so I
didn't see it.
Modified:
lldb/trunk/source/Host/common/Host.cpp
Modified: l
Thanks I'll take a look. I only saw the other because I got a buildbot
break notification. I'll go checkout Host.mm
On Fri, Sep 23, 2016 at 3:44 PM Jim Ingham wrote:
> I think you missed some changes in Host.mm on OS X as well.
>
> Jim
>
> > On Sep 23, 2016, at
Ahh nvm, I see you beat me to it. Thanks
On Fri, Sep 23, 2016 at 3:47 PM Zachary Turner wrote:
> Thanks I'll take a look. I only saw the other because I got a buildbot
> break notification. I'll go checkout Host.mm
>
> On Fri, Sep 23, 2016 at 3:44 PM Jim Ingham wrote:
zturner accepted this revision.
zturner added a comment.
lgtm, everything works.
https://reviews.llvm.org/D24846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added inline comments.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:46-47
@@ +45,4 @@
+ source_data = source_data.drop_front(6 * 8); // p[1-6] home registers
+ const uint32_t *context_flags;
+ consumeObject(source_data, context_flags);
zturner added inline comments.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:49
@@ +48,3 @@
+writeRegister(source_data, result_base, ®_info[lldb_cs_x86_64], 2);
+ }
+
dvlahovski wrote:
> sizeof(uint16_t), sizeof(uint32_t), et
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
zturner added a dependency: D24880: Add StringExtras join_items function.
This patch depends on D24880 going in for the `join_items` function, but at
least you can comment on it now.
ht
Test would be nice, but otoh command line tests are discouraged. Maybe it
will be easier to write this kind of test if we had a tool specifically for
testing command line options similar to what I proposed with unwinding etc.
oh well
On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits <
Oh cool. Is it not hooked up to the public waterfall?
On Mon, Sep 26, 2016 at 3:02 PM Enrico Granata wrote:
> On Sep 26, 2016, at 2:50 PM, Zachary Turner wrote:
>
> Test would be nice, but otoh command line tests are discouraged. Maybe it
> will be easier to write this kind of test
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added subscribers: lldb-commits, LLDB.
The `Args` class was trying to maintain two parallel argument vectors. One
that owned the memory and contained `std::strings`, and one that contained
`const char *`'s that could be
zturner added a comment.
Ignore the changes to `FileSpec`, it seems the two CLs I was working on got
mixed together.
https://reviews.llvm.org/D24952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
zturner updated this revision to Diff 72657.
zturner added a comment.
Updated
https://reviews.llvm.org/D24952
Files:
examples/plugins/commands/fooplugin.cpp
include/lldb/API/SBCommandInterpreter.h
include/lldb/Host/OptionParser.h
include/lldb/Interpreter/Args.h
source/API/SBCommandInt
zturner added a comment.
`ASSERT_EQ` causes the test method to return immediately if the condition
fails. `EXPECT_EQ` will continue running the same test body. I like to use
`ASSERT_EQ`, for example, if you are checking the value of a pointer returned
by a function. First you want to check i
zturner accepted this revision.
This revision is now accepted and ready to land.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:50
@@ +49,3 @@
+size = 8;
+break;
+ }
If they are just smaller (but never bigger), you can cal
zturner added inline comments.
Comment at: source/Interpreter/Args.cpp:269-272
@@ -320,6 +268,6 @@
const char *Args::GetArgumentAtIndex(size_t idx) const {
- if (idx < m_argv.size())
-return m_argv[idx];
+ if (idx < m_args.size())
+return m_args[idx].c_str();
retur
zturner added inline comments.
Comment at: source/Interpreter/Args.cpp:286-288
@@ -338,5 +285,5 @@
-const char **Args::GetConstArgumentVector() const {
- if (!m_argv.empty())
-return const_cast(&m_argv[0]);
- return nullptr;
+ // This is kind of gross, but it ensures that
zturner added inline comments.
Comment at: source/Interpreter/Args.cpp:286-288
@@ -338,5 +285,5 @@
-const char **Args::GetConstArgumentVector() const {
- if (!m_argv.empty())
-return const_cast(&m_argv[0]);
- return nullptr;
+ // This is kind of gross, but it ensures that
Author: zturner
Date: Tue Sep 27 15:48:37 2016
New Revision: 282537
URL: http://llvm.org/viewvc/llvm-project?rev=282537&view=rev
Log:
Update FileSpec's interface to use StringRefs.
Differential Revision: https://reviews.llvm.org/D24936
Modified:
lldb/trunk/include/lldb/Host/FileSpec.h
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282537: Update FileSpec's interface to use StringRefs.
(authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D24936?vs=72555&id=72705#toc
Repository:
rL LLVM
https://reviews.llvm.
Not sure why operator= is returning a const&. It doesn't matter in practice
but it's a bit strange. Anyway lgtm
On Tue, Sep 27, 2016 at 7:11 PM Daniel Austin Noland via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Explicit delete is preferable to declaring a method private when
> your inte
On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> -
> +
> + static ConstString g___i_("__i_");
> +
>// this must be a ValueObject* because it is a child of the ValueObject
> we are
>// producing children for
>// it if were a Valu
On Wed, Sep 28, 2016 at 5:54 PM Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Wed Sep 28 19:45:33 2016
> New Revision: 282657
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282657&view=rev
> Log:
> Fixed TestObjCStructArgument/i386; expressions can
On Wed, Sep 28, 2016 at 6:09 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> +#include "x86AssemblyInspectionEngine.h"
> +
> +#include "llvm-c/Disassembler.h"
> +
> +#include "lldb/Core/Address.h"
> +#include "lldb/Symbol/UnwindPlan.h"
> +#include "lldb/Target/RegisterC
On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> + EXPECT_TRUE(regloc.GetOffset() == -8);
>
This should be
EXPECT_EQ(-8, regloc.GetOffset());
That way if it fails, you'll get a handy error message that says:
Expected: -8
Actual: -7
If yo
On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata wrote:
> On Sep 28, 2016, at 5:58 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>
> -
> +
> + static ConstStrin
6 at 10:58 AM Enrico Granata wrote:
>
> On Sep 29, 2016, at 10:50 AM, Zachary Turner wrote:
>
>
>
> On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata
> wrote:
>
> On Sep 28, 2016, at 5:58 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 28, 2016 at 4:02 PM Enri
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added subscribers: lldb-commits, LLDB.
In https://reviews.llvm.org/D24952 I tried to refactor the `Args` class to get
rid of `m_argv`. The original motivation for this is that I wanted a way to
implement `GetArgumentAtIn
zturner updated this revision to Diff 73099.
zturner added a comment.
Renamed `EntryData` to `ArgEntry` and made it public. This will be useful
later for providing iterator support over the entries.
https://reviews.llvm.org/D25099
Files:
include/lldb/Interpreter/Args.h
source/Core/StringL
zturner updated this revision to Diff 73095.
https://reviews.llvm.org/D25099
Files:
include/lldb/Interpreter/Args.h
source/Core/StringList.cpp
source/Interpreter/Args.cpp
unittests/Interpreter/TestArgs.cpp
Index: unittests/Interpreter/TestArgs.cpp
zturner created this revision.
zturner added a reviewer: jingham.
zturner added a subscriber: lldb-commits.
This is an incremental step towards getting some other code converted. In any
case, I believe this makes the breakpoint code significantly easier to
understand and also removes many strin
zturner added inline comments.
> labath wrote in Args.cpp:207
> I think we don't need to call Clear() here, as all memory owned by the object
> will be correctly destroyed anyway.
Thanks for pointing that out. Originally I wasn't using `unique_ptr` but
rather `new[]` and `delete[]`. After I
zturner added a comment.
Hi Greg, might you have a chance to look at this today? I've got a huge
backlog of CLs to get in. The rest probably won't require reviews, but this
one is a precursor to everything else.
https://reviews.llvm.org/D25099
_
He lgtm'ed my last patch, so I guess he's ok with the general concept.
Perhaps if someone could just run the test suite for me that would be good
enough.
On Mon, Oct 3, 2016 at 10:25 AM Todd Fiala wrote:
> tfiala added a comment.
>
> @zturner , Greg is out this week (and was last Friday as well)
zturner updated this revision to Diff 73335.
zturner added a comment.
I know what this is. It should be fixed in this patch, I guess I didn't have
the newest patch uploaded.
https://reviews.llvm.org/D25099
Files:
include/lldb/Interpreter/Args.h
source/Core/Logging.cpp
source/Core/String
Thanks, I'll fix it up before submitting
On Mon, Oct 3, 2016 at 2:40 PM Jim Ingham wrote:
> jingham added a comment.
>
> You messed up the meaning of one comment (noted inline). Otherwise this
> looks fine to me too.
>
>
>
> > Args.cpp:97-98
> > + // Argument can be split into multiple disconti
Author: zturner
Date: Mon Oct 3 17:51:09 2016
New Revision: 283157
URL: http://llvm.org/viewvc/llvm-project?rev=283157&view=rev
Log:
Refactor the Args class.
There were a number of issues with the Args class preventing
efficient use of strings and incoporating LLVM's StringRef class.
The two big
Author: zturner
Date: Mon Oct 3 18:20:36 2016
New Revision: 283159
URL: http://llvm.org/viewvc/llvm-project?rev=283159&view=rev
Log:
Modernize some code related to Args usage / implementation.
Mostly this involves simplifying some logical constructs and using
some ranges instead of index-based i
Was this clang-formatted? some of these lines look way longer than 80
columns.
On Mon, Oct 3, 2016 at 4:41 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: enrico
> Date: Mon Oct 3 18:33:00 2016
> New Revision: 283160
>
> URL: http://llvm.org/viewvc/llvm-projec
Author: zturner
Date: Mon Oct 3 19:09:44 2016
New Revision: 283168
URL: http://llvm.org/viewvc/llvm-project?rev=283168&view=rev
Log:
Try to fix failing tests when running remote test suite.
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp
Modified: lldb/trunk/s
Author: zturner
Date: Mon Oct 3 20:34:39 2016
New Revision: 283176
URL: http://llvm.org/viewvc/llvm-project?rev=283176&view=rev
Log:
Fix TestNestedAliases.py
I missed an if/else branch when doing the conversion.
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283157: Refactor the Args class. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D25099?vs=73335&id=73418#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25099
Files:
ll
zturner created this revision.
zturner added a reviewer: beanz.
zturner added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
We don't control the generated code here, so there often isn't anything we can
do about these warnings. They'll still show when -Werror is off so they aren
zturner created this revision.
zturner added reviewers: amccarth, labath.
zturner added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.
Some of this is in Windows specific code, but some of it is not. In a few
places I think I fixed real bugs in LLDB, but not sure how to really t
zturner added inline comments.
> MinidumpParser.cpp:81-82
>
> - return llvm::ArrayRef(m_data_sp->GetBytes() + iter->second.rva,
> + return llvm::ArrayRef(GetData().data() + iter->second.rva,
> iter->second.data_size);
> }
Change this line to `return GetDat
zturner added a comment.
Thankfully, yes. Technically it's not supported by MSVC 2013, which is still a
supported LLVM compiler. But we said long ago that we require MSVC 2015 for
running the test suite on Windows. And in any case, LLVM is bumping to MSVC
2015 within the next 2 weeks. So I'
zturner marked an inline comment as done.
zturner added inline comments.
> Eugene.Zelenko wrote in Platform.h:16
> This is application header. Should be in quotes. Same below.
Thanks for pointing this out. Fixed locally
https://reviews.llvm.org/D25247
___
zturner added a comment.
In https://reviews.llvm.org/D25246#561323, @Eugene.Zelenko wrote:
> You could use -Wno-error= instead.
Yes but it's a little bit annoying to track down every single one we get in
this file with all the different compilers. Since we can't really control the
generated
zturner updated this revision to Diff 73554.
zturner added a comment.
Fixed up `ParseCanonicalReference` and `SplitIDRangeExpression` as suggested.
I could have probably returned an `Optional>`
but it seemed like overkill. An empty pair seems sufficient for conveying
failure.
https://review
zturner added inline comments.
> jingham wrote in BreakpointIDList.cpp:329-330
> Did you upload the latest version of your patch, I don't see a comment here...
I put the comment in the header. I can put it here if you prefer. Putting it
on both places seems unnecessary though. LMK which you
TheStmt(S),
MSAsmNameResolved(false),
LocStart(StartL) {}
If so that's less work I have to do on clang-format to get it up to spec.
On Fri, Dec 11, 2015 at 4:34 PM Jim Ingham wrote:
> On Dec 11, 2015, at 2:42 PM, Zachary Turner wrote:
>
> Yes, but as I mentioned, two thin
compelling reason as it makes the history harder to
> trace by inserting random inessential checkins that you have to peer
> through. And this seems like make-work to me.
>
> Jim
>
>
>
> On Dec 11, 2015, at 4:40 PM, Zachary Turner wrote:
>
> Hrmm, that's int
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255525: Make debug info specification use categories system.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D15428?vs=42550&id=42739#toc
Repository:
rL LLVM
http://reviews.l
Author: zturner
Date: Mon Dec 14 12:49:16 2015
New Revision: 255525
URL: http://llvm.org/viewvc/llvm-project?rev=255525&view=rev
Log:
Make debug info specification use categories system.
Reviewed By: Tamas Berghammer, Pavel Labath
Differential Revision: http://reviews.llvm.org/D15428
Modified:
bot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/lldbtest.py",
> line 1096, in fn debug_info_passes = debug_info is None or self.debug_info
> in debug_info
> TypeError: argument of type 'function' is not iterable
> Config=i386-clang-3.5
>
> C
Author: zturner
Date: Mon Dec 14 15:26:49 2015
New Revision: 255542
URL: http://llvm.org/viewvc/llvm-project?rev=255542&view=rev
Log:
Make skipIf decorator support not_in() functor.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/lldbsuite
Siva Chandra wrote:
> On Mon, Dec 14, 2015 at 10:49 AM, Zachary Turner via lldb-commits
> wrote:
> > Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
> > URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=25552
x27;s my understanding.
On Mon, Dec 14, 2015 at 2:09 PM Siva Chandra wrote:
> Previously, self.debug_info was under different functions
> (dwarf_test_method, dwo_test_method etc.). Now, they are all under
> test_method. Even I am equally ignorant about the Python nuances here.
>
> O
Author: zturner
Date: Mon Dec 14 16:58:16 2015
New Revision: 255567
URL: http://llvm.org/viewvc/llvm-project?rev=255567&view=rev
Log:
Remove the multiplier loop.
This is leading to some kind of subtle issue related to local
functions and closures, so let's just go back to the old way for
now.
Mo
Alright, I'll revert this loop for now. This is in at r255567.
On Mon, Dec 14, 2015 at 2:33 PM Siva Chandra wrote:
> On Mon, Dec 14, 2015 at 2:15 PM, Zachary Turner
> wrote:
> > Diff looks like this:
> >
> > -@dwarf_test
> >
On Mon, Dec 14, 2015 at 4:10 PM Siva Chandra wrote:
> This change looks very innocent, but:
>
> On Mon, Dec 14, 2015 at 1:26 PM, Zachary Turner via lldb-commits
> wrote:
> > URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?re
zturner added inline comments.
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622
@@ -621,3 +621,3 @@
return list_or_lambda(value)
-elif isinstance(list_or_lambda, list):
-return list_or_lambda is None or value is None or value in
list_or_l
A unit test would be good at catching bugs like this.
On Mon, Dec 14, 2015 at 6:23 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: enrico
> Date: Mon Dec 14 20:20:48 2015
> New Revision: 255603
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255603&view=rev
> L
ppen
>
> On Dec 14, 2015, at 6:45 PM, Zachary Turner wrote:
>
> A unit test would be good at catching bugs like this.
>
> On Mon, Dec 14, 2015 at 6:23 PM Enrico Granata via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: enrico
>> Dat
#x27;
> True
> >>> 'bc' in s
> True
> >>> 'clang' in 'clang'
> True
>
> On Mon, Dec 14, 2015 at 6:45 PM, Siva Chandra
> wrote:
>
>> On Mon, Dec 14, 2015 at 6:42 PM, Zachary Turner
>> wrote:
>> > zt
language categories via the command line/API. Then one could have an ad-hoc
> formatter added just for testing.
>
> Sent from my iPhone
>
> On Dec 14, 2015, at 7:07 PM, Zachary Turner wrote:
>
> Ahh. Is there any way to change that behavior so that you can add back
>
d will have the same category value. The canonical way to solve
> these issues is to add a new argument called category and set its default
> value to category (same as I did for argvalue).
>
> On Mon, Dec 14, 2015 at 11:01 PM Zachary Turner via lldb-commits <
> lldb-commits@lis
1501 - 1600 of 3010 matches
Mail list logo
