[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

xujuntwt95329 added a comment. Hi @paolosev, **many thanks for such a great patch which makes it possible to debug WebAssembly applications.** It is really really useful especially in non-browser environments. We have enabled source debugging feature in **WebAssembly Micro Runtime

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

xujuntwt95329 added a comment. In D78801#3279811 , @paolosev wrote: > Thanks @xujuntwt95329! I am very happy that this was useful for WebAssembly > Micro Runtime! I believe we are making the world of WebAssembly better! BTW, I find an issue when trying

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

xujuntwt95329 added a comment. In D78801#3281504 , @paolosev wrote: > Hi @xujuntwt95329, > Honestly I wasn't thinking to support multithreading with this initial patch > so I am not surprised that it doesn't work. You are right, we should add > thread in

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The key stored in the source map is a normalized path string with host's path style, so it is also necessary to normalize the file path durin

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3084948 , @wallace wrote: > Is it possible to add a test for that? In any case, this makes sense to me In D112439#3085304 , @clayborg wrote: > Adding a test would be g

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 382235. xujuntwt95329 added a comment. Herald added a subscriber: mgorny. add unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Targ

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 382237. xujuntwt95329 added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp lldb/unittest

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. I've added the unit test. The "FindFile" method requires the FileSystem, so I added a new file rather then put these code into exist PathMappingListTest.cpp Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1124

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33-37 ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for // us. We then grab the string and turn it back int

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 383083. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp lldb/unittests/T

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 383553. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp lldb/unittests/T

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The amount of roundtrips between StringRefs, ConstStrings and std::strings is getting a bit out of hand, this patch avoid the unnecessary ro

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 updated this revision to Diff 383559. xujuntwt95329 added a comment. address dblaikie's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 Files: lldb/include/lldb/Target/PathMapping

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 marked 2 inline comments as done. xujuntwt95329 added a comment. @dblaikie Thanks for your detailed comments, I've uploaded the new patch-set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 marked 2 inline comments as done. xujuntwt95329 added a comment. Hi, @aprantl I've submitted a NFC patch here: https://reviews.llvm.org/D112863 Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 added a comment. In D112863#3098706 , @wallace wrote: > @xujuntwt95329 do you have push permissions or do you need help to land this > diff? I don't have push permissions, could you please help me to land this? Thanks a lot! Repository:

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 updated this revision to Diff 383965. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 Files: lldb/include/lldb/Target/PathMappingList.h lldb/source/

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 added a comment. @wallace rebased But I guess you should apply this patch firstly? https://reviews.llvm.org/D112439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 _

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3102506 , @teemperor wrote: > In D112439#3098307 , @xujuntwt95329 > wrote: > >> Seems that patch can't build by CI because it is based on this patch. In my >> understand

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3102548 , @teemperor wrote: > In D112439#3102533 , @xujuntwt95329 > wrote: > >> In D112439#3102506 , @teemperor >> wrote: >> >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3102600 , @teemperor wrote: > In D112439#3102559 , @xujuntwt95329 > wrote: > >> In D112439#3102548 , @teemperor >> wrote: >> >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. Thanks a lot for your comments, they are very useful and I learned a lot about C++ by talking with you. I'll address these comments and submit a patch and request your review. Much appreciated！ Comment at: lldb/unittests/Target/FindFileTest.cpp

[Lldb-commits] [PATCH] D113011: [lldb] make the code prettier in FindFileTest.cpp

xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113011 Files: lldb/unittests/Target/FindFileTest.cpp Index: lldb/unitte

[Lldb-commits] [PATCH] D113011: [lldb] make the code prettier in FindFileTest.cpp

xujuntwt95329 added a comment. Thanks to @teemperor's comments in https://reviews.llvm.org/D112439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113011/new/ https://reviews.llvm.org/D113011 ___ lldb-comm

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 marked 7 inline comments as done. xujuntwt95329 added a comment. I have submitted a new patch here: https://reviews.llvm.org/D113011 Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439