[Lldb-commits] [PATCH] D156367: [BSDArchive] NULL check the child object file ptr before accessing its member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b9eed9c64f3: [BSDArchive] NULL check the child object file ptr before accessing its member (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG L

[Lldb-commits] [PATCH] D156367: [BSDArchive] NULL check the child object file ptr before accessing its member

kusmour added a comment. In D156367#4539916 , @bulbazord wrote: > Hey, I think this may have broken the green dragon bots. Could you take a > look and fix forward or revert? Thanks > > https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/3262/ (Y

[Lldb-commits] [PATCH] D156564: [lldb] Fix test TestBSDArchives.py properly

This revision was automatically updated to reflect the committed changes. Closed by commit rGca76281917d0: [lldb] Fix test TestBSDArchives.py properly (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

kusmour added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

kusmour accepted this revision. kusmour added a comment. The fix looks straightforward. And @splhack has verified locally. Accepting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390 ___

[Lldb-commits] [PATCH] D136177: [lldb-vscode] Send Statistics Dump in terminated event

This revision was automatically updated to reflect the committed changes. kusmour marked 3 inline comments as done. Closed by commit rGc8a26f8c6de3: [lldb-vscode] Send Statistics Dump in terminated event (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

kusmour added a comment. It'd be great to put some background in the summary. The issue is introduced when adding Symbol OnDemand feature. We added a wrapper that ignore the error. And this affected the ability to populate the error when we have this feature turned on :D (something like this,

[Lldb-commits] [PATCH] D137003: [lldb-vscode] Send Statistics Dump in terminated event

This revision was automatically updated to reflect the committed changes. kusmour marked an inline comment as done. Closed by commit rGe3ccbae30927: [lldb-vscode] Send Statistics Dump in terminated event (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D137003: [lldb-vscode] Send Statistics Dump in terminated event

kusmour added a comment. In D137003#3908918 , @shafik wrote: > It looks like this change broke `TestVSCode_terminatedEvent.py` see Green > Dragon build bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48111/ > > Please fix or revert. I

[Lldb-commits] [PATCH] D137665: [lldb-vscode] Send Selected Statistics Dump in Terminated Event

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bc86ae83e95: [lldb-vscode] Send Selected Statistics Dump in Terminated Event (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

kusmour marked an inline comment as done. kusmour added inline comments. Comment at: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp:1280 // Reenable async events and start the event thread to catch async events. - g_vsc.debugger.SetAsync(true); + // g_vsc.debugger.SetAsync(tru

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This can help `lldb-vscode` handle launch commands associate with remote platform attach request have field `attachCommands` to handle attach specific commands

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

kusmour updated this revision to Diff 212683. kusmour added a comment. complete the corresponding test for extra `launchCommands` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65363/new/ https://reviews.llvm.org/D65363 Files: lldb/packages/Python/lldbsuite/

[Lldb-commits] [PATCH] D65784: [lldb] delete "--platform-path" option from "target create"

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This option is dead. lldb under platform mode can resolve the path wether it's on remote platform or not clean the option to avoid misleading Repository

[Lldb-commits] [PATCH] D65784: [lldb] delete "--platform-path" option from "target create"

kusmour added a comment. In D65784#1616118 , @jasonmolenda wrote: > Yeah, it's not currently hooked up to anything; I'm returning to > remote-platform testing soon, if we've lost some necessary functionality I > can re-add it, but this option right now

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. kusmour added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. Implement the ABI for WIndows-x86_64 including register info and calling convention. Handled nested struct returned in register (Sys

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 200622. kusmour added a comment. Herald added a subscriber: fedor.sergeev. update a new version based on comment. cleaned some useless comment change to use CHAR_BIT for readability Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour marked 16 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + +// We currently only support extracting values with Clang QualTypes. Do we +// care about others? -

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour marked an inline comment as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1096 + if (arch_type == llvm::Triple::x86_64 +&& os_type == llvm::Triple::OSType::Win32) { +return ABISP(new ABIWindows_x86_6

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 200844. kusmour added a comment. update nit Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 Files: lldb/source/API/SystemInitializerFull.cpp lldb/source/Plugins/ABI/CMakeLists.t

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 201377. kusmour added a comment. update the `CreateDefaultUnwindPlan`. return false or give empty Unwind Plan may cause lldb to crash and break tests on windows. So for now, copy the SysV-x86_64 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a function to flatten the nested aggregate type Repository: rLLDB LLDB https://reviews.llvm.org/D62702 Files: lldb/source/Plugins/ABI/SysV-x

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour added a comment. @jingham working on the unit test rn. will upload soon Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour marked an inline comment as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1568 +// return false if the aggregate is in memory +static bool FlattenAggregateType( +ExecutionContext &exe_ctx, comp

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour updated this revision to Diff 202340. kusmour added a comment. simplify the method in 'FlattenAggregateType' added test for nested struct returned in registers Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702 Fil

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour added a comment. In D62702#1525655 , @compnerd wrote: > Actually, I think that we should extend `CompilerType` and `TypeSystem` to > expose Clang's knowledge of whether a type is passed in a register by means > of using `clang::RecordDecl::isPass

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour updated this revision to Diff 202517. kusmour added a comment. Herald added a subscriber: teemperor. added a virtual function `CanPassInRegister` in TypeSystem class to provide info about type can be passed in register or not `ClangASTContext` will refer to `clang::RecordDecl::canPassInReg

[Lldb-commits] [PATCH] D62771: [LLDBregisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. Herald added subscribers: lldb-commits, kristof.beyls, javed.absar. Herald added a project: LLDB. llvm updated the function from `llvm::codeview::getRegisterNames()` to `llvm::codeview::getRegisterNames(CPUType)` according

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour marked 2 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:3915 +bool ClangASTContext::CanPassInRegisters(const CompilerType &type) { + if (clang::RecordDecl *record_decl = + ClangASTContext::GetAsRecordDecl(

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour updated this revision to Diff 202574. kusmour marked an inline comment as done. kusmour added a comment. small update :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62702/new/ https://reviews.llvm.org/D62702 Files: lldb/include/lldb/Symbol/ClangAST

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour updated this revision to Diff 202585. kusmour added a comment. fix switch statement Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62771/new/ https://reviews.llvm.org/D62771 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpressio

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour marked 2 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:32 +case llvm::Triple::ArchType::aarch64_32: + cpu = llvm::codeview::CPUType::ARM64; +default: --

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

kusmour abandoned this revision. kusmour marked an inline comment as done. kusmour added a comment. D62772 toke care of this Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62771/new/ https://reviews.llvm.org/D62771 __

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

kusmour updated this revision to Diff 202824. kusmour added a comment. 1. Limit the `TestReturnValue` for nested struct and class (cpp support) to only x86_64 2. This patch somehow fix the bug: pr36870 for Systerm V ABI (windows is waiting for this

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 203061. kusmour added a comment. Update the `GetReturnValueObjectImpl` using function `CanPassInRegisters` to explicitly check NOTE: There's NO register context info about registers beyond general purpose registers So floating point return type is not suppo

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 204695. kusmour added a comment. Added support for XMM registers. Now the step out on a function returns floating point number should have the right value. To play with it, define a function float getFloat(float value) { return value; } set a brea

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 204885. kusmour added a comment. complete the code for floating point registers and cleaned up the support for floating point registers fixed `TestRegistersIterator` update the testcased Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 205390. kusmour added a comment. the OS check in SysV x64 ABI broke the test `SymbolFile/DWARF/debug_loc.s` added a restriction `lld` to `#REQUIRES` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.l

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour added a comment. @labath Hi, you're right about the `lld`, it didn't make the test pass, instead it became unsupported. In D62213#1548835 , @labath wrote: > Can you elaborate on that? How exactly did it break this test? So the problem here is t

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 205640. kusmour added a comment. allow SysV_x86_64 ABI to handle unknown OS type this should fix the test `SymbolFile/DWARF/debug_loc.s` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D622

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Fixed `Android.rules` for running test suite on remote android - the build configuration is not compatible with ndk structure, change it to link to sta

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

kusmour updated this revision to Diff 208465. kusmour edited the summary of this revision. kusmour added a comment. added method skipIfTargetAndroid Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64118/new/ https://reviews.llvm.org/D64118 Files: lldb/package

[Lldb-commits] [PATCH] D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Move checking pointer code block before accessing the pointer This caused lldb to crash when testing on Android Repository: rLLDB LLDB https://revi

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Delete the duplicate func `skipIfTargetAndroid` Fix the old one Repository: rLLDB LLDB https://reviews.llvm.org/D64583 Files: lldb/packages/Pytho

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

kusmour updated this revision to Diff 209325. kusmour edited the summary of this revision. kusmour added a comment. Herald added a subscriber: abidh. add more context to diff Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64583/new/ https://reviews.llvm.org/D645

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

kusmour created this revision. kusmour added reviewers: xiaobai, labath. Herald added subscribers: lldb-commits, kristof.beyls, javed.absar, srhines. Herald added a project: LLDB. update some test decorates that can actually pass on andriod aarch64 Repository: rLLDB LLDB https://reviews.llvm.

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

kusmour created this revision. kusmour added reviewers: xiaobai, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added a local variable to hold the return value to avoid delayed calculation on variables This issue occurred when using NDK 20 clang with `-O0` flag set

[Lldb-commits] [PATCH] D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up

kusmour created this revision. kusmour added reviewers: xiaobai, labath. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Delete the android target from `libstdcpp` test category, since android no longer support libstdcxx Repository: rLLDB LLDB https://reviews.l

[Lldb-commits] [PATCH] D64769: [lldb][test_suite] change the test main.cpp to avoid expression reschedule

kusmour added a comment. In D64769#1587318 , @labath wrote: > The change is fine, but for my own education, could you elaborate on what > this "delayed calculation" is, and how does it make the test fail? The test set the breakpoint to the return statem

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

kusmour added a comment. In D64767#1587311 , @labath wrote: > Whether a lot of these tests (e.g. all watchpoint related tests) pass or fail > may depend on the exact android device you are running the tests against. > However, you are the only ones runni