https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74748
There are some typescript vscode extensions that are effectively wrappers of
lldb-dap, and they commonly configure the debug adapter in particular ways
using initCommands, among other settings. An unfor
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74748
>From 07bd16ac9bbc4f9868d1b541e003aa95bf6ae8be Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Wed, 29 Nov 2023 18:12:54 -0500
Subject: [PATCH] [lldb-dap] Introduce the new privateConfiguration set
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/74748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , the main issue is to allow users to use the regular initCommands
and at the same time have another way for the vscode extension to issue their
own initCommands and control the output of these specific commands without
interfering with the initCommands provid
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/74748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Closing this because I'm going to change my approach after talking to Greg.
https://github.com/llvm/llvm-project/pull/74748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74808
This adds support for optionally prefixing any command with `?`, which
effectively prevents the output of these commands to be printed to the console
unless they fail. This comes handy when programmatic
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74808
>From d544ba0cc6836c0b5c2086edccfc2b41080174ef Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 00:11:19 -0500
Subject: [PATCH] [lldb-dap] Implement quiet commands
This adds support
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/74808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/74808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74861
Currently there's an include in which `[opt]` might be emitted twice if the
frame format also asks for it. As a trivial fix, we should manually emit
`[opt]` only if a custom frame format is not specifie
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74865
This is an extension to the protocol that emits the declaration information
along with the metadata of each variable. This can be used by vscode extensions
to implement, for example, a "goToDefinition"
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix,
const char *error = result.GetError();
strm << error;
}
+ };
+
+ lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter();
+ for (llvm::StringRef command : commands) {
+lld
@@ -1101,6 +1101,29 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
// can use this optional information to present the
// children in a paged UI and fetch them in chunks."
// }
+// "declaration": {
+//
walter-erquinigo wrote:
@clayborg , I actually insist on aborting on failure for this feature. You
mention:
> It would be nice if the RunLLDBCommands function could take an extra bool
> &fatal_error that clients could check after running when needed to decide
> what to do if this is set to tr
walter-erquinigo wrote:
> Is this extension to the protocol documented anywhere I can see? Or is this
> an ad-hoc thing? I think it would be useful to write down somewhere other
> than a commit message (in docs, comments, or otherwise) that this is an
> extension.
@bulbazord , it's an ad hoc
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/74861
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/74865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1165,6 +1188,24 @@ llvm::json::Value CreateVariable(lldb::SBValue v,
int64_t variablesReference,
const char *evaluateName = evaluateStream.GetData();
if (evaluateName && evaluateName[0])
EmplaceSafeString(object, "evaluateName", std::string(evaluateName));
+
+ if
walter-erquinigo wrote:
> Might be good idea to only add "declaration" if and only if we have both a
> file and line at least?
I think it's better to emit it if there's at least one of them. We can leave it
to the client the decision of what to do if only one of them is available.
https://git
walter-erquinigo wrote:
> "error: one of your required 'attachCommands' failed, check the debug console
> for details"
This is a key thing that I didn't consider in the beginning. I'm going to
update this patch to only support `?`, and then I'll make another one for `!`,
because I need to exp
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74808
>From e4c6bed8327aaedab1b5bd0a13e7408dc4d152e4 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 00:11:19 -0500
Subject: [PATCH] [lldb-dap] Implement quiet commands
This adds support
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/75244
In order to allow smarter vscode extensions, it's useful to send additional
structured information of SBValues to the client. Specifically, I'm now sending
error, summary, autoSummary and inMemoryValue
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/75244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@dodzey, thanks for submitting this PR.
@clayborg and I have recently been discussing the idea of implementing a
minimal typescript extension for lldb-dap, which could host the kind of
functionality that you are trying to fix.
I haven't had yet time to do it, but it's
@@ -1103,28 +1116,52 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
// can use this optional information to present the
// children in a paged UI and fetch them in chunks."
// }
+//
+//
+// // Unofficial e
walter-erquinigo wrote:
> Would you want the minimal typescript extension to be a separate extension
> from the main lldb-dap one?, or would it be okay to have the typescript in
> the lldb-dap project/extension?
It should be part of the lldb-dap folder/project and it should also be the
defaul
walter-erquinigo wrote:
@Dodzey , I think I'll add the minimal TS project tonight and you can review
it. Then we can add a few additional features there are as follow ups
https://github.com/llvm/llvm-project/pull/75342
___
lldb-commits mailing list
ll
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74808
>From 4e6bfb5f26f7744db1cb4a37d0e342195ae0ff8a Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 00:11:19 -0500
Subject: [PATCH] [lldb-dap] Implement quiet commands
This adds support
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75244
>From d8397cb98d219f8d368937efb5c7ba940f420fe3 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 12:58:30 -0500
Subject: [PATCH] [lldb-dap] Emit more structured info along with variab
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/75515
This is very straightforward and these are the most important details:
- All the cpp code has been moved to a subfolder for cleanness. There's a
specific commit in the list of commits of this PR that ju
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75515
>From f5a7a59dc4bd2601403abae06aba7fc534974b7a Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 14 Dec 2023 11:52:18 -0500
Subject: [PATCH 1/2] Move files to src-cpp
---
lldb/tools/lldb-dap/{
walter-erquinigo wrote:
Here it is https://github.com/llvm/llvm-project/pull/75515!
https://github.com/llvm/llvm-project/pull/75342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74808
>From 4e6bfb5f26f7744db1cb4a37d0e342195ae0ff8a Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 00:11:19 -0500
Subject: [PATCH 1/2] [lldb-dap] Implement quiet commands
This adds sup
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74808
>From 4e6bfb5f26f7744db1cb4a37d0e342195ae0ff8a Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 00:11:19 -0500
Subject: [PATCH 1/3] [lldb-dap] Implement quiet commands
This adds sup
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/74808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1133,63 +1175,64 @@ llvm::json::Value CreateVariable(lldb::SBValue v,
int64_t variablesReference,
int64_t varID, bool format_hex,
bool is_name_duplicated,
std::optional custo
@@ -153,10 +153,18 @@ def do_test_scopes_variables_setVariable_evaluate(
buffer_children = make_buffer_verify_dict(0, 32)
verify_locals = {
"argc": {
-"equals": {"type": "int", "value": "1"},
-"declaration": {
-
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75244
>From b8c91437e95d45d2435e264084b1118491a2318c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 12:58:30 -0500
Subject: [PATCH] [lldb-dap] Emit more structured info along with variab
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75244
>From 724ac112073c87c4a6b82618c8704c049e8112a5 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 8 Dec 2023 12:58:30 -0500
Subject: [PATCH] [lldb-dap] Emit more structured info along with variab
@@ -0,0 +1,5 @@
+out
+node_modules
+.vscode-test
+*.vsix
+!.vscode
walter-erquinigo wrote:
yes, npm creates all these files
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lis
@@ -27,58 +31,43 @@ get a full featured debugger with a well defined protocol.
# Installation for Visual Studio Code
-Installing the plug-in involves creating a directory in any location outside of
-`~/.vscode/extensions`. For example, `~/vscode-lldb` is a valid one. You'll
@@ -0,0 +1,21 @@
+import * as vscode from 'vscode';
walter-erquinigo wrote:
This approach doesn't work anymore. In fact, for the entirety of 2023 this was
not possible.
https://github.com/llvm/llvm-project/pull/75515
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75515
>From aa071e67b07bd23550253ce4f4ca093eb6b8431c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 14 Dec 2023 12:29:52 -0500
Subject: [PATCH] Add TS files
---
lldb/tools/lldb-dap/.gitignore
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75515
>From a3cd529575b6d8b28204489308a9787ca5a44889 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 14 Dec 2023 12:29:52 -0500
Subject: [PATCH] Add TS files
---
lldb/tools/lldb-dap/.editorconfig
@@ -0,0 +1,21 @@
+import * as vscode from 'vscode';
walter-erquinigo wrote:
Perhaps your docker config is allowing you to do that, but you can see this old
gh issue that talks more about this problem
https://github.com/llvm/llvm-project/issues/63655#issuecommen
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75515
>From f43036155fd42a6203e99ff6757054f2d256d81a Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 14 Dec 2023 12:29:52 -0500
Subject: [PATCH] Add TS files
---
lldb/tools/lldb-dap/.editorconfig
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/75515
>From b209c5276d14c46c08143af458188a42e6a28615 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 14 Dec 2023 12:29:52 -0500
Subject: [PATCH] Add TS files
---
lldb/tools/lldb-dap/.editorconfig
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/75244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: walter erquinigo
Date: 2024-01-02T13:30:44-05:00
New Revision: 0d19a8983c05de321d8ab592995e7a36bca448ee
URL:
https://github.com/llvm/llvm-project/commit/0d19a8983c05de321d8ab592995e7a36bca448ee
DIFF:
https://github.com/llvm/llvm-project/commit/0d19a8983c05de321d8ab592995e7a36bca448ee.di
@@ -103,12 +103,10 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t
pid,
ParsedProcess parsed_process;
parsed_process.target_sp = target_sp;
- // This should instead try to directly create an instance of ProcessTrace.
- // ProcessSP process_sp = target_sp->Cr
@@ -85,6 +85,11 @@ double DecodedThread::NanosecondsRange::GetInterpolatedTime(
return interpolate(next_range->nanos);
}
+DecodedThread::TraceItemStorage::TraceItemStorage(
+const TraceItemStorage &other) {
+ std::memcpy(this, &other, sizeof *this);
wal
@@ -108,8 +108,8 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t
pid,
///*listener*/ nullptr, "trace",
///*crash_file*/ nullptr,
///*can_connect*/ false);
-
- process_sp->SetID(static_cast(pid));
+ //
+ // process_sp->SetID(static_cast(pid));
-
https://github.com/walter-erquinigo commented:
These changes lgtm at this point. Btw, how are you testing them?
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
walter-erquinigo wrote:
`third-party/llvm-project/lldb/test/API/commands/trace` has a set of pythong
tests.
You should be able to run them with
```
build lldb-dotest
lldb-dotest -p TestTrace
```
Also, the CMake variable `LLDB_INCLUDE_TESTS` must be enabled (e.g. `ON`) in
order to build `lldb
walter-erquinigo wrote:
> At least one test fails: `./bin/lldb -o 'trace load -v
> /llvm/lldb/test/API/commands/trace/intelpt-trace/trace_2threads.json'`
> crashes with an assertion failure on TraceIntelPTBundleLoader.cpp:127
> (`*process_sp` is a null pointer dereference).
>
> Do you know wh
walter-erquinigo wrote:
> because the prior call to `CreateProcess` on line 107 returned null.
If that call returned null, that means that CreateProcess wasn't able to find
the "trace" process plugin. Another thing to add, which should definitely work,
is to invoke
```
ProcessTrace::Initializ
@@ -276,6 +276,9 @@ class DecodedThread : public
std::enable_shared_from_this {
/// The string message of this item if it's an error
std::string error;
+
+TraceItemStorage() {}
+~TraceItemStorage() {}
walter-erquinigo wrote:
do you still need
@@ -107,7 +107,15 @@ DecodedThread::CreateNewTraceItem(lldb::TraceItemKind
kind) {
(*m_last_tsc)->second.items_count++;
if (m_last_nanoseconds)
(*m_last_nanoseconds)->second.items_count++;
- return m_item_data.back();
+
+ TraceItemStorage &data = m_item_data.back()
walter-erquinigo wrote:
Nice! Could you just delete all the tests that check for number of bytes? I
think it's better to delete them because they might change in different systems.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits maili
@@ -107,7 +107,15 @@ DecodedThread::CreateNewTraceItem(lldb::TraceItemKind
kind) {
(*m_last_tsc)->second.items_count++;
if (m_last_nanoseconds)
(*m_last_nanoseconds)->second.items_count++;
- return m_item_data.back();
+
+ TraceItemStorage &data = m_item_data.back()
walter-erquinigo wrote:
> Also, I noticed some error messages were different for some tests — I'm
> guessing they may have changed in newer versions of libipt.
That makes sense. In this case I'd just drop text comparisons for those tests.
Just knowing that an error was found is good enough.
>
walter-erquinigo wrote:
Just let me know when your changes are ready and only that test fails.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/77252
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -242,19 +254,57 @@ def do_test_scopes_variables_setVariable_evaluate(
},
"pt": {
"equals": {"type": "PointType"},
-"startswith": {
-"result": "{x:11, y:22}"
+"equals": {
+
@@ -135,6 +135,18 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ value.GetDescription(stream);
walter-erquinigo wrote:
The method `bool
walter-erquinigo wrote:
@ashgti , for some reason I can't assign you as reviewer for this PR, but PTAL!
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -0,0 +1,57 @@
+import * as vscode from "vscode";
+import { LLDBDapOptions } from "./types";
+import { DisposableContext } from "./disposable-context";
+import { LLDBDapDescriptorFactory } from "./debug-adapter-factory";
+import * as fs from 'fs/promises'
+
+/**
+ * This creates
@@ -242,19 +254,57 @@ def do_test_scopes_variables_setVariable_evaluate(
},
"pt": {
"equals": {"type": "PointType"},
-"startswith": {
-"result": "{x:11, y:22}"
+"equals": {
+
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
just two minor things left, but otherwise LGTM
https://github.com/llvm/llvm-project/pull/77026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -135,6 +135,21 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
walter-erquinigo wrote:
add a comment for this function mentioning that this returns an empty string
@@ -135,6 +135,21 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+static std::string GetDescriptionTrimmed(lldb::SBValue &value) {
+ lldb::SBStream stream;
+ if (!value.GetDescription(stream)) {
+return "";
+ }
walter-erquini
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/75515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@Dodzey, the typescript extension has been merged and, if you want, you can
implement an integrated process picker for lldb-dap.
https://github.com/llvm/llvm-project/pull/75342
___
lldb-commits mailing list
lldb-commits@lists.l
walter-erquinigo wrote:
Now that I think of it, it would be really nice if GetDescription() could get a
`one_line` flag that prints the description as a single line. Then the
rendering will be much better on vscode, because we already dump the children
of each object anyway.
https://github.co
Author: walter erquinigo
Date: 2023-08-22T12:27:08-04:00
New Revision: a4dbdf4749938396dbf913478289fa426d8341ae
URL:
https://github.com/llvm/llvm-project/commit/a4dbdf4749938396dbf913478289fa426d8341ae
DIFF:
https://github.com/llvm/llvm-project/commit/a4dbdf4749938396dbf913478289fa426d8341ae.di
Author: walter erquinigo
Date: 2023-08-22T17:04:53-04:00
New Revision: 9e66ea503ea1727b333ecb088e73e81a4c0736d5
URL:
https://github.com/llvm/llvm-project/commit/9e66ea503ea1727b333ecb088e73e81a4c0736d5
DIFF:
https://github.com/llvm/llvm-project/commit/9e66ea503ea1727b333ecb088e73e81a4c0736d5.di
Author: walter erquinigo
Date: 2023-08-22T17:41:14-04:00
New Revision: 7822e5dbf1cb4be2d73eb13da27b04de684c318b
URL:
https://github.com/llvm/llvm-project/commit/7822e5dbf1cb4be2d73eb13da27b04de684c318b
DIFF:
https://github.com/llvm/llvm-project/commit/7822e5dbf1cb4be2d73eb13da27b04de684c318b.di
Author: walter erquinigo
Date: 2023-08-28T17:47:30-04:00
New Revision: 47aca7562abe8de378fdb88160ece9e3fcac24f4
URL:
https://github.com/llvm/llvm-project/commit/47aca7562abe8de378fdb88160ece9e3fcac24f4
DIFF:
https://github.com/llvm/llvm-project/commit/47aca7562abe8de378fdb88160ece9e3fcac24f4.di
Author: walter erquinigo
Date: 2023-08-28T17:55:15-04:00
New Revision: bc0b5699063ef4a678e663b8aee738b4906f8719
URL:
https://github.com/llvm/llvm-project/commit/bc0b5699063ef4a678e663b8aee738b4906f8719
DIFF:
https://github.com/llvm/llvm-project/commit/bc0b5699063ef4a678e663b8aee738b4906f8719.di
Author: walter erquinigo
Date: 2023-08-30T14:14:28-04:00
New Revision: 79d5d9a0824ddcd5493a451e5009dd6393646e51
URL:
https://github.com/llvm/llvm-project/commit/79d5d9a0824ddcd5493a451e5009dd6393646e51
DIFF:
https://github.com/llvm/llvm-project/commit/79d5d9a0824ddcd5493a451e5009dd6393646e51.di
Author: walter erquinigo
Date: 2023-09-01T20:52:00-04:00
New Revision: 2f9cd6377f3d972ed8cf814225a02a353d6cc545
URL:
https://github.com/llvm/llvm-project/commit/2f9cd6377f3d972ed8cf814225a02a353d6cc545
DIFF:
https://github.com/llvm/llvm-project/commit/2f9cd6377f3d972ed8cf814225a02a353d6cc545.di
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/65514:
We've been displaying types and addresses for containers, but that's not very
useful information. A better approach is to compose the summary of containers
with the summary of a few of its children.
N
https://github.com/walter-erquinigo review_requested
https://github.com/llvm/llvm-project/pull/65514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/65514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo review_requested
https://github.com/llvm/llvm-project/pull/65514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/65514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -132,6 +132,84 @@ std::vector GetStrings(const
llvm::json::Object *obj,
return strs;
}
+/// Create a short summary for a container that contains the summary of its
+/// first children, so that the user can get a glimpse of its contents at a
+/// glance.
+static std::opti
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/65514:
>From e7ed33687a44992889df60eae5af03fb439aacc0 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Wed, 6 Sep 2023 10:38:41 -0400
Subject: [PATCH 1/2] [lldb-vscode] Display a more descriptive summary
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/65514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/65537:
We were invoking GetChildAtIndex(0) without checking the number of children.
This was not crashing but was showing some warnings in python formatters.
>From 78d2b81b4a6fb55b98b42f6e3edd0f6d96f20fd8 Mon
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/65537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/65552:
Currently, if the user wants to inspect the raw version of a synthetic
variable, they have to go to the debug console and type `frame var ,
which is not a great experience. Taking inspiration from Code
https://github.com/walter-erquinigo review_requested
https://github.com/llvm/llvm-project/pull/65552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo review_requested
https://github.com/llvm/llvm-project/pull/65552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/65552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/65552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
201 - 300 of 974 matches
Mail list logo
