valentinagiusti created this revision.
valentinagiusti added a reviewer: zturner.
valentinagiusti added a subscriber: lldb-commits.
Let the inferior test code determine if CPU and kernel support Intel(R)
MPX and cleanup test script.
Signed-off-by: Valentina Giusti
https://reviews.llvm.org/D253
valentinagiusti created this revision.
valentinagiusti added reviewers: zturner, labath.
valentinagiusti added subscribers: emaste, lldb-commits.
This patch adds support for handling the SIGSEGV signal with 'si_code ==
SEGV_BNDERR', which is thrown when a bound violation is caught by the
Intel(R)
Author: valentinagiusti
Date: Thu Oct 6 10:49:10 2016
New Revision: 283461
URL: http://llvm.org/viewvc/llvm-project?rev=283461&view=rev
Log:
Improve test for Intel(R) MPX registers.
Summary:
Let the inferior test code determine if CPU and kernel support Intel(R)
MPX and cleanup test script.
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283461: Improve test for Intel(R) MPX registers. (authored
by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D25328?vs=73798&id=73804#toc
Repository:
rL LLVM
https://reviews.llv
valentinagiusti updated this revision to Diff 73811.
valentinagiusti added a comment.
used llvm:raw_string_ostream instead of std::stringstream
https://reviews.llvm.org/D25329
Files:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile
valentinagiusti updated this revision to Diff 73823.
valentinagiusti added a comment.
fixed usage of llvm:raw_string_ostream
https://reviews.llvm.org/D25329
Files:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile
packages/Python/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283474: Add bound violation handling for Intel(R) Memory
Protection Extensions (Intel… (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D25329?vs=73823&id=73826#toc
Repo
Author: valentinagiusti
Date: Thu Oct 6 13:05:12 2016
New Revision: 283474
URL: http://llvm.org/viewvc/llvm-project?rev=283474&view=rev
Log:
Add bound violation handling for Intel(R) Memory Protection Extensions
(Intel(R) MPX)
Summary:
This patch adds support for handling the SIGSEGV signal wit
valentinagiusti created this revision.
valentinagiusti added reviewers: zturner, labath.
valentinagiusti added subscribers: lldb-commits, emaste.
https://reviews.llvm.org/D25362
Files:
source/Plugins/Process/POSIX/CrashReason.cpp
source/Plugins/Process/POSIX/CrashReason.h
Index: source/Plug
valentinagiusti updated this revision to Diff 73907.
valentinagiusti added a comment.
applied clang-format
https://reviews.llvm.org/D25362
Files:
source/Plugins/Process/POSIX/CrashReason.cpp
source/Plugins/Process/POSIX/CrashReason.h
Index: source/Plugins/Process/POSIX/CrashReason.h
=
valentinagiusti updated this revision to Diff 73909.
valentinagiusti added a comment.
cleaned up code
https://reviews.llvm.org/D25362
Files:
source/Plugins/Process/POSIX/CrashReason.cpp
source/Plugins/Process/POSIX/CrashReason.h
Index: source/Plugins/Process/POSIX/CrashReason.h
==
Author: valentinagiusti
Date: Fri Oct 7 08:21:59 2016
New Revision: 283548
URL: http://llvm.org/viewvc/llvm-project?rev=283548&view=rev
Log:
Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474
Differential Revision: https://reviews.llvm.org/D25362
Modified:
lldb/trunk/s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283548: Fix build failure on lldb-amd64-ninja-freebsd11
error caused by rL283474 (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D25362?vs=73909&id=73945#toc
Repository
Author: valentinagiusti
Date: Tue Jan 31 12:02:54 2017
New Revision: 293660
URL: http://llvm.org/viewvc/llvm-project?rev=293660&view=rev
Log:
Add a command to access and manipulate the Intel(R) MPX Boundary Tables.
Summary:
The Boundary Table Entries are stored in the application memory and allow
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280668: Intel(R) Memory Protection Extensions (Intel(R) MPX)
support. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24187?vs=70152&id=70342#toc
Repository:
rL LLVM
Author: valentinagiusti
Date: Mon Sep 5 12:43:10 2016
New Revision: 280668
URL: http://llvm.org/viewvc/llvm-project?rev=280668&view=rev
Log:
Intel(R) Memory Protection Extensions (Intel(R) MPX) support.
Summary:
The Intel(R) Memory Protection Extensions (Intel(R) MPX) associates pointers
to bou
valentinagiusti created this revision.
valentinagiusti added a subscriber: lldb-commits.
Signed-off-by: Valentina Giusti
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalities/register/Makefile
packages/Python/lldbsuite/test/functionalities/register/TestRegist
valentinagiusti added a comment.
Thanks for the review! You can find my replies inline.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27
@@ +26,3 @@
+
+@skipIfiOSSimulator
+@skipIf(compiler="clang")
-
valentinagiusti added a comment.
Hi, inline there are my other replies.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
valentinagiusti updated this revision to Diff 70507.
valentinagiusti added a comment.
Improved TestMPXRegisters.py and Makefile according to review.
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalities/register/Makefile
packages/Python/lldbsuite/test/functio
valentinagiusti marked an inline comment as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6
@@ +5,3 @@
+ifeq "$(ARCH)" "i386"
+ CFLAGS_EXTRAS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
+ LD_EXTRAS +=
valentinagiusti updated this revision to Diff 70695.
valentinagiusti added a comment.
Improved MPX test Makefile and removed workaround for unnamed register sets,
and rebased according to the new coding style.
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalit
valentinagiusti added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:7
@@ +6,2 @@
+
+include $(LEVEL)/Makefile.rules
Np, thanks for the review and explanations ;)
https://reviews.llvm.org/D2
Author: valentinagiusti
Date: Thu Sep 8 09:16:45 2016
New Revision: 280942
URL: http://llvm.org/viewvc/llvm-project?rev=280942&view=rev
Log:
Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.
Summary: Signed-off-by: Valentina Giusti
Reviewers: dvlahovski, granata.e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280942: Fix for rL280668, Intel(R) Memory Protection
Extensions (Intel(R) MPX) support. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24255?vs=70695&id=70698#toc
Rep
valentinagiusti marked 2 inline comments as done.
valentinagiusti added a comment.
This fixes the fact that there is no proper check that the kernel or the
hardware are actually supporting either AVX or MPX. Before this patch, the code
only relied on a "hack" that checks if it's possible to do a
valentinagiusti updated this revision to Diff 71371.
valentinagiusti added a comment.
moved header to the bottom and moved enum into header file
https://reviews.llvm.org/D24559
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
source/Plugins/Process/Linux/NativeRegis
Author: valentinagiusti
Date: Wed Sep 14 12:27:48 2016
New Revision: 281507
URL: http://llvm.org/viewvc/llvm-project?rev=281507&view=rev
Log:
Use Intel CPU flags to determine target supported features.
Summary:
This patch uses the instruction CPUID to verify that FXSAVE, XSAVE, AVX
and MPX are su
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281507: Use Intel CPU flags to determine target supported
features. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24559?vs=71371&id=71390#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281528: Use 'enum class' instead of 'enum' in
NativeRegisterContextLinux_x86_x64. (authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24578?vs=71412&id=71418#toc
Repositor
Author: valentinagiusti
Date: Wed Sep 14 15:12:12 2016
New Revision: 281528
URL: http://llvm.org/viewvc/llvm-project?rev=281528&view=rev
Log:
Use 'enum class' instead of 'enum' in NativeRegisterContextLinux_x86_x64.
Reviewers: labath, clayborg, zturner
Subscribers: lldb-commits
Differential Rev
valentinagiusti marked an inline comment as done.
valentinagiusti added a comment.
Thanks for your review! Please find my answers inline.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:807
@@ -827,2 +806,3 @@
+ if (m_xstate_type == XStateType::I
valentinagiusti updated this revision to Diff 71949.
valentinagiusti added a comment.
Removed unnecessary header, corrected switch-case.
https://reviews.llvm.org/D24764
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
source/Plugins/Process/Linux/NativeRegisterConte
valentinagiusti added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805
@@ -827,2 +804,3 @@
+ if (m_xstate_type == XStateType::Invalid) {
if (const_cast(this)->ReadFPR().Fail())
return false;
labath w
valentinagiusti added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805
@@ -827,2 +804,3 @@
+ if (m_xstate_type == XStateType::Invalid) {
if (const_cast(this)->ReadFPR().Fail())
return false;
valentin
valentinagiusti added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805
@@ -827,2 +804,3 @@
+ if (m_xstate_type == XStateType::Invalid) {
if (const_cast(this)->ReadFPR().Fail())
return false;
valentin
valentinagiusti added a comment.
Thechnically it's not correct that I am introducing this issue, because the old
code already used a cast. It was done in the old and now not existing method
"GetFPRType()", long before I introduced the MPX changes, and then I later
moved it into HasXSave()/HasXS
Author: valentinagiusti
Date: Wed Sep 21 08:33:01 2016
New Revision: 282072
URL: http://llvm.org/viewvc/llvm-project?rev=282072&view=rev
Log:
Refactor NativeRegisterContextLinux_x86_64 code.
This patch refactors the way the XState type is checked and, in order to
simplify the code, it removes the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282072: Refactor NativeRegisterContextLinux_x86_64 code.
(authored by valentinagiusti).
Changed prior to commit:
https://reviews.llvm.org/D24764?vs=71949&id=72036#toc
Repository:
rL LLVM
https://rev
valentinagiusti added a comment.
ok, I will keep it in mind for some further refactoring, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D24764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
40 matches
Mail list logo
