[Lldb-commits] [PATCH] D27161: Fix floating point register reads x86_64 linux on targets with no AVX support

2016-11-28 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti accepted this revision. valentinagiusti added a comment. This revision is now accepted and ready to land. lgtm, thanks! https://reviews.llvm.org/D27161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-24 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti created this revision. Herald added a subscriber: mgorny. The Boundary Table Entries are stored in the application memory and allow to store boundary info for all the pointers of the program, also those that otherwise wouldn't fit in the 4 bound registers provided by the HW. Here

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-25 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti marked 2 inline comments as done. valentinagiusti added a comment. Hi Greg, thanks a lot for your review. I have a question about the API that you proposed, please have a look at the inline comments. Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:143-150 +

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-25 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti marked 3 inline comments as done. valentinagiusti added inline comments. Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:199-218 + if (arch == llvm::Triple::ArchType::x86_64) { +lbound = toU64(bt_entry_v[7], bt_entry_v[6], bt_entry_v[5], bt_entry_v[4], +

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-25 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti updated this revision to Diff 85733. valentinagiusti added a comment. Applied some of the proposed changes. https://reviews.llvm.org/D29078 Files: tools/CMakeLists.txt tools/intel-mpx/CMakeLists.txt tools/intel-mpx/IntelMPXTablePlugin.cpp tools/intel-mpx/test/Makefile

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-26 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti marked 2 inline comments as done. valentinagiusti added inline comments. Comment at: tools/intel-mpx/IntelMPXTablePlugin.cpp:219 +} + +static std::vector uIntToU8(uint64_t input, size_t size) { clayborg wrote: > I'll fix SBData and this should wor

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-26 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti updated this revision to Diff 85906. valentinagiusti marked an inline comment as done. valentinagiusti added a comment. used GetAddress() instead of GetUnsignedIntXX() https://reviews.llvm.org/D29078 Files: tools/CMakeLists.txt tools/intel-mpx/CMakeLists.txt tools/intel-mp

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-01-31 Thread Valentina Giusti via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL293660: Add a command to access and manipulate the Intel(R) MPX Boundary Tables. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D29078?vs=85906&id=86453#toc Repository

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-02-01 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti added a comment. Do you have a better proposal? Repository: rL LLVM https://reviews.llvm.org/D29078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29078: This patch implements a command to access and manipulate the Intel(R) MPX Boundary Tables.

2017-02-01 Thread Valentina Giusti via Phabricator via lldb-commits
valentinagiusti added a comment. I am not sure what you mean, this is a pluggable command and as such it has to be a dynamic loadable lib. As for the wrong install name of the binary, I don't think I can fix it from here, the SOVERSION is set by AddLLVM.cmake. On which platform did you get this