[Lldb-commits] [PATCH] D57907: lldb: Fix compilation on OpenBSD

2019-02-07 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer created this revision. mortimer added a reviewer: krytarowski. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update the OpenBSD Host.cpp for the new SetFile() function signature. Fixes compiling lldb on OpenBSD. Repository: rLLDB LLDB https://reviews.llvm.or

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

2019-02-07 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer created this revision. mortimer added a reviewer: jasonmolenda. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replace 0xc9 (LEAVE) with 0xcb (RETF) in ret_pattern_p(). Also put 0xc3 first, since it is the most common form and will match first. Repository: rLL

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

2019-02-08 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer added a comment. For sure I can add a test. I found this only because I was looking to fix something else (prologue detection on OpenBSD with -fret-protector) and noticed that the return pattern detect function was wrong. So nothing was broken that I found, though the inclusion of 0xc

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

2019-02-09 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer updated this revision to Diff 186144. mortimer added a comment. Added a test to verify that the unwind state is reset after each kind of return. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57928/new/ https://reviews.llvm.org/D57928 Files: lldb/source/Plugins/UnwindAssembly

[Lldb-commits] [PATCH] D57928: Fix x86 return pattern detection

2019-02-10 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer added a comment. Happy to help out. :-) I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57928/new/ https://reviews.llvm.org/D57928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D57907: lldb: Fix compilation on OpenBSD

2019-02-10 Thread Todd Mortimer via Phabricator via lldb-commits
mortimer added a comment. I don't have commit access, so if there is ready to land, could someone commit it? Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57907/new/ https://reviews.llvm.org/D57907 ___ lld