Author: tfiala
Date: Tue Dec 15 19:20:08 2015
New Revision: 255742
URL: http://llvm.org/viewvc/llvm-project?rev=255742&view=rev
Log:
Xcode project changes for r255729.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.or
I had to run out the door so my quick inclusion didn't get a full clean
build in. Looks like I need to adjust my last Xcode change as I'm getting
a linkage issue on OS X. I'll fix that.
-Todd
On Tue, Dec 15, 2015 at 4:28 PM, Siva Chandra via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
Yeah, wrong target membership. Fixing now...
On Tue, Dec 15, 2015 at 6:14 PM, Todd Fiala wrote:
> I had to run out the door so my quick inclusion didn't get a full clean
> build in. Looks like I need to adjust my last Xcode change as I'm getting
> a linkage issue on OS X. I'll fix that.
>
> -
Author: tfiala
Date: Tue Dec 15 20:18:56 2015
New Revision: 255746
URL: http://llvm.org/viewvc/llvm-project?rev=255746&view=rev
Log:
Really fix Xcode build.
Fixes target membership settings from my last check-in.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.
Author: tfiala
Date: Tue Dec 15 20:46:57 2015
New Revision: 255747
URL: http://llvm.org/viewvc/llvm-project?rev=255747&view=rev
Log:
Disable test reruns on arm unless explicitly marked with --rerun-all-issues
Workaround part 2 for:
https://llvm.org/bugs/show_bug.cgi?id=25844
Modified:
lldb/t
tfiala added a reviewer: jingham.
tfiala added a comment.
Hey Jim, this looks right to me. Agree?
-Todd
http://reviews.llvm.org/D15562
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
Author: tfiala
Date: Wed Dec 16 10:09:59 2015
New Revision: 255775
URL: http://llvm.org/viewvc/llvm-project?rev=255775&view=rev
Log:
Remove the "MacOSX and Linux" and "Linux" targets from Xcode.
I added these long ago, but as we work to simplify the Xcode
project, their lack of use has made them
tfiala added a comment.
I think we're good with this then, Pavel.
http://reviews.llvm.org/D15562
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Thu Dec 17 00:55:50 2015
New Revision: 255880
URL: http://llvm.org/viewvc/llvm-project?rev=255880&view=rev
Log:
test infra: force rerun to use parallel runner
We've now seen the rerun test phase hang in a few
scenarios. Eliminate the serial test runner (which
is not exercise
Author: tfiala
Date: Thu Dec 17 13:13:58 2015
New Revision: 255917
URL: http://llvm.org/viewvc/llvm-project?rev=255917&view=rev
Log:
ResultsFormatter: always lock on handle_event()
Some of the newer structures were not protected. Now that we have
a recursive lock, we just lock the whole handle_e
Author: tfiala
Date: Thu Dec 17 16:42:50 2015
New Revision: 255935
URL: http://llvm.org/viewvc/llvm-project?rev=255935&view=rev
Log:
Revert "Disable test reruns on arm unless explicitly marked with
--rerun-all-issues"
and
Revert "prevent rerun logic from kicking in on test runs including aarch64
Author: tfiala
Date: Fri Dec 18 12:40:33 2015
New Revision: 256006
URL: http://llvm.org/viewvc/llvm-project?rev=256006&view=rev
Log:
mark TestGlobalVariables.py as XFAIL on OS X dwarf.
tracking bug:
https://llvm.org/bugs/show_bug.cgi?id=25872
Modified:
lldb/trunk/packages/Python/lldbsuite/t
Author: tfiala
Date: Fri Dec 18 14:44:45 2015
New Revision: 256027
URL: http://llvm.org/viewvc/llvm-project?rev=256027&view=rev
Log:
Xcode build: add a lldb-python-test-suite target.
The llvm.org Green Dragon OS X lldb builder will be using this
target to run the LLDB Python test suite.
Modified
Author: tfiala
Date: Fri Dec 18 16:08:24 2015
New Revision: 256043
URL: http://llvm.org/viewvc/llvm-project?rev=256043&view=rev
Log:
remove xcshareddata exclusion from .gitignore; add desktop and
lldb-python-testsuite shared schemes used by Xcode buildbot
Added:
lldb/trunk/lldb.xcodeproj/xcs
Author: tfiala
Date: Fri Dec 18 17:12:19 2015
New Revision: 256059
URL: http://llvm.org/viewvc/llvm-project?rev=256059&view=rev
Log:
Xcode build: pass in vt100 to the Python test runner.
Some of the Green Dragon tests were failing because they didn't
have a TERM set.
Modified:
lldb/trunk/lld
Author: tfiala
Date: Fri Dec 18 17:22:15 2015
New Revision: 256062
URL: http://llvm.org/viewvc/llvm-project?rev=256062&view=rev
Log:
Xcode: remove --test-subdir test reduction from previous check-in
That was not meant to go in, as it was for testing my last change.
Modified:
lldb/trunk/lldb.
Author: tfiala
Date: Tue Dec 22 11:14:47 2015
New Revision: 256255
URL: http://llvm.org/viewvc/llvm-project?rev=256255&view=rev
Log:
test infra: fix lldbinline tests to work with rerun
Fixes:
https://llvm.org/bugs/show_bug.cgi?id=25922
Added:
lldb/trunk/packages/Python/lldbsuite/test/issue_v
Author: tfiala
Date: Tue Dec 22 11:24:31 2015
New Revision: 256257
URL: http://llvm.org/viewvc/llvm-project?rev=256257&view=rev
Log:
skip TestEvents.py on Darwin
This is generating a SIGSEGV somewhere around 1 in 10 runs on OS X.
Skip the whole test to avoid testbot noise until we can get the
SI
tfiala added a comment.
Sorry, late to the party. All the same, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks good!
http://reviews.llvm.org/D15855
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: tfiala
Date: Wed Jan 6 13:16:45 2016
New Revision: 256961
URL: http://llvm.org/viewvc/llvm-project?rev=256961&view=rev
Log:
fixup lldbinline-style tests to clean up Makefiles and *.d files
The lldbinline inline-test mechanism will create a Makefile
if one does not exist in the test direc
Author: tfiala
Date: Wed Jan 13 17:55:16 2016
New Revision: 257717
URL: http://llvm.org/viewvc/llvm-project?rev=257717&view=rev
Log:
change Xcode test run default to ignore xpass on Xunit output
The Green Dragon LLVM builders are starting to parse xunit output
on LLDB Xcode builders. By default
tfiala added a subscriber: tfiala.
tfiala added a comment.
> Setting the dependencies as private required a fixup of the argdumper link
> command, as it was not
actually linking to liblldb (it was referring to symbols from the lldb_private
namespace, which
are not exposed in liblldb),
At some
tfiala added a comment.
Oops, this one slipped past me. Looking now!
http://reviews.llvm.org/D16322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks reasonable.
I added one question on whether we can get a warning on failure to retrieve the
server.log file when expecting one and it doesn't show up (perhaps only in
verbose mode), whi
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D15318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Is this ready to close out?
http://reviews.llvm.org/D15162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D14885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D14896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Ready to close out?
http://reviews.llvm.org/D14937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D15209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+# This is executed on a best-effort basis. If the file is not
there, so be it.
+lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+
tfiala created this revision.
tfiala added a reviewer: labath.
tfiala added a subscriber: lldb-commits.
As would happen if the test suite was given "--platform-name iso-simulator".
Also removes the expected timeouts for Darwin as these are now handled by
reruns.
http://reviews.llvm.org/D16423
tfiala added a subscriber: emaste.
tfiala added a comment.
Hi Ed - not sure if freebsd still needs the set of expected timeout tests. If
you were to run with --rerun-all-issues, then all tests are eligible for a
rerun on the first failure/timeout/error/whatever. (expected failure- and the
exp
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:1145
@@ -1144,1 +1144,3 @@
+else:
+target = None
labath wrote:
> I think this should be `target = platform_name`, so that you can still match
> the ios-simulat
Author: tfiala
Date: Fri Jan 22 14:20:48 2016
New Revision: 258542
URL: http://llvm.org/viewvc/llvm-project?rev=258542&view=rev
Log:
fixed test suite crash when --platform-name doesn't start with 'remote-'
Also removes Darwin test case files from the expectedTimeout hard-coded
file list.
See:
ht
tfiala closed this revision.
tfiala added a comment.
Closed by svn commit r258542.
http://reviews.llvm.org/D16423
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Fri Jan 22 15:58:55 2016
New Revision: 258565
URL: http://llvm.org/viewvc/llvm-project?rev=258565&view=rev
Log:
added test fixture to EditlineTest gtest
Primarily a trial test for me to try out the
git clang-format integration. Works like a charm!
This change adds a gtest f
Author: tfiala
Date: Fri Jan 22 17:50:57 2016
New Revision: 258585
URL: http://llvm.org/viewvc/llvm-project?rev=258585&view=rev
Log:
candidate fix for Green Dragon lldb testbot
The python test run target started failing recently.
I tracked it down to what looks like the passing of
environment var
Author: tfiala
Date: Fri Jan 22 20:24:41 2016
New Revision: 258601
URL: http://llvm.org/viewvc/llvm-project?rev=258601&view=rev
Log:
fixed TestConsecutiveBreakpoints test on OS X
Also renamed directory and class name to fix typos.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionali
Author: tfiala
Date: Fri Jan 22 20:34:16 2016
New Revision: 258602
URL: http://llvm.org/viewvc/llvm-project?rev=258602&view=rev
Log:
Skipped IncompleteModulesTestCase on OS X
This is hitting an assert in clang when evaluating the
module load. I am seeing it locally on Xcode 7.3 public Beta 1
and
tfiala added a comment.
In http://reviews.llvm.org/D16508#334424, @krytarowski wrote:
> I had difficulties with this code, as each platform implements it differently.
This class is one of the parts of the infrastructure needed to access registers
for a given platform. These show up on the LLD
tfiala added a comment.
The important part is that you look to see what NetBSD exposes register-wise
for a given process. Even though the architecture is the same across several
different versions of this class, it is possible for an OS to tweak the way the
CPU starts up and therefore influenc
tfiala added a comment.
If all else fails when trying to look up the NetBSD expectations about register
access, you can start with the ptrace interface (man ptrace). It should have
some way for you to ask for some kind of register-file-offset-based value and a
width to retrieve content from th
tfiala added a comment.
In http://reviews.llvm.org/D16508#334452, @krytarowski wrote:
> @tfiala thank you for your verbose and quick feedback. It made the things
> more clear!
My pleasure!
> While I'm processing your reply -- a question, does it matter whether we
> define GPR as signed or un
On Tue, Jan 26, 2016 at 5:43 PM, Zachary Turner wrote:
> zturner updated this revision to Diff 46086.
> zturner added a comment.
>
> Add back the check for `six.callable`. Also added a detailed comment
> explaining what this atrocity actually does.
>
Yeah - I was thinking that actually caught s
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D16615#337359, @zturner wrote:
> If the goal is to delete all the highly specialized decorators (after all,
> expectedFailureWindows is just expectedFailureAll(oslis
Author: tfiala
Date: Thu Jan 28 01:36:44 2016
New Revision: 259027
URL: http://llvm.org/viewvc/llvm-project?rev=259027&view=rev
Log:
modify Xcode build to use cmake/ninja for internal llvm/clang
This change restores the Xcode build to working after Makefile support
was stripped from LLVM and clan
Author: tfiala
Date: Thu Jan 28 02:16:18 2016
New Revision: 259028
URL: http://llvm.org/viewvc/llvm-project?rev=259028&view=rev
Log:
fixed Xcode gtest build failure
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/v
tfiala added a comment.
I can give this a try later today.
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Hey Tamas,
I haven't tried it yet, but I won't be into the office until later. Why don't
you go ahead and submit it, and if it blows up the OS X testbot, you'll get an
email and you (or whoe
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Seems reasonable to me.
http://reviews.llvm.org/D16678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
tfiala added a comment.
> What's the correct approach to address it? Mirror modified
> RegisterInfos_x86_64.h in RegisterContextNetBSD_x86_64.cpp and
> removed/altered static_assert?
I think that's worth trying. That will let you have a contiguous, consistent
register set.
Repository:
rL
tfiala added a comment.
That seems very reasonable.
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Sounds great, Zachary. Thanks!
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Glad to hear it!
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Thu Jan 28 16:34:36 2016
New Revision: 259102
URL: http://llvm.org/viewvc/llvm-project?rev=259102&view=rev
Log:
add back an Xcode-specific Makefile for header installation
Added:
lldb/trunk/tools/install-headers/Makefile
Added: lldb/trunk/tools/install-headers/Makefile
U
Author: tfiala
Date: Thu Jan 28 17:17:53 2016
New Revision: 259114
URL: http://llvm.org/viewvc/llvm-project?rev=259114&view=rev
Log:
fix up missing header from change r259084.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
Modified: lldb/trunk/source/Plugins/Ex
Author: tfiala
Date: Fri Jan 29 12:13:30 2016
New Revision: 259216
URL: http://llvm.org/viewvc/llvm-project?rev=259216&view=rev
Log:
Revert "fix up missing header from change r259084."
This change was made based on a bad signal from the
Green Dragon LLDB builder. This change was not needed.
Reve
tfiala added a comment.
I'll give it a run!
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Running the test suite now. So far so good (it didn't blow up immediately like
it has for other attempts). I'll post back when the test run completes.
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
The only test I see fail with this is:
TestGDBRemoteMemoryRead.py:
ERROR: test_memory_read_dwarf (TestGDBRemoteMemoryRead.MemoryReadTestCase)
--
Traceback (most recent call last):
File
"/Users/
tfiala added a comment.
In http://reviews.llvm.org/D16736#339889, @zturner wrote:
> Hmm, that almost looks to me like it's finding a real bug. Which it
> probably is, because higher up the callstack it's reading the response of a
> memory send. I'm guessing that the response includes non-prin
tfiala added a comment.
In http://reviews.llvm.org/D16736#339925, @tfiala wrote:
> In http://reviews.llvm.org/D16736#339889, @zturner wrote:
>
> > Hmm, that almost looks to me like it's finding a real bug. Which it
> > probably is, because higher up the callstack it's reading the response of a
tfiala added a comment.
> I'm going to have a look at trying this modification now.
I'm getting the same error with the replace.
Here is the patch (okay the whole encoded_file.py) I was able to use to get
past this - which ultimately looks to be an error in the match result printing
of a raw
tfiala added a comment.
In http://reviews.llvm.org/D16736#340302, @tfiala wrote:
> In any event, the right fix here probably is to have displays of
> matched/expected text for known-to-be binary data *not* try to print results
> in the expect-string-match code since these are just going to have
tfiala added a comment.
In fact I'd say you could do this, now that I've looked at the test:
diff --git
a/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py
b/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py
index 7b974e5..9f80abe 100644
Just that x command needs to be commented out. The m command is fine as is.
-Todd
> On Feb 1, 2016, at 5:03 AM, Pavel Labath wrote:
>
> labath added a comment.
>
> TestGDBRemoteMemoryRead.py is my test and I gotta admit it is somewhat
> hackish. If this is the only issue that is stopping this
tfiala added a subscriber: tfiala.
tfiala added a comment.
Just that x command needs to be commented out. The m command is fine as is.
-Todd
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
tfiala accepted this revision.
tfiala added a comment.
Seems reasonable to start. If there are issues, they'll show up when lldb
starts using registers. This will get you started, though.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
tfiala added a subscriber: tfiala.
tfiala added a comment.
I'll see if I can run this tonight. If not tonight, I'll do it first
thing in the morning.
http://reviews.llvm.org/D16741
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
I'll see if I can run this tonight. If not tonight, I'll do it first
thing in the morning.
On Mon, Feb 1, 2016 at 5:17 PM, Zachary Turner wrote:
> zturner updated this revision to Diff 46599.
> zturner added a comment.
> Herald added subscribers: srhines, danalbert, tberghammer.
>
> I think th
tfiala added a comment.
> We've already had a case when a test wasn't running for several months
before I noticed (see r257901) that it had a bad decorator applied at the
class level.
I've been thinking about this in the background lately. Several times over
the last couple years I found decor
> We've already had a case when a test wasn't running for several months
before I noticed (see r257901) that it had a bad decorator applied at the
class level.
I've been thinking about this in the background lately. Several times over
the last couple years I found decorator logic that had errors
tfiala added a subscriber: tfiala.
tfiala added a comment.
This change looks like it introduced a test failure on OS X:
http://lab.llvm.org:8080/green/job/lldb_build_test/16215/
Per another email on lldb-dev, the error emails were not getting generated
because, while the test failure was logged
tfiala added a comment.
In http://reviews.llvm.org/D16736#341705, @tfiala wrote:
> This change appears to have caused a test error (rather than a test failure)
> on the OS X builder.
It's not clear to me yet why I didn't see this at home, but my first guess is
that I have all my consoles set
tfiala added a comment.
This change appears to have caused a test error (rather than a test failure) on
the OS X builder. See here (master builder step):
http://lab.llvm.org:8080/green/job/LLDB/16318/
and here (build and test run step):
http://lab.llvm.org:8080/green/job/lldb_build_test/16209/
Author: tfiala
Date: Tue Feb 2 11:00:34 2016
New Revision: 259526
URL: http://llvm.org/viewvc/llvm-project?rev=259526&view=rev
Log:
skip TestWatchLocation on OS X
Skipping this test while I investigate. It started failing
with r259379. (It is generating an error due to unicode
decode issues.)
tfiala added a comment.
Skipped TestWatchLocation.py test method on OS X with r259526 while I
investigate.
Repository:
rL LLVM
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
tfiala added a subscriber: tfiala.
tfiala added a comment.
This needs to be reverted. We've got 92 tests failing when this hit:
http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
Repository:
rL LLVM
http://reviews.llvm.org/D16769
___
lld
tfiala added a comment.
In http://reviews.llvm.org/D16769#342069, @tfiala wrote:
> This needs to be reverted. We've got 92 tests failing when this hit:
>
> http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
I'm in the process of testing the issues go away with the revert. I'll commit
Author: tfiala
Date: Tue Feb 2 14:26:50 2016
New Revision: 259556
URL: http://llvm.org/viewvc/llvm-project?rev=259556&view=rev
Log:
Revert "[NFC] Cleanup RangeMap.h"
This reverts commit r259538. Caused 92 test failures on
the OS X testbot.
Modified:
lldb/trunk/include/lldb/Core/RangeMap.h
tfiala added a comment.
In http://reviews.llvm.org/D16769#342073, @tfiala wrote:
> In http://reviews.llvm.org/D16769#342069, @tfiala wrote:
>
> > This needs to be reverted. We've got 92 tests failing when this hit:
> >
> > http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
>
>
> I'm in th
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM.
BTW I was planning on re-organizing the lldb-server/debugserver tests sometime
in the near future to break them into many different directories and pull off
the dsym/dwarf/dwo changes f
tfiala added a comment.
I'm going to try this out now
http://reviews.llvm.org/D16900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This tested cleanly, no failures on OS X. Lgtm.
-Todd
> On Feb 4, 2016, at 2:15 PM, Todd Fiala wrote:
>
> tfiala added a comment.
>
> I'm going to try this out now
>
>
> http://reviews.llvm.org/D16900
>
>
>
___
lldb-commits mailing list
lldb-com
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D16900#344702, @sivachandra wrote:
> Thanks a lot Todd. I will put this in tomorrow morning just to be on the
> safer side.
My pleasure, Siva!
http://reviews.llv
tfiala added a comment.
In http://reviews.llvm.org/D16858#343895, @labath wrote:
> In http://reviews.llvm.org/D16858#343140, @tfiala wrote:
>
> > BTW I was planning on re-organizing the lldb-server/debugserver tests
> > sometime in the near future to break them into many different directories
>
:-) Okay. I'll attack that problem when I get ambitious and need a break
from something else.
On Fri, Feb 5, 2016 at 1:53 AM, Pavel Labath wrote:
> On 5 February 2016 at 03:13, Todd Fiala wrote:
> > True.
> >
> > Maybe I'll wait until then.
>
> Just don't hold your breath for too long. What I
tfiala added a comment.
I'll go ahead and run this before and after and compare totals.
http://reviews.llvm.org/D16936
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I'll have a look at this after I get through http://reviews.llvm.org/D16936.
Concept sounds great.
http://reviews.llvm.org/D16938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
tfiala added a comment.
I'm seeing 8 errors after applying this diff:
ERROR: test_expr_stripped_dwarf (lang/objc/hidden-ivars/TestHiddenIvars.py)
ERROR: test_frame_variable_stripped_dwarf
(lang/objc/hidden-ivars/TestHiddenIvars.py)
ERROR: test_with_python_api_dsym
(lang/cpp/class_static/T
tfiala added a comment.
Here's one:
Traceback (most recent call last):
File
"/Users/tfiala/src/lldb-tot/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 1442, in dsym_test_method
return attrvalue(self)
File
"/Users/tfiala/src/lldb-tot/lldb/packages/Python/lldbsuite/test/d
tfiala added a comment.
Yep, I'll give that a shot now.
http://reviews.llvm.org/D16936
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM with the change you suggested above. I tried that and it worked on OS X.
The change itself looked fine as well.
Comment at: packages/Python/lldbsuite/test/decorators.p
tfiala added a comment.
> I agree but I also might consider going further where the only thing you can
> specify is a function and we remove all arguments. Then we implement
> functions like architectureMatches, targetOsMatches, hostOsMatches, etc.. and
> some logical function what can combine
tfiala accepted this revision.
tfiala added a comment.
LGTM.
Regarding the section Pavel was looking at, on the Apple side we have a
simulator target that is not technically remote, but isn't really local either.
I'll have to look at that if/when we actually want to mark a simulator test as
f
tfiala accepted this revision.
tfiala added a comment.
LGTM. Having the single list to cover host and target is a good way to go
here, too.
http://reviews.llvm.org/D17088
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
tfiala added a reviewer: spyffe.
tfiala added a comment.
+Sean
Sean, I'm okay with this for now. You know my changes coming down the pipe,
and I can add a configuration setting for the git side that lets us optionally
add in the history truncation. Thoughts?
http://reviews.llvm.org/D17425
tfiala added a comment.
(Stephane, I've got a change in the works that is currently backed up behind
some other things, but it allows better mapping of Xcode lldb configuration to
llvm/clang configuration, and includes specifying if svn or git should be used.
It will actually default to svn.
601 - 700 of 963 matches
Mail list logo
