ond test.
>
>
> On Thu, Oct 29, 2015 at 11:26 PM, Zachary Turner
> wrote:
>
>>
>>
>> On Thu, Oct 29, 2015 at 7:57 PM Todd Fiala via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: tfiala
>>> Date: Thu Oct 29 21:5
uot;reduce duplication" XP style phase that will eliminate that. Good
>>> catch. I should have done it at my second test.
>>>
>>>
>>> On Thu, Oct 29, 2015 at 11:26 PM, Zachary Turner
>>> wrote:
>>>
>>>>
>>>>
Author: tfiala
Date: Mon Nov 2 15:05:28 2015
New Revision: 251831
URL: http://llvm.org/viewvc/llvm-project?rev=251831&view=rev
Log:
First pass on www docs: Adding Programming Language Support to LLDB
We'll hook this up to the main page after Greg, Sean and others
iterate on it to a useful point.
On Mon, Nov 2, 2015 at 10:12 PM, Zachary Turner wrote:
> On Mon, Nov 2, 2015 at 10:02 PM Todd Fiala wrote:
>
>> Do you have a script you used to tweak these?
>>
>> (We have a ton of stuff broken internally on this that I need to fix up).
>>
>> We're starting to need to do quite a bit of extra ty
No, we won't need/want to revert. I just wanted to see if you already had
a snazzy script I could whiz through a directory tree with.
-Todd
On Mon, Nov 2, 2015 at 10:26 PM, Zachary Turner wrote:
> Also, one last thing. The reason this is probably wreaking havoc on your
> stuff internally is b
:-)
On Mon, Nov 2, 2015 at 10:30 PM, Zachary Turner wrote:
>
>
> On Mon, Nov 2, 2015 at 10:27 PM Todd Fiala wrote:
>
>> On Mon, Nov 2, 2015 at 10:12 PM, Zachary Turner
>> wrote:
>>
>>>
>>> Luckily the extra typing only comes at the import site. If you use the
>>> syntax I suggested in #2 and
Author: tfiala
Date: Wed Nov 4 11:10:40 2015
New Revision: 252058
URL: http://llvm.org/viewvc/llvm-project?rev=252058&view=rev
Log:
Fix test infrastructure when using xunit output.
Our test reporting infrastructure needed module names to change based on the
python package layout.
Modified:
tfiala added a comment.
I'll have a look. How do I test it, @artagnon?
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I think this went in, right?
http://reviews.llvm.org/D14162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I think this got checked in, right?
http://reviews.llvm.org/D14157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Nov 4 12:10:31 2015
New Revision: 252059
URL: http://llvm.org/viewvc/llvm-project?rev=252059&view=rev
Log:
OS X: fix the Xcode debugserver lookup code when LLDB.framework does not
contain a debugserver
LLDB recently started supporting LLDB.framework without a
debugserve
tfiala added a comment.
Does this mean that if we import third party modules, and since you have
embedded them into our package, that we would have to change third party code
to adhere to our packaging structure? If not, fine. If so, this was one of
the areas I mentioned that I was concerned
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Okay, looks good then. Thanks, Zachary!
http://reviews.llvm.org/D14342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks reasonable. Do we know if it runs anywhere else yet?
http://reviews.llvm.org/D14395
___
lldb-commits mailing list
lldb-commits@lists.llvm.
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM. We just weren't using the reversed_cmp() code it seems?
http://reviews.llvm.org/D14453
___
lldb-commits mailing list
lldb-commits@lists.ll
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Okay, this seems reasonable.
http://reviews.llvm.org/D13819
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
tfiala added a comment.
I meant I looked at it but didn't try to run it (on Linux or OS X), and was
wondering if you had tried to run it on a non-Windows platform.
http://reviews.llvm.org/D14395
___
lldb-commits mailing list
lldb-commits@lists.llvm
tfiala created this revision.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
This shortcut is equivalent to specifying:
--results-formatter lldbsuite.test.curses_results.Curses
--results-file stdout (or --results-file /dev/stdout on some systems)
The change adds t
Author: tfiala
Date: Sun Nov 8 18:23:01 2015
New Revision: 252438
URL: http://llvm.org/viewvc/llvm-project?rev=252438&view=rev
Log:
Fix up curses_results.py for new package specification requirement.
This was breaking but probably missed since it is currently
infrequently used.
Modified:
ll
Author: tfiala
Date: Sun Nov 8 19:24:36 2015
New Revision: 252441
URL: http://llvm.org/viewvc/llvm-project?rev=252441&view=rev
Log:
Added myself to the CODE_OWNERS.txt list for a few subsystems.
I'm primarily testing my git-svn setup.
Modified:
lldb/trunk/CODE_OWNERS.txt
Modified: lldb/tru
Author: tfiala
Date: Mon Nov 9 12:51:04 2015
New Revision: 252498
URL: http://llvm.org/viewvc/llvm-project?rev=252498&view=rev
Log:
Add --curses shortcut for specifying the curses-based test results formatter.
This commit closes the following review:
http://reviews.llvm.org/D14488
Modified:
tfiala closed this revision.
tfiala added a comment.
Closed by commit:
Committed r252498
M packages/Python/lldbsuite/test/dosep.py
M packages/Python/lldbsuite/test/dotest_args.py
M packages/Python/lldbsuite/test/dotest.py
http://reviews.llvm.org/D1448
The reason you probably want this unbuffered is for cases where you crash.
When a dotest.py process crashes, the buffered content won't necessarily
get flushed. So the session file may or may not contain the last thing
that happened in that case.
I think we want it unbuffered where we can.
-Todd
Sounds good.
Not super critical, but I'd definitely rather it stay unbuffered where
possible.
On Mon, Nov 9, 2015 at 1:10 PM, Zachary Turner wrote:
> Hmm, ok. I'll loop back around to this when I get some cycles. Still
> working on Python 3 stuff so I don't think this will fall off my radar
>
Author: tfiala
Date: Tue Nov 10 14:01:33 2015
New Revision: 252642
URL: http://llvm.org/viewvc/llvm-project?rev=252642&view=rev
Log:
Updated lldb_pylint_helper to work with recent Python package changes.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldb_pylint_helper.py
Modified: lldb
Yeah, we can get some gtests in for this. I'll tail back on it. It'll be
a bit before I can put cycles on it but it's on my list.
On Mon, Nov 9, 2015 at 9:46 PM, Zachary Turner wrote:
> This is really the kind of thing that would be good to write a unit test
> for. There's a lot of institutio
tfiala resigned from this revision.
tfiala removed a reviewer: tfiala.
tfiala added a comment.
Zachary, I am going to defer to Enrico on this. He has better context.
http://reviews.llvm.org/D14524
___
lldb-commits mailing list
lldb-commits@lists.ll
tfiala added a subscriber: tfiala.
tfiala added a comment.
(Which I guess means Greg, seeing Enrico's comment earlier!)
http://reviews.llvm.org/D14524
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tfiala added a comment.
Okay Greg's not had a chance to look at this. I just had a look at it. I'm
okay with it, Zachary. Feel free to check it in.
http://reviews.llvm.org/D14524
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
Author: tfiala
Date: Tue Nov 10 21:43:05 2015
New Revision: 252699
URL: http://llvm.org/viewvc/llvm-project?rev=252699&view=rev
Log:
Mark TestTerminal.py as XFAIL on OS X.
See the following tracking bug:
https://llvm.org/bugs/show_bug.cgi?id=25484
Modified:
lldb/trunk/packages/Python/lldbsu
Author: tfiala
Date: Tue Nov 10 23:01:30 2015
New Revision: 252702
URL: http://llvm.org/viewvc/llvm-project?rev=252702&view=rev
Log:
Mark TestCompletion.py test_symbol_name_dwarf XFAIL on Darwin.
This test fails most of the time when run under heavy load. The dsym
variant doesn't seem to be fail
Author: tfiala
Date: Tue Nov 10 23:10:07 2015
New Revision: 252703
URL: http://llvm.org/viewvc/llvm-project?rev=252703&view=rev
Log:
Bump up test timeout interval on Darwin from 4 to 6 minutes.
We have several tests that TIMEOUT under heavy load but just need a bit
more time to complete.
Modifie
Author: tfiala
Date: Wed Nov 11 00:32:44 2015
New Revision: 252707
URL: http://llvm.org/viewvc/llvm-project?rev=252707&view=rev
Log:
Marked test_qRegisterInfo_returns_{one_valid_result,all_valid_results} XFAIL on
Darwin.
Tracked by:
https://llvm.org/bugs/show_bug.cgi?id=25486
Modified:
lld
Author: tfiala
Date: Tue Nov 17 01:17:38 2015
New Revision: 253317
URL: http://llvm.org/viewvc/llvm-project?rev=253317&view=rev
Log:
Add Pythonic language binding wrapper generation script.
This is only used by Xcode at the moment. It replaces the
buildSwigWrapperClasses.py and related per-scrip
tfiala accepted this revision.
tfiala added a comment.
Yep, looks good.
http://reviews.llvm.org/D14726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14718
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Author: tfiala
Date: Tue Nov 17 01:56:42 2015
New Revision: 253319
URL: http://llvm.org/viewvc/llvm-project?rev=253319&view=rev
Log:
Revert out Xcode hookup of r253317.
The green dragon OS X builder doesn't have swig on the path.
I need to enable behavior where we can look for it
in some well kno
the swig executable not be
> part of this script? Seems like running swig should be a build step, and
> running these scripts on the output of swig should be a step that follows
>
> On Mon, Nov 16, 2015 at 11:20 PM Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wr
the output of swig should be a step that follows
>>
>> On Mon, Nov 16, 2015 at 11:20 PM Todd Fiala via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: tfiala
>>> Date: Tue Nov 17 01:17:38 2015
>>> New Revision: 25
Author: tfiala
Date: Tue Nov 17 11:13:06 2015
New Revision: 253346
URL: http://llvm.org/viewvc/llvm-project?rev=253346&view=rev
Log:
Added --find-swig option to allow searching for swig in path or other likely
locations.
Modified:
lldb/trunk/scripts/prepare_bindings.py
Modified: lldb/trunk/
Author: tfiala
Date: Tue Nov 17 11:13:09 2015
New Revision: 253347
URL: http://llvm.org/viewvc/llvm-project?rev=253347&view=rev
Log:
Reinstate Xcode project usage of prepare_bindings.py, with new --find-swig
option set.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trun
Author: tfiala
Date: Tue Nov 17 12:10:54 2015
New Revision: 253353
URL: http://llvm.org/viewvc/llvm-project?rev=253353&view=rev
Log:
Remove --swig-executable `which swig` from Xcode prepare_bindings.py call.
This is no longer needed with --find-swig, and although innocuous on systems
with
swig i
Nothing concrete at the moment; however, it could be interesting to look at
the clang community and see what could be done for llvm-based language
implementations. The angle that I think would be interesting would be if
we can generate bindings more effectively based on the in-depth
understanding
> that comes out of python
that comes out of swig, rather (i.e. the binding generation output).
On Tue, Nov 17, 2015 at 8:03 PM, Todd Fiala wrote:
> Nothing concrete at the moment; however, it could be interesting to look
> at the clang community and see what could be done for llvm-based langua
Author: tfiala
Date: Wed Nov 18 02:52:33 2015
New Revision: 253448
URL: http://llvm.org/viewvc/llvm-project?rev=253448&view=rev
Log:
prepare_bindings.py: enable static bindings
Added a new flag, --allow-static-binding. When specified,
if (and only if) the swig binary cannot be found, then the
LL
Usage of static bindings for the prepare_bindings.py script went in here:
r253448.
Only Xcode provides the flag to use it. The commit description indicates
how it works in this incarnation. Essentially it only uses the static
Python binding if and only if a swig isn't specified or cannot be foun
Author: tfiala
Date: Wed Nov 18 11:36:15 2015
New Revision: 253478
URL: http://llvm.org/viewvc/llvm-project?rev=253478&view=rev
Log:
Switched cmake build from using buildSwigWrapperClases.py to the cleaned up
version.
This change does not introduce static bindings. It is simply using
the pylint
Checking in the static bindings is no different than projects checking in
autoconf config baked scripts so that the vast majority of people don't
need to run autoconf just to get a setup that rarely changes. There is
precedent for this going back a long way on open source projects.
I'm backing of
> On OS X, it is a pain to get unless you install homebrew/macports/fink.
On Linux, you'll need to do an apt-get or yum install.
And I should add that installing home-brew (the most common way of picking
up extra goodies, as I know I do it on home machines) is also one of the
most common ways to p
s in the
> past few days to embed the swig version in the generated lldb.py? Maybe
> you did, I just want to make sure that change is in your new version.
>
> On Wed, Nov 18, 2015 at 9:38 AM Todd Fiala via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Autho
the generated lldb.py?
>> Maybe you did, I just want to make sure that change is in your new version.
>>
>> On Wed, Nov 18, 2015 at 9:38 AM Todd Fiala via lldb-commits <
>> lldb-commits@lists.llvm.org> wrote:
>>
>>> Author: tfiala
>>> Date: We
t; on Friday/Sunday).
>>
>> On Wed, Nov 18, 2015 at 9:47 AM, Zachary Turner
>> wrote:
>>
>>> Just to be sure, did you catch the change I made to the old scripts in
>>> the past few days to embed the swig version in the generated lldb.py?
>>> Maybe y
t;>> wrote:
>>>
>>>> Double checking now, if it happens in that lldb-modify script, we're
>>>> covered. Otherwise I need to adjust... (the bulk of the rewrite happened
>>>> on Friday/Sunday).
>>>>
>>>> On Wed, Nov 18,
; wrote:
>>>>
>>>>> Double checking now, if it happens in that lldb-modify script, we're
>>>>> covered. Otherwise I need to adjust... (the bulk of the rewrite happened
>>>>> on Friday/Sunday).
>>>>>
>>>&
On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner wrote:
>
>
> On Wed, Nov 18, 2015 at 10:00 AM Todd Fiala wrote:
>
>> Checking in the static bindings is no different than projects checking in
>> autoconf config baked scripts so that the vast majority of people don't
>> need to run autoconf just
Author: tfiala
Date: Wed Nov 18 13:34:03 2015
New Revision: 253490
URL: http://llvm.org/viewvc/llvm-project?rev=253490&view=rev
Log:
remove defunct scripts/build-swig-wrapper-classes.sh; switch autoconf build to
prepare_bindings.py.
Xcode moved off of build-swig-wrapper-classes.sh earlier this w
Author: tfiala
Date: Wed Nov 18 13:37:51 2015
New Revision: 253491
URL: http://llvm.org/viewvc/llvm-project?rev=253491&view=rev
Log:
Remove the scripts/Python/build-swig-Python.sh script.
This logically goes with my previous commit.
Removed:
lldb/trunk/scripts/Python/build-swig-Python.sh
Re
/llvm-project/lldb/trunk@253262
>>>>> 91177308-0d34-0410-b5e6-96231b3b80d8
>>>>>
>>>>>
>>>>> On Wed, Nov 18, 2015 at 10:07 AM, Todd Fiala
>>>>> wrote:
>>>>>
>>>>>> Double checking now, if it ha
>>> git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@253262
>>>>>> 91177308-0d34-0410-b5e6-96231b3b80d8
>>>>>>
>>>>>>
>>>>>> On Wed, Nov 18, 2015 at 10:07 AM, Todd Fiala
>>>>>> wrote:
>>
tfiala created this revision.
tfiala added a reviewer: zturner.
tfiala added a subscriber: lldb-commits.
These classes have been cleaned up in scripts/prepare_bindings.py and
scripts/Python/prepare_binding_Python.py.
Both Xcode and cmake builds have been converted over.
Waiting to make sure thi
10-b5e6-96231b3b80d8
>>>>
>>>>
>>>> On Wed, Nov 18, 2015 at 10:07 AM, Todd Fiala
>>>> wrote:
>>>>
>>>>> Double checking now, if it happens in that lldb-modify script, we're
>>>>> cove
s to allow us to add skip / xfail decorators
>>>>> based on SWIG version.
>>>>>
>>>>> git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@253262
>>>>> 91177308-0d34-0410-b5e6-96231b3b80d8
>>>>>
>>>>
On Wed, Nov 18, 2015 at 12:45 PM, Zachary Turner wrote:
>
>
> On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote:
>
>> On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner
>> wrote:
>>
>>> Because even if it isn't perfect for everyone, it works for everyone.
>>>
>>
>> Unless you can't get swig on
On Wed, Nov 18, 2015 at 12:53 PM, Todd Fiala wrote:
>
>
> On Wed, Nov 18, 2015 at 12:45 PM, Zachary Turner
> wrote:
>
>>
>>
>> On Wed, Nov 18, 2015 at 11:15 AM Todd Fiala wrote:
>>
>>> On Wed, Nov 18, 2015 at 10:34 AM, Zachary Turner
>>> wrote:
>>>
Because even if it isn't perfect for e
On Wed, Nov 18, 2015 at 12:51 PM, Zachary Turner wrote:
> (This is originally from a thread on lldb-commits, but it seems more
> appropriate here, so I'm responding here.
>
> On Wed, Nov 18, 2015 at 12:47 PM Todd Fiala wrote:
>
>> BTW if you cook up something on the swig-as-a-service end that en
I don't *think* that's right? (At least, not for Linux).
It's not coming from the source dir. It gets generated into the binary
directory. Or - maybe the Windows ones write the output into the source
tree? Do we need to conditionalize the location of lldb.py based on the
build?
-Todd
On Wed,
(good catch :-) )
On Wed, Nov 18, 2015 at 1:20 PM, Todd Fiala wrote:
> Nope, I'm wrong. Sorry!
>
> On Wed, Nov 18, 2015 at 1:15 PM, Todd Fiala wrote:
>
>> I don't *think* that's right? (At least, not for Linux).
>>
>> It's not coming from the source dir. It gets generated into the binary
>>
Nope, I'm wrong. Sorry!
On Wed, Nov 18, 2015 at 1:15 PM, Todd Fiala wrote:
> I don't *think* that's right? (At least, not for Linux).
>
> It's not coming from the source dir. It gets generated into the binary
> directory. Or - maybe the Windows ones write the output into the source
> tree?
t it now...)
>>>>>>>
>>>>>>> commit cc353bbc992ab324aef395c54a2a46fcaaa3855b
>>>>>>> Author: Zachary Turner
>>>>>>> Date: Mon Nov 16 22:40:20 2015 +
>>>>>>>
>>>>>>&
tfiala added a comment.
We can close this one out too, right?
http://reviews.llvm.org/D14718
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Is this one ready to close out?
http://reviews.llvm.org/D14726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Looks like with your change in r253501, we are okay to delete these?
http://reviews.llvm.org/D14783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Okay, thanks. I'll grep the source base first to make sure I'm not missing
anything else.
http://reviews.llvm.org/D14783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tfiala updated this revision to Diff 40560.
tfiala added a comment.
Missed one reference in a cmake custom command dependency. Fixed in latest
diff.
http://reviews.llvm.org/D14783
Files:
scripts/CMakeLists.txt
scripts/Python/buildSwigPython.py
scripts/buildSwigWrapperClasses.py
Index:
tfiala added a comment.
Aside from that one fix in the second patch, a grep for those two scripts came
back clean on the source tree.
http://reviews.llvm.org/D14783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: tfiala
Date: Wed Nov 18 16:21:47 2015
New Revision: 253513
URL: http://llvm.org/viewvc/llvm-project?rev=253513&view=rev
Log:
Remove superseded buildSwigWrapperClasses.py and buildSwigPython.py classes
This closes:
http://reviews.llvm.org/D14783
Removed:
lldb/trunk/scripts/Python/buil
tfiala closed this revision.
tfiala added a comment.
Committed here:
r253513.
http://reviews.llvm.org/D14783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala created this revision.
tfiala added reviewers: labath, zturner, spyffe.
tfiala added a subscriber: lldb-commits.
This change does the following:
* Adds a cached LLDB_ALLOW_STATIC_BINDINGS variable, defaults to off/false
* If specified, flips on the --allow-static-binding flag to prepare_bin
tfiala added a comment.
BTW I've tested this with the static bindings we use on OS X on Ubuntu 14.04
with a clang 3.6 build.
http://reviews.llvm.org/D14790
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
tfiala added a comment.
In http://reviews.llvm.org/D14790#292220, @zturner wrote:
> If nobody on the Apple side is using CMake, then I'm still not clear why we
> need this. Everyone using CMake already will continue to work fine using
> dynamically generated bindings, right?
I'm at Apple. I
tfiala added a comment.
(And I also work on cmake-based OS X lldb when there are issues that break
there).
http://reviews.llvm.org/D14790
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
tfiala added a comment.
Keep in mind this is an opt-in flag. No developers get the behavior unless
they specifically ask for it.
I'm adding it because I specifically need it.
http://reviews.llvm.org/D14790
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
In http://reviews.llvm.org/D14790#292226, @zturner wrote:
> So you can't install swig on your Linux machines either?
>
> I really can't wrap my head around why we need this. What is the problem
> with installing swig, given that we need to install other software already?
tfiala added a comment.
In http://reviews.llvm.org/D14790#292255, @zturner wrote:
>
> What is worth arguing about, however, is that changes need to have some kind
> of reasonable justification.
I strongly disagree with this statement from a procedural point of view. It is
just an invalid
tfiala added a comment.
> For now please leave an option that end user to disable Python. Otherwise
> erasing it will be done downstream without benefit for the project.
Nobody is talking about removing the option to disable python.
The static binding binding option is ignored (i.e. irrelevant
Moot point now, but thanks.
The reason for the flag name is that the prepare_bindings.py script as it
stands will always generate the bindings with swig if a swig is either
specified or allowed to be found in some common places. So the
"USE_STATIC_BINDINGS" would be misleading --- they wouldn't n
tfiala added a subscriber: tfiala.
tfiala added a comment.
Moot point now, but thanks.
The reason for the flag name is that the prepare_bindings.py script as it
stands will always generate the bindings with swig if a swig is either
specified or allowed to be found in some common places. So the
"
Author: tfiala
Date: Thu Nov 19 10:56:12 2015
New Revision: 253575
URL: http://llvm.org/viewvc/llvm-project?rev=253575&view=rev
Log:
Revert "prepare_bindings.py: enable static bindings"
This reverts commit 40f789f2dc6bb80fd25a33f91e452d081ed9d0ee.
Removed:
lldb/trunk/scripts/Python/static-bi
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D14885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tfiala added a comment.
Nice, I'm looking forward to looking at this in depth.
I'm out (not around a computer) until after Thanksgiving. I may be a little
laggy on feedback.
http://reviews.llvm.org/D14896
___
lldb-commits mailing list
lldb-commit
Author: tfiala
Date: Wed Dec 2 12:48:38 2015
New Revision: 254530
URL: http://llvm.org/viewvc/llvm-project?rev=254530&view=rev
Log:
Adds candidate formatter for replacing legacy summary results.
Also cleans up some usages of strings where symbolic names
were safer and made more sense.
Try a tes
Author: tfiala
Date: Wed Dec 2 15:12:17 2015
New Revision: 254546
URL: http://llvm.org/viewvc/llvm-project?rev=254546&view=rev
Log:
Make --results-file stdout implied if unspecified when using a results
formatter.
Also cleans up pylint warnings (stock settings) in the modified function.
Modifi
Author: tfiala
Date: Wed Dec 2 15:45:15 2015
New Revision: 254550
URL: http://llvm.org/viewvc/llvm-project?rev=254550&view=rev
Log:
Candidate fixes for python2/3 compatible string handling in pickling support.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest_channels.py
lldb/tr
Lgtm
-Todd
> On Dec 2, 2015, at 2:28 PM, Zachary Turner wrote:
>
> zturner created this revision.
> zturner added a reviewer: tfiala.
> zturner added a subscriber: lldb-commits.
>
> http://reviews.llvm.org/D15162
>
> Files:
> packages/Python/lldbsuite/test/dotest_channels.py
> packages/Pyth
tfiala added a subscriber: tfiala.
tfiala added a comment.
Lgtm
-Todd
http://reviews.llvm.org/D15162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Okay I also had a chance to run it with the patch locally, and I didn't see any
issues.
http://reviews.llvm.org/D15162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
tfiala added a comment.
Yep - I can make sure this works on Xcode tonight. I'll either direct send you
the diff or incorporate it with what you have here.
It probably won't be until much later tonight, but I'll definitely hit this.
http://reviews.llvm.org/D15209
___
tfiala added a comment.
Doesn't look like I can hit this until the morning. But it'll be first thing
on my list.
http://reviews.llvm.org/D15209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
I'm not sure exactly how these were divided up initially, but I'd suspect a
substantial amount of it is similar along the vein of POSIX vs. non-POSIX,
probably with some diffs for OS X support
tfiala added a comment.
Looking at this now.
http://reviews.llvm.org/D15209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
201 - 300 of 963 matches
Mail list logo
