tberghammer added a comment.
I see. Thank you for the clarification
Repository:
rL LLVM
http://reviews.llvm.org/D12757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added subscribers: lldb-commits, sivachandra.
tberghammer added a comment.
Hi Greg,
This change introduced a regression in expression evaluation. When I try to
evaluate any expression in some specific context then lldb prints out the
following error:
error: out-of-line definition
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with minor comment inline
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3228-3230
@@ -3227,3 +3227,5 @@
-if (die.GetReferenced
tberghammer created this revision.
tberghammer added reviewers: jingham, dawn.
tberghammer added a subscriber: lldb-commits.
Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
Both GNU AS and LLVM emits language type DW_LANG_Mips_Assembler for all
assembly code.
http
tberghammer created this revision.
tberghammer added a reviewer: spyffe.
tberghammer added a subscriber: lldb-commits.
Eliminate a potential crash in the struct layout code with a gracefull fallback
http://reviews.llvm.org/D12963
Files:
source/Expression/ClangASTSource.cpp
Index: source/Expre
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote:
> In http://reviews.llvm.org/D12899#248648, @zturner wrote:
>
> > One possible solution is to make an lldb-all target.
>
>
> As I said, it would much better rather t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248146: Use ClangASTContext for compile units with language
eLanguageTypeMipsAssembler (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12962?vs=35083&id=35218#toc
Repositor
Author: tberghammer
Date: Mon Sep 21 05:08:49 2015
New Revision: 248146
URL: http://llvm.org/viewvc/llvm-project?rev=248146&view=rev
Log:
Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
Both GNU AS and LLVM emits language type DW_LANG_Mips_Assembler for
all assembly
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I committed in the fix mentioned by Pavel as http://reviews.llvm.org/rL248146
http://reviews.llvm.org/D12976
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Possibly we can try to run IWYU
(https://github.com/include-what-you-use/include-what-you-use). I haven't tried
it but it sounds like a tool what is suitable for the task.
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: tberghammer
Date: Mon Sep 21 05:24:59 2015
New Revision: 248148
URL: http://llvm.org/viewvc/llvm-project?rev=248148&view=rev
Log:
Fix MSVC warings in DWARFExpression.cpp
Modified:
lldb/trunk/source/Expression/DWARFExpression.cpp
Modified: lldb/trunk/source/Expression/DWARFExpression.
tberghammer added a comment.
I decided to make it an opt-out feature as most of the test case will use some
debug info and this way you don't have to specify it explicitly (mutating a
test what don't have any debug info only have performance hit because it will
run the same test multiple times)
tberghammer added a subscriber: lldb-commits.
http://reviews.llvm.org/rL248277
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added a subscriber: tberghammer.
tberghammer raised a concern with this commit.
tberghammer added a comment.
Hi Sagar,
This change break the Linux build
(http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6568)
because the register enums have been renamed recent
Author: tberghammer
Date: Tue Sep 22 10:04:39 2015
New Revision: 248281
URL: http://llvm.org/viewvc/llvm-project?rev=248281&view=rev
Log:
Fix register names in EmulateInstructionMIPS.cpp
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp
Modified: lldb/trunk/sour
tberghammer resigned from this audit.
tberghammer added a comment.
I committed in a build fix as http://reviews.llvm.org/rL248281
Users:
tberghammer (Auditor)
http://reviews.llvm.org/rL248277
___
lldb-commits mailing list
lldb-commits@lists.llvm.
tberghammer added a comment.
In http://reviews.llvm.org/D13028#250822, @clayborg wrote:
> Looks good. For the failing test cases, just check this stuff in and we
> should take care or marking any needed tests and expected fail. Is there a
> way to mark a test such that the "dwarf in .o files" w
Author: tberghammer
Date: Wed Sep 23 06:00:35 2015
New Revision: 248373
URL: http://llvm.org/viewvc/llvm-project?rev=248373&view=rev
Log:
Fix xcode build after r248366
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.or
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as
Author: tberghammer
Date: Fri Sep 25 07:50:51 2015
New Revision: 248571
URL: http://llvm.org/viewvc/llvm-project?rev=248571&view=rev
Log:
Eliminate a potential crash in the struct layout code with a gracefull fallback
Differential revision: http://reviews.llvm.org/D12963
Modified:
lldb/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248571: Eliminate a potential crash in the struct layout
code with a gracefull fallback (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12963?vs=35084&id=35717#toc
Reposito
tberghammer marked 3 inline comments as done.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:340
@@ -346,1 +339,3 @@
[this](std::string* s) {
+AdbClient adb(m_device_id);
+
ovyalov wrote:
> Could you reuse adb variable defined
Author: tberghammer
Date: Tue Sep 29 06:04:18 2015
New Revision: 248788
URL: http://llvm.org/viewvc/llvm-project?rev=248788&view=rev
Log:
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as application user
because the sel
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL248788: Change oat symbolization code for android to work on
non-rooted devices (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an exception.
http://r
701 - 725 of 725 matches
Mail list logo
