tberghammer added a comment.
In the current version of the patch the compile units in the main object file
hands out only the compile unit DIE with the information what is available in
the main object file. I considered the other approach (hand out all DIEs by the
DWARF compile unit in the main
Author: tberghammer
Date: Tue Aug 25 05:27:38 2015
New Revision: 245928
URL: http://llvm.org/viewvc/llvm-project?rev=245928&view=rev
Log:
Fix source manager regression caused by r245905
Modified:
lldb/trunk/source/Symbol/SymbolFile.cpp
Modified: lldb/trunk/source/Symbol/SymbolFile.cpp
URL:
Author: tberghammer
Date: Tue Aug 25 06:46:06 2015
New Revision: 245932
URL: http://llvm.org/viewvc/llvm-project?rev=245932&view=rev
Log:
Handle DW_OP_GNU_addr_index in DWARF expressions
Differential revision: http://reviews.llvm.org/D12290
Modified:
lldb/trunk/include/lldb/Expression/DWARFE
Author: tberghammer
Date: Tue Aug 25 06:45:46 2015
New Revision: 245930
URL: http://llvm.org/viewvc/llvm-project?rev=245930&view=rev
Log:
Fix buffer overflow for fixed_form_sizes
The array is indexed by the value in the DW_FORM filed what can be
bigger then the size of the array. This CL add boun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245930: Fix buffer overflow for fixed_form_sizes (authored
by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12239?vs=32946&id=33060#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: tberghammer
Date: Tue Aug 25 06:45:58 2015
New Revision: 245931
URL: http://llvm.org/viewvc/llvm-project?rev=245931&view=rev
Log:
Add support for DW_FORM_GNU_[addr,str]_index
These are 2 new value currently in experimental status used when split
debug info is enabled.
Differential revisi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245932: Handle DW_OP_GNU_addr_index in DWARF expressions
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12290?vs=32971&id=33061#toc
Repository:
rL LLVM
http://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245931: Add support for DW_FORM_GNU_[addr,str]_index
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12238?vs=32949&id=33062#toc
Repository:
rL LLVM
http://reviews.llvm.
tberghammer updated this revision to Diff 33073.
tberghammer marked 10 inline comments as done.
tberghammer added a comment.
Fix the minor refactors requested in the review.
I haven't changed the approach to return all DIEs from the dwo file when
indexing the main compile unit because I would li
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few minor comments inline
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp:397
@@ +396,3 @@
+
+uint32_t control_valu
tberghammer added a comment.
In http://reviews.llvm.org/D12291#232191, @clayborg wrote:
> I also question why Symbo
>
> In http://reviews.llvm.org/D12291#231523, @tberghammer wrote:
>
> > In the current version of the patch the compile units in the main object
> > file hands out only the compile
tberghammer added a comment.
Sorry, first I manage to submit my comments without finishing them.
In http://reviews.llvm.org/D12291#232191, @clayborg wrote:
> I also question why Symbo
>
> In http://reviews.llvm.org/D12291#231523, @tberghammer wrote:
>
> > In the current version of the patch the
tberghammer added a comment.
If I understand you correctly then you are suggesting to create a class like
SymbolFileDWARFDebugMap for handling object files with dwo files. I think that
approach is practically have the same code flow as the current one (one symbol
file which one stores a list of
tberghammer added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:469
@@ -457,1 +468,3 @@
+if (error.Fail())
+return LLDB_INVALID_INDEX32;
This should be "return false"
Comment at:
so
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
You added 10 new function to the emulator where the first 8 functions and the
last 2 functions are almost identical. I know that the rest of the MIPS64
instruction emulator is having the same issue but I would like to see
tberghammer added a comment.
I though a bit more about the abstraction you plan to introduce (DWARFDIE) and
I started to believe we don't need it at all. If we use lldb::user_id_t in the
NameToDIE indexes where the first 4 byte is the compile unit offset (for dwo)
or the compile unit index (for
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Code cleanup in preparation of adding split dwarf support
* Remove some unused code
* Remove usage of DWARFDebugInfoEntry::Attributes where usage isn't reasonable
* Cleanup DWA
tberghammer added a comment.
I don't know too much about mips so I haven't checked if the emulation is
actually correct but the general concept looks good to me. I added a few
comments inline but they are mostly suggestions what you might want to consider.
Comment at:
source/
tberghammer added a subscriber: tberghammer.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853
@@ -852,3 +852,3 @@
if (platform_sp && platform_sp->IsConnected())
-SetUnixSignals(platform_sp->GetUnixSignals());
+
SetUnixSignals(
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D12356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 33676.
tberghammer added a comment.
[RFC] DO NOT COMMIT!
Update the design based on the discussion for the previous diff.
The current version have ~35 failures with split dwarf (most of them hit an
asse
tberghammer added a comment.
Added some inline comments to explain some implementation decisions
Comment at: include/lldb/Symbol/ObjectFile.h:372
@@ -371,3 +371,3 @@
virtual SectionList *
-GetSectionList ();
+GetSectionList (bool update_module_section_list = true);
tberghammer requested changes to this revision.
This revision now requires changes to proceed.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:820-821
@@ -819,1 +819,4 @@
+
+ioVec.iov_len = (offsetof (struct user_hwdebug_state,
dbg_regs[m_ma
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Fix tab completion for command arguments containing spaces
If a command argument contains a space then it have to be escaped with
backslash signs so the argument parsin
tberghammer updated this revision to Diff 33692.
tberghammer added a comment.
Address review comment (the function already exists in Args)
http://reviews.llvm.org/D12531
Files:
source/Interpreter/Options.cpp
test/functionalities/completion/Makefile
test/functionalities/completion/TestComp
tberghammer updated this revision to Diff 33702.
tberghammer added a comment.
Move escaping code to Args
http://reviews.llvm.org/D12531
Files:
include/lldb/Interpreter/Args.h
source/Interpreter/Args.cpp
source/Interpreter/CommandInterpreter.cpp
test/functionalities/completion/Makefile
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246639: Fix tab completion for command arguments containing
spaces (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12531?vs=33702&id=33794#toc
Repository:
rL LLVM
http:/
Author: tberghammer
Date: Wed Sep 2 05:35:27 2015
New Revision: 246639
URL: http://llvm.org/viewvc/llvm-project?rev=246639&view=rev
Log:
Fix tab completion for command arguments containing spaces
If a command argument contains a space then it have to be escaped with
backslash signs so the argume
tberghammer created this revision.
tberghammer added reviewers: labath, dsrbecky.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Fix arm disassambler with specifying armv8.1a architecture
If no architecture is defined for the disassambler command then
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246648: Fix arm disassambler with specifying armv8.1a
architecture (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12553?vs=33800&id=33801#toc
Repository:
rL LLVM
http:/
Author: tberghammer
Date: Wed Sep 2 08:24:50 2015
New Revision: 246648
URL: http://llvm.org/viewvc/llvm-project?rev=246648&view=rev
Log:
Fix arm disassambler with specifying armv8.1a architecture
If no architecture is defined for the disassambler command then it uses
the architecture of the targ
Author: tberghammer
Date: Wed Sep 2 08:31:18 2015
New Revision: 246649
URL: http://llvm.org/viewvc/llvm-project?rev=246649&view=rev
Log:
Only create alternative thumb disassembler if the main one is arm
This fixes a regression caused by r245645 where creating alternative
thumb disassembler was e
Hi Jason,
This commit caused a regression in disassembling thumb code when the
architecture is specified explicitly for the disassemble because we try to
create an alternative thumb disassembler even when the primary disassembler
is already thumb.
I committed in a fix as
http://llvm.org/viewvc/l
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
Introduce new address class eAddressClassDataIntermixedCode
It is used for marking data what is intermixed into the code section
on arm/aar
tberghammer added a comment.
In http://reviews.llvm.org/D12556#238457, @clayborg wrote:
> Changing all $d symbols to always say they are
> eAddressClassDataIntermixedCode is wrong because the symbols in the .data
> section now would be marked as eAddressClassDataIntermixedCode.
We only use th
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
I don't understand why it is necessary on OSX but I am fine with this change if
it fixes the issue (at the moment I am struggling with building lldb on OSX so
I can't test it).
One
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:316-328
@@ +315,15 @@
+
+const char* dwo_name = cu_die.GetAttributeValueAsString(m_dwarf2Data,
+this,
+
tberghammer retitled this revision from "Introduce new address class
eAddressClassDataIntermixedCode" to "Use eAddressClassCode for address lookup
for opcodes".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 33937.
tberghammer added a comment.
Addres
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fix TestLoadUnload.test_load_unload for android API > 21
* Change Module::MatchesModuleSpec to return true in case the file spe
Sorry for the breakage. It should be fixed by r246791
On Fri, Sep 4, 2015 at 1:34 AM Dawn Perchik wrote:
> dawn added a subscriber: dawn.
> dawn added a comment.
>
> We're seeing 2 new failures on OSX since this commit:
>
>
> Failure-TestCompletion.CommandLineCompletionTestCase.test_symbol_name
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Sorry for the breakage. It should be fixed by r246791
Users:
tberghammer (Author)
http://reviews.llvm.org/rL246639
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
tberghammer added inline comments.
Comment at: source/Core/Module.cpp:1712
@@ -1712,1 +1711,3 @@
+if (!FileSpec::Equal (file_spec, m_file,
(bool)file_spec.GetDirectory()) &&
+!FileSpec::Equal (file_spec, m_platform_file,
(bool)file_spec.GetDirectory()))
Author: tberghammer
Date: Fri Sep 4 07:42:41 2015
New Revision: 246852
URL: http://llvm.org/viewvc/llvm-project?rev=246852&view=rev
Log:
Fix TestLoadUnload.test_load_unload for android API > 21
* Change Module::MatchesModuleSpec to return true in case the file spec
in the specified module spec
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246852: Fix TestLoadUnload.test_load_unload for android API
> 21 (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12601?vs=33949&id=34025#toc
Repository:
rL LLVM
http://r
tberghammer created this revision.
tberghammer added reviewers: labath, chaoren, omjavaid.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
Fix the handling of FPR offsets in Linux arm/aarch64 register contexts
This should fix the
tberghammer updated this revision to Diff 34038.
tberghammer added a comment.
Updated the change based on the comments.
I don't fully agree with restricting the user from setting breakpoint in
non-code locations because if LLDB classified a section incorrectly (e.g.
haven't found the SO file fo
tberghammer added a comment.
I agree that we want to enable it only in very special cases when the user
really know what he/she wants (probably pass in a --force flag). Anyway, it
isn't implemented with this change and I don't expect it to be implemented in
the near future.
http://reviews.llv
tberghammer added a comment.
I prefer to keep it this way because there is no canonical register layout we
can rely on so putting them just next to each other would be just an arbitrary
layout what might break in the future. If we want the offsets to make sense,
then on arm/aarch64 the best app
Author: tberghammer
Date: Mon Sep 7 04:58:09 2015
New Revision: 246958
URL: http://llvm.org/viewvc/llvm-project?rev=246958&view=rev
Log:
Use eAddressClassCode for address lookup for opcodes for stack frames
It is required because of the following edge case on arm:
bxNon-tail call in a no re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246958: Use eAddressClassCode for address lookup for opcodes
for stack frames (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12556?vs=34038&id=34133#toc
Repository:
rL L
Author: tberghammer
Date: Mon Sep 7 05:11:23 2015
New Revision: 246959
URL: http://llvm.org/viewvc/llvm-project?rev=246959&view=rev
Log:
Fix the handling of FPR offsets in Linux arm/aarch64 register contexts
Differential revision: http://reviews.llvm.org/D12636
Modified:
lldb/trunk/source/P
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246959: Fix the handling of FPR offsets in Linux arm/aarch64
register contexts (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12636?vs=34034&id=34138#toc
Repository:
rL
Author: tberghammer
Date: Mon Sep 7 10:18:24 2015
New Revision: 246970
URL: http://llvm.org/viewvc/llvm-project?rev=246970&view=rev
Log:
XFAIL test_fp_special_purpose_register_read on android i386
Modified:
lldb/trunk/test/functionalities/register/TestRegisters.py
Modified: lldb/trunk/test/
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:34-44
@@ +33,13 @@
+
+DIERef::DIERef(const DWARFFormValue& form_value) :
+cu_offset(DW_INVALID_OFFSET),
+die_offset(DW_INVALID_OFFSET)
+{
+if (form_value.IsValid())
+{
+
Author: tberghammer
Date: Mon Sep 7 10:50:19 2015
New Revision: 246971
URL: http://llvm.org/viewvc/llvm-project?rev=246971&view=rev
Log:
XFAIL TestBuiltinTrap on android-arm (gcc bug)
Modified:
lldb/trunk/test/linux/builtin_trap/TestBuiltinTrap.py
lldb/trunk/test/lldbtest.py
Modified: l
Author: tberghammer
Date: Mon Sep 7 11:01:26 2015
New Revision: 246972
URL: http://llvm.org/viewvc/llvm-project?rev=246972&view=rev
Log:
XFAIL single_step_only_steps_one_instruction related tests on arm/aarch64
Modified:
lldb/trunk/test/tools/lldb-server/TestGdbRemoteSingleStep.py
lldb/t
Author: tberghammer
Date: Tue Sep 8 11:22:23 2015
New Revision: 247022
URL: http://llvm.org/viewvc/llvm-project?rev=247022&view=rev
Log:
Fix assertion failure caused by a bug in 128bit register handling in
RegisterValue
Modified:
lldb/trunk/include/lldb/Core/RegisterValue.h
lldb/trunk/s
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Change the looping stack detection code
In some special case (e.g. signal handlers, hand written assembly) it is
valid to have 2 stack frame with the same CFA value. This C
Author: tberghammer
Date: Wed Sep 9 05:20:30 2015
New Revision: 247130
URL: http://llvm.org/viewvc/llvm-project?rev=247130&view=rev
Log:
Remove the dwo files in the cleanup stage of the tests
The dwo files are generated when the tests run with split dwarf info.
Modified:
lldb/trunk/test/mak
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247131: Code cleanup in preparation of adding split dwarf
support (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12374?vs=33226&id=34309#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Wed Sep 9 05:20:36 2015
New Revision: 247131
URL: http://llvm.org/viewvc/llvm-project?rev=247131&view=rev
Log:
Code cleanup in preparation of adding split dwarf support
* Remove some unused code
* Remove usage of DWARFDebugInfoEntry::Attributes where usage isn't
reaso
tberghammer added a comment.
In ABI conforming code we will never have even 2 consecutive frames with the
same CFA for all ABI I know about.
In practice, 2 consecutive frame with the same CFA can happen (for hand written
assembly and signal handling), but more then 2 is highly unlikely.
In theor
Author: tberghammer
Date: Wed Sep 9 05:26:50 2015
New Revision: 247133
URL: http://llvm.org/viewvc/llvm-project?rev=247133&view=rev
Log:
Change the looping stack detection code
In some special case (e.g. signal handlers, hand written assembly) it is
valid to have 2 stack frame with the same CFA
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247133: Change the looping stack detection code (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12699?vs=34227&id=34313#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: tberghammer
Date: Wed Sep 9 06:16:32 2015
New Revision: 247135
URL: http://llvm.org/viewvc/llvm-project?rev=247135&view=rev
Log:
Add missing include after rL247131
Modified:
lldb/trunk/include/lldb/Core/MappedHash.h
Modified: lldb/trunk/include/lldb/Core/MappedHash.h
URL:
http://ll
Author: tberghammer
Date: Wed Sep 9 06:28:52 2015
New Revision: 247137
URL: http://llvm.org/viewvc/llvm-project?rev=247137&view=rev
Log:
Fix type in include header name
Modified:
lldb/trunk/include/lldb/Core/MappedHash.h
Modified: lldb/trunk/include/lldb/Core/MappedHash.h
URL:
http://llvm.
Hi Enrico,
TestFormattersBoolRefPtr.py started to fail on the OSX buildbot. I think
the first build where it is failed is
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5522, but
I am not sure as the bot is a bit unreliable. Can you take a look for it,
or if not, then are you fin
I attached the log for the failure (come from the build bot).
About the double reporting, I seen it on one of the build bot, but we have
some case when 2 different test have the same name what can explain the
issue (e.g. TestFormattersBoolRefPtr)
Tamas
On Wed, Sep 9, 2015 at 6:54 PM Zachary Turn
I don't know about any recent compiler update, about the build bot, but
will try to figure it out.
The current versions:
Darwin Yings-Mac-Pro.local 14.4.0 Darwin Kernel Version 14.4.0: Thu May 28
11:35:04 PDT 2015; root:xnu-2782.30.5~1/RELEASE_X86_64 x86_64
Apple LLVM version 6.1.0 (clang-602.0.53
Author: tberghammer
Date: Thu Sep 10 06:08:41 2015
New Revision: 247267
URL: http://llvm.org/viewvc/llvm-project?rev=247267&view=rev
Log:
Fix crash in lldb-server caused by an API change in LLVM
Modified:
lldb/trunk/tools/lldb-server/LLDBServerUtilities.cpp
Modified: lldb/trunk/tools/lldb-se
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Improve the arm/aarch64 mapping symbol handling
Change the mapping symbol handling to handle the case when the mapping
symbols are
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Fix prologue end handling when code compiled by gcc
GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue. Instead of it it is issuing a line
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I tried to apply your patch but couldn't manage to do it because
source/Utility/ARM_ehframe_Registers.[h,cpp] is not available in TOT. I think
you uploaded only a part of your patch.
Repository:
rL LLVM
http://reviews
Author: tberghammer
Date: Fri Sep 11 05:04:00 2015
New Revision: 247400
URL: http://llvm.org/viewvc/llvm-project?rev=247400&view=rev
Log:
Improve the arm/aarch64 mapping symbol handling
Change the mapping symbol handling to handle the case when the mapping
symbols are prefixed with an arbitrary p
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL247400: Improve the arm/aarch64 mapping symbol handling
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12755?vs=34432&id=34536
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Fix several issues around dwo symbol file handling
This change all dwo related test failure on Linux x86_64
http://reviews.llvm.org/D12804
Files:
source/Plugins/SymbolFile/
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Generally looks good to me with a few minor comments, but please wait for a
review from Greg or Jim.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3201
@@ +3200,3 @@
+
Author: tberghammer
Date: Mon Sep 14 10:44:29 2015
New Revision: 247571
URL: http://llvm.org/viewvc/llvm-project?rev=247571&view=rev
Log:
Fix a possible SEGV in SymbolFileDWARF
The iterator pointing to an element of a dense map was used after
the element from was removed from the map what isn't g
tberghammer added a comment.
I tried out this change and it compiles both on Linux and on arm, but it causes
2 test failure:
TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_returns_all_valid_results_llgs_dwarf
TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_returns_one_valid
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248
@@ -2241,2 +2241,9 @@
lldb::addr_t highest_func_addr = func_ranges.GetMaxRangeEnd (0);
+
+// lowest_func_addr is a file address what can't be 0 because
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for DW_OP_GNU_const_index to dwarf expression
DW_OP_GNU_const_index is a new opcode used when split dwarf is enabled
http://reviews.llvm.org/D12849
Files:
inclu
tberghammer added a comment.
Those tests are communicating on the gdb remote protocol directly and do a
pattern matching on the response. I think they have the register set names hard
coded in one of those patters, but haven't looked into it (I expect that they
will fail on OSX too).
http://r
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3892-3893
@@ +3891,4 @@
+{
+lldb::user_id_t spec_uid = form_value.Reference();
+if (UserIDMatches(spec_uid))
+
tberghammer added a comment.
Thank you for the clarification. I will commit in this patch without the change
we discussed (ignoring 0 file address) and I will address that issue later.
http://reviews.llvm.org/D12804
___
lldb-commits mailing list
ll
Author: tberghammer
Date: Tue Sep 15 05:33:41 2015
New Revision: 247671
URL: http://llvm.org/viewvc/llvm-project?rev=247671&view=rev
Log:
Fix several issues arount dwo symbol file handling
Differential revision: http://reviews.llvm.org/D12804
Modified:
lldb/trunk/source/Plugins/SymbolFile/DW
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247671: Fix several issues arount dwo symbol file handling
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12804?vs=34550&id=34793#toc
Repository:
rL LLVM
http://reviews
Author: tberghammer
Date: Tue Sep 15 05:33:54 2015
New Revision: 247672
URL: http://llvm.org/viewvc/llvm-project?rev=247672&view=rev
Log:
Add support for DW_OP_GNU_const_index to dwarf expression
DW_OP_GNU_const_index is a new opcode used when split dwarf is enabled
Differential revision: http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247672: Add support for DW_OP_GNU_const_index to dwarf
expression (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12849?vs=34697&id=34794#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Tue Sep 15 09:04:52 2015
New Revision: 247690
URL: http://llvm.org/viewvc/llvm-project?rev=247690&view=rev
Log:
Skip TestGoASTContext on remote targets as it it not remote compatible
Modified:
lldb/trunk/test/lang/go/types/TestGoASTContext.py
Modified: lldb/trunk/te
tberghammer added a comment.
Hi Greg, what do you think about my inline suggestion? Are you fine with
removing the original hack about removing duplicate entries from the line table
end then solve the problem around duplicate line entries with always returning
the last entry if we have multiple
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for the DWARFLocationList used by split-dwarf
Split-dwarf uses a different header format to specify the address range for the
elements of the location lists.
http
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision now requires changes to proceed.
If I understand this change correctly then OperatingSystemGo::CreateInstance
will be
tberghammer added a comment.
In http://reviews.llvm.org/D12757#246497, @clayborg wrote:
> Maybe we can try still removing duplicates, but remembering the first index
> where we had a duplicate line entry. If we don't get a prologue end, then we
> got back to the index we remembered for the firs
tberghammer added a comment.
The line number is not always the same for the 2 entry (the first one points to
the open '{' and the second one to the first instruction of the function). I
added the check for the file name, but I would be quite surprised if we find a
scenario when the file names d
tberghammer marked an inline comment as done.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:36-228
@@ -37,1 +35,195 @@
+static int
+print_dwarf_exp_op (Stream &s,
+const DWARFDataExtractor& data,
+lldb::offset_t *offs
Author: tberghammer
Date: Wed Sep 16 07:36:37 2015
New Revision: 247788
URL: http://llvm.org/viewvc/llvm-project?rev=247788&view=rev
Log:
Fix prologue end handling when code compiled by gcc
GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue. Instead of it it i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247788: Fix prologue end handling when code compiled by gcc
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12757?vs=34435&id=34886#toc
Repository:
rL LLVM
http://review
Author: tberghammer
Date: Wed Sep 16 07:37:06 2015
New Revision: 247789
URL: http://llvm.org/viewvc/llvm-project?rev=247789&view=rev
Log:
Add support for the DWARFLocationList used by split-dwarf
Split-dwarf uses a different header format to specify the address range
for the elements of the locat
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL247789: Add support for the DWARFLocationList used by
split-dwarf (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12880?vs=3480
Author: tberghammer
Date: Thu Sep 17 05:05:21 2015
New Revision: 247879
URL: http://llvm.org/viewvc/llvm-project?rev=247879&view=rev
Log:
XFAIL step after crash tests on android-aarch64 API 21
Android-aarch64 for API21 uses sa_restore to return from a signal handler
what have no eh_frame specifie
601 - 700 of 725 matches
Mail list logo
