[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

2020-08-19 Thread Steven Johnson via Phabricator via lldb-commits
srj added a comment. This seems to have injected a link-time dependency on `setupterm` etc. even if you configure CMake with LLVM_ENABLE_TERMINFO=OFF (which was not the case before) -- this is breaking some builds of Halide as a result. (Should the `#idef LLVM_ENABLE_TERMINFO` actually if `#if`

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

2020-08-19 Thread Steven Johnson via Phabricator via lldb-commits
srj added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} srj

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

2020-08-19 Thread Steven Johnson via Phabricator via lldb-commits
srj added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO} In m