[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

stella.stamenova added a comment. Sadly, I think this broke the windows bot now (assuming it got applied to staging, otherwise I have to figure out what did): http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/46/steps/cmake-configure/logs/stdio Repository: rZORG LLVM Github Zor

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_. ---

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:94 +project, it generates the files needed by your build tool. The recommended +build tool for LLVM is Ninja. Please also read `Building LLVM with CMake +`_. ---

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova accepted this revision. stella.stamenova added a comment. I think you need one small change for lld still - to make it clear that it is required on Windows in the Windows section, but it looks good otherwise. Please fix that before committing. Comment at: lld

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. I'll run some tests and let you know the result. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. One failure: Error : no member named 'argc' in namespace '$__lldb_local_vars' from LLDB :: SymbolFile/NativePDB/local-variables.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. I am able to do some testing as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D65546: Fix TestThreadSpecificBreakpoint on Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Please keep an eye on the bot after you commit though CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65546/new/ https://reviews.llvm.org/D65546 ___

[Lldb-commits] [PATCH] D55571: [ast] CreateParameterDeclaration should use an appropriate DeclContext.

stella.stamenova added a comment. Herald added a project: LLDB. Test passes now. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55571/new/ https://reviews.llvm.org/D55571 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. Yes, it was! Thanks for catching that :) The tests pass with the latest update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

stella.stamenova added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:318 + if(MSVC) +set(flag_werror "/WX") + endif() sgraenitz wrote: > I copied the flag from LLVM. Is it the right one for MSVC? Yes: https://docs.microsoft.com/en-us/cpp/

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata

stella.stamenova added a comment. This change caused failures on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7681 compounding on the existing failures from [lldb] Refactor guard variable checks in IRForTarget Repository: rL LLVM CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D66429: [CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. I think this is actually fine. The change that was needed for multi-configuration generators is how the two default paths for the compilers are set. The USE variables were

[Lldb-commits] [PATCH] D66499: [LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (NFC)

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Please monitor the windows Buildbot to make sure it still passes after your commit though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D66546: Extend FindTypes w/ CompilerContext to allow filtering by language

stella.stamenova added a comment. It looks like this broke the windows build bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/8120 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

stella.stamenova added a comment. Is there a way to reduce some of the code duplication? The more duplication there is, the harder it is to maintain. Comment at: cmake/modules/LLDBConfig.cmake:240 + if (NOT DEFINED CMAKE_BUILD_TYPE) +# multiconfiguration generator was sel

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

stella.stamenova added a comment. This broke the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/8741 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Yes, sorry. I hadn't gotten around to testing it to make sure the failures were gone. Do you still need someone to commit for you? Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

stella.stamenova added a comment. A couple of the tests from TestVSCode_attach.py (test_by_pid and test_by_name) are failing for us on Ubuntu because they are failing to attach: `AssertionError: False is not True : attach failed (Operation not permitted)`. It looks like attaching by pid or by n

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

stella.stamenova added a comment. In D61611#1496681 , @sgraenitz wrote: > In D61611#1496644 , @probinson wrote: > > > Sorry for the drive-by... what is this `REQUIRES: nowindows`? I don't see > > where lit generat

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

stella.stamenova added a comment. In D61611#1496838 , @probinson wrote: > @stella.stamenova I'm not familiar with any lit feature that gives a special > meaning to the prefix "no". The opposite of "REQUIRES: windows" is not > "REQUIRES: nowindows" but "

[Lldb-commits] [PATCH] D61752: Re-enable a test for non-Windows

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lldb/lit/Breakpoint/case-sensitive.test:1 -# REQUIRES: nowindows +# UNSUPPORTED: windows # This should be syst

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

stella.stamenova added a comment. Thanks, Pavel! I tested out the proposed change and all of our Ubuntu bots now work. I've committed it as well. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60153/new/ https://reviews.llvm.org/D60153 _

[Lldb-commits] [PATCH] D62305: [lldb] fix cannot convert from 'nullptr' to 'lldb::thread_result_t'

stella.stamenova added a comment. It looks like this was not enough and the build is still broken. Please revert your change or fix it and then keep an eye on the Buildbot to make sure it turns to green again. Once it's broken, it won't continue sending failure emails, so you have to monitor it

[Lldb-commits] [PATCH] D62337: [lldb] followup fix for https://reviews.llvm.org/D62305

stella.stamenova added a comment. This looks good - it is still not all though. Even after Jonas' change the build failed with the same error elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62337/new/ https://reviews.llvm.org/D62337 __

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. I don't think that this would apply very well to Visual Studio with the current change because it is likely that if you are using VS to build LLDB, you also used

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 ___

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

stella.stamenova added inline comments. Comment at: lldb/lit/CMakeLists.txt:13 +# Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided +# LLVM build-tree used a single-configuration generator like Ninja. +string(REPLACE ${CMAKE_CFG_INTDIR} "." LLDB_D

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

stella.stamenova accepted this revision. stella.stamenova added inline comments. This revision is now accepted and ready to land. Comment at: lldb/lit/CMakeLists.txt:13 +# Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided +# LLVM build-tree used a sin

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

stella.stamenova added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEFAULT_PATH) endif() ---

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

stella.stamenova added a comment. It looks like this broke the Windows bot. I am no longer receiving emails when the bot fails (as bot owner I used to always get the failure emails), so I am assuming for some reason notifications aren't working correctly. Can you have a look at the failure? ht

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

stella.stamenova added a comment. This test is extremely flaky on Windows - it looks like it passes on the bot less than 10% of the time: http://lab.llvm.org:8011/buildslaves/win-py3-buildbot. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63110/new/ https://revi

[Lldb-commits] [PATCH] D63268: Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups

stella.stamenova added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63268/new/ https://reviews.llvm.org/D63268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

stella.stamenova added a comment. In D63110#1551572 , @mgorny wrote: > @stella.stamenova could you try running the lldb invocation manually like I > did? I'm wondering if you're getting the same issue. It is the same. The interesting thing is that it pa

[Lldb-commits] [PATCH] D63679: [lit] Make lit-lldb-init configurable by CMake

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63679/new/ https://reviews.llvm.org/D63679 ___

[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:132 environment variable if it is specified). * ``LLDB_TEST_C_COMPILER`` or ``LLDB_TEST_CXX_COMPILER``: The test suite needs to be able to find a copy of clang.exe that it can use to compile

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

stella.stamenova added a comment. Re: Windows CMake: I am not sure, I'd have to do look into it further. On a separate note: I haven't looked into it yet, but we have a setup to run the LLDB tests on Ubuntu and that started failing somewhat recently with some Swig and Python errors. For example

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

stella.stamenova added a comment. load-pdb is still failing on the Windows bot. Can you please commit a fix soon or revert the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 __

[Lldb-commits] [PATCH] D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC

stella.stamenova added a comment. This test is failing on the Windows bot: http://lab.llvm.org:8011/#/builders/83/builds/678 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91220/new/ https://reviews.llvm.org/D91220

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

stella.stamenova added a comment. It looks like this broke the windows lldb buildbot: http://lab.llvm.org:8011/#/builders/83/builds/693 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90490/new/ https://reviews.llvm.org/D90490 _

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

stella.stamenova added a comment. This caused failures on the Windows lldb buildbot: http://lab.llvm.org:8011/#/builders/83/builds/1294 Tests have to have unique names, so the two new added tests that use TestCase as the class name are both trying to write to the same log file and failing to d

[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

stella.stamenova added a comment. In D92425#2428952 , @teemperor wrote: > In D92425#2428844 , > @stella.stamenova wrote: > >> This caused failures on the Windows lldb buildbot: >> >> http://lab.llvm.org:8011/#/buil

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

stella.stamenova added inline comments. Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:87 set(LLDB_LIBS_DIR_CONFIGURED "${LLDB_LIBS_DIR}") + set(LLVM_TOOLS_DIR_CONFIGURED "${LLVM_TOOLS_DIR_CONFIGURED}") I think here you just want to set it to LLVM_TOOLS_

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

stella.stamenova added inline comments. Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:87 set(LLDB_LIBS_DIR_CONFIGURED "${LLDB_LIBS_DIR}") + set(LLVM_TOOLS_DIR_CONFIGURED "${LLVM_TOOLS_DIR_CONFIGURED}") labath wrote: > stella.stamenova wrote: > > I think

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added a comment. It looks like this broke the windows lldb bot: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D95008: Revert "Revert "Ignores functions that have a range starting outside of a code section""

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:775 + return dwarf_ast->ParseFunctionFromDWARF(comp_unit, die, + m_first_code_address); } This line does not b

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added a comment. I am seeing this consistently fail on our internal Ubuntu bot: ERROR: test_missingArgInRunInTerminalLauncher (TestVSCode_runInTerminal.TestVSCode_runInTerminal) -- Traceback (most recent c

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added a comment. In D93951#2523886 , @wallace wrote: > @stella.stamenova , is that build a Debug or Release build? I think that will > help me determine why it's failing Release. It passed in Debug. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 + +#if !defined(WIN32) +#include Also, this is no good. It works if you are targeting windows on windows, but not if you are targeting something else and building on wind

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Sorry, I was out on vacation until today :). The bot is actually running 3.14 already, I updated the host file to reflect that. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

stella.stamenova added a comment. It looks like this also caused a failure on the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11896 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71372/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

stella.stamenova added a comment. This broke the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 __

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

stella.stamenova added a comment. This introduced a failure on the Windows LLDB bot (there were already other failing tests though, so maybe you missed it): http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

stella.stamenova added a comment. This change is causing a build break on Windows (which was hidden by the Hexagon build break you just fixed :(). http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12857/steps/build/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D74093: [lldb/tests] Correctly configure the lldb dotest arguments

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. When the generator used for CMake is a multi-configuration generator (such as VS), the arguments passed to dotest are not currentl

[Lldb-commits] [PATCH] D74093: [lldb/tests] Correctly configure the lldb dotest arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd53c8c6af522: [lldb/tests] Correctly configure the lldb dotest arguments (authored by stella.stamenova). Changed prior to commit: https://reviews.llvm.org/D74093?vs=242753&id=242941#toc Repository: r

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Currently, lldb-repro is placed in the wrong location for multi-configuration generators. For example, in the case of VS, it is pl

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

stella.stamenova marked an inline comment as done. stella.stamenova added inline comments. Comment at: lldb/utils/lldb-repro/CMakeLists.txt:6 +# Generate lldb-repro Python script for each build mode. +if(LLDB_BUILT_STANDALONE) + set(config_types ".") JDevliegher

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

This revision was automatically updated to reflect the committed changes. Closed by commit rG733923a97dff: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi… (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D74168: [lldb\CMake] Exclude the reproducer test suites from check-all

stella.stamenova added inline comments. Comment at: lldb/test/Shell/CMakeLists.txt:24 PARAMS "lldb-run-with-repro=capture" + EXCLUDE_FROM_ALL DEPENDS lldb-test-deps) After the change you made to add_lit_testsuite, this can be anywhere in the function call

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.org/D74168 ___

<    1   2   3   4