[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young created this revision. siger-young added reviewers: JDevlieghere, tammela. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit supports registerubg breakpoint callback when using liblldb in Lua. (able to `Set

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young updated this revision to Diff 395076. siger-young added a comment. Remove "return" to prevent memory leakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115926/new/ https://reviews.llvm.org/D115926 Files: lldb/bindings/interface/S

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young added a comment. In D115926#3199496 , @labath wrote: > I don't know if you've seen this but we have some description of it here > https://lldb.llvm.org/design/sbapi.html. The gist of it is: > > - be backward compatible > - don't depend on oth

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young added inline comments. Comment at: lldb/bindings/lua/lua-typemaps.swig:219-221 +%typecheck(SWIG_TYPECHECK_STRING_ARRAY) char ** { + $1 = (lua_istable(L, $input) || lua_isnil(L, $input)); +} tammela wrote: > This is not being generated by SWIG for so

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 375081. siger-young added a comment. This update mainly fixed problematic typemaps and adding necessary comments. Together, it forced Lua installation path as "PREFIX/lib/lua/5.3" and removed "lit.util" in tests. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young updated this revision to Diff 375086. siger-young added a comment. Remove "REQUIRED" flags when finding Lua at "FindLuaAndSwig.cmake". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108515/new/ https://reviews.llvm.org/D108515 Files:

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 375100. siger-young added a comment. Fix typo in SBData test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Files: lldb/test/API/lua_api/TestComprehensive.lua

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 375103. siger-young added a comment. Rebase commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Files: lldb/CMakeLists.txt lldb/bindings/lua/CMakeLists.t

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young added inline comments. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + tammela wrote: > Could we not use an external dependency? > For instance in my setup it fails because it couldn't find

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young added inline comments. Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3 +EXPORT_ASSERT_TO_GLOBALS = true +require('luaunit') + tammela wrote: > siger-young wrote: > > tammela wrote: > > > Could we not use an external dependency? > > > For instanc

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 375240. siger-young added a comment. Add assertion functions and error status detection to remove "luaunit" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Files:

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 378971. siger-young added a comment. Pull and merge conflicts, will soon be merged into main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Files: lldb/CMakeL

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young created this revision. Herald added a subscriber: arphaman. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a basic reference page for Lua scripting, as a counterpart to section "Python Reference". Repository:

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young added a comment. In D104281#2818620 , @teemperor wrote: > Instead of copying the text from the Python page, I was actually thinking > whether we should make the 'scripting' page more generic and just add the > language-specific examples for

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 353434. siger-young added a comment. Reference page for Python and Lua is ready. A new sphinx extension "sphinx-tabs" is added to enable users switching the language. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young added inline comments. Comment at: lldb/docs/conf.py:32-33 # set by CMake. -sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE")) +if os.getenv("LLDB_SWIG_MODULE") is not None: +sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE")) JDev

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young created this revision. siger-young added reviewers: tammela, JDevlieghere. siger-young added a project: LLDB. siger-young requested review of this revision. Herald added a subscriber: lldb-commits. Add support for Lua scripted watchpoints, with basic tests. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young updated this revision to Diff 355428. siger-young added a comment. This patch mainly adds two extra tests for Lua scripted watchpoints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 Files:

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young updated this revision to Diff 355429. siger-young added a comment. Fix some linting and add extra tests for Lua scripted watchpoints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 Files: l

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 355439. siger-young added a comment. Rebase two commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281 Files: lldb/docs/conf.py lldb/docs/index.rst lldb/d

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 362990. siger-young added a comment. Add integrated pages (Lua + Python) for scripting docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281 Files: lldb/docs/co

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 366494. siger-young added a comment. This update marks features that are only supported by Python, and adds Lua example code for using LLDB module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement typemaps for Lua bindings

siger-young created this revision. Herald added a subscriber: mgorny. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add necessary typemaps for Lua bindings. Signed-off-by: Siger Yang Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement typemaps for Lua bindings

siger-young updated this revision to Diff 366520. siger-young added a comment. Using `lua_newuserdata` instead of `lua_newuserdatauv` to support Lua 5.3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Fil

[Lldb-commits] [PATCH] D108090: [lldb/lua] Supplement Lua bindings for lldb module

siger-young updated this revision to Diff 367971. siger-young added a comment. This update adds some tests for Lua LLDB module. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108090/new/ https://reviews.llvm.org/D108090 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young created this revision. siger-young added reviewers: tammela, JDevlieghere. Herald added a subscriber: mgorny. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Due to CMake cache, find_package in FindLuaAndSwig.cmake w

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 368028. siger-young added a comment. This update makes scripting example more coherent even if Lua parts are added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 368029. siger-young added a comment. This update improves the scripting reference parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104281/new/ https://reviews.llvm.org/D104281 Files: lldb/docs/conf.p

[Lldb-commits] [PATCH] D108515: [lldb/lua] Force Lua version to be 5.3

siger-young added inline comments. Comment at: lldb/cmake/modules/FindLuaAndSwig.cmake:12 if (SWIG_FOUND) -find_package(Lua 5.3) +find_package(Lua 5.3 EXACT REQUIRED) if(LUA_FOUND AND SWIG_FOUND) mstorsjo wrote: > This breaks building in setups wh