[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

rastogishubham added a comment. It looks like this change is breaking some lldb tests. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/57586/consoleFull#-1731262255a1ca8a51-895e-46c6-af87-ce24fa4cd561 - TEST 'lldb-api :: tools/lldb-vscode/console/TestVSCode_console.py' FAILED

[Lldb-commits] [PATCH] D154030: [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

rastogishubham added a comment. I am reverting the change for now, I apologize for any inconvenience Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154030/new/ https://reviews.llvm.org/D154030 ___ lldb-co

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

rastogishubham added a comment. The unit test LocateModuleCallbackTest.cpp is very flaky and is failing on the lldb arm64 incremental bot Notice build https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/2259/ passes and https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/2260/

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

rastogishubham added a comment. I am reverting both fb087c17c8230 and 7f1028e9df52b to see if the bot becomes green again Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

rastogishubham added a comment. In D153734#4501034 , @rastogishubham wrote: > I am reverting both fb087c17c8230 > and > 7f1028e9df52b >

[Lldb-commits] [PATCH] D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd317637708d: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14 (authored by rastogishubham). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

rastogishubham updated this revision to Diff 483042. rastogishubham added a comment. Herald added subscribers: Michael137, JDevlieghere. I was not able to land this patch earlier because of some bot failures and then I got busy with some other stuff, this is just an update of the patch with merg

[Lldb-commits] [PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

rastogishubham updated this revision to Diff 483403. rastogishubham added a comment. Fix the lldb test failures: lldb-shell :: SymbolFile/DWARF/x86/DW_AT_loclists_base.s lldb-shell :: SymbolFile/DWARF/x86/debug_loc.s lldb-shell :: SymbolFile/DWARF/x86/debug_loc_and_loclists.s lldb-shell :

[Lldb-commits] [PATCH] D150222: [lldb][NFCI] Remove custom dwarf LEB128 types

rastogishubham accepted this revision. rastogishubham added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150222/new/ https://reviews.llvm.org/D150222 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form

rastogishubham accepted this revision. rastogishubham added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Great refactoring! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150228/new/ https://re

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

rastogishubham accepted this revision. rastogishubham added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32 - typedef std::map range_map; - typedef range_map::iterator range_map_iterator;

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

rastogishubham added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32 - typedef std::map range_map; - typedef range_map::iterator range_map_iterator; - typedef range_map::const_iterator range_map_const_iterator; - range_map m_range_map

[Lldb-commits] [PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0008990479a2: Remove the dependency between lib/DebugInfoDWARF and MC. (authored by rastogishubham). Herald added a project: LLDB. Herald added a sub

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

rastogishubham accepted this revision. rastogishubham added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 __