[Lldb-commits] [lldb] r360599 - [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas operator()() but using FindSymbolsMatchingRegExAndType()

2019-05-13 Thread Shafik Yaghmour via lldb-commits
Author: shafik Date: Mon May 13 09:48:06 2019 New Revision: 360599 URL: http://llvm.org/viewvc/llvm-project?rev=360599&view=rev Log: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas operator()() but using FindSymbolsMatchingRegExAndTy

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

2019-06-05 Thread Shafik Yaghmour via lldb-commits
abs(offset) is not the same as addr_t(-offset) AFAICT offset is positive so we are casting a small negative number to an unsigned type which will result in a really large value e.g. https://godbolt.org/z/B2Z7Ok > On Jun 4, 2019, at 6:49 PM, Fangrui Song via lldb-commits > wrote: > > Author: m

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

2019-06-05 Thread Shafik Yaghmour via lldb-commits
Apologies, I somehow missed the offset < 0. > On Jun 5, 2019, at 12:38 PM, Pavel Labath wrote: > > On 05/06/2019 21:23, Shafik Yaghmour via lldb-commits wrote: >> abs(offset) is not the same as addr_t(-offset) > > It is, if you assume that offset is negative, wh

[Lldb-commits] [lldb] r366365 - Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

2019-07-17 Thread Shafik Yaghmour via lldb-commits
Author: shafik Date: Wed Jul 17 13:16:13 2019 New Revision: 366365 URL: http://llvm.org/viewvc/llvm-project?rev=366365&view=rev Log: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory In ClangASTContext::CreateFunctionTemplateSpecializationInfo a TemplateArgumen

[Lldb-commits] [lldb] dc057e8 - [LLDB] Fix how ObjCBOOLSummaryProvider deals with BOOL

2021-01-22 Thread Shafik Yaghmour via lldb-commits
Author: Shafik Yaghmour Date: 2021-01-22T10:05:24-08:00 New Revision: dc057e87f6c18c24d17c7cae97ebe95f78b6d934 URL: https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934 DIFF: https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934.dif

[Lldb-commits] [lldb] 4f14c17 - [LLDB] Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

2021-02-09 Thread Shafik Yaghmour via lldb-commits
Author: Shafik Yaghmour Date: 2021-02-09T16:11:28-08:00 New Revision: 4f14c17df70916913d71914343dd4f6c709e218d URL: https://github.com/llvm/llvm-project/commit/4f14c17df70916913d71914343dd4f6c709e218d DIFF: https://github.com/llvm/llvm-project/commit/4f14c17df70916913d71914343dd4f6c709e218d.dif

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

2020-04-16 Thread Shafik Yaghmour via lldb-commits
> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-04-16T14:03:55-07:00 > New Revision: 9f6a308457d1bfebf1cee94b0306e738f270e512 > > URL: > https://github.com/llvm/llvm-project/commit/9f6a308457d1bfebf1cee94b0306e738f270e51

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

2020-04-16 Thread Shafik Yaghmour via lldb-commits
> On Apr 16, 2020, at 3:17 PM, Davidino Italiano wrote: > > > >> On Apr 16, 2020, at 2:37 PM, Shafik Yaghmour via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >>> >>> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere vi

[Lldb-commits] [Differential] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

2020-07-20 Thread Shafik Yaghmour via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa54c42df9a72: Fix how we handle bit-fields for Objective-C when creating an AST (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D83433?vs=278026&id=

Re: [Lldb-commits] [lldb] fe8e25a - [lldb][NFC] Create type-safe function for creating a CompilerType from a QualType

2020-01-02 Thread Shafik Yaghmour via lldb-commits
Instead of GetType(...) I think GetCompilerType(…) is better or maybe even GetAsCompilerType(…). It adds a bit more context, we have so many types. It also feels a bit more consistent with methods like: > On Jan 2, 2020, at 2:55 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: R

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

2020-01-02 Thread Shafik Yaghmour via lldb-commits
I am not crazy about the reinterpret_cast although if we look inside CompilerDecl impl we can see that basically it is always assuming it is a Decl* and just C-style casts it as such. So why not just make it a Decl* Also operator<(…) is super sketchy doing a < on void* > On Dec 28, 2019, at 6:

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

2020-01-02 Thread Shafik Yaghmour via lldb-commits
Apologies, m_opaque_decl member of CompilerDecl and operator < in CompilerDecl.h > On Jan 2, 2020, at 3:54 PM, Raphael “Teemperor” Isemann > wrote: > > Not sure if I can follow. What variable should just be a Decl* and what > operator > (Also yeah that reinterpret_cast could also be a stati

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

2020-01-02 Thread Shafik Yaghmour via lldb-commits
Decl* > On Jan 2, 2020, at 4:20 PM, Shafik Yaghmour via lldb-commits > wrote: > > Apologies, m_opaque_decl member of CompilerDecl and operator < in > CompilerDecl.h > >> On Jan 2, 2020, at 3:54 PM, Raphael “Teemperor” Isemann >> wrote: >> >> N

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

2024-10-14 Thread Shafik Yaghmour via lldb-commits
shafik wrote: This crash is due to this set of changes: https://github.com/llvm/llvm-project/issues/11 https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

<    1   2