spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
There are a few changes I'd recommend to this patch. The biggest one is to
move mangling knowledge from IRExecutionUnit to LanguageCPlusPlus, where it
logically fits better.
The tes
spyffe added a reviewer: clayborg.
spyffe added a comment.
Added Greg to look at the testsuite changes.
Repository:
rL LLVM
http://reviews.llvm.org/D17957
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This looks fine. Overloadable C functions are being tested separately, so this
is fine to go in.
http://reviews.llvm.org/D1
___
lldb-commit
Author: spyffe
Date: Fri Mar 18 19:51:43 2016
New Revision: 263864
URL: http://llvm.org/viewvc/llvm-project?rev=263864&view=rev
Log:
Handle any persistent Decl in the Clang expression parser, not just types.
Persistent decls have traditionally only been types. However, we want to
be able to pers
Author: spyffe
Date: Mon Mar 21 17:23:38 2016
New Revision: 263995
URL: http://llvm.org/viewvc/llvm-project?rev=263995&view=rev
Log:
Collect IRExecutionUnits as part of persistent expression state.
IRExecutionUnits contain code and data that persistent declarations can
depend on. In order to kee
Author: spyffe
Date: Tue Mar 22 16:05:51 2016
New Revision: 264095
URL: http://llvm.org/viewvc/llvm-project?rev=264095&view=rev
Log:
Backend support for top-level Clang epxressions
This patch adds a new ExecutionPolicy, eExecutionPolicyTopLevel, which
tells the expression parser that the expressi
Author: spyffe
Date: Tue Mar 22 17:42:42 2016
New Revision: 264113
URL: http://llvm.org/viewvc/llvm-project?rev=264113&view=rev
Log:
Reverted a change in r264074 that made lldb-mi use lldb_private APIs.
FileSystem::Fopen is a lldb_private API, but lldb-mi uses only the
public API. Depending on l
Author: spyffe
Date: Fri Mar 25 18:51:25 2016
New Revision: 264478
URL: http://llvm.org/viewvc/llvm-project?rev=264478&view=rev
Log:
Removed LoggingDiagnosticConsumer, an unused class.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/
Author: spyffe
Date: Fri Mar 25 19:30:40 2016
New Revision: 264483
URL: http://llvm.org/viewvc/llvm-project?rev=264483&view=rev
Log:
Record all translation units with more than one function in them (e.g., blocks).
Blocks and lambdas have their implementation functions stored in the IR for an
expr
Author: spyffe
Date: Fri Mar 25 19:37:55 2016
New Revision: 264485
URL: http://llvm.org/viewvc/llvm-project?rev=264485&view=rev
Log:
When we import the definition for a Tagdecl, propagate its completeness too.
The ASTImporter completes the full definiton for a TagDecl in several places,
including
Author: spyffe
Date: Mon Mar 28 16:07:53 2016
New Revision: 264659
URL: http://llvm.org/viewvc/llvm-project?rev=264659&view=rev
Log:
Removed an override of LookupSymbol that mistakenly disabled it for Clang.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
Author: spyffe
Date: Mon Mar 28 16:10:36 2016
New Revision: 264660
URL: http://llvm.org/viewvc/llvm-project?rev=264660&view=rev
Log:
Don't try to actually run code when the expression is top-level.
Modified:
lldb/trunk/source/Expression/UserExpression.cpp
Modified: lldb/trunk/source/Expressi
Author: spyffe
Date: Mon Mar 28 16:20:05 2016
New Revision: 264662
URL: http://llvm.org/viewvc/llvm-project?rev=264662&view=rev
Log:
Expose top-level Clang expressions via the command line and the API.
Top-level Clang expressions are expressions that act as new translation units,
and define their
N.b., the Clang ASTImporter fixes for this went in as r264669. Make sure Clang
has this fix if your testcases are failing.
Sean
> On Mar 28, 2016, at 2:20 PM, Sean Callanan via lldb-commits
> wrote:
>
> Author: spyffe
> Date: Mon Mar 28 16:20:05 2016
> New Revision: 264
Author: spyffe
Date: Tue Mar 29 22:44:51 2016
New Revision: 264821
URL: http://llvm.org/viewvc/llvm-project?rev=264821&view=rev
Log:
Don't register the addresses of private symbols from expressions.
They're not supposed to go in the symbol table, and in fact the way the JIT
is currently implement
Author: spyffe
Date: Wed Mar 30 15:17:41 2016
New Revision: 264914
URL: http://llvm.org/viewvc/llvm-project?rev=264914&view=rev
Log:
Fixed a problem where a dSYM wasn't properly found because it had the wrong name
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-static-me
Hurray for the Android g++ bot!
Sean
> On Apr 13, 2016, at 6:23 PM, Enrico Granata via lldb-commits
> wrote:
>
> Author: enrico
> Date: Wed Apr 13 20:23:01 2016
> New Revision: 266271
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266271&view=rev
> Log:
> Don't use auto - (try to) appease t
Author: spyffe
Date: Thu Apr 14 19:05:50 2016
New Revision: 266389
URL: http://llvm.org/viewvc/llvm-project?rev=266389&view=rev
Log:
Added a testcase for defining and using a block in the expression parser.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/blocks/TestBlocks.py
Mod
Author: spyffe
Date: Thu Apr 14 19:26:32 2016
New Revision: 266397
URL: http://llvm.org/viewvc/llvm-project?rev=266397&view=rev
Log:
Added a testcase for defining and using lambdas in the expression parser.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/lambdas/
lldb/trunk/pa
Author: spyffe
Date: Thu Apr 14 19:44:59 2016
New Revision: 266400
URL: http://llvm.org/viewvc/llvm-project?rev=266400&view=rev
Log:
Blocks are only reliably supported on Darwin. Disable the test otherwise.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/blocks/TestBlocks.py
Modi
spyffe added a comment.
It looks like this patch does not use "language" to determine which language
the expression parser runs in, but rather to allow lookups specifically of "id"
and "Class" if the current frame is not Objective-C++. Is that correct?
http://reviews.llvm.org/D11790
__
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Ooh, I'm reading the patch at the beginning of ClangUserExpression::Evaluate
again and it does look like this patch sets language based on the language of
the containing frame, and t
spyffe added a subscriber: spyffe.
spyffe added a comment.
I totally agree that Objective-C shouldn’t be part of the default on non-Apple
platforms.
The way I imagine this working is that your current frame’s language gets
“upgraded” – for the Clang expression parser, at least to something that
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
This looks great to me. Thank you!
http://reviews.llvm.org/D11543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
spyffe added a comment.
I looked at this with Jim, and once his suggestions are applied this patch is
fine. Thanks for working with us on it.
I want to follow up and make non-Apple platforms not force ObjC (it doesn't
matter for making the expression parser work).
http://reviews.llvm.org/D111
Author: spyffe
Date: Tue Sep 1 12:58:03 2015
New Revision: 246562
URL: http://llvm.org/viewvc/llvm-project?rev=246562&view=rev
Log:
Add a predicate to allow a ClangASTContext to identify Clang types.
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
Modified: lldb/trunk/include/lld
Author: spyffe
Date: Tue Sep 1 13:00:35 2015
New Revision: 246563
URL: http://llvm.org/viewvc/llvm-project?rev=246563&view=rev
Log:
When looking up types, find the first type we can import rather than just taking
the first type we find and failing if it can't be imported.
Modified:
lldb/trun
Author: spyffe
Date: Wed Sep 2 11:39:23 2015
New Revision: 24
URL: http://llvm.org/viewvc/llvm-project?rev=24&view=rev
Log:
Improved logging for deported types in the ClangASTImporter.
Modified:
lldb/trunk/source/Symbol/ClangASTImporter.cpp
Modified: lldb/trunk/source/Symbol/ClangAS
Author: spyffe
Date: Wed Sep 2 11:40:59 2015
New Revision: 246667
URL: http://llvm.org/viewvc/llvm-project?rev=246667&view=rev
Log:
Removed comments that suggested that asserts in the ClangASTImporter should be
debug-only. This is not the case; when they fire we are about to crash or do
somethin
Author: spyffe
Date: Wed Sep 2 11:49:14 2015
New Revision: 246674
URL: http://llvm.org/viewvc/llvm-project?rev=246674&view=rev
Log:
Added an ExpressionParser plugin skeleton with nothing in it (yet).
Added:
lldb/trunk/source/Plugins/ExpressionParser/
Modified:
lldb/trunk/lldb.xcodeproj/p
Author: spyffe
Date: Wed Sep 2 11:59:02 2015
New Revision: 246677
URL: http://llvm.org/viewvc/llvm-project?rev=246677&view=rev
Log:
Added a skeleton plugin for the Clang expression parser, so I can start
factoring stuff into it.
Added:
lldb/trunk/source/Plugins/ExpressionParser/Clang/
Modif
Author: spyffe
Date: Wed Sep 2 19:35:46 2015
New Revision: 246737
URL: http://llvm.org/viewvc/llvm-project?rev=246737&view=rev
Log:
In preparation for factoring persistent variables into a generic part and a
Clang-specific part, create the ExpressionVariable source/header file and
move ClangExpre
Author: spyffe
Date: Wed Sep 2 19:48:23 2015
New Revision: 246738
URL: http://llvm.org/viewvc/llvm-project?rev=246738&view=rev
Log:
Jim told me about a cleaner way to include headers from plug-ins.
This is still something I need to fix, but at least it's not so ugly, and it's
consistent with the
spyffe accepted this revision.
spyffe added a comment.
Looks good to me. Thanks, Dawn.
Repository:
rL LLVM
http://reviews.llvm.org/D11102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
spyffe created this revision.
spyffe added a reviewer: jingham.
spyffe added a subscriber: lldb-commits.
spyffe set the repository for this revision to rL LLVM.
This patch separates the generic portion of ClangExpressionVariable, which
stores information about a variable that different parts of L
spyffe added a comment.
What is up with the name such that we have to look for its demangled version?
Can you provide an example where this search would be required?
http://reviews.llvm.org/D12613
___
lldb-commits mailing list
lldb-commits@lists.l
spyffe removed rL LLVM as the repository for this revision.
spyffe updated this revision to Diff 33986.
spyffe added a comment.
Removed ClangExpressionVariable from the friend list for ValueObject.
http://reviews.llvm.org/D12602
Files:
include/lldb/Core/ValueObject.h
include/lldb/Expression
spyffe updated this revision to Diff 34004.
spyffe added a comment.
According to Jim's suggestions, made CreateVariableInList return a
ClangExpressionVariable * rather than a ExpressionVariableSP. Also made
ExpressionVariable be able to get a shared pointer from itself, so that the few
cases t
spyffe added a comment.
Working on that now. I have to be careful not just to stuff
ClangExpressionVariable* into ExpressionVariableSP, but to use
shared_from_this, otherwise I get crashes in the testsuite. I'll update this
patch once I get that cleaned up.
http://reviews.llvm.org/D12602
spyffe updated this revision to Diff 34055.
spyffe added a comment.
Applied Jim's suggestion that FindVariableInList return a
ClangExpressionVariable *. Also fixed some places where we should have called
shared_from_this instead of creating a new shared pointer.
http://reviews.llvm.org/D12602
spyffe updated this revision to Diff 34061.
spyffe added a comment.
Added a newline to the end of ExpressionVariable.cpp
http://reviews.llvm.org/D12602
Files:
include/lldb/Core/ValueObject.h
include/lldb/Expression/ClangExpressionDeclMap.h
include/lldb/Expression/ClangFunction.h
include
Author: spyffe
Date: Fri Sep 4 15:49:51 2015
New Revision: 246871
URL: http://llvm.org/viewvc/llvm-project?rev=246871&view=rev
Log:
This patch separates the generic portion of ClangExpressionVariable, which
stores information about a variable that different parts of LLDB use, from the
compiler-sp
Author: spyffe
Date: Fri Sep 4 15:54:25 2015
New Revision: 246872
URL: http://llvm.org/viewvc/llvm-project?rev=246872&view=rev
Log:
I accidentally committed some project-file changes. Undid those.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/lldb.xcodeproj/xcshareddata
Author: spyffe
Date: Tue Sep 8 17:23:39 2015
New Revision: 247085
URL: http://llvm.org/viewvc/llvm-project?rev=247085&view=rev
Log:
ExpressionVariable now uses llvm::cast() instead of As...() for RTTI.
As part of our overall switch from hand-rolling RTTI to using LLVM-compatible
methods, I've don
spyffe requested changes to this revision.
spyffe added a comment.
I LOVE the idea of getting rid of those horrid "alternate manglings." We knew
what the mangling was during name lookup, we should be able to recognize them
later!
As listed in my inline comments, I have some concerns about the s
Author: spyffe
Date: Mon Sep 14 16:03:44 2015
New Revision: 247615
URL: http://llvm.org/viewvc/llvm-project?rev=247615&view=rev
Log:
ClangExpressionDeclMap should only disable the Clang parser-specific state on
Clang persistent variables.
Modified:
lldb/trunk/source/Expression/ClangExpression
Dawn,
this breaks the OS X Xcode build because it can’t find
“../lib/Support/regex_impl.h”.
I only see that header in llvm/lib, but so far lldb-mi hasn’t had any LLVM
dependencies and it doesn’t even have the right header search paths in Xcode.
Should we be adding the LLVM headers as search pa
Sure. What about the LLVM libraries – right now after fixing the header issues
I’m getting link errors:
Undefined symbols for architecture x86_64:
"_llvm_regcomp", referenced from:
MIUtilParse::CRegexParser::CRegexParser(char const*) in MIUtilParse.o
"_llvm_regexec", referenced from:
Author: spyffe
Date: Thu Sep 17 13:03:26 2015
New Revision: 247909
URL: http://llvm.org/viewvc/llvm-project?rev=247909&view=rev
Log:
Updated the Xcode build to reflect lldb-mi's dependency on LLVM.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/projec
$ svn commit
Sendinglldb.xcodeproj/project.pbxproj
Transmitting file data .
Committed revision 247909.
> On Sep 17, 2015, at 10:53 AM, d...@burble.org wrote:
>
> On Thu, Sep 17, 2015 at 10:49:22AM -0700, Sean Callanan wrote:
>> Sure. What about the LLVM libraries ??? right now after fixi
Author: spyffe
Date: Thu Sep 17 13:19:12 2015
New Revision: 247910
URL: http://llvm.org/viewvc/llvm-project?rev=247910&view=rev
Log:
Removed a needless cast to ClangExpressionVariable.
Modified:
lldb/trunk/source/Expression/Materializer.cpp
Modified: lldb/trunk/source/Expression/Materializer
spyffe created this revision.
spyffe added a reviewer: clayborg.
spyffe added a subscriber: lldb-commits.
When running the testsuite, the LLDB shlib is a symlink to its actual location,
so finding shlib-relative resources can be problematic. This patch fixes that
by resolving symlinks.
http://
spyffe updated this revision to Diff 35138.
spyffe added a comment.
Updated to reflect Greg's comments.
http://reviews.llvm.org/D12984
Files:
include/lldb/Host/FileSpec.h
source/Host/common/FileSpec.cpp
source/Host/common/HostInfoBase.cpp
Index: source/Host/common/HostInfoBase.cpp
==
Author: spyffe
Date: Fri Sep 18 16:39:31 2015
New Revision: 248048
URL: http://llvm.org/viewvc/llvm-project?rev=248048&view=rev
Log:
Added support for resolving symbolic links to FileSpec.
We use the symbolic link to resolver to find the target of the LLDB shlib
symlink if there is a symlink. Th
Sure. On it.
Sean
> On Sep 18, 2015, at 2:44 PM, Zachary Turner wrote:
>
> zturner added a comment.
>
> Furthermore, FileSpec can refer to a remote path, so you can't even
> guarantee that the OS you're on is the same OS as that which the path
> refers to. So another reason why putting this
spyffe added a subscriber: spyffe.
spyffe added a comment.
Sure. On it.
Sean
http://reviews.llvm.org/D12984
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
spyffe added a reviewer: zturner.
spyffe removed a subscriber: zturner.
spyffe updated this revision to Diff 35143.
spyffe added a comment.
At zturner's suggestion, moved the function to FileSystem and renamed it to be
more consistent with what other FileSystem functions are called.
http://revi
spyffe updated this revision to Diff 35144.
spyffe added a comment.
Restored the old name based on zturner's suggestion that Realpath() is too
specific and has semantics that Windows wouldn't honor.
http://reviews.llvm.org/D12984
Files:
include/lldb/Host/FileSpec.h
include/lldb/Host/FileSy
Author: spyffe
Date: Fri Sep 18 17:24:57 2015
New Revision: 248055
URL: http://llvm.org/viewvc/llvm-project?rev=248055&view=rev
Log:
Moved ResolveSymbolicLink() to the FileSystem where it belongs, thanks
zturner!
http://reviews.llvm.org/D12984
Modified:
lldb/trunk/include/lldb/Host/FileSpec.
Author: spyffe
Date: Fri Sep 25 17:47:07 2015
New Revision: 248631
URL: http://llvm.org/viewvc/llvm-project?rev=248631&view=rev
Log:
Moved ClangExpressionHelper.h into the Clang expression parser plug-in.
Added:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionHelper.h
-
201 - 260 of 260 matches
Mail list logo
