[Lldb-commits] [lldb] e56ba37 - build: make standalone builds work again

2019-10-29 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-10-29T08:24:10-07:00 New Revision: e56ba3743bcc344c51be9d919c32ec8f88ddef44 URL: https://github.com/llvm/llvm-project/commit/e56ba3743bcc344c51be9d919c32ec8f88ddef44 DIFF: https://github.com/llvm/llvm-project/commit/e56ba3743bcc344c51be9d919c32ec8f88ddef44.

[Lldb-commits] [lldb] 5e029c4 - DebugServer: be more lenient about the target triple

2019-10-30 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-10-30T12:08:29-07:00 New Revision: 5e029c4cfd7b8db269b6db475ecd420311fbd7d1 URL: https://github.com/llvm/llvm-project/commit/5e029c4cfd7b8db269b6db475ecd420311fbd7d1 DIFF: https://github.com/llvm/llvm-project/commit/5e029c4cfd7b8db269b6db475ecd420311fbd7d1.

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

2019-08-04 Thread Saleem Abdulrasool via lldb-commits
On Wed, Jul 31, 2019 at 11:29 AM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > > > On Jul 31, 2019, at 10:57 AM, Raphael Isemann > wrote: > > > > It seems that patch is lacking a test (which doesn't seem too hard to > provide). > > I am not the original author of this pa

[Lldb-commits] [lldb] r369307 - Windows: Include "windows" Instead of "Windows"

2019-08-19 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Aug 19 15:45:01 2019 New Revision: 369307 URL: http://llvm.org/viewvc/llvm-project?rev=369307&view=rev Log: Windows: Include "windows" Instead of "Windows" The actual include directory is lldb/Host/windows not lldb/Host/Windows which breaks on case sensitive file system

[Lldb-commits] [lldb] r369788 - Windows: explicitly cast constants to `DWORD`

2019-08-23 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri Aug 23 10:58:53 2019 New Revision: 369788 URL: http://llvm.org/viewvc/llvm-project?rev=369788&view=rev Log: Windows: explicitly cast constants to `DWORD` STATUS_SINGLE_STEP and STATUS_BREAKPOINT are defined as 0x8-- which is negative and thus can't be implicitly nar

[Lldb-commits] [lldb] r372788 - Host: use the platform identifiers from LLVM (NFC)

2019-09-24 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue Sep 24 15:55:44 2019 New Revision: 372788 URL: http://llvm.org/viewvc/llvm-project?rev=372788&view=rev Log: Host: use the platform identifiers from LLVM (NFC) Use symbolic constants for the platform identifiers rather than replicating them locally. Modified: lldb/t

[Lldb-commits] [lldb] r359738 - lldb-server: remove link against lldbInterpreter

2019-05-01 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed May 1 16:06:45 2019 New Revision: 359738 URL: http://llvm.org/viewvc/llvm-project?rev=359738&view=rev Log: lldb-server: remove link against lldbInterpreter This dependency is unused. Remove the extraneous link. Modified: lldb/trunk/tools/lldb-server/CMakeLists.txt

[Lldb-commits] [lldb] r359810 - Initialization: remove ObjectContainer from Common

2019-05-02 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu May 2 11:11:44 2019 New Revision: 359810 URL: http://llvm.org/viewvc/llvm-project?rev=359810&view=rev Log: Initialization: remove ObjectContainer from Common This restructures the initialization path to move the ObjectContainer initialization into the *full* initializa

[Lldb-commits] [lldb] r359811 - gdb-remote: reduce some inclusion of Target/Process.h

2019-05-02 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu May 2 11:15:03 2019 New Revision: 359811 URL: http://llvm.org/viewvc/llvm-project?rev=359811&view=rev Log: gdb-remote: reduce some inclusion of Target/Process.h Reduce the inclusion of Target/Process.h to help isolate why Process is being preserved during the build of

[Lldb-commits] [lldb] r359816 - gdb-remote: fix the build on Windows

2019-05-02 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu May 2 12:09:58 2019 New Revision: 359816 URL: http://llvm.org/viewvc/llvm-project?rev=359816&view=rev Log: gdb-remote: fix the build on Windows Windows does not have a definition for `mode_t`. Include the appropriate header. Modified: lldb/trunk/source/Plugins/Pr

[Lldb-commits] [lldb] r359817 - Initialization: correct macro usage

2019-05-02 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu May 2 12:25:18 2019 New Revision: 359817 URL: http://llvm.org/viewvc/llvm-project?rev=359817&view=rev Log: Initialization: correct macro usage `_MSC_VER` indiciates that you are building with MSVC, not that you are building for Windows. Use `_WIN32` (which identifies

[Lldb-commits] [lldb] r359832 - Initialization: move InstructionEmulation to full initialization

2019-05-02 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu May 2 14:49:29 2019 New Revision: 359832 URL: http://llvm.org/viewvc/llvm-project?rev=359832&view=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need to use the instruction emulation. This helps reduce the size of t

[Lldb-commits] [lldb] r359944 - ExpressionParser: only force link MCJIT when needed

2019-05-03 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri May 3 16:19:27 2019 New Revision: 359944 URL: http://llvm.org/viewvc/llvm-project?rev=359944&view=rev Log: ExpressionParser: only force link MCJIT when needed This was added to support FreeBSD. The inclusion of this header increases the size of `lldb-server` due to MC

[Lldb-commits] [lldb] r360067 - Initialization: move InstructionEmulation to full initialization

2019-05-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon May 6 12:38:24 2019 New Revision: 360067 URL: http://llvm.org/viewvc/llvm-project?rev=360067&view=rev Log: Initialization: move InstructionEmulation to full initialization The debug server does not need to use the instruction emulation. This helps reduce the size of th

[Lldb-commits] [lldb] r360693 - lldb-server: rename `llgs::terminate` (NFC)

2019-05-14 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue May 14 10:07:36 2019 New Revision: 360693 URL: http://llvm.org/viewvc/llvm-project?rev=360693&view=rev Log: lldb-server: rename `llgs::terminate` (NFC) `terminate` overlaps with a C function on Windows: ``` D:\a\1\s\lldb\tools\lldb-server\lldb-server.cpp(45,13): warni

[Lldb-commits] [lldb] r360695 - build: use the correct variable

2019-05-14 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue May 14 10:24:45 2019 New Revision: 360695 URL: http://llvm.org/viewvc/llvm-project?rev=360695&view=rev Log: build: use the correct variable Adjust the variable that controls whether the unit tests use `lldb-server`. This should repair the default build on Windows. Modi

[Lldb-commits] [lldb] r360745 - Revert "build: use the correct variable"

2019-05-14 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue May 14 20:57:07 2019 New Revision: 360745 URL: http://llvm.org/viewvc/llvm-project?rev=360745&view=rev Log: Revert "build: use the correct variable" This reverts commit b5a8abd57f23e2f621d5ceb0f64f1bb8f9579c3f. This should not be needed as the lldb-server tool will add

[Lldb-commits] [lldb] r361210 - lldb-server: LLGS: support 32-bit on 64-bit hosts

2019-05-20 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon May 20 18:25:48 2019 New Revision: 361210 URL: http://llvm.org/viewvc/llvm-project?rev=361210&view=rev Log: lldb-server: LLGS: support 32-bit on 64-bit hosts Enable the ARM emulation support on AArch64 which can execute ARM32 code. Similarly, handle MIPS 32 on 64. Modi

[Lldb-commits] [lldb] r361443 - Expression: correct relocation model for Windows

2019-05-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed May 22 16:23:39 2019 New Revision: 361443 URL: http://llvm.org/viewvc/llvm-project?rev=361443&view=rev Log: Expression: correct relocation model for Windows The Windows Code Generation model cannot generation code with the PIC relocation model - all code is implicitly p

[Lldb-commits] [lldb] r361915 - build: only search for the needed python type

2019-05-28 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue May 28 19:26:29 2019 New Revision: 361915 URL: http://llvm.org/viewvc/llvm-project?rev=361915&view=rev Log: build: only search for the needed python type Windows has different types of runtime libraries which are ABI incompatible with one another. This requires that th

[Lldb-commits] [lldb] r362961 - ABI: reflow the table text (NFC)

2019-06-10 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Jun 10 09:32:33 2019 New Revision: 362961 URL: http://llvm.org/viewvc/llvm-project?rev=362961&view=rev Log: ABI: reflow the table text (NFC) Reflow the text for the table to make the table legible. This is purely cosmetic, but makes understanding the contents of the ta

[Lldb-commits] [lldb] r365155 - Plugins: permit building on Windows ARM64

2019-07-04 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Jul 4 12:26:49 2019 New Revision: 365155 URL: http://llvm.org/viewvc/llvm-project?rev=365155&view=rev Log: Plugins: permit building on Windows ARM64 Rather than relying on `sizeof(void *)` to determine the architecture, use the `CMAKE_SYSTEM_PROCESSOR` variable. This

[Lldb-commits] [lldb] r365282 - Process: generalise Windows thread setup

2019-07-07 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Jul 7 10:58:11 2019 New Revision: 365282 URL: http://llvm.org/viewvc/llvm-project?rev=365282&view=rev Log: Process: generalise Windows thread setup The Windows build currently cannot support debugging foreign targets or debugging Windows ARM NT and Windows ARM64 target

[Lldb-commits] [lldb] r366639 - build: allow the user to specify `llvm-tblgen`

2019-07-20 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sat Jul 20 10:59:08 2019 New Revision: 366639 URL: http://llvm.org/viewvc/llvm-project?rev=366639&view=rev Log: build: allow the user to specify `llvm-tblgen` This follows the same pattern as Clang and permits the user to specify the tablegen to use via `-DLLVM_TABLEGEN=`.

[Lldb-commits] [lldb] 7c8fa95 - lldb: use the newer `find_package` if available

2020-04-28 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2020-04-29T03:54:33Z New Revision: 7c8fa95395e719f9a2c211ee0f574ac9ef88a19d URL: https://github.com/llvm/llvm-project/commit/7c8fa95395e719f9a2c211ee0f574ac9ef88a19d DIFF: https://github.com/llvm/llvm-project/commit/7c8fa95395e719f9a2c211ee0f574ac9ef88a19d.diff

[Lldb-commits] [lldb] 4ec7bb4 - Symbol: use elaborated types for `DataExtractor`

2019-12-07 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-07T11:23:25-08:00 New Revision: 4ec7bb42aa67b8a03a9be497dd44195990c3ac74 URL: https://github.com/llvm/llvm-project/commit/4ec7bb42aa67b8a03a9be497dd44195990c3ac74 DIFF: https://github.com/llvm/llvm-project/commit/4ec7bb42aa67b8a03a9be497dd44195990c3ac74.

[Lldb-commits] [lldb] 2046d72 - build: improve python checks for Windows

2019-12-22 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-22T13:57:46-08:00 New Revision: 2046d72e91670114625c87e122db6e013ba089d5 URL: https://github.com/llvm/llvm-project/commit/2046d72e91670114625c87e122db6e013ba089d5 DIFF: https://github.com/llvm/llvm-project/commit/2046d72e91670114625c87e122db6e013ba089d5.

[Lldb-commits] [lldb] b449d19 - build: use `find_package(Python3)` rather than `PYTHON_HOME`

2019-12-22 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-22T20:47:25-08:00 New Revision: b449d19e55888ab9554b04184c6d9716389820fd URL: https://github.com/llvm/llvm-project/commit/b449d19e55888ab9554b04184c6d9716389820fd DIFF: https://github.com/llvm/llvm-project/commit/b449d19e55888ab9554b04184c6d9716389820fd.

[Lldb-commits] [lldb] 4b0563f - test: correct flags for Windows

2019-12-23 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-23T20:21:26-08:00 New Revision: 4b0563f89f939f2160002298d5491a8fc8ee1137 URL: https://github.com/llvm/llvm-project/commit/4b0563f89f939f2160002298d5491a8fc8ee1137 DIFF: https://github.com/llvm/llvm-project/commit/4b0563f89f939f2160002298d5491a8fc8ee1137.

[Lldb-commits] [lldb] 64c6bb3 - test: ensure that we dead-strip in the linker

2019-12-24 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-12-24T10:19:22-08:00 New Revision: 64c6bb37832c2139a91801fece96de8898151079 URL: https://github.com/llvm/llvm-project/commit/64c6bb37832c2139a91801fece96de8898151079 DIFF: https://github.com/llvm/llvm-project/commit/64c6bb37832c2139a91801fece96de8898151079.

[Lldb-commits] [lldb] fb170fd - tests: XFAIL/UNSUPPORTED tests on Windows

2020-01-01 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2020-01-01T14:22:49-08:00 New Revision: fb170fd652bf2fcc4c2cd54aaf384591d8df266b URL: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b DIFF: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b.

[Lldb-commits] [lldb] abb0075 - build: reduce CMake handling for zlib

2020-01-02 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2020-01-02T11:19:12-08:00 New Revision: abb00753069554c538f3d850897373d093389945 URL: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945 DIFF: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945.

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-24 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/106443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-24 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: Going to go ahead and merge this since there/s not been any additional feedback. https://github.com/llvm/llvm-project/pull/106443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] build: enable CONFIG mode search for LibXml2 for LLDB (PR #117615)

2024-11-25 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd created https://github.com/llvm/llvm-project/pull/117615 The `find_package(LibXml2 ...)` invocation that we are currently using precludes the use of "CONFIG mode" for libxml2. This is important to allow dependencies to flow through the build with static builds on Wi

[Lldb-commits] [lldb] [lldb] build: cleanup extraneous include paths (PR #117615)

2024-11-27 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/117615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] build: cleanup extraneous include paths (PR #117615)

2024-11-27 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/117615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] build: cleanup extraneous include paths (PR #117615)

2024-11-27 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/117615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [DebugInfo] Add explicit visibility macros to CodeView template functions (PR #113102)

2024-11-19 Thread Saleem Abdulrasool via lldb-commits
@@ -32,6 +32,19 @@ class SimpleTypeSerializer { ArrayRef serialize(const FieldListRecord &Record) = delete; }; +// Needed by RandomAccessVisitorTest.cpp +#define TYPE_RECORD(EnumName, EnumVal, Name) \ + class Name##Record;

[Lldb-commits] [lldb] [llvm] [DebugInfo] Add explicit visibility macros to CodeView template functions (PR #113102)

2024-11-19 Thread Saleem Abdulrasool via lldb-commits
@@ -495,7 +495,8 @@ class ClassRecord : public TagRecord { }; // LF_UNION -struct UnionRecord : public TagRecord { +class UnionRecord : public TagRecord { +public: compnerd wrote: Why the change here? The use of `struct` _should_ be fine. Or was it that there

[Lldb-commits] [lldb] [llvm] [DebugInfo] Add explicit visibility macros to CodeView template functions (PR #113102)

2024-11-19 Thread Saleem Abdulrasool via lldb-commits
@@ -50,6 +50,20 @@ class ContinuationRecordBuilder { std::vector end(TypeIndex Index); }; + +// Needed by RandomAccessVisitorTest.cpp +#define TYPE_RECORD(EnumName, EnumVal, Name) +#define TYPE_RECORD_ALIAS(EnumName, EnumVal, Name, AliasName) +#define MEMBER_RECORD(EnumName,

[Lldb-commits] [lldb] build: enable CONFIG mode search for LibXml2 for LLDB (PR #117615)

2024-11-26 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/117615 >From 16271991a157b7892cb3d0e914aac63f7659d41b Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Mon, 25 Nov 2024 11:21:17 -0800 Subject: [PATCH] build: clean up extraneous include paths Clean up some un

[Lldb-commits] [lldb] build: enable CONFIG mode search for LibXml2 for LLDB (PR #117615)

2024-11-26 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/117615 >From 0b7645656a9a79a496438f49c7906dead1319fe7 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Mon, 25 Nov 2024 11:21:17 -0800 Subject: [PATCH] build: enable CONFIG mode search for LibXml2 for LLDB The

[Lldb-commits] [lldb] build: enable CONFIG mode search for LibXml2 for LLDB (PR #117615)

2024-11-26 Thread Saleem Abdulrasool via lldb-commits
@@ -57,7 +57,17 @@ add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses support in LLDB" Curse add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in LLDB" LibLZMA LIBLZMA_FOUND) add_optional_dependency(LLDB_ENABLE_LUA "Enable Lua scripting support i

[Lldb-commits] [lldb] build: enable CONFIG mode search for LibXml2 for LLDB (PR #117615)

2024-11-26 Thread Saleem Abdulrasool via lldb-commits
@@ -57,7 +57,17 @@ add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses support in LLDB" Curse add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in LLDB" LibLZMA LIBLZMA_FOUND) add_optional_dependency(LLDB_ENABLE_LUA "Enable Lua scripting support i

[Lldb-commits] [lldb] build: remove extraneous search paths for LibXml2 (PR #117615)

2024-11-26 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/117615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use LLDB_LOG_ERROR in ObjectFilePECOFF.cpp (NFC) (PR #126972)

2025-02-12 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. Thanks for cleaning this up! https://github.com/llvm/llvm-project/pull/126972 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-07 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: UTF-8 is a multibyte encoding, and if there is existing content in the output string, the generated result may not be a valid string, if you passed in a buffer with `\xe0` and then convert the input of `a`, we would get something that is invalid. https://github.com/llvm/llvm-p

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-03 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: I think that a fully symbolicated stack trace would be very helpful. It might explain the reason for the precondition. https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

<    1   2