[Lldb-commits] [lldb] r345569 - Utility: fix cross-compilation from Linux to Windows

2018-10-29 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Oct 29 23:29:28 2018 New Revision: 345569 URL: http://llvm.org/viewvc/llvm-project?rev=345569&view=rev Log: Utility: fix cross-compilation from Linux to Windows Only attempt to link against Backtrace if it is found. Without this, trying to cross-compile to Windows woul

[Lldb-commits] [lldb] r348332 - gdb-remote: use elaborated type specifier for `Module`

2018-12-04 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue Dec 4 20:04:14 2018 New Revision: 348332 URL: http://llvm.org/viewvc/llvm-project?rev=348332&view=rev Log: gdb-remote: use elaborated type specifier for `Module` When building with MSVC, the type `Module` is ambiguous due to both the lldb_private and llvm namespaces be

[Lldb-commits] [lldb] r348556 - Host: remove Yield on Windows

2018-12-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Dec 6 16:31:34 2018 New Revision: 348556 URL: http://llvm.org/viewvc/llvm-project?rev=348556&view=rev Log: Host: remove Yield on Windows Windows provides a Yield function-like macro that allows a thread to yield the CPU. However, this conflicts with `Yield` in swift.

[Lldb-commits] [lldb] r333041 - build: use cmake to find the libedit content

2018-05-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue May 22 16:24:46 2018 New Revision: 333041 URL: http://llvm.org/viewvc/llvm-project?rev=333041&view=rev Log: build: use cmake to find the libedit content Use proper cmake techniques to detect where the libedit package resides. This allows for the use of libedit from an a

[Lldb-commits] [lldb] r333863 - Python: adjust the include directories

2018-06-03 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Jun 3 19:08:12 2018 New Revision: 333863 URL: http://llvm.org/viewvc/llvm-project?rev=333863&view=rev Log: Python: adjust the include directories Restructure the include search order to adjust for libedit. This ensures that the variables are not unused if they are not

[Lldb-commits] [lldb] r323363 - www: update lldb architecture doc

2018-01-24 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed Jan 24 11:00:08 2018 New Revision: 323363 URL: http://llvm.org/viewvc/llvm-project?rev=323363&view=rev Log: www: update lldb architecture doc ArchSpec was moved from Core to Utility, so I modified the docs to reflect that. Patch by Alex Langford ! Modified: lldb/t

[Lldb-commits] [lldb] r308489 - silence a couple of -Wqual-cast warning from GCC (NFC)

2017-07-19 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed Jul 19 08:46:21 2017 New Revision: 308489 URL: http://llvm.org/viewvc/llvm-project?rev=308489&view=rev Log: silence a couple of -Wqual-cast warning from GCC (NFC) Cast to `const uint8_t *` instead of `uint8_t *` to avoid the warning from GCC. EmulationStateARM.cpp:20

[Lldb-commits] [lldb] r311577 - ObjC: fix some -Wpedantic warnings by removing '; '

2017-08-23 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed Aug 23 10:00:14 2017 New Revision: 311577 URL: http://llvm.org/viewvc/llvm-project?rev=311577&view=rev Log: ObjC: fix some -Wpedantic warnings by removing ';' Remove some stray ';' that were in the source code. NFC. Modified: lldb/trunk/source/Plugins/Language/Obj

[Lldb-commits] [lldb] r311579 - Process: fix FXSAVE on x86

2017-08-23 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed Aug 23 10:23:12 2017 New Revision: 311579 URL: http://llvm.org/viewvc/llvm-project?rev=311579&view=rev Log: Process: fix FXSAVE on x86 The FXSAVE member `ftw` (FPU Tag Word) was given the wrong size (8-bit) instead of the correct width (16-bit) as per the x87 Programmer

Re: [Lldb-commits] [lldb] r311579 - Process: fix FXSAVE on x86

2017-08-23 Thread Saleem Abdulrasool via lldb-commits
This would be nice to merge to 5.0 IMO. It fixes reading the x87 FPU state. What do you think Greg? On Wed, Aug 23, 2017 at 10:24 AM Saleem Abdulrasool via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Wed Aug 23 10:23:12 2017 > New Revision:

[Lldb-commits] [lldb] r311582 - test: fix missed test

2017-08-23 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Wed Aug 23 11:05:19 2017 New Revision: 311582 URL: http://llvm.org/viewvc/llvm-project?rev=311582&view=rev Log: test: fix missed test I had built without python bindings and did not find this in the grep output. Adjust the test output for the printing format update. Modif

[Lldb-commits] [lldb] r312841 - Plugins: fix resolution ambiguity in PDB plugin

2017-09-08 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri Sep 8 17:13:49 2017 New Revision: 312841 URL: http://llvm.org/viewvc/llvm-project?rev=312841&view=rev Log: Plugins: fix resolution ambiguity in PDB plugin A clang change caused the inclusion of `llvm::Type` and `lldb_private::Type` to be pulled into the global namespac

Re: [Lldb-commits] LLGS for Free/NetBSD (was: Re: [PATCH] D25756: FreeBSD ARM support for software single step.)

2016-10-24 Thread Saleem Abdulrasool via lldb-commits
On Mon, Oct 24, 2016 at 11:38 AM, Ed Maste via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On 24 October 2016 at 06:26, Pavel Labath wrote: > > > > It's not my place to tell you how to work, but I'd recommend a > > different approach to this. If you base your work on the current > > Free

[Lldb-commits] [lldb] r250661 - Silence some -Wunused-but-set-variable with gcc 5.2.0

2015-10-18 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Oct 18 14:34:31 2015 New Revision: 250661 URL: http://llvm.org/viewvc/llvm-project?rev=250661&view=rev Log: Silence some -Wunused-but-set-variable with gcc 5.2.0 Cleanup some unused variables. NFC. Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstr

[Lldb-commits] [lldb] r250662 - Silence -Wqual-cast warnings from GCC 5.2

2015-10-18 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Oct 18 14:34:38 2015 New Revision: 250662 URL: http://llvm.org/viewvc/llvm-project?rev=250662&view=rev Log: Silence -Wqual-cast warnings from GCC 5.2 There were a number of const qualifiers being cast away which caused warnings. This cluttered the output hiding real err

[Lldb-commits] [lldb] r250667 - Silence -Wreturn-type with gcc 5.2

2015-10-18 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Oct 18 15:51:18 2015 New Revision: 250667 URL: http://llvm.org/viewvc/llvm-project?rev=250667&view=rev Log: Silence -Wreturn-type with gcc 5.2 The switch is fully covered, mark "default" as unreachable. NFC. Modified: lldb/trunk/source/DataFormatters/StringPrinter

[Lldb-commits] [lldb] r250673 - Python: follow python guidelines for header usage

2015-10-18 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Oct 18 20:16:17 2015 New Revision: 250673 URL: http://llvm.org/viewvc/llvm-project?rev=250673&view=rev Log: Python: follow python guidelines for header usage Python requires that Python.h is included before any std header. Not doing so results in conflicts with standar

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-04-30 Thread Saleem Abdulrasool via lldb-commits
compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149 @@ +148,3 @@ +{ +spec.SetTriple("armv7-pc-windows"); +specs.Append(Module

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

2016-05-02 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. The few lines above are for the x86, x86_64 targets, which traditionally use the pc vendor as a legacy label. http://reviews.llvm.org/D19604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [lldb] r268755 - debugserver: fix some -Wformat-pedantic warnings

2016-05-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri May 6 12:32:58 2016 New Revision: 268755 URL: http://llvm.org/viewvc/llvm-project?rev=268755&view=rev Log: debugserver: fix some -Wformat-pedantic warnings Perform explicit casts for the log message to address some `-Wformat-pedantic` warnings from clang. NFC. Modifi

[Lldb-commits] [lldb] r268756 - debugserver: fix a few -Wcovered-swift-default warnings

2016-05-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri May 6 12:33:01 2016 New Revision: 268756 URL: http://llvm.org/viewvc/llvm-project?rev=268756&view=rev Log: debugserver: fix a few -Wcovered-swift-default warnings Remove a couple of `default` cases from switches which are covered. This is beneficial since it would all

[Lldb-commits] [lldb] r268759 - debugserver; fix -Wunused-local-typedef, -Wunused-variable warnings

2016-05-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri May 6 12:33:13 2016 New Revision: 268759 URL: http://llvm.org/viewvc/llvm-project?rev=268759&view=rev Log: debugserver; fix -Wunused-local-typedef, -Wunused-variable warnings Remove the typedef and local structure which was unused. Fixes last of the new clang warnings

[Lldb-commits] [lldb] r268757 - debugserver: fix some -Wpessimizing-move warnings

2016-05-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri May 6 12:33:04 2016 New Revision: 268757 URL: http://llvm.org/viewvc/llvm-project?rev=268757&view=rev Log: debugserver: fix some -Wpessimizing-move warnings Remove the unnecessary use of std::move to permit the compiler to perform NVRO instead. Fixes more warnings fro

[Lldb-commits] [lldb] r268758 - debugserver: fix a couple of -Wmissing-field-initializers warnings

2016-05-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri May 6 12:33:09 2016 New Revision: 268758 URL: http://llvm.org/viewvc/llvm-project?rev=268758&view=rev Log: debugserver: fix a couple of -Wmissing-field-initializers warnings Explicitly provide an initializer for the std::vector in the constructed type. Addresses -Wmiss

[Lldb-commits] [lldb] r269598 - Fix a few -Wformat-pedantic warnings

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 13:18:13 2016 New Revision: 269598 URL: http://llvm.org/viewvc/llvm-project?rev=269598&view=rev Log: Fix a few -Wformat-pedantic warnings Clean up some newly introduced -Wformat-pedantic warnings (%p expects a void *). Modified: lldb/trunk/source/Core/Listen

[Lldb-commits] [lldb] r269599 - Symbol: fix -Wcovered-switch warning

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 13:18:16 2016 New Revision: 269599 URL: http://llvm.org/viewvc/llvm-project?rev=269599&view=rev Log: Symbol: fix -Wcovered-switch warning Add the Float128 type to the enumeration. Float128 is covered under IEEE754 as a quad precision floating point value. Modif

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. I don't think I can write code without clang-format anymore (so, yes, it is clang-formatted). http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] r269627 - test: add missing splat

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 22:13:08 2016 New Revision: 269627 URL: http://llvm.org/viewvc/llvm-project?rev=269627&view=rev Log: test: add missing splat The parameter here is a list, not a string. Ensure that the we splat the list into arguments prior to invoke os.path.join. This would pr

[Lldb-commits] [lldb] r269628 - test: remove use of undefined variables

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 22:13:12 2016 New Revision: 269628 URL: http://llvm.org/viewvc/llvm-project?rev=269628&view=rev Log: test: remove use of undefined variables The variables referenced in the print message are not defined. Simply state that the requisite script is not found. Corr

[Lldb-commits] [lldb] r269626 - test: add missing parameter

2016-05-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 15 22:13:05 2016 New Revision: 269626 URL: http://llvm.org/viewvc/llvm-project?rev=269626&view=rev Log: test: add missing parameter Add the missing required parameter to the function. This permits tests to get a bit further before failing. Modified: lldb/trunk

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-16 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. Zach is correct, this doesn't *remove* the Mutex and Condition types, merely starts reducing the easier uses of it. My thinking is to do this piecemeal, slowly reducing the local usage until the real uses remain in the cases where we need to actually change the structu

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-16 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. I ran it on Darwin while I was working on this. Ill run it on Linux once before I commit the first pass. http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-16 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. If you can run the test that would be wonderful. Im going to upload a slight update to this tonight that catches a few more of the trivial cases. I think minimizing the second pass is ideal since that is going to be much more involved (changing APIs and such). http

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-17 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. Ah, I just ran git-clang-format, and that found a few additional things. Incorporated that; Ill commit this tonight and hopefully have the second pass done soon. http://reviews.llvm.org/D20278 ___ lldb-commits mailing li

Re: [Lldb-commits] [PATCH] D20278: first pass for removing Mutex for std::{, recursive_}mutex

2016-05-17 Thread Saleem Abdulrasool via lldb-commits
compnerd closed this revision. compnerd added a comment. SVN r269877 http://reviews.llvm.org/D20278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

2016-05-18 Thread Saleem Abdulrasool via lldb-commits
compnerd marked 2 inline comments as done. Comment at: source/Interpreter/CommandObject.cpp:339 @@ -338,3 +338,3 @@ m_exe_ctx.Clear(); -m_api_locker.Unlock(); +m_api_locker.unlock(); } zturner wrote: > ``` > if (m_api_locker) > m_api_locker.unloc

Re: [Lldb-commits] [PATCH] D20351: second pass over removal of Mutex and Condition

2016-05-18 Thread Saleem Abdulrasool via lldb-commits
compnerd closed this revision. compnerd marked an inline comment as done. compnerd added a comment. SVN r270024. Repository: rL LLVM http://reviews.llvm.org/D20351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-05-19 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. Yeah, I was thinking that once this clean up is done, we should remove the use of TimeValue in favor of std::chrono::duration. Repository: rL LLVM http://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] r270377 - SymbolFile: remove an unused variable

2016-05-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun May 22 15:16:53 2016 New Revision: 270377 URL: http://llvm.org/viewvc/llvm-project?rev=270377&view=rev Log: SymbolFile: remove an unused variable Address a -Wunused-but-set-variable warning from gcc. NFC. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFA

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Saleem Abdulrasool via lldb-commits
compnerd added inline comments. Comment at: docs/Proposals/GitHub.rst:167 @@ +166,3 @@ +with the limited number of developers whose job will be to mainly merge +thousands of patches a day. + rengolin wrote: > compnerd wrote: > > I don't fully understand how this i

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-18 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. Ugh, yeah, I had forgotten about this. Ill try to get to this tonight/tomorrow. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:354-355 @@ -358,5 +353,4 @@ { -// Calculate absolute timeout value -TimeValue timeout = Ti

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-18 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. *hadn't Repository: rL LLVM https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Saleem Abdulrasool via lldb-commits
compnerd added inline comments. Comment at: docs/Proposals/GitHub.rst:127 @@ +126,3 @@ +* The projects' repositories will remain identical, with a new address (GitHub). +* They'll continue to have SVN RW access, but will also gain Git RW access. +* The linear history can still be

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-18 Thread Saleem Abdulrasool via lldb-commits
compnerd added a comment. Tested against Linux-x86_64, tests state seems unchanged across the patch. @zturner you want to run another round on Windows before I merge this? https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-26 Thread Saleem Abdulrasool via lldb-commits
compnerd added a subscriber: sas. compnerd added a comment. @emaste I think so. I was hoping that @zturner or @sas would be able to get a windows run. However, Linux and FreeBSD should give us some assurance that this is good. How about I go ahead and commit this tomorrow? https://reviews.l

[Lldb-commits] [lldb] r277013 - Host: correct use of std::condition_variable::wait_for

2016-07-28 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Jul 28 13:16:07 2016 New Revision: 277013 URL: http://llvm.org/viewvc/llvm-project?rev=277013&view=rev Log: Host: correct use of std::condition_variable::wait_for std::condition::wait_for takes a std::unique_lock. The previous commit accidentally left a reference to `m

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-28 Thread Saleem Abdulrasool via lldb-commits
compnerd closed this revision. compnerd added a comment. SVN r277011 https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r278774 - Symbol: add missing item in covered switch

2016-08-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Aug 15 23:12:36 2016 New Revision: 278774 URL: http://llvm.org/viewvc/llvm-project?rev=278774&view=rev Log: Symbol: add missing item in covered switch RenderScript was missing from the covered switch. Add it to avoid a warning of the missing entry. NFC. Modified:

[Lldb-commits] [lldb] r258547 - Target: fix -Wcast-qual warning

2016-01-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri Jan 22 14:26:32 2016 New Revision: 258547 URL: http://llvm.org/viewvc/llvm-project?rev=258547&view=rev Log: Target: fix -Wcast-qual warning We were unnecessarily stripping the const qualifier on the temporary variable. Restore the constness to avoid the warning. NFC.

[Lldb-commits] [lldb] r258546 - Silence -Wreturn-type warnings

2016-01-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri Jan 22 14:26:30 2016 New Revision: 258546 URL: http://llvm.org/viewvc/llvm-project?rev=258546&view=rev Log: Silence -Wreturn-type warnings Address a couple of instances of -Wreturn-type warning from GCC. The switches are covered, add an llvm_unreachable to the end of t

[Lldb-commits] [lldb] r258548 - Commands: silence dumb -Wextra warning from GCC

2016-01-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri Jan 22 14:26:34 2016 New Revision: 258548 URL: http://llvm.org/viewvc/llvm-project?rev=258548&view=rev Log: Commands: silence dumb -Wextra warning from GCC This is a rather unhelpful warning indicating that the ternary operator return types are mismatched, returning an

[Lldb-commits] [lldb] r258821 - Revert r258546.

2016-01-26 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue Jan 26 11:43:48 2016 New Revision: 258821 URL: http://llvm.org/viewvc/llvm-project?rev=258821&view=rev Log: Revert r258546. Seems that the patch was rebased on top of another change which obsoleted the change but wasnt caught. Thanks to nbjoerg for pointing this out!

Re: [Lldb-commits] [lldb] r258546 - Silence -Wreturn-type warnings

2016-01-26 Thread Saleem Abdulrasool via lldb-commits
On Sat, Jan 23, 2016 at 3:24 PM, Joerg Sonnenberger wrote: > On Fri, Jan 22, 2016 at 08:26:30PM -0000, Saleem Abdulrasool via > lldb-commits wrote: > > Author: compnerd > > Date: Fri Jan 22 14:26:30 2016 > > New Revision: 258546 > > > > URL: http://llvm.org

[Lldb-commits] [lldb] r260868 - ExpressionParser: silence some GCC warnings

2016-02-14 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sun Feb 14 21:23:14 2016 New Revision: 260868 URL: http://llvm.org/viewvc/llvm-project?rev=260868&view=rev Log: ExpressionParser: silence some GCC warnings Silence a -Wreorder warning about order of member initialization and a -Wqual-cast warning about casting away constnes

[Lldb-commits] [lldb] r260914 - Silence some clang warnings

2016-02-15 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Feb 15 15:50:28 2016 New Revision: 260914 URL: http://llvm.org/viewvc/llvm-project?rev=260914&view=rev Log: Silence some clang warnings Silences -Wmissing-brace and -Wformat-pedantic warnings from clang on Linux. NFC. Modified: lldb/trunk/source/Plugins/Language

[Lldb-commits] [lldb] r261612 - RenderScript: silence some -Wmissing-brace warnings

2016-02-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Mon Feb 22 22:56:31 2016 New Revision: 261612 URL: http://llvm.org/viewvc/llvm-project?rev=261612&view=rev Log: RenderScript: silence some -Wmissing-brace warnings Silence some -Wmissing-brace warnings on Linux with clang 3.7. Modified: lldb/trunk/source/Plugins/Langu

[Lldb-commits] [lldb] r265644 - Symbol: fix build

2016-04-06 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Apr 7 01:51:10 2016 New Revision: 265644 URL: http://llvm.org/viewvc/llvm-project?rev=265644&view=rev Log: Symbol: fix build TargetOptions is ambiguous due to a definition in LLVM and in clang. This was exposed by SVN r265640. Update to fix the build against the newe

[Lldb-commits] [lldb] r266042 - Process: fix the build with certain kernel versions

2016-04-11 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Tue Apr 12 00:40:51 2016 New Revision: 266042 URL: http://llvm.org/viewvc/llvm-project?rev=266042&view=rev Log: Process: fix the build with certain kernel versions The structure definitions are not provided, but we perform a sizeof operation of them which causes a build fai

[Lldb-commits] [lldb] r267000 - Host: fix some -Wformat-pedantic warnings

2016-04-21 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Apr 21 11:55:58 2016 New Revision: 267000 URL: http://llvm.org/viewvc/llvm-project?rev=267000&view=rev Log: Host: fix some -Wformat-pedantic warnings Add explicit casts for function pointer to void * for %p conversion. NFC. Modified: lldb/trunk/source/Host/macosx/

[Lldb-commits] [lldb] r267001 - API: fix a -Wunused-variable warning

2016-04-21 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Thu Apr 21 11:56:02 2016 New Revision: 267001 URL: http://llvm.org/viewvc/llvm-project?rev=267001&view=rev Log: API: fix a -Wunused-variable warning expr_log is only conditionally used via preprocessing. Ensure that we guard the definition accordingly. NFC. Modified:

[Lldb-commits] [PATCH] D19446: ObjectFile: parse EABI Attributes

2016-04-22 Thread Saleem Abdulrasool via lldb-commits
compnerd created this revision. compnerd added a reviewer: clayborg. compnerd added a subscriber: lldb-commits. compnerd set the repository for this revision to rL LLVM. This adds basic parsing of the EABI attributes section. This section contains additional information about the target for which

[Lldb-commits] [lldb] r267247 - Source: fix another -Wunused-variable warning

2016-04-22 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Fri Apr 22 18:08:34 2016 New Revision: 267247 URL: http://llvm.org/viewvc/llvm-project?rev=267247&view=rev Log: Source: fix another -Wunused-variable warning Conditionalise a variable definition which may be unused in certain compilations due to the preprocessor. Protect t

[Lldb-commits] [lldb] r267291 - ObjectFile: parse EABI Attributes

2016-04-23 Thread Saleem Abdulrasool via lldb-commits
Author: compnerd Date: Sat Apr 23 11:00:15 2016 New Revision: 267291 URL: http://llvm.org/viewvc/llvm-project?rev=267291&view=rev Log: ObjectFile: parse EABI Attributes This adds basic parsing of the EABI attributes section. This section contains additional information about the target for which

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse in lldb test utilities (PR #99934)

2024-07-22 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/99934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: android: fix missing Python import of urlparse in lldb test utilities (PR #99934)

2024-07-23 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd closed https://github.com/llvm/llvm-project/pull/99934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-01 Thread Saleem Abdulrasool via lldb-commits
@@ -97,7 +97,7 @@ class LLDB_API SBError { friend class lldb_private::ScriptInterpreter; friend class lldb_private::python::SWIGBridge; - SBError(const lldb_private::Status &error); + SBError(lldb_private::Status &&error); compnerd wrote: I agree with @

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-16 Thread Saleem Abdulrasool via lldb-commits
@@ -1,81 +1,59 @@ NDK_ROOT := $(shell dirname $(CC))/../../../../.. -ifeq "$(findstring 64, $(ARCH))" "64" - # lowest 64-bit API level - API_LEVEL := 21 -else ifeq "$(ARCH)" "i386" - # clone(2) declaration is present only since this api level - API_LEVEL

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-16 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/106443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-11 Thread Saleem Abdulrasool via lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = --

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-11 Thread Saleem Abdulrasool via lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-11 Thread Saleem Abdulrasool via lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-12 Thread Saleem Abdulrasool via lldb-commits
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() { return Status(); } + +const char *TargetThreadWindows::GetName() { + Log *log = GetLog(LLDBLog::Thread); + HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll"); + if (hModule) { +auto GetThreadDescription = +

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-12 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Define _BSD_SOURCE globally, to get optreset available in mingw's getopt.h (PR #76137)

2023-12-21 Thread Saleem Abdulrasool via lldb-commits
@@ -44,6 +44,10 @@ endif() if (WIN32) add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE) + if (NOT MSVC) compnerd wrote: clang-cl should be detected as MSVC. The define should be generally safe, but it is nice to be more precise and add it when needed.

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-27 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: Philosophically, I agree with this change. Enshrining the information about the line endings into the SCM tool makes sense. I think that the concern that I have is that do we have sufficient testing for supporting line-ending dependent behaviour in the compiler? Additionally, d

[Lldb-commits] [clang] [lldb] Revert "NFC: Make clang resource headers an interface library (#88317)" (PR #89266)

2024-04-18 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. Approving it in case it needs to be merged, but I think that we should try to determine how it is breaking. This change feels like it should be correct and is a pretty good cleanup, so I would prefer that fix forward rather than revert. h

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-04-25 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: > @compnerd I just realised I didn't respond to your concern. Apologies. > > > I think that the concern that I have is that do we have sufficient testing > > for supporting line-ending dependent behaviour in the compiler? > > For the first part: I don't know that it matters, si

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-04-25 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: > changes to `clang/test/CXX/lex/lex.literal/lex.string/p4.cpp` should be > reverted (it's a CRLF related test) This is the type of problems that I am concerned about. We certainly have some tests which are line-ending sensitive, and each test should be audited before we make

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-04-25 Thread Saleem Abdulrasool via lldb-commits
compnerd wrote: > Also, it's a bit funny to have .bat files without CRLF endings given that > they run on Windows. I'm not sure about the funny bit - but certainly dangerous. I've had cmd misinterpret batch files with LF vs CRLF. https://github.com/llvm/llvm-project/pull/86318 ___

[Lldb-commits] [lldb] f1585a4 - Windows: support `DoLoadImage`

2021-12-04 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2021-12-04T11:11:47-08:00 New Revision: f1585a4b47cc9c08c9a4c10058597f4b7468c227 URL: https://github.com/llvm/llvm-project/commit/f1585a4b47cc9c08c9a4c10058597f4b7468c227 DIFF: https://github.com/llvm/llvm-project/commit/f1585a4b47cc9c08c9a4c10058597f4b7468c227.

[Lldb-commits] [lldb] 906e60b - lldb: silence a warning on the Windows error path (NFCI)

2021-12-08 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2021-12-08T09:01:10-08:00 New Revision: 906e60b9f923464cba0f71a9205846550752162f URL: https://github.com/llvm/llvm-project/commit/906e60b9f923464cba0f71a9205846550752162f DIFF: https://github.com/llvm/llvm-project/commit/906e60b9f923464cba0f71a9205846550752162f.

[Lldb-commits] [lldb] b5491dd - ObjectFile: add a case for `EM_RISCV`

2022-03-04 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2022-03-04T21:54:20Z New Revision: b5491dd30792c1ad31bfc8e2f9d1809a79205234 URL: https://github.com/llvm/llvm-project/commit/b5491dd30792c1ad31bfc8e2f9d1809a79205234 DIFF: https://github.com/llvm/llvm-project/commit/b5491dd30792c1ad31bfc8e2f9d1809a79205234.diff

[Lldb-commits] [lldb] f52b5a8 - lldb/ObjectFile: reflow a comment (NFC)

2022-03-09 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2022-03-09T18:47:31Z New Revision: f52b5a852a4b4d48b9c049e68569cfdb184f11ab URL: https://github.com/llvm/llvm-project/commit/f52b5a852a4b4d48b9c049e68569cfdb184f11ab DIFF: https://github.com/llvm/llvm-project/commit/f52b5a852a4b4d48b9c049e68569cfdb184f11ab.diff

[Lldb-commits] [lldb] c604207 - lldb/ObjectFile, Disassembler: read some state from the executable

2022-03-10 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2022-03-10T21:42:06Z New Revision: c6042076081025bc8060637b05fbeb24dbb82538 URL: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538 DIFF: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538.diff

[Lldb-commits] [lldb] 2696d82 - Windows: correct iteration of additional search paths

2022-04-16 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2022-04-16T18:01:02-07:00 New Revision: 2696d82fa0c323d92d8794f0a34ea9619888fae9 URL: https://github.com/llvm/llvm-project/commit/2696d82fa0c323d92d8794f0a34ea9619888fae9 DIFF: https://github.com/llvm/llvm-project/commit/2696d82fa0c323d92d8794f0a34ea9619888fae9.

[Lldb-commits] [lldb] 16b7cf2 - SymbolFile: ensure that we have a value before invoking `getBitWidth`

2023-03-22 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-03-22T14:14:13-04:00 New Revision: 16b7cf245ec0ff5428daee4f71af62e1938bfc73 URL: https://github.com/llvm/llvm-project/commit/16b7cf245ec0ff5428daee4f71af62e1938bfc73 DIFF: https://github.com/llvm/llvm-project/commit/16b7cf245ec0ff5428daee4f71af62e1938bfc73.

[Lldb-commits] [lldb] d87cd45 - PECOFF: consume errors properly

2023-04-17 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-04-17T07:53:54-07:00 New Revision: d87cd45e4d855b57aed76dbd72c270ed152542ff URL: https://github.com/llvm/llvm-project/commit/d87cd45e4d855b57aed76dbd72c270ed152542ff DIFF: https://github.com/llvm/llvm-project/commit/d87cd45e4d855b57aed76dbd72c270ed152542ff.

[Lldb-commits] [lldb] ade3c6a - Host: generalise `GetXcodeSDKPath`

2023-04-28 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-04-28T09:30:59-07:00 New Revision: ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9 URL: https://github.com/llvm/llvm-project/commit/ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9 DIFF: https://github.com/llvm/llvm-project/commit/ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9.

[Lldb-commits] [lldb] 6bca093 - SymbolFile: invert condition, remove unnecessary `else` (NFC)

2023-05-05 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-05-05T07:31:19-07:00 New Revision: 6bca093976ef40f36a396b11a61a44dc0f4dcd13 URL: https://github.com/llvm/llvm-project/commit/6bca093976ef40f36a396b11a61a44dc0f4dcd13 DIFF: https://github.com/llvm/llvm-project/commit/6bca093976ef40f36a396b11a61a44dc0f4dcd13.

[Lldb-commits] [lldb] 039fc57 - ObjectFile: remove extraneous shadowed variable (NFCI)

2023-05-05 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-05-05T10:55:29-07:00 New Revision: 039fc57191980847afb6e674cac8bcbb6c1efa13 URL: https://github.com/llvm/llvm-project/commit/039fc57191980847afb6e674cac8bcbb6c1efa13 DIFF: https://github.com/llvm/llvm-project/commit/039fc57191980847afb6e674cac8bcbb6c1efa13.

[Lldb-commits] [lldb] 5014830 - ObjectFile: introduce a COFF object file plugin

2023-05-07 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-05-07T12:40:44-07:00 New Revision: 5014830ede78e55e2c638948ca00cea045eac9ce URL: https://github.com/llvm/llvm-project/commit/5014830ede78e55e2c638948ca00cea045eac9ce DIFF: https://github.com/llvm/llvm-project/commit/5014830ede78e55e2c638948ca00cea045eac9ce.

[Lldb-commits] [lldb] cd21c0d - Revert "Revert "Host: generalise `GetXcodeSDKPath`""

2023-05-29 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-05-29T10:16:41-07:00 New Revision: cd21c0d30c0803b24e1dcf71d2f04cb46e539905 URL: https://github.com/llvm/llvm-project/commit/cd21c0d30c0803b24e1dcf71d2f04cb46e539905 DIFF: https://github.com/llvm/llvm-project/commit/cd21c0d30c0803b24e1dcf71d2f04cb46e539905.

[Lldb-commits] [lldb] 6488bd1 - test: add a lit configuration for Windows subdirectory

2021-11-28 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2021-11-28T18:27:47-08:00 New Revision: 6488bd1d51715501632778e3c9a1d4eedfac2998 URL: https://github.com/llvm/llvm-project/commit/6488bd1d51715501632778e3c9a1d4eedfac2998 DIFF: https://github.com/llvm/llvm-project/commit/6488bd1d51715501632778e3c9a1d4eedfac2998.

[Lldb-commits] [lldb] [lldb] Fix missing comsumeError() with LLDB_LOG in ObjectFileCOFF/PECOFF (PR #70793)

2023-10-31 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/70793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

2020-04-06 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2020-04-06T17:37:57-07:00 New Revision: 3775be2d8e17aaeae62ab83ded005867f4bf70ac URL: https://github.com/llvm/llvm-project/commit/3775be2d8e17aaeae62ab83ded005867f4bf70ac DIFF: https://github.com/llvm/llvm-project/commit/3775be2d8e17aaeae62ab83ded005867f4bf70ac.

[Lldb-commits] [lldb] 92d42b3 - Utility: ignore OS version on non-Darwin targets in `ArchSpec`

2020-09-23 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2020-09-23T18:21:34-07:00 New Revision: 92d42b32a9b7a085fd200a56022724a77cf12a2d URL: https://github.com/llvm/llvm-project/commit/92d42b32a9b7a085fd200a56022724a77cf12a2d DIFF: https://github.com/llvm/llvm-project/commit/92d42b32a9b7a085fd200a56022724a77cf12a2d.

[Lldb-commits] [lldb] 55eec2b - build: workaround stale caches (NFC)

2019-10-29 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2019-10-29T08:20:58-07:00 New Revision: 55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 URL: https://github.com/llvm/llvm-project/commit/55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 DIFF: https://github.com/llvm/llvm-project/commit/55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6.

  1   2   >