[Lldb-commits] [lldb] r249020 - [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target

2015-10-01 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Thu Oct 1 10:05:31 2015 New Revision: 249020 URL: http://llvm.org/viewvc/llvm-project?rev=249020&view=rev Log: [LLDB][MIPS] Fix gp register value for o32 applications on 64-bit target GP registers for o32 applications were always giving zero value because SetType() on the

[Lldb-commits] [lldb] r249021 - Romove accidentially added statement in r249020

2015-10-01 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Thu Oct 1 10:15:42 2015 New Revision: 249021 URL: http://llvm.org/viewvc/llvm-project?rev=249021&view=rev Log: Romove accidentially added statement in r249020 Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified: lldb/trunk/source/Plugins/Obje

[Lldb-commits] [lldb] r250696 - [LLDB][MIPS] Use the correct ptrace buffer for writing register value for o32 applications

2015-10-19 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Mon Oct 19 06:21:20 2015 New Revision: 250696 URL: http://llvm.org/viewvc/llvm-project?rev=250696&view=rev Log: [LLDB][MIPS] Use the correct ptrace buffer for writing register value for o32 applications For o32 applications on mips we were getting segmentation fault while

[Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-12 Thread Sagar Thakur via lldb-commits
sagar created this revision. sagar added reviewers: clayborg, tberghammer. sagar added subscribers: nitesh.jain, jaydeep, bhushan, mohit.bhakkad, lldb-commits. sagar set the repository for this revision to rL LLVM. Herald added a subscriber: dsanders. This patch will clear bug 25194 - LLDB-Server

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-16 Thread Sagar Thakur via lldb-commits
sagar updated this revision to Diff 40256. sagar added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D14633 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp Index: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.c

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-16 Thread Sagar Thakur via lldb-commits
sagar added a comment. > Admittedly it's a bit unintuitive for an unsigned 32-bit value from a MIPS32 > binary to be represented in a 64-bit register as, for example, > 0x8000 but the debugger shouldn't normally admit to the existence > of the extra bits when debugging 32-bit code s

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-17 Thread Sagar Thakur via lldb-commits
sagar added a comment. Hi @tberghammer, I tried using RegisterValue::SetUInt() instead of RegisterValue::SetBytes(). When using RegisterValue::SetUInt() all register values we get are zero in case of mips32 big endian machine. The GDBRemoteCommunicationServerLLGS::SendStopReplyPacketForThread(

[Lldb-commits] [lldb] r253444 - [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS

2015-11-18 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Nov 18 02:12:34 2015 New Revision: 253444 URL: http://llvm.org/viewvc/llvm-project?rev=253444&view=rev Log: [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS Patch by Nitesh Jain Summary: The self.getArchitecture() returns the architecture based on the value of -A f

Re: [Lldb-commits] [PATCH] D14493: [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS

2015-11-18 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in r253444 on behalf of @nitesh.jain Repository: rL LLVM http://reviews.llvm.org/D14493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] r253445 - [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS

2015-11-18 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Nov 18 02:18:03 2015 New Revision: 253445 URL: http://llvm.org/viewvc/llvm-project?rev=253445&view=rev Log: [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS Patch by Nitesh Jain Summary: The break is opcode for breakpoint instruction. Subscribers: lldb-commits,

Re: [Lldb-commits] [PATCH] D14634: [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS

2015-11-18 Thread Sagar Thakur via lldb-commits
sagar added a comment. Committed in r253445 on behalf of @nitesh.jain Repository: rL LLVM http://reviews.llvm.org/D14634 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-18 Thread Sagar Thakur via lldb-commits
sagar added a comment. Hi, @tberghammer : For both mips32 and mips64 big endian 'T' packet response contains the register values in target byte order only. But for mips32 big endian when we set the value of the register in RegisterValue using RegisterValue::SetUInt() the upper half of the cont

[Lldb-commits] [lldb] r253555 - [LLDB][MIPS] Fix lldbplatformutil.py Failure

2015-11-19 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Thu Nov 19 05:01:21 2015 New Revision: 253555 URL: http://llvm.org/viewvc/llvm-project?rev=253555&view=rev Log: [LLDB][MIPS] Fix lldbplatformutil.py Failure Patch by Nitesh Jain Summary: This patch check whether first register is readable. Subscribers: lldb-commits, mohit

Re: [Lldb-commits] [PATCH] D14635: [LLDB][MIPS] Fix lldbplatformutil.py Failure

2015-11-19 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in r253555 on behalf of @nitesh.jain Repository: rL LLVM http://reviews.llvm.org/D14635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-23 Thread Sagar Thakur via lldb-commits
sagar added a comment. Hi, Could we use SetBytes for now for clearing the bug 25194? I have tried using SetBytes(), it does not cause any issue on MIPS for both endian. Once we have a new function to llvm::APInt to access actual data I will revert back to using SetUInt. Kindly let me know if y

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-26 Thread Sagar Thakur via lldb-commits
sagar updated this revision to Diff 41232. sagar added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D14633 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp Index: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cp

[Lldb-commits] [lldb] r254379 - [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-30 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Mon Nov 30 23:44:18 2015 New Revision: 254379 URL: http://llvm.org/viewvc/llvm-project?rev=254379&view=rev Log: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS This patch will clear bug 25194 - LLDB-Server Assertion raised when sing

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

2015-11-30 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 254379 Repository: rL LLVM http://reviews.llvm.org/D14633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r254850 - [LLDB][MIPS] Fix TestConstVariables.py

2015-12-05 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Sat Dec 5 06:01:48 2015 New Revision: 254850 URL: http://llvm.org/viewvc/llvm-project?rev=254850&view=rev Log: [LLDB][MIPS] Fix TestConstVariables.py Patch by Nitesh Jain. Summary: There is no debug information generated for variable index with –O3 optimization flag. The

Re: [Lldb-commits] [PATCH] D15224: [LLDB][MIPS] Fix TestConstVariables.py

2015-12-05 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 254850 on behalf of Nitesh Jain. Repository: rL LLVM http://reviews.llvm.org/D15224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] r255108 - [LLDB][MIPS] Adding call to IsMSAAvailable() while creating RegisterInfoInterface

2015-12-09 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Dec 9 06:31:01 2015 New Revision: 255108 URL: http://llvm.org/viewvc/llvm-project?rev=255108&view=rev Log: [LLDB][MIPS] Adding call to IsMSAAvailable() while creating RegisterInfoInterface This patch will fix the test case test_p_returns_correct_data_size_for_each_qR

[Lldb-commits] [lldb] r269181 - [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

2016-05-11 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed May 11 08:08:29 2016 New Revision: 269181 URL: http://llvm.org/viewvc/llvm-project?rev=269181&view=rev Log: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI Patch by Nitesh Jain. Summary: The ArchSpec::m_flags will be set based on ELF flag ABI. Reviewer

[Lldb-commits] [lldb] r269407 - [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-05-13 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 13 06:04:47 2016 New Revision: 269407 URL: http://llvm.org/viewvc/llvm-project?rev=269407&view=rev Log: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS Patch by Nitesh Jain. Summary: These patch will set clang::TargetOptions::A

[Lldb-commits] [lldb] r270207 - [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 20 07:07:27 2016 New Revision: 270207 URL: http://llvm.org/viewvc/llvm-project?rev=270207&view=rev Log: [LLDB][MIPS] Fix floating point handling in case of thread step-out Patch by Nitesh Jain. Summary: These patch fix thread step-out for hard and soft float. Revi

[Lldb-commits] [lldb] r270208 - [LLDB][MIPS] Fix Floating point Registers Encoding

2016-05-20 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri May 20 07:11:52 2016 New Revision: 270208 URL: http://llvm.org/viewvc/llvm-project?rev=270208&view=rev Log: [LLDB][MIPS] Fix Floating point Registers Encoding Patch by Nitesh Jain. Summary: Currently floating point regsiters has eEncodingUint encoding. Hence register

[Lldb-commits] [lldb] r270564 - [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-24 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Tue May 24 09:52:50 2016 New Revision: 270564 URL: http://llvm.org/viewvc/llvm-project?rev=270564&view=rev Log: [LLDB][MIPS] Fix floating point handling in case of thread step-out Patch by Nitesh Jain. Summary: These patch fix thread step-out for hard and soft float. Revi

Re: [Lldb-commits] [PATCH] D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-24 Thread Sagar Thakur via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270564: [LLDB][MIPS] Fix floating point handling in case of thread step-out (authored by slthakur). Changed prior to commit: http://reviews.llvm.org/D20416?vs=57739&id=58236#toc Repository: rL LLVM

[Lldb-commits] [lldb] r273535 - [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-22 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Thu Jun 23 01:40:37 2016 New Revision: 273535 URL: http://llvm.org/viewvc/llvm-project?rev=273535&view=rev Log: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions Patch by Nitesh Jain. This patch contains 2 changes: - Corrected target address calculatio

Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-22 Thread Sagar Thakur via lldb-commits
slthakur closed this revision. slthakur added a comment. Committed in http://reviews.llvm.org/rL273535 Repository: rL LLVM http://reviews.llvm.org/D21064 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] r274121 - [LLDB][MIPS] Check if libatomic needs to be specified explicitly

2016-06-29 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Jun 29 07:30:18 2016 New Revision: 274121 URL: http://llvm.org/viewvc/llvm-project?rev=274121&view=rev Log: [LLDB][MIPS] Check if libatomic needs to be specified explicitly Patch by Nitesh Jain. Summary : The problem appears while linking liblldb.so. The class Address

[Lldb-commits] [lldb] r255619 - [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

2015-12-14 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Mon Dec 14 23:50:55 2015 New Revision: 255619 URL: http://llvm.org/viewvc/llvm-project?rev=255619&view=rev Log: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets Patch by Nitesh Jain. Summary: This Patch will allowed LLDB to debug respec

Re: [Lldb-commits] [PATCH] D15487: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

2015-12-14 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 255619 on behalf of Nitesh Jain. Repository: rL LLVM http://reviews.llvm.org/D15487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D15884: [LLDB][MIPS] Make register read/write to set/get the size of register according to abi.

2016-01-04 Thread Sagar Thakur via lldb-commits
sagar created this revision. sagar added reviewers: clayborg, tberghammer. sagar added subscribers: jaydeep, bhushan, mohit.bhakkad, nitesh.jain, lldb-commits. sagar set the repository for this revision to rL LLVM. For O32 abi register size should be 4 bytes. For N32 and N64 abi register size sho

[Lldb-commits] [lldb] r256834 - [LLDB][MIPS] Make register read/write to set/get the size of register according to abi.

2016-01-05 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Tue Jan 5 08:03:45 2016 New Revision: 256834 URL: http://llvm.org/viewvc/llvm-project?rev=256834&view=rev Log: [LLDB][MIPS] Make register read/write to set/get the size of register according to abi. Summary: For O32 abi register size should be 4 bytes. For N32 and N64 abi

Re: [Lldb-commits] [PATCH] D15884: [LLDB][MIPS] Make register read/write to set/get the size of register according to abi.

2016-01-05 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar marked an inline comment as done. sagar added a comment. Committed in revision 256834 Repository: rL LLVM http://reviews.llvm.org/D15884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [lldb] r257587 - [LLDB][MIPS] Fix TestDisassembleRawData.py

2016-01-13 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Jan 13 05:22:56 2016 New Revision: 257587 URL: http://llvm.org/viewvc/llvm-project?rev=257587&view=rev Log: [LLDB][MIPS] Fix TestDisassembleRawData.py Patch by Nitesh Jain. Summary: This patch adds check for the correctness of disassembling instruction for MIPS target

Re: [Lldb-commits] [PATCH] D15915: [LLDB][MIPS] Fix TestDisassembleRawData.py

2016-01-13 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 257587 on behalf of Nitesh Jain. Repository: rL LLVM http://reviews.llvm.org/D15915 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] r258684 - [LLDB][MIPS] Fix TestExprsChar.py

2016-01-25 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Mon Jan 25 06:27:46 2016 New Revision: 258684 URL: http://llvm.org/viewvc/llvm-project?rev=258684&view=rev Log: [LLDB][MIPS] Fix TestExprsChar.py Patch by Nitesh Jain. Summary: When incorrect type used for 'char' then (at least) one of the expression evaluates to incorrec

Re: [Lldb-commits] [PATCH] D16132: [LLDB][MIPS] Fix TestExprsChar.py

2016-01-25 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 258684 Repository: rL LLVM http://reviews.llvm.org/D16132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r258685 - [LLDB][MIPS] Fix TestPrintStackTraces.py

2016-01-25 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Mon Jan 25 06:33:03 2016 New Revision: 258685 URL: http://llvm.org/viewvc/llvm-project?rev=258685&view=rev Log: [LLDB][MIPS] Fix TestPrintStackTraces.py Patch by Nitesh Jain. Summary: The thread_start function in libc doesn't contain any epilogue and prologue instructions

Re: [Lldb-commits] [PATCH] D16136: [LLDB][MIPS] Fix TestPrintStackTraces.py

2016-01-25 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 258685. Repository: rL LLVM http://reviews.llvm.org/D16136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] r262011 - [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-26 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Fri Feb 26 07:30:34 2016 New Revision: 262011 URL: http://llvm.org/viewvc/llvm-project?rev=262011&view=rev Log: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS Patch by Nitesh Jain. Summary: The debug version of libc.so is require for backtracing which may not be availabl

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-26 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 262011. Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D18853: [LLDB][MIPS] Fix Floating point Registers Encoding

2016-04-07 Thread Sagar Thakur via lldb-commits
sagar accepted this revision. sagar added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D18853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-18 Thread Sagar Thakur via lldb-commits
sagar added a comment. Hi, I have corrected the patch for Scalar which was reverted in r245222 and addressed all concerns raised (http://reviews.llvm.org/rL245216) by Pavel Labath. Could you please review it? Repository: rL LLVM http://reviews.llvm.org/D12100 ___

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-19 Thread Sagar Thakur via lldb-commits
sagar added inline comments. Comment at: include/lldb/Core/RegisterValue.h:185 @@ -190,1 +184,3 @@ +llvm::APInt +GetAsUInt128 (llvm::APInt& fail_value, bool *success_ptr = NULL) const; ovyalov wrote: > Could you pass fail_value as a const referen

[Lldb-commits] [lldb] r245927 - Fix build on mips

2015-08-25 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Tue Aug 25 04:52:59 2015 New Revision: 245927 URL: http://llvm.org/viewvc/llvm-project?rev=245927&view=rev Log: Fix build on mips Setting and getting register values as bytes instead of depending on the 128 bit integer support in register value. This patch will fix the bui

Re: [Lldb-commits] [PATCH] D12275: Fix build on mips

2015-08-25 Thread Sagar Thakur via lldb-commits
sagar added a comment. Hi Hans, I have committed it to the trunk in revision 245927. You can now merge it to the release branch. Thanks, Sagar Repository: rL LLVM http://reviews.llvm.org/D12275 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-08-26 Thread Sagar Thakur via lldb-commits
sagar created this revision. sagar added reviewers: jaydeep, clayborg. sagar added subscribers: bhushan, mohit.bhakkad, nitesh.jain, lldb-commits. sagar set the repository for this revision to rL LLVM. This patch adds MSA branch instruction emulation for MIPS64. Repository: rL LLVM http://revi

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-08-27 Thread Sagar Thakur via lldb-commits
sagar updated this revision to Diff 33323. sagar added a comment. Addressed review comments Repository: rL LLVM http://reviews.llvm.org/D12356 Files: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h Index: source

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-08-31 Thread Sagar Thakur via lldb-commits
sagar updated this revision to Diff 33567. sagar added a comment. Addressed review commenst Repository: rL LLVM http://reviews.llvm.org/D12356 Files: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h Index: source

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-08-31 Thread Sagar Thakur via lldb-commits
sagar marked 7 inline comments as done. Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3160 @@ +3159,3 @@ +if((*ptr == 0 && bnz) || (*ptr != 0 && !bnz) ) +branch_hit = false; +break; T

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-08-31 Thread Sagar Thakur via lldb-commits
sagar updated this revision to Diff 33668. sagar marked 4 inline comments as done. sagar added a comment. Corrected code indent and initialized wr_val correctly. Repository: rL LLVM http://reviews.llvm.org/D12356 Files: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp sourc

[Lldb-commits] [lldb] r246745 - [MIPS64] Emulate MSA branch instructions

2015-09-02 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Wed Sep 2 22:57:44 2015 New Revision: 246745 URL: http://llvm.org/viewvc/llvm-project?rev=246745&view=rev Log: [MIPS64] Emulate MSA branch instructions This patch adds MSA branch instruction emulation for MIPS64. Reviewers: tberghammer, jaydeep Subscribers: tberghammer, l

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

2015-09-02 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar added a comment. Committed in revision 246745 Repository: rL LLVM http://reviews.llvm.org/D12356 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] r248277 - [MIPS32] Emulate MSA instructions for MIPS32

2015-09-22 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Tue Sep 22 08:57:11 2015 New Revision: 248277 URL: http://llvm.org/viewvc/llvm-project?rev=248277&view=rev Log: [MIPS32] Emulate MSA instructions for MIPS32 This patch adds MSA branch instruction emulation for MIPS32. Reviewers: tberghammer, jaydeep Subscribers: mohit.bhak