[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

rmaz created this revision. Herald added a subscriber: mgorny. rmaz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add an option to skip generating a dSYM when installing the LLDB framework on Darwin. Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

rmaz added a comment. In D103124#2780955 , @smeenai wrote: > Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO. > > LGTM. Do you need this to be committed for you? If you could, thanks Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz created this revision. Herald added a subscriber: mgorny. rmaz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When enabling LLDB tests with `LLVM_ENABLE_RUNTIMES=libcxx` CMake will fail with: LLDB test suite requires libc++, but i

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz added a comment. In D97227#2580049 , @smeenai wrote: > My understanding of the issue is that, with the runtimes build, the `cxx` > target will get created after we process LLDB's build files. The `TARGET cxx` > check here will therefore fail, but th

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz updated this revision to Diff 325600. rmaz added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 Files: lldb/test/CMakeLists.txt Index: lldb/test/CMakeLists.txt ==

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

rmaz added a comment. > I'd still like to hear an explanation on how is this patch relevant (in this > repository). Apologies, missed the last notification. > Judging by the error message, this dependency is not correct even in the > swift fork. lldbSymbol does not have a direct dependency on

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

rmaz added a comment. In D80659#2062304 , @labath wrote: > Btw, given that Richard has found some vscode code which already tries to > send stderr to the console window > https://github.com/microsoft/vscode/blob/master/src/vs/workbench/contrib/debug/no