[Lldb-commits] [lldb] r342804 - Change type of m_user_expression_start_pos to size_t

2018-09-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Sep 22 06:33:08 2018 New Revision: 342804 URL: http://llvm.org/viewvc/llvm-project?rev=342804&view=rev Log: Change type of m_user_expression_start_pos to size_t AbsPosToLineColumnPos is the only reader of m_user_expression_start_pos and actually treats it like a size_t

Re: [Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

2018-09-23 Thread Raphael Isemann via lldb-commits
> AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The > test will still be failing on Arch. I was more hoping it would at least turn the deadlock into a fail, this way I could at least run the test suit. Anyway, the actual issue is related Python 3: Arch Linux (and probab

[Lldb-commits] [lldb] r343191 - Refactor ClangUserExpression::GetLanguageForExpr

2018-09-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Sep 27 03:12:54 2018 New Revision: 343191 URL: http://llvm.org/viewvc/llvm-project?rev=343191&view=rev Log: Refactor ClangUserExpression::GetLanguageForExpr Summary: The `ClangUserExpression::GetLanguageForExpr` method is currently a big source of sadness, as it's name

Re: [Lldb-commits] [lldb] r344982 - [ValueObject] Stop assuming types are non-zero sized.

2018-10-23 Thread Raphael Isemann via lldb-commits
You maybe able to add a test for that in C++: Clang types can have 0 size, the padding from 0 to 1 happens in the CodeGen IIRC. See also this bug: https://bugs.llvm.org/show_bug.cgi?id=31612 - Raphael Am Di., 23. Okt. 2018 um 02:33 Uhr schrieb Davide Italiano via lldb-commits : > > Author: davide

[Lldb-commits] [lldb] r350675 - Fix unused private field warning.

2019-01-08 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jan 8 14:55:02 2019 New Revision: 350675 URL: http://llvm.org/viewvc/llvm-project?rev=350675&view=rev Log: Fix unused private field warning. Summary: The member is private and unused if HAVE_LIBCOMPRESSION is undefined, which triggers Clang's -Wunused-private-field w

[Lldb-commits] [lldb] r333342 - Forward declare DumpValueObjectOptions in ValueObject.h

2018-05-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat May 26 07:34:49 2018 New Revision: 42 URL: http://llvm.org/viewvc/llvm-project?rev=42&view=rev Log: Forward declare DumpValueObjectOptions in ValueObject.h Summary: This resolves unnecessary the header dependency from Core to DataFormatters. Patch is necessary

[Lldb-commits] [lldb] r333343 - Don't include headers from inside a namespace in MIUtilSingletonHelper.h

2018-05-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat May 26 07:39:35 2018 New Revision: 43 URL: http://llvm.org/viewvc/llvm-project?rev=43&view=rev Log: Don't include headers from inside a namespace in MIUtilSingletonHelper.h Subscribers: ki.stfu, lldb-commits Differential Revision: https://reviews.llvm.org/D474

[Lldb-commits] [lldb] r333345 - Add missing includes to some LLDB headers.

2018-05-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat May 26 07:59:14 2018 New Revision: 45 URL: http://llvm.org/viewvc/llvm-project?rev=45&view=rev Log: Add missing includes to some LLDB headers. Summary: When compiling with modules, these missing includes cause the build to fail (as the header can't be compiled

[Lldb-commits] [lldb] r333353 - Fix memory leak in SubsPrimitiveParmItanium

2018-05-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun May 27 00:31:06 2018 New Revision: 53 URL: http://llvm.org/viewvc/llvm-project?rev=53&view=rev Log: Fix memory leak in SubsPrimitiveParmItanium Summary: FastDemangle gives us a C-string that we own (which is allocated in SymbolDemangler::GetDemangledCopy). As

[Lldb-commits] [lldb] r334259 - Added missing include to LoadedModuleInfoList.h

2018-06-07 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jun 7 19:00:27 2018 New Revision: 334259 URL: http://llvm.org/viewvc/llvm-project?rev=334259&view=rev Log: Added missing include to LoadedModuleInfoList.h Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D47923 Modified: lldb/trunk/inclu

[Lldb-commits] [lldb] r334549 - Added modulemap for lldb-mi

2018-06-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jun 12 14:22:52 2018 New Revision: 334549 URL: http://llvm.org/viewvc/llvm-project?rev=334549&view=rev Log: Added modulemap for lldb-mi Summary: This patch allows building a C++ module for the lldb-mi headers. Reviewers: bruno, aprantl Reviewed By: aprantl Subscribe

[Lldb-commits] [lldb] r334557 - Disable warnings for the generated LLDB wrapper source

2018-06-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jun 12 15:51:20 2018 New Revision: 334557 URL: http://llvm.org/viewvc/llvm-project?rev=334557&view=rev Log: Disable warnings for the generated LLDB wrapper source Summary: This source files emits all kind of compiler warnings on different platforms. As the source code

[Lldb-commits] [lldb] r334611 - Add modules support for lldb headers in include/

2018-06-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Jun 13 08:50:45 2018 New Revision: 334611 URL: http://llvm.org/viewvc/llvm-project?rev=334611&view=rev Log: Add modules support for lldb headers in include/ Summary: This patch adds a modulemap which allows compiling the lldb headers into C++ modules (for example in b

[Lldb-commits] [lldb] r334978 - Fixed file completion for paths that start with '~'.

2018-06-18 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jun 18 13:11:38 2018 New Revision: 334978 URL: http://llvm.org/viewvc/llvm-project?rev=334978&view=rev Log: Fixed file completion for paths that start with '~'. We didn't add the remaining path behind the '~' to the completion string, causing it to just complete direct

[Lldb-commits] [lldb] r335078 - Refactor OnExit utility class in ClangUserExpression

2018-06-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jun 19 14:25:59 2018 New Revision: 335078 URL: http://llvm.org/viewvc/llvm-project?rev=335078&view=rev Log: Refactor OnExit utility class in ClangUserExpression Summary: OnExit ensures we call `ResetDeclMap` before this method ends. However, we also have a few manual c

[Lldb-commits] [lldb] r323064 - [modules] Fix missing includes/typo in LLDB's includes. [NFC]

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Jan 21 01:54:19 2018 New Revision: 323064 URL: http://llvm.org/viewvc/llvm-project?rev=323064&view=rev Log: [modules] Fix missing includes/typo in LLDB's includes. [NFC] Summary: This patch adds missing includes to the LLDB headers inside `include/` as a first step of

[Lldb-commits] [lldb] r335905 - Added test case for: r334978 - Fixed file completion for paths that start with '~'

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jun 28 12:34:49 2018 New Revision: 335905 URL: http://llvm.org/viewvc/llvm-project?rev=335905&view=rev Log: Added test case for: r334978 - Fixed file completion for paths that start with '~' Reviewers: labath Reviewed By: labath Subscribers: lldb-commits Different

Re: [Lldb-commits] [lldb] r334978 - Fixed file completion for paths that start with '~'.

2018-07-06 Thread Raphael Isemann via lldb-commits
t; > A test? > > > > It looks like it should be possible to test this in a similar way to > > other CommandCompletion tests > > (unittests/Interpreter/TestCompletion.cpp). > > On Mon, 18 Jun 2018 at 21:16, Raphael Isemann via lldb-commits > > wrote: >

[Lldb-commits] [lldb] r336377 - Fixed redefinition warnings with LLVM_ENABLE_MODULES

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 5 10:12:11 2018 New Revision: 336377 URL: http://llvm.org/viewvc/llvm-project?rev=336377&view=rev Log: Fixed redefinition warnings with LLVM_ENABLE_MODULES Summary: It seems we both have the HAVE_LIBCOMPRESSION define in the config header and in the source files d

[Lldb-commits] [lldb] r336149 - Fixed compilation failure after the code completion refactor patch

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 2 15:18:18 2018 New Revision: 336149 URL: http://llvm.org/viewvc/llvm-project?rev=336149&view=rev Log: Fixed compilation failure after the code completion refactor patch Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D48855 Modified:

[Lldb-commits] [lldb] r336146 - Refactoring for for the internal command line completion API (NFC)

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 2 14:29:56 2018 New Revision: 336146 URL: http://llvm.org/viewvc/llvm-project?rev=336146&view=rev Log: Refactoring for for the internal command line completion API (NFC) Summary: This patch refactors the internal completion API. It now takes (as far as possible)

[Lldb-commits] [lldb] r336154 - FIx XCode project files for lldb

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 2 16:27:29 2018 New Revision: 336154 URL: http://llvm.org/viewvc/llvm-project?rev=336154&view=rev Log: FIx XCode project files for lldb Summary: Fixes the XCode builds that started failing when i added CompletionRequest.cpp/.h. The patch is so large because XCod

[Lldb-commits] [lldb] r335934 - Fix path completion test case added in rL335905 on Windows

2018-07-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jun 28 15:40:10 2018 New Revision: 335934 URL: http://llvm.org/viewvc/llvm-project?rev=335934&view=rev Log: Fix path completion test case added in rL335905 on Windows Summary: The test fails because we don't rewrite the slash behind `foo` to the OS specific separator

[Lldb-commits] [lldb] r336582 - Don't take the address of an xvalue when printing an expr result

2018-07-09 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 9 11:57:11 2018 New Revision: 336582 URL: http://llvm.org/viewvc/llvm-project?rev=336582&view=rev Log: Don't take the address of an xvalue when printing an expr result Summary: If we have an xvalue here, we will always hit the `err_typecheck_invalid_lvalue_addrof

[Lldb-commits] [lldb] r336723 - Refactor parsing of option lists with a raw string suffix.

2018-07-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 10 13:17:38 2018 New Revision: 336723 URL: http://llvm.org/viewvc/llvm-project?rev=336723&view=rev Log: Refactor parsing of option lists with a raw string suffix. Summary: A subset of the LLDB commands follows this command line interface style: [arguments] --

[Lldb-commits] [lldb] r336734 - Refactor ClangUserExpression::Parse [NFC]

2018-07-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 10 15:12:39 2018 New Revision: 336734 URL: http://llvm.org/viewvc/llvm-project?rev=336734&view=rev Log: Refactor ClangUserExpression::Parse [NFC] Summary: This patch splits out functionality from the `Parse` method into different methods. This benefits the code co

[Lldb-commits] [lldb] r336824 - Allow specifying an exit code for the 'quit' command

2018-07-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Jul 11 10:18:01 2018 New Revision: 336824 URL: http://llvm.org/viewvc/llvm-project?rev=336824&view=rev Log: Allow specifying an exit code for the 'quit' command Summary: This patch adds the possibility to specify an exit code when calling quit. We accept any int, even

[Lldb-commits] [lldb] r336955 - Get rid of the C-string parameter in DoExecute

2018-07-12 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 12 15:28:52 2018 New Revision: 336955 URL: http://llvm.org/viewvc/llvm-project?rev=336955&view=rev Log: Get rid of the C-string parameter in DoExecute Summary: This patch gets rid of the C-string parameter in the RawCommandObject::DoExecute function, making the co

[Lldb-commits] [lldb] r337030 - No longer pass a StringRef to the Python API

2018-07-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 13 11:13:46 2018 New Revision: 337030 URL: http://llvm.org/viewvc/llvm-project?rev=337030&view=rev Log: No longer pass a StringRef to the Python API Summary: The refactoring patch for DoExecute missed this case of a variadic function that just silently accepts a S

[Lldb-commits] [lldb] r337031 - Replaced more boilerplate code with CompletionRequest (NFC)

2018-07-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 13 11:28:14 2018 New Revision: 337031 URL: http://llvm.org/viewvc/llvm-project?rev=337031&view=rev Log: Replaced more boilerplate code with CompletionRequest (NFC) Summary: As suggested in D48796, this patch replaces even more internal calls that were using the ol

[Lldb-commits] [lldb] r337032 - Add includes for CompletionRequest to every file that uses it

2018-07-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 13 11:54:55 2018 New Revision: 337032 URL: http://llvm.org/viewvc/llvm-project?rev=337032&view=rev Log: Add includes for CompletionRequest to every file that uses it Summary: Should fix the builds (and prevent future builds from failing when people try to reduce i

[Lldb-commits] [lldb] r337189 - Fix some crashes and deadlocks in FormatAnsiTerminalCodes

2018-07-16 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 16 09:38:30 2018 New Revision: 337189 URL: http://llvm.org/viewvc/llvm-project?rev=337189&view=rev Log: Fix some crashes and deadlocks in FormatAnsiTerminalCodes Summary: This patch fixes a few problems with the FormatAnsiTerminalCodes function: * It does an infin

[Lldb-commits] [lldb] r337475 - Added unit tests for Flags

2018-07-19 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 19 10:45:51 2018 New Revision: 337475 URL: http://llvm.org/viewvc/llvm-project?rev=337475&view=rev Log: Added unit tests for Flags Reviewers: labath Reviewed By: labath Subscribers: labath, mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/D49

[Lldb-commits] [lldb] r337737 - [NFC] Minor code refactoring.

2018-07-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 23 13:56:49 2018 New Revision: 337737 URL: http://llvm.org/viewvc/llvm-project?rev=337737&view=rev Log: [NFC] Minor code refactoring. Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D49696 Modified: lldb/trunk/source/Plugins/ScriptI

[Lldb-commits] [lldb] r337741 - [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config

2018-07-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 23 14:14:52 2018 New Revision: 337741 URL: http://llvm.org/viewvc/llvm-project?rev=337741&view=rev Log: [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config Summary: LLDB_PLUGINS doesn't exist as a variable, so this line doesn't add

[Lldb-commits] [lldb] r337778 - Added unit test for StreamTee

2018-07-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 23 17:01:32 2018 New Revision: 337778 URL: http://llvm.org/viewvc/llvm-project?rev=337778&view=rev Log: Added unit test for StreamTee Reviewers: davide Reviewed By: davide Subscribers: davide, mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/

[Lldb-commits] [lldb] r337855 - Remove unused History class

2018-07-24 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 24 14:09:17 2018 New Revision: 337855 URL: http://llvm.org/viewvc/llvm-project?rev=337855&view=rev Log: Remove unused History class Summary: This class doesn't seem to be used anywhere, so we might as well remove the code. Reviewers: labath Reviewed By: labath

[Lldb-commits] [lldb] r337873 - Add unit tests for VMRange

2018-07-24 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 24 16:52:39 2018 New Revision: 337873 URL: http://llvm.org/viewvc/llvm-project?rev=337873&view=rev Log: Add unit tests for VMRange Subscribers: clayborg, labath, mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/D49415 Added: lldb/trunk/uni

[Lldb-commits] [lldb] r338040 - Don't print two errors for unknown commands.

2018-07-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 26 09:32:05 2018 New Revision: 338040 URL: http://llvm.org/viewvc/llvm-project?rev=338040&view=rev Log: Don't print two errors for unknown commands. Summary: We always print two error messages when we hit an unknown command. As the function `CommandInterpreter::Ha

[Lldb-commits] [lldb] r338043 - Fix duplicate suggestions after an ambiguous command

2018-07-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Jul 26 10:14:18 2018 New Revision: 338043 URL: http://llvm.org/viewvc/llvm-project?rev=338043&view=rev Log: Fix duplicate suggestions after an ambiguous command Summary: So far lldb is printing this when it finds an ambiguous command: ``` (lldb) g Ambiguous command 'g'

[Lldb-commits] [lldb] r338151 - Narrow the CompletionRequest API to being append-only.

2018-07-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 27 11:42:46 2018 New Revision: 338151 URL: http://llvm.org/viewvc/llvm-project?rev=338151&view=rev Log: Narrow the CompletionRequest API to being append-only. Summary: We currently allow any completion handler to read and manipulate the list of matches we calculat

[Lldb-commits] [lldb] r338171 - Fix whitespace in the python test suite.

2018-07-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 27 15:20:59 2018 New Revision: 338171 URL: http://llvm.org/viewvc/llvm-project?rev=338171&view=rev Log: Fix whitespace in the python test suite. Summary: The test suite has often unnecessary trailing whitespace, and sometimes unnecessary trailing lines or a missing

[Lldb-commits] [lldb] r338177 - Add missing boundary checks to variable completion.

2018-07-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 27 16:37:08 2018 New Revision: 338177 URL: http://llvm.org/viewvc/llvm-project?rev=338177&view=rev Log: Add missing boundary checks to variable completion. Summary: Stopgap patch to at least stop all the crashes I get from this code. Subscribers: lldb-commits Dif

[Lldb-commits] [lldb] r338179 - Add the actually calculated completions to COMPLETION_MSG

2018-07-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Jul 27 16:42:34 2018 New Revision: 338179 URL: http://llvm.org/viewvc/llvm-project?rev=338179&view=rev Log: Add the actually calculated completions to COMPLETION_MSG Summary: Otherwise this assertion message is not very useful to whoever is reading the log. Subscribe

[Lldb-commits] [lldb] r338311 - Remove unnecessary newlines from break command help text.

2018-07-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 30 14:41:13 2018 New Revision: 338311 URL: http://llvm.org/viewvc/llvm-project?rev=338311&view=rev Log: Remove unnecessary newlines from break command help text. Summary: We usually don't have trailing newlines in the short help strings. This just adds unnecessary

[Lldb-commits] [lldb] r338345 - Remove Stream::UnitTest

2018-07-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Jul 30 18:21:36 2018 New Revision: 338345 URL: http://llvm.org/viewvc/llvm-project?rev=338345&view=rev Log: Remove Stream::UnitTest Summary: No one is using this method, and it also doesn't really make a lot of sense to have it around. Reviewers: davide Reviewed By:

[Lldb-commits] [lldb] r338488 - Added initial unit test for LLDB's Stream class.

2018-07-31 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 31 23:04:48 2018 New Revision: 338488 URL: http://llvm.org/viewvc/llvm-project?rev=338488&view=rev Log: Added initial unit test for LLDB's Stream class. Summary: This adds an initial small unit test for LLDB's Stream class, which should at least cover most of the

[Lldb-commits] [lldb] r338491 - Removed failing StreamTest case

2018-07-31 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Jul 31 23:35:27 2018 New Revision: 338491 URL: http://llvm.org/viewvc/llvm-project?rev=338491&view=rev Log: Removed failing StreamTest case The suspicious behavior is obviously because this method reads OOB memory, so I'll remove it for now and re-add the test alongsid

[Lldb-commits] [lldb] r338591 - Don't ignore byte_order in Stream::PutMaxHex64

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 10:12:58 2018 New Revision: 338591 URL: http://llvm.org/viewvc/llvm-project?rev=338591&view=rev Log: Don't ignore byte_order in Stream::PutMaxHex64 Reviewers: labath Reviewed By: labath Subscribers: zturner, lldb-commits Differential Revision: https://reviews

[Lldb-commits] [lldb] r338605 - Remove outdated documentation for Stream's LEB128 methods

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 11:28:54 2018 New Revision: 338605 URL: http://llvm.org/viewvc/llvm-project?rev=338605&view=rev Log: Remove outdated documentation for Stream's LEB128 methods There is no format parameter for any of these methods. Modified: lldb/trunk/include/lldb/Utility/S

[Lldb-commits] [lldb] r338611 - Fixed documentation for PutHex8 [NFC]

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 11:38:19 2018 New Revision: 338611 URL: http://llvm.org/viewvc/llvm-project?rev=338611&view=rev Log: Fixed documentation for PutHex8 [NFC] The previous documentation was just copied from PrintfAsRawHex8 but doesn't actually fit to the PutHex8 method. Modified:

[Lldb-commits] [lldb] r338637 - Fix out-of-bounds read in Stream::PutCStringAsRawHex8

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 14:07:18 2018 New Revision: 338637 URL: http://llvm.org/viewvc/llvm-project?rev=338637&view=rev Log: Fix out-of-bounds read in Stream::PutCStringAsRawHex8 Summary: When I added the Stream unit test (r338488), the build bots failed due to an out-of- bound reads

[Lldb-commits] [lldb] r338657 - Remove unnecessary target from TestCompletion patch

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 16:54:37 2018 New Revision: 338657 URL: http://llvm.org/viewvc/llvm-project?rev=338657&view=rev Log: Remove unnecessary target from TestCompletion patch As Jim pointed out, we don't need to manually create a target here because we already create a target implici

[Lldb-commits] [lldb] r338662 - [LLDB] Added syntax highlighting support

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 17:30:15 2018 New Revision: 338662 URL: http://llvm.org/viewvc/llvm-project?rev=338662&view=rev Log: [LLDB] Added syntax highlighting support Summary: This patch adds syntax highlighting support to LLDB. When enabled (and lldb is allowed to use colors), printed

[Lldb-commits] [lldb] r338669 - Added missing highlighter files to XCode project

2018-08-01 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 1 20:01:09 2018 New Revision: 338669 URL: http://llvm.org/viewvc/llvm-project?rev=338669&view=rev Log: Added missing highlighter files to XCode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL

[Lldb-commits] [lldb] r338733 - Add byte counting mechanism to LLDB's Stream class.

2018-08-02 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 2 09:38:34 2018 New Revision: 338733 URL: http://llvm.org/viewvc/llvm-project?rev=338733&view=rev Log: Add byte counting mechanism to LLDB's Stream class. Summary: This patch allows LLDB's Stream class to count the bytes it has written to so far. There are two m

[Lldb-commits] [lldb] r338901 - Add raw_ostream wrapper to the Stream class

2018-08-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 3 09:56:33 2018 New Revision: 338901 URL: http://llvm.org/viewvc/llvm-project?rev=338901&view=rev Log: Add raw_ostream wrapper to the Stream class Summary: This wrapper will allow us in the future to reuse LLVM methods from within the Stream class. Currently no t

[Lldb-commits] [lldb] r338920 - Replace LLDB's LEB128 implementation with the one from LLVM

2018-08-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 3 13:51:31 2018 New Revision: 338920 URL: http://llvm.org/viewvc/llvm-project?rev=338920&view=rev Log: Replace LLDB's LEB128 implementation with the one from LLVM Reviewers: davide, labath Reviewed By: labath Subscribers: lldb-commits Differential Revision: htt

[Lldb-commits] [lldb] r338952 - Fixed header of StringLexer.h

2018-08-03 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 3 22:53:07 2018 New Revision: 338952 URL: http://llvm.org/viewvc/llvm-project?rev=338952&view=rev Log: Fixed header of StringLexer.h Modified: lldb/trunk/include/lldb/Utility/StringLexer.h Modified: lldb/trunk/include/lldb/Utility/StringLexer.h URL: http://l

[Lldb-commits] [lldb] r338961 - Added unit test for StringList

2018-08-04 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Aug 4 10:28:21 2018 New Revision: 338961 URL: http://llvm.org/viewvc/llvm-project?rev=338961&view=rev Log: Added unit test for StringList Reviewers: labath Reviewed By: labath Subscribers: mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/D50293

[Lldb-commits] [lldb] r338976 - Remove duplicated code in CommandObjectQuit

2018-08-05 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Aug 5 17:04:51 2018 New Revision: 338976 URL: http://llvm.org/viewvc/llvm-project?rev=338976&view=rev Log: Remove duplicated code in CommandObjectQuit Summary: We already have the same check directly before, so this code can never be reached (as seen in the test cover

[Lldb-commits] [lldb] r339202 - Removed duplicated commented-out code [NFC]

2018-08-07 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 7 16:24:24 2018 New Revision: 339202 URL: http://llvm.org/viewvc/llvm-project?rev=339202&view=rev Log: Removed duplicated commented-out code [NFC] Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp UR

[Lldb-commits] [lldb] r339204 - Removed doxygen comment that doesn't fit to function signature

2018-08-07 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 7 16:47:05 2018 New Revision: 339204 URL: http://llvm.org/viewvc/llvm-project?rev=339204&view=rev Log: Removed doxygen comment that doesn't fit to function signature Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h Modified:

[Lldb-commits] [lldb] r339351 - Also display the output and error output of a failed command

2018-08-09 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 9 08:29:32 2018 New Revision: 339351 URL: http://llvm.org/viewvc/llvm-project?rev=339351&view=rev Log: Also display the output and error output of a failed command Summary: Instead of just printing the current "False is not True, ..." message when we fail to run a

[Lldb-commits] [lldb] r339353 - Added missing null checks to fix r339351

2018-08-09 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 9 08:57:43 2018 New Revision: 339353 URL: http://llvm.org/viewvc/llvm-project?rev=339353&view=rev Log: Added missing null checks to fix r339351 Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [lldb] r339473 - Remove copy-pasted and unrelated comment [NFC]

2018-08-10 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 10 14:31:44 2018 New Revision: 339473 URL: http://llvm.org/viewvc/llvm-project?rev=339473&view=rev Log: Remove copy-pasted and unrelated comment [NFC] That comment was copied from the CombineConsecutiveEntriesWithEqualData() implementation below, and doesn't actual

[Lldb-commits] [lldb] r339504 - Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

2018-08-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat Aug 11 16:40:27 2018 New Revision: 339504 URL: http://llvm.org/viewvc/llvm-project?rev=339504&view=rev Log: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID Summary: Instead of iterating over our vector of functions, we might as well use

[Lldb-commits] [lldb] r339611 - Added test for Core/Range class.

2018-08-13 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 13 13:43:06 2018 New Revision: 339611 URL: http://llvm.org/viewvc/llvm-project?rev=339611&view=rev Log: Added test for Core/Range class. Summary: We can optimize and refactor some of the classes in RangeMap.h, but first we should have some tests for all the data st

[Lldb-commits] [lldb] r339695 - Remove manual byte counting from Highlighter code.

2018-08-14 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 14 10:12:54 2018 New Revision: 339695 URL: http://llvm.org/viewvc/llvm-project?rev=339695&view=rev Log: Remove manual byte counting from Highlighter code. Summary: This removes the manual byte counting mechanism from the syntax highlighting code. This is no longer

[Lldb-commits] [lldb] r339715 - Stability improvements for CompletionTest

2018-08-14 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 14 12:36:58 2018 New Revision: 339715 URL: http://llvm.org/viewvc/llvm-project?rev=339715&view=rev Log: Stability improvements for CompletionTest Summary: CompletionTest.DirCompletionAbsolute had a random failure on a CI node (in the failure, the completion count w

[Lldb-commits] [lldb] r339825 - [ASTImporter] Add test for IfStmt

2018-08-15 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 15 15:31:44 2018 New Revision: 339825 URL: http://llvm.org/viewvc/llvm-project?rev=339825&view=rev Log: [ASTImporter] Add test for IfStmt Reviewers: a.sidorin, hiraditya Reviewed By: hiraditya Subscribers: hiraditya, martong, cfe-commits Differential Revision: h

[Lldb-commits] [lldb] r339826 - Revert "[ASTImporter] Add test for IfStmt"

2018-08-15 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 15 15:32:35 2018 New Revision: 339826 URL: http://llvm.org/viewvc/llvm-project?rev=339826&view=rev Log: Revert "[ASTImporter] Add test for IfStmt" That's actually a clang patch, sorry. Removed: lldb/trunk/test/Import/if-stmt/Inputs/F.cpp lldb/trunk/test/Im

[Lldb-commits] [lldb] r340179 - Remove manual byte counting from Opcode::Dump

2018-08-20 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 20 08:51:14 2018 New Revision: 340179 URL: http://llvm.org/viewvc/llvm-project?rev=340179&view=rev Log: Remove manual byte counting from Opcode::Dump Summary: Stream now has byte-counting functionality, so let's use this instead of manual byte counting. Reviewers

[Lldb-commits] [lldb] r340448 - Add unit test for StringLexer

2018-08-22 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 22 13:22:34 2018 New Revision: 340448 URL: http://llvm.org/viewvc/llvm-project?rev=340448&view=rev Log: Add unit test for StringLexer Reviewers: labath, #lldb Reviewed By: labath Subscribers: jloser, mgorny, lldb-commits Differential Revision: https://reviews.ll

[Lldb-commits] [lldb] r340571 - Fix broken builtin functions in the expression command

2018-08-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 23 13:40:45 2018 New Revision: 340571 URL: http://llvm.org/viewvc/llvm-project?rev=340571&view=rev Log: Fix broken builtin functions in the expression command Summary: Calling any non-libc builtin function in the expression command currently just causes Clang to s

[Lldb-commits] [lldb] r340585 - Reuse the SelectorTable from Clang's Preprocessor

2018-08-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 23 15:40:54 2018 New Revision: 340585 URL: http://llvm.org/viewvc/llvm-project?rev=340585&view=rev Log: Reuse the SelectorTable from Clang's Preprocessor Summary: At the moment we create our own SelectorTable even though the Preprocessor always creates one for us

[Lldb-commits] [lldb] r340589 - Add more pre-run asserts for the DirCompletionAbsolute test

2018-08-23 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 23 16:21:52 2018 New Revision: 340589 URL: http://llvm.org/viewvc/llvm-project?rev=340589&view=rev Log: Add more pre-run asserts for the DirCompletionAbsolute test Summary: The DirCompletionAbsolute is still randomly failing on the nodes even after D50722, so this

[Lldb-commits] [lldb] r340652 - Fixed windows bots that were failing because of PATH_MAX

2018-08-24 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Fri Aug 24 13:55:23 2018 New Revision: 340652 URL: http://llvm.org/viewvc/llvm-project?rev=340652&view=rev Log: Fixed windows bots that were failing because of PATH_MAX As we only use PATH_MAX for an assert in a unit test that is supposed to catch the random failures on th

[Lldb-commits] [lldb] r340747 - Disable use-color if the output stream is not a terminal with color support.

2018-08-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 27 08:16:25 2018 New Revision: 340747 URL: http://llvm.org/viewvc/llvm-project?rev=340747&view=rev Log: Disable use-color if the output stream is not a terminal with color support. Summary: LLDB currently only checks the output terminal for color support by looking

[Lldb-commits] [lldb] r340748 - Let the CompilerInstance create our clang ASTContext

2018-08-27 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Mon Aug 27 08:18:33 2018 New Revision: 340748 URL: http://llvm.org/viewvc/llvm-project?rev=340748&view=rev Log: Let the CompilerInstance create our clang ASTContext Summary: Now that we moved the BuiltinContext and SelectorTable to the CompilerInstance, we can also get rid

[Lldb-commits] [lldb] r340835 - Use a RAII guard to control access to DisassemblerLLVMC.

2018-08-28 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 28 08:31:01 2018 New Revision: 340835 URL: http://llvm.org/viewvc/llvm-project?rev=340835&view=rev Log: Use a RAII guard to control access to DisassemblerLLVMC. Summary: This patch replaces the manual lock/unlock calls for gaining exclusive access to the disassemb

[Lldb-commits] [lldb] r340876 - [lldb] Fix lldb build on musl

2018-08-28 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Aug 28 15:17:28 2018 New Revision: 340876 URL: http://llvm.org/viewvc/llvm-project?rev=340876&view=rev Log: [lldb] Fix lldb build on musl Summary: limits.h is needed for getting PATH_MAX definition, this comes to fore with musl libc where limits.h is not included indir

[Lldb-commits] [lldb] r340958 - Removed commented out includes [NFC]

2018-08-29 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 29 12:55:33 2018 New Revision: 340958 URL: http://llvm.org/viewvc/llvm-project?rev=340958&view=rev Log: Removed commented out includes [NFC] Modified: lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h Modified: lldb/trunk/include/lldb/DataFormatters/

[Lldb-commits] [lldb] r340988 - Don't cancel the current IOHandler when we push a handler for an utility function run.

2018-08-29 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 29 15:50:54 2018 New Revision: 340988 URL: http://llvm.org/viewvc/llvm-project?rev=340988&view=rev Log: Don't cancel the current IOHandler when we push a handler for an utility function run. Summary: D48465 is currently blocked by the fact that tab-completing the

[Lldb-commits] [lldb] r341003 - Move the column marking functionality to the Highlighter framework

2018-08-29 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Aug 29 17:09:21 2018 New Revision: 341003 URL: http://llvm.org/viewvc/llvm-project?rev=341003&view=rev Log: Move the column marking functionality to the Highlighter framework Summary: The syntax highlighting feature so far is mutually exclusive with the lldb feature t

[Lldb-commits] [lldb] r341086 - Added initial code completion support for the `expr` command

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 10:29:37 2018 New Revision: 341086 URL: http://llvm.org/viewvc/llvm-project?rev=341086&view=rev Log: Added initial code completion support for the `expr` command Summary: This patch adds initial code completion support for the `expr` command. We now have a comp

[Lldb-commits] [lldb] r341089 - Move Predicate.h from Host to Utility

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 10:51:10 2018 New Revision: 341089 URL: http://llvm.org/viewvc/llvm-project?rev=341089&view=rev Log: Move Predicate.h from Host to Utility Summary: This class was initially in Host because its implementation used to be very OS-specific. However, with C++11, it h

[Lldb-commits] [lldb] r341105 - Fixed code style for the CodeCompletion members [NFC]

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 12:47:53 2018 New Revision: 341105 URL: http://llvm.org/viewvc/llvm-project?rev=341105&view=rev Log: Fixed code style for the CodeCompletion members [NFC] This code is in LLDB, so it should also follow the LLDB code style and use the m_ prefix for members. Modi

[Lldb-commits] [lldb] r341109 - Added missing include to for 'std::isalnum'

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 13:14:22 2018 New Revision: 341109 URL: http://llvm.org/viewvc/llvm-project?rev=341109&view=rev Log: Added missing include to for 'std::isalnum' Should fix the failing Windows bots. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpression

[Lldb-commits] [lldb] r341112 - Adjusting some comments in ClangExpressionParser.cpp

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 13:19:57 2018 New Revision: 341112 URL: http://llvm.org/viewvc/llvm-project?rev=341112&view=rev Log: Adjusting some comments in ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/tr

[Lldb-commits] [lldb] r341121 - Move NoBuiltin=true closer to the other LangOpts code [NFC]

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 13:56:58 2018 New Revision: 341121 URL: http://llvm.org/viewvc/llvm-project?rev=341121&view=rev Log: Move NoBuiltin=true closer to the other LangOpts code [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified:

[Lldb-commits] [lldb] r341124 - Use a CompletionRequest in the expression command completion [NFC]

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 14:26:32 2018 New Revision: 341124 URL: http://llvm.org/viewvc/llvm-project?rev=341124&view=rev Log: Use a CompletionRequest in the expression command completion [NFC] The patch was originally written before we had a CompletionRequest, so it still used a StringL

[Lldb-commits] [lldb] r341126 - Fixed comment for UserExpression::Complete [NFC]

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 14:31:04 2018 New Revision: 341126 URL: http://llvm.org/viewvc/llvm-project?rev=341126&view=rev Log: Fixed comment for UserExpression::Complete [NFC] Modified: lldb/trunk/include/lldb/Expression/UserExpression.h Modified: lldb/trunk/include/lldb/Expression/

[Lldb-commits] [lldb] r341157 - Fixed missing sidebars on the website

2018-08-30 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Aug 30 19:07:05 2018 New Revision: 341157 URL: http://llvm.org/viewvc/llvm-project?rev=341157&view=rev Log: Fixed missing sidebars on the website We didn't mark these HTML files as executable, which means that the SSI includes for including the sidebar didn't work. Mo

[Lldb-commits] [lldb] r341471 - [www] Updated outdated download links [NFC]

2018-09-05 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Wed Sep 5 07:27:48 2018 New Revision: 341471 URL: http://llvm.org/viewvc/llvm-project?rev=341471&view=rev Log: [www] Updated outdated download links [NFC] Also added ubuntu and Arch Linux links. Modified: lldb/trunk/www/download.html Modified: lldb/trunk/www/downloa

[Lldb-commits] [lldb] r341532 - Revert "[ClangUserExpression][NFC] Removed unused code"

2018-09-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Sep 6 02:42:44 2018 New Revision: 341532 URL: http://llvm.org/viewvc/llvm-project?rev=341532&view=rev Log: Revert "[ClangUserExpression][NFC] Removed unused code" GetLanguageForExpr has side effects, so this actually breaks the completion. Should fix TestExprCompletio

[Lldb-commits] [lldb] r341535 - Reland [ClangUserExpression][NFC] Removed unused code

2018-09-06 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Thu Sep 6 03:24:11 2018 New Revision: 341535 URL: http://llvm.org/viewvc/llvm-project?rev=341535&view=rev Log: Reland [ClangUserExpression][NFC] Removed unused code The GetLanguageForExpr has side effects, so we can't remove this call without breaking the completion mecha

Re: [Lldb-commits] [lldb] r341535 - Reland [ClangUserExpression][NFC] Removed unused code

2018-09-06 Thread Raphael Isemann via lldb-commits
> Might be a good idea to add a comment in the code for this explaining the > desired side effects? > > > > On Sep 6, 2018, at 3:24 AM, Raphael Isemann via lldb-commits > > wrote: > > > > Author: teemperor > > Date: Thu Sep 6 03:24:11 2018 > >

[Lldb-commits] [lldb] r341931 - [NFC] Fix compiler warning in TestArmv7Disassembly.cpp

2018-09-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 11 05:45:22 2018 New Revision: 341931 URL: http://llvm.org/viewvc/llvm-project?rev=341931&view=rev Log: [NFC] Fix compiler warning in TestArmv7Disassembly.cpp The warning is comparison of integers of different signs: 'const int' and 'const unsigned long' and t

[Lldb-commits] [lldb] r341940 - Print the correct error when our DynamicCheckerFunctions fail to install

2018-09-11 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Tue Sep 11 06:59:47 2018 New Revision: 341940 URL: http://llvm.org/viewvc/llvm-project?rev=341940&view=rev Log: Print the correct error when our DynamicCheckerFunctions fail to install Summary: The check is inverted here: If we have error messages, we should print those i

  1   2   3   4   5   6   7   8   9   10   >