Re: [Lldb-commits] [PATCH] D18646: Fix DWO breakage in r264909

This revision was automatically updated to reflect the committed changes. Closed by commit rL265011: Fix DWO breakage in r264909 (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18646?vs=52196&id=52198#toc Repository: rL LLVM http://reviews.llvm.org/D18646 Files: ll

Re: [Lldb-commits] [PATCH] D18530: Move some functions from ClangASTContext to ClangUtil

labath added a subscriber: labath. labath added a comment. Cyclic code dependencies are not an imaginary problem. Right now, it is very hard to make lldb-server small, because everything in lldb depends on everything else, and so lldb-server ends up containing chunks e.g. clang, even though tha

[Lldb-commits] [lldb] r265017 - Don't vary debug info for lldb-server tests

Author: labath Date: Thu Mar 31 09:22:52 2016 New Revision: 265017 URL: http://llvm.org/viewvc/llvm-project?rev=265017&view=rev Log: Don't vary debug info for lldb-server tests Summary: Debug info is used only by the client and lldb-server tests do not even have the client component running, as

Re: [Lldb-commits] [PATCH] D18598: Don't vary debug info for lldb-server tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL265017: Don't vary debug info for lldb-server tests (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18598?vs=52058&id=52203#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r265124 - Change a recently added assert into lldbassert

Author: labath Date: Fri Apr 1 04:57:30 2016 New Revision: 265124 URL: http://llvm.org/viewvc/llvm-project?rev=265124&view=rev Log: Change a recently added assert into lldbassert Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp Modified: lldb/trunk/source/Plugins/

[Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

labath created this revision. labath added a reviewer: zturner. labath added a subscriber: lldb-commits. Even though FileSpec attempted to handle both kinds of path syntaxes (posix and windows) on both platforms, it relied on the llvm path library to do its work, whose behavior differed on diffe

[Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. This resolves a similar problem as D16720 (which handled the case when we single-step onto a breakpoint), but this one deals with involutary stops: when we stop a thread (e.g. because anothe

[Lldb-commits] [lldb] r265140 - Fix clean rule for a makefile

Author: labath Date: Fri Apr 1 07:59:37 2016 New Revision: 265140 URL: http://llvm.org/viewvc/llvm-project?rev=265140&view=rev Log: Fix clean rule for a makefile The test was failing on windows because the clean rule (which is executed even if the test is skipped) returned an error there. Modi

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

labath updated this revision to Diff 52357. labath added a comment. I've realized that some foreign stubs may not send the "reason" field, so I limit the scope of this change to cases where "signal" is zero as well. http://reviews.llvm.org/D18692 Files: source/Plugins/Process/gdb-remote/Proc

[Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. There was a bug in linux core file handling, where if there was a running process with the same process id as the id in the core file, the core file debugging would fail, as we would

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

labath added a comment. In http://reviews.llvm.org/D18519#390337, @eran.ifrah wrote: > Spoke too soon, the hack into `CMakeLists.txt` is still needed > Passing ` -mbig-obj` crashes `ld.exe` (although it crashes in a much later > stage, at about 77% in the build) Clang only puts /bigobj on a

[Lldb-commits] [lldb] r265294 - Fix flakyness in TestWatchpointMultipleThreads

Author: labath Date: Mon Apr 4 09:18:21 2016 New Revision: 265294 URL: http://llvm.org/viewvc/llvm-project?rev=265294&view=rev Log: Fix flakyness in TestWatchpointMultipleThreads This addresses the same problem as r264846 (the test not expecting the situation when two thread hit the watchpoint

[Lldb-commits] [lldb] r265299 - Make FileSpec handling platform-independent

Author: labath Date: Mon Apr 4 09:39:12 2016 New Revision: 265299 URL: http://llvm.org/viewvc/llvm-project?rev=265299&view=rev Log: Make FileSpec handling platform-independent Summary: Even though FileSpec attempted to handle both kinds of path syntaxes (posix and windows) on both platforms, it

Re: [Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

This revision was automatically updated to reflect the committed changes. Closed by commit rL265299: Make FileSpec handling platform-independent (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18689?vs=52348&id=52556#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

labath updated this revision to Diff 52572. labath added a comment. Address review comments. http://reviews.llvm.org/D18697 Files: include/lldb/Target/Process.h packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py packages/Python/lldbsuite/test/functional

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

labath marked an inline comment as done. labath added a comment. I have also added a test which loads two core files with the same pid. (Based on very little experimentation) everything seems to be working ok for that case. Comment at: source/Plugins/Process/elf-core/ProcessElf

[Lldb-commits] [lldb] r265391 - Fix a bug in linux core file handling

Author: labath Date: Tue Apr 5 08:07:16 2016 New Revision: 265391 URL: http://llvm.org/viewvc/llvm-project?rev=265391&view=rev Log: Fix a bug in linux core file handling Summary: There was a bug in linux core file handling, where if there was a running process with the same process id as the id

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL265391: Fix a bug in linux core file handling (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18697?vs=52572&id=52679#toc Repository: rL LLVM http://reviews.llvm.org/D18697

Re: [Lldb-commits] [PATCH] D18789: [NFC] Cleanup the code used to run shell commands from tests

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. A very nice cleanup. Comment at: packages/Python/lldbsuite/test/lldbutil.py:1040 @@ +1039,3 @@ +# Exponential backoff! +time.sleep(pow(2, i) * 0.25) +

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

labath added a comment. In http://reviews.llvm.org/D18692#389529, @clayborg wrote: > Looks fine. We should probably put the code that checks for a breakpoint at > the thread PC into a function since it is done about 5 times in this function. I'll prepare a follow-up to deduplicate the code her

[Lldb-commits] [lldb] r265524 - Fixup r265398

Author: labath Date: Wed Apr 6 03:55:31 2016 New Revision: 265524 URL: http://llvm.org/viewvc/llvm-project?rev=265524&view=rev Log: Fixup r265398 Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py URL: http://llvm

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rL265525: Fix a cornercase in breakpoint reporting (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18692?vs=52357&id=52771#toc Repository: rL LLVM http://reviews.llvm.org/D1869

[Lldb-commits] [lldb] r265525 - Fix a cornercase in breakpoint reporting

Author: labath Date: Wed Apr 6 04:10:29 2016 New Revision: 265525 URL: http://llvm.org/viewvc/llvm-project?rev=265525&view=rev Log: Fix a cornercase in breakpoint reporting Summary: This resolves a similar problem as D16720 (which handled the case when we single-step onto a breakpoint), but thi

[Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. SetThreadStopInfo was checking for a breakpoint at the current PC several times. This merges the identical code into a separate function. I've left one breakpoint check alone, as it was doin

[Lldb-commits] [lldb] r265529 - Fixup TestLinuxCore on windows

Author: labath Date: Wed Apr 6 06:05:30 2016 New Revision: 265529 URL: http://llvm.org/viewvc/llvm-project?rev=265529&view=rev Log: Fixup TestLinuxCore on windows test_same_pid_running couldn't delete the temporary files, while we had them open. Deleting the target should make things work. Mod

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

BTW, the same test fails on our windows->android buildbot (which still uses python 2). I haven't investigated the issue yet, I'm writing it just as an additional data point... cheers, pl On 6 April 2016 at 16:19, Zachary Turner via lldb-commits wrote: > Well, it would belong anywhere that does a

[Lldb-commits] [lldb] r265560 - Reduce code duplication in ProcessGDBRemote

Author: labath Date: Wed Apr 6 11:49:13 2016 New Revision: 265560 URL: http://llvm.org/viewvc/llvm-project?rev=265560&view=rev Log: Reduce code duplication in ProcessGDBRemote Summary: SetThreadStopInfo was checking for a breakpoint at the current PC several times. This merges the identical cod

Re: [Lldb-commits] [PATCH] D18819: Reduce code duplication in ProcessGDBRemote

This revision was automatically updated to reflect the committed changes. Closed by commit rL265560: Reduce code duplication in ProcessGDBRemote (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18819?vs=52773&id=52817#toc Repository: rL LLVM http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r265647 - Revert "Reduce code duplication in ProcessGDBRemote"

Author: labath Date: Thu Apr 7 03:16:10 2016 New Revision: 265647 URL: http://llvm.org/viewvc/llvm-project?rev=265647&view=rev Log: Revert "Reduce code duplication in ProcessGDBRemote" In turns out this does make a functional change, in case when the inferior hits an int3 that was not placed by

[Lldb-commits] [lldb] r265650 - Enable TestDebugBreak on x86_64 as well

Author: labath Date: Thu Apr 7 04:25:04 2016 New Revision: 265650 URL: http://llvm.org/viewvc/llvm-project?rev=265650&view=rev Log: Enable TestDebugBreak on x86_64 as well Test passes there, and this would have helped me catch the snafu in the previous commit. Modified: lldb/trunk/package

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

labath added a subscriber: labath. labath added a comment. Does this fix an existing test or is a new issue? If it's new (it sounds like it is, as I don't see any test failures), could you also add a test for this. It shouldn't be too difficult to write one... Would something like this: dbg.S

[Lldb-commits] [PATCH] D18965: [Driver] Fix a segfault in signal handlers

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. If we recieve a SIGCONT or SIGTSTP, while the driver is shutting down (which, sometimes, we do, for reasons which are not completely clear to me), we would crash to due a null pointer derefe

Re: [Lldb-commits] [PATCH] D18965: [Driver] Fix a segfault in signal handlers

This revision was automatically updated to reflect the committed changes. Closed by commit rL265958: [Driver] Fix a segfault in signal handlers (authored by labath). Changed prior to commit: http://reviews.llvm.org/D18965?vs=53239&id=53265#toc Repository: rL LLVM http://reviews.llvm.org/D18

[Lldb-commits] [lldb] r265958 - [Driver] Fix a segfault in signal handlers

Author: labath Date: Mon Apr 11 11:40:09 2016 New Revision: 265958 URL: http://llvm.org/viewvc/llvm-project?rev=265958&view=rev Log: [Driver] Fix a segfault in signal handlers Summary: If we recieve a SIGCONT or SIGTSTP, while the driver is shutting down (which, sometimes, we do, for reasons whi

[Lldb-commits] [lldb] r265959 - Mark TestPrintStackTraces as flaky on android arm

Author: labath Date: Mon Apr 11 11:50:08 2016 New Revision: 265959 URL: http://llvm.org/viewvc/llvm-project?rev=265959&view=rev Log: Mark TestPrintStackTraces as flaky on android arm Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/lldbutil/process/TestPrintStackTraces.py Modi

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

labath added a comment. In http://reviews.llvm.org/D18886#397843, @amccarth wrote: > It's weird in that, if you run the test independently, it passes. But if you > run it with the multiprocess test runner (ninja check-lldb), then it fails on > this line: > > self.fail("Setting a breakpoint gen

Re: [Lldb-commits] [PATCH] D18886: Reset continue_after_async only if neither SIGINIT nor SIGSTOP received

labath added a comment. A random thought: will `getchar()` block the inferior on windows (because of missing stdio forwarding, et al.). If it wont then this could be the cause of the flakyness. If that's the case, then we can replace that call with something that will surely halt progress, like

[Lldb-commits] [lldb] r266050 - Revert "Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work"

Author: labath Date: Tue Apr 12 04:06:08 2016 New Revision: 266050 URL: http://llvm.org/viewvc/llvm-project?rev=266050&view=rev Log: Revert "Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work" This change breaks python unit tests.

Re: [Lldb-commits] [lldb] r266033 - Restore the lazy initialization of ScriptInterpreterPython, which was lost as part of the SystemLifetimeManager work

This breaks the python unit tests. Doesn't seem hard to fix, it seems we just need some way to "really" initialize python before we run the tests. However, I have reverted this change until that happens to keep to bots green. pl On 12 April 2016 at 02:41, Enrico Granata via lldb-commits < lldb-co

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D18985#398169, @uweigand wrote: > In http://reviews.llvm.org/D18985#397674, @clayborg wrote: > > > So many tests above are going to accept either a little endian or big > > endian value. This will make most of

[Lldb-commits] [lldb] r266054 - Skip a test in TestNamespaceLookup on linux to avoid a crash

Author: labath Date: Tue Apr 12 05:06:37 2016 New Revision: 266054 URL: http://llvm.org/viewvc/llvm-project?rev=266054&view=rev Log: Skip a test in TestNamespaceLookup on linux to avoid a crash Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py Mod

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath added a comment. Could you also add a core file test to `TestLinuxCore`? It should be a matter of running `make_core.sh`, saving the files and creating a new test function in the file (I've tried to make it simple, if you see room for improvement, then let me know). I think this is espe

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

labath added a subscriber: labath. labath added a comment. It would be worthwhile to add a unit test for the DataExtractor fix (we don't have many of those, but we're trying to build them up). http://reviews.llvm.org/D18982 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

labath added a comment. It would be great if you could add a some unit tests for your modifications to the Scalar class. You don't have to be too exhaustive, but a couple of tests would go a long way. http://reviews.llvm.org/D18981 ___ lldb-commit

[Lldb-commits] [lldb] r266058 - Bump up timeout in TestGdbRemoteProcessInfo

Author: labath Date: Tue Apr 12 06:59:41 2016 New Revision: 266058 URL: http://llvm.org/viewvc/llvm-project?rev=266058&view=rev Log: Bump up timeout in TestGdbRemoteProcessInfo the process info packet is slow, and sometimes it does not arrive on time when run on the android emulator. Modified:

[Lldb-commits] [lldb] r266072 - Fixup TestFdLeak

Author: labath Date: Tue Apr 12 08:55:54 2016 New Revision: 266072 URL: http://llvm.org/viewvc/llvm-project?rev=266072&view=rev Log: Fixup TestFdLeak this test was unintentionally XFAILed due to a change in the behavior of the expectedFailure decorator. Fix that. Also, mark the test as debug-inf

[Lldb-commits] [PATCH] D19052: Make destructor breakpoint location test more resilient

labath created this revision. labath added a reviewer: clayborg. labath added subscribers: lldb-commits, zturner, ovyalov. The original breakpoint location test was failing for linux, because the compilers here tend to merge the full-object and subobject destructors even at -O0 (as a result, we

[Lldb-commits] [lldb] r266192 - Fix test rerun logic

Author: labath Date: Wed Apr 13 07:05:48 2016 New Revision: 266192 URL: http://llvm.org/viewvc/llvm-project?rev=266192&view=rev Log: Fix test rerun logic result_formatter used inspect.getfile() to get the python file name, which returned "*.pyc" if the bytecode file was present. This resulted in

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

labath added a subscriber: labath. labath added a comment. I think having a self-contained test for this issue (one which does not rely on internals of some system library) would be extremely valuable. Could you add one? http://reviews.llvm.org/D18976 ___

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

labath added a comment. I think adding it to the extending the existing test is fine, given that it's a fairly small one. (In case of large tests, it's better to make a new one, so it can be debugged/xfailed independently). Maybe just add `int C` so that we test both the situation when we have

[Lldb-commits] [lldb] r266196 - Remove obsolete comments

Author: labath Date: Wed Apr 13 08:26:45 2016 New Revision: 266196 URL: http://llvm.org/viewvc/llvm-project?rev=266196&view=rev Log: Remove obsolete comments Modified: lldb/trunk/unittests/Host/FileSpecTest.cpp Modified: lldb/trunk/unittests/Host/FileSpecTest.cpp URL: http://llvm.org/viewvc

[Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

labath created this revision. labath added a reviewer: zturner. labath added a subscriber: lldb-commits. In D18689, I removed the call to Normalize() in FileSpec::SetFile, because it no longer seemed needed, and it resolved a quirk in the FileSpec API (spec.GetCString() returnes a path with back

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

labath added a comment. It's a bit more complicated than it seems. GetDirectory() returns a reference into the FileSpec, and a lot of code modifies it through it. Changing that would require fixups in all of the users, which I'd want to do separately. But I do agree that this is the best way fo

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

labath added a comment. In http://reviews.llvm.org/D19060#399915, @zturner wrote: > Ahh that's unfortunate. I guess the thing to do is make SetFile and > SetDirectory. At least by changing the return type we can get the compiler > to tell us everywhere this is happening. Did you run the test su

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath accepted this revision. labath added a comment. That's perfect, thanks a lot. :) Do you have commit access? If not, let me know when you're ready to start landing these things... http://reviews.llvm.org/D18978 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

labath added a subscriber: labath. labath added a comment. Actually, the destination for liblldb.so depends on the LLVM_LIBDIR_SUFFIX cmake variable. If you're on a system which likes to shove things into lib64, maybe you could follow suit and define the variable when you build llvm/lldb. (othe

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

labath accepted this revision. labath added a comment. I am glad that the unit tests are finding real problems and not just being a nuisance. Thanks a lot. Comment at: source/Core/Scalar.cpp:2655 @@ -2654,3 +2656,3 @@ int128.x[1] = (uint64_t)data.GetU64 (&o

Re: [Lldb-commits] [PATCH] D19082: Store absolute path for lldb executable in dotest.py

labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. Not sure what is the difference, but my check-lldb target has already the full path in it. Sounds like a good idea nonetheles

Re: [Lldb-commits] [PATCH] D19060: FileSpec: make matching separator-agnostic again

This revision was automatically updated to reflect the committed changes. Closed by commit rL266286: FileSpec: make matching separator-agnostic again (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19060?vs=53567&id=53680#toc Repository: rL LLVM http://reviews.llvm.o

[Lldb-commits] [lldb] r266286 - FileSpec: make matching separator-agnostic again

Author: labath Date: Thu Apr 14 04:38:06 2016 New Revision: 266286 URL: http://llvm.org/viewvc/llvm-project?rev=266286&view=rev Log: FileSpec: make matching separator-agnostic again Summary: In D18689, I removed the call to Normalize() in FileSpec::SetFile, because it no longer seemed needed, an

Re: [Lldb-commits] [PATCH] D19052: Make destructor breakpoint location test more resilient

labath updated this revision to Diff 53694. labath added a comment. One more tweak to make the test work on linux clang: I've needed to move the constructors out-of-line to make sure the compiler generates the expected symbols. http://reviews.llvm.org/D19052 Files: packages/Python/lldbsuit

[Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

labath created this revision. labath added reviewers: tfiala, ovyalov. labath added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. On some android targets, a binary can produce additional garbage (e.g. warning messages from the dynamic linker) on the standa

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Hi, this has broken basically everything on 32-bit targets . Will you be able to track down the problem quickly? I don't expect the fix to be complicated, but if we can't track it down quickly (1-2 hours?) we should sta

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

labath added a subscriber: labath. labath added a comment. Hi, this has broken basically everything on 32-bit targets http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13413. Will you be able to track down the problem quickly? I don't expect the fix to be complicated, but if

[Lldb-commits] [lldb] r266327 - [test] make expect_state_changes actually expect *only* them

Author: labath Date: Thu Apr 14 10:52:58 2016 New Revision: 266327 URL: http://llvm.org/viewvc/llvm-project?rev=266327&view=rev Log: [test] make expect_state_changes actually expect *only* them The android dirty stderr problem has uncovered an issue where lldbutil.expect_state_changes was readin

[Lldb-commits] [lldb] r266326 - [test] Relax stderr expectations on targets with chatty output

Author: labath Date: Thu Apr 14 10:52:53 2016 New Revision: 266326 URL: http://llvm.org/viewvc/llvm-project?rev=266326&view=rev Log: [test] Relax stderr expectations on targets with chatty output Summary: On some android targets, a binary can produce additional garbage (e.g. warning messages fro

Re: [Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

This revision was automatically updated to reflect the committed changes. Closed by commit rL266326: [test] Relax stderr expectations on targets with chatty output (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19114?vs=53718&id=53737#toc Repository: rL LLVM http://

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

labath added a subscriber: labath. labath added a comment. Judging by the cryptic error message, and the fact that a global variable should not cause an issue, i suspect stdout was a macro in this case... http://reviews.llvm.org/D19092 ___ lldb-com

Re: [Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

labath added a comment. In http://reviews.llvm.org/D19067#401416, @fjricci wrote: > When I use LLVM_LIBDIR_SUFFIX=64, it looks like the python _lldb.so symlink > still points to build/lib/liblldb.so, instead of using the lib64 directory. > So if I do this, none of the tests will run on the chec

[Lldb-commits] [lldb] r266416 - Make destructor breakpoint location test more resilient

Author: labath Date: Fri Apr 15 04:11:22 2016 New Revision: 266416 URL: http://llvm.org/viewvc/llvm-project?rev=266416&view=rev Log: Make destructor breakpoint location test more resilient Summary: The original breakpoint location test was failing for linux, because the compilers here tend to me

Re: [Lldb-commits] [PATCH] D19052: Make destructor breakpoint location test more resilient

This revision was automatically updated to reflect the committed changes. Closed by commit rL266416: Make destructor breakpoint location test more resilient (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19052?vs=53694&id=53860#toc Repository: rL LLVM http://reviews

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Thanks a lot for cleaning that up. I hope you'll be able to find the cause of the 32-bit problems quickly. If you need help reproducing the errors, I can send you some of the detailed logs from our buildbots. cheers, pl On 14 April 2016 at 22:25, Ulrich Weigand wrote: > Ulrich Weigand/Germany/IB

[Lldb-commits] [PATCH] D19153: Work around a linux libc bug causing a crash in TaskPool

labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. Doing a pthread_detach while the thread is exiting can cause crashes or other mischief, so we make sure the thread stays around long enough. The performance impact of the added synchroniz

[Lldb-commits] [lldb] r266423 - Work around a linux libc bug causing a crash in TaskPool

Author: labath Date: Fri Apr 15 05:49:07 2016 New Revision: 266423 URL: http://llvm.org/viewvc/llvm-project?rev=266423&view=rev Log: Work around a linux libc bug causing a crash in TaskPool Summary: Doing a pthread_detach while the thread is exiting can cause crashes or other mischief, so we mak

Re: [Lldb-commits] [PATCH] D19153: Work around a linux libc bug causing a crash in TaskPool

This revision was automatically updated to reflect the committed changes. Closed by commit rL266423: Work around a linux libc bug causing a crash in TaskPool (authored by labath). Changed prior to commit: http://reviews.llvm.org/D19153?vs=53865&id=53869#toc Repository: rL LLVM http://review

Re: [Lldb-commits] [PATCH] D19067: Make sure to use lib instead of lib64 for LLDB_LIB_DIR

labath added a comment. Yes, please use a command-line argument to pass that information into python. http://reviews.llvm.org/D19067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This sounds a lot like the problem that has been plaguing our darwin buildbot (interestingly, I have never seen it happen on linux). Thanks for tracking that down. I am not sure I understand

Re: [Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

labath added a comment. So, I think I have already fixed the problem with r266192. This seems a bit like using a sledgehammer to kill a fly. If anything, I'd add an assert somewhere that makes sure the file names are in the right form to begin with. http://reviews.llvm.org/D19215 _

Re: [Lldb-commits] [PATCH] D19216: test infra cleanup: make test_runner/lib into the test_runner package

labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. Looks good, but I'll defer to Zachary. http://reviews.llvm.org/D19216 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

[Lldb-commits] [lldb] r266598 - Fixup r266327

Author: labath Date: Mon Apr 18 06:01:41 2016 New Revision: 266598 URL: http://llvm.org/viewvc/llvm-project?rev=266598&view=rev Log: Fixup r266327 Fix XFAILed tests in TestThreadStates for the new signature of wait_for_running_event. Modified: lldb/trunk/packages/Python/lldbsuite/test/func

[Lldb-commits] [lldb] r266605 - Attempt to fix darwin build after header refactor in llvm (r266595)

Author: labath Date: Mon Apr 18 07:18:35 2016 New Revision: 266605 URL: http://llvm.org/viewvc/llvm-project?rev=266605&view=rev Log: Attempt to fix darwin build after header refactor in llvm (r266595) Modified: lldb/trunk/source/API/SBHostOS.cpp Modified: lldb/trunk/source/API/SBHostOS.cpp U

Re: [Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, makes sense then, thanks for making sure it's necessary. I don't quite understand how the string makes it's way there though, as the only place setting this field in the entire repository

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

labath added a comment. BTW, we are still seeing these fake timeouts on our buildbot http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/9770, so I am not sure if this actually fixed the problem. It could be that this is actually a different problem, but it does fit your descript

[Lldb-commits] [lldb] r266725 - Fix typo in TestSourceManager.py

Author: labath Date: Tue Apr 19 04:31:14 2016 New Revision: 266725 URL: http://llvm.org/viewvc/llvm-project?rev=266725&view=rev Log: Fix typo in TestSourceManager.py Modified: lldb/trunk/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py Modified: lldb/trunk/packages/Python

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

labath added a subscriber: labath. labath added a comment. Hi, I have reverted this as it was causing a number of failures on the linux build bot http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/13585. I think we'll need to investigate them before putting this in. Do you

[Lldb-commits] [lldb] r266736 - Revert "LLDB: Fixed two race conditions when stopping private state thread"

Author: labath Date: Tue Apr 19 09:03:43 2016 New Revision: 266736 URL: http://llvm.org/viewvc/llvm-project?rev=266736&view=rev Log: Revert "LLDB: Fixed two race conditions when stopping private state thread" This reverts commit r266733 as it causes a number of failures on linux buildbots. Modi

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

labath added a comment. In http://reviews.llvm.org/D19214#405204, @tfiala wrote: > Okay I just looked at those, Pavel. > > They fall into a category that I know is not yet handled. This is the > category: > > - No test method is "open" (i.e. the dotest.py inferior is not in between a > start_t

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. This revision is now accepted and ready to land. Comment at: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp:253 @@ +252,3 @@ +ValueObjectSP allgs_sp = FindGlobal(target_

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

labath added a comment. btw, this does not seem to follow lldb code style (braces on a new line), please reformat that. Repository: rL LLVM http://reviews.llvm.org/D19273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

Re: [Lldb-commits] [PATCH] D19288: test infra: move test event-related handling into its own package

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense. Comment at: packages/Python/lldbsuite/test_event/formatter/curses.py:1 @@ +1,2 @@ +#!/usr/bin/env python + Is this actually supposed to be execut

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D18848#406509, @zturner wrote: > I was under the impression the make build was officially unsupported/dead? You can still cmake to generate makefiles (and it does that by default). In any case, this problem s

[Lldb-commits] [lldb] r267124 - Update comment in lldb-enumerations.h

Author: labath Date: Fri Apr 22 03:41:07 2016 New Revision: 267124 URL: http://llvm.org/viewvc/llvm-project?rev=267124&view=rev Log: Update comment in lldb-enumerations.h Modified: lldb/trunk/include/lldb/lldb-enumerations.h Modified: lldb/trunk/include/lldb/lldb-enumerations.h URL: http://

[Lldb-commits] [lldb] r267392 - Remove flaky decorator from two tests on linux

Author: labath Date: Mon Apr 25 05:32:23 2016 New Revision: 267392 URL: http://llvm.org/viewvc/llvm-project?rev=267392&view=rev Log: Remove flaky decorator from two tests on linux The flakyness is no longer reproducible, and the tests seem to be passing reliably now. Modified: lldb/trunk/p

Re: [Lldb-commits] [PATCH] D19480: Fix ARM attribute parsing for Android after rL267291

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ideally, we'd be able to pick up the fact that we're dealing with an android shared library just from looking at it, but it seems they don't contain any information which would identify them a

[Lldb-commits] [lldb] r267407 - Skip TestBitfileds on linux

Author: labath Date: Mon Apr 25 09:00:23 2016 New Revision: 267407 URL: http://llvm.org/viewvc/llvm-project?rev=267407&view=rev Log: Skip TestBitfileds on linux Test added in r267248 exposed a bug in handling of dwarf produced by clang>=3.9, which causes a crash during expression evaluation. Ski

Re: [Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. I'll let Tamas review this. http://reviews.llvm.org/D19520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D19533: Introduce Connection::ReadAll and fix AdbClient

labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. AdbClient was attempting to handle the case where the socket input arrived in pieces, but it was failing to handle the case where the

[Lldb-commits] [lldb] r267554 - Bump up timeout in TestCallWithTimeout

Author: labath Date: Tue Apr 26 08:37:24 2016 New Revision: 267554 URL: http://llvm.org/viewvc/llvm-project?rev=267554&view=rev Log: Bump up timeout in TestCallWithTimeout Expression very rarely (linux buildbot, build 13907) completed before we managed to interrupt it. Modified: lldb/trunk

Re: [Lldb-commits] [PATCH] D19535: Fix 2 LLVM assertion caoused by an API missues in Scalar

labath added a comment. Could you please add one or two unit tests for this in ScalarTest? http://reviews.llvm.org/D19535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12083: [LLGS] Avoid misrepresenting log lines as inferior output

labath created this revision. labath added reviewers: clayborg, ovyalov. labath added subscribers: lldb-commits, dean. in case we are logging to stdout, any log lines from the forked child can be misconstrued to be inferior output. To avoid this, we disable all logging immediately after forking.

<    17   18   19   20   21   22   23   24   25   26   >