labath closed this revision.
labath added a comment.
Submitted in r276406.
https://reviews.llvm.org/D22628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
It seems this was added in 2014 for cross-compilation for android. Given that
it's in a `if ! PYTHON` block and we don't use python anymore on android, I
think it's pretty safe to remove.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D22771
___
Author: labath
Date: Tue Jul 26 03:11:57 2016
New Revision: 276734
URL: http://llvm.org/viewvc/llvm-project?rev=276734&view=rev
Log:
Fix DataExtractor::PeekData for zero length peeks
Summary:
The function was returning the null pointer for peeks of size zero, which seems
like a sensible
thing to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276734: Fix DataExtractor::PeekData for zero length peeks
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D22755?vs=65339&id=65478#toc
Repository:
rL LLVM
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276735: Fix incorrect form test in SymbolFileDWARF (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D22756?vs=65340&id=65479#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: labath
Date: Tue Jul 26 03:16:19 2016
New Revision: 276735
URL: http://llvm.org/viewvc/llvm-project?rev=276735&view=rev
Log:
Fix incorrect form test in SymbolFileDWARF
Summary:
We were checking whether an attribute is in block form by getting the block
data pointer, which
was not correct
This fix is going to be flaky: Since the private state can flip back
and forth between running and stopped and there's no sychronization
between the private state thread and this code, you're going to get
unpredictable behavior depending on the exact moment you call
Destroy().
I assume the other t
On 27 July 2016 at 17:41, Jim Ingham wrote:
> If you go to halt a thread whose private state is running, and by the time
> you get to halting it the private state has gone from running to stopped then
> the code doing the halt will declare victory, since that's what it was trying
> to do. If i
On 27 July 2016 at 23:39, Jim Ingham wrote:
>
> Yes, I see.
>
> This change always checks public state running, so all the flips from run to
> stopped in the private state thread will have no effect on all the modes of
> running except expression evaluation.
>
> The change as is is better than w
labath added a subscriber: labath.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandPluginInterface *impl, const
char* help);
+AddCommand (const char* name, lldb::SBCom
labath updated this revision to Diff 65895.
labath marked 2 inline comments as done.
labath updated the summary for this revision.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D22629
Files:
source/Plugins/Process/gdb-remote/CMakeLists.txt
source/Plugins/Process/
labath added a comment.
In https://reviews.llvm.org/D22629#498135, @clayborg wrote:
> I have some reservations about your future changes to add concurrent packets.
> We should discuss this at length before you try to make any changes on the
> mailing list.
Agreed. I have a follow-up almost re
labath added inline comments.
Comment at: source/API/SBCommandInterpreter.cpp:156
@@ -155,3 +155,3 @@
}
-lldb::SBCommandPluginInterface* m_backend;
+std::shared_ptr m_backend;
};
abhishek.aggarwal wrote:
> clayborg wrote:
> > Can't change public API,
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
This change adds the ability to the client to send multiple packets without
waiting for the
response to the first one. The individual senders
labath added a comment.
Looks great, thanks.
Please just fix the null pointer issue and we are good to go.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1506
@@ -1502,2 +1505,3 @@
{
llvm::StringRef path(data.GetCStr(&offset));
Author: labath
Date: Fri Jul 29 05:34:52 2016
New Revision: 277133
URL: http://llvm.org/viewvc/llvm-project?rev=277133&view=rev
Log:
Fixup r277011 - wrong use of infinite timeout
The commit accidentally switched a timed wait on a condition variable into an
infinite timeout.
Change that back. And
labath added a comment.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:269
@@ +268,3 @@
+void
+GDBRemoteClientBase::OnRunPacketSent(bool first)
+{
Will do. At that point this whole function becomes pretty irrelevant and i will
inline it
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
thanks
https://reviews.llvm.org/D22917
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
Author: labath
Date: Fri Jul 29 08:10:02 2016
New Revision: 277139
URL: http://llvm.org/viewvc/llvm-project?rev=277139&view=rev
Log:
Rewrite gdb-remote's SendContinuePacketAndWaitForResponse
SendContinuePacketAndWaitForResponse was huge function with very complex
interactions with
several other
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277139: Rewrite gdb-remote's
SendContinuePacketAndWaitForResponse (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D22629?vs=65895&id=66113#toc
Repository:
rL LLVM
https://rev
labath added a comment.
I am going to put my responses inilne:
In https://reviews.llvm.org/D22914#499519, @clayborg wrote:
> A few things that worry me:
>
> - There are no sequence IDs on any packets so when receiving responses, I am
> not sure how you are going to match up packets with their r
Author: labath
Date: Fri Jul 29 10:41:52 2016
New Revision: 277154
URL: http://llvm.org/viewvc/llvm-project?rev=277154&view=rev
Log:
Revert "Rewrite gdb-remote's SendContinuePacketAndWaitForResponse"
This reverts commit r277139, because:
- broken unittest on windows (likely typo on my part)
- see
labath added a subscriber: labath.
labath added a comment.
Ok, there is one more big difference: MainLoop doesn't have timeouts yet. So
yes, I guess these are not yet ready for merging...
https://reviews.llvm.org/D22950
___
lldb-commits mailing lis
labath resigned from this revision.
labath removed a reviewer: labath.
labath added a comment.
@clayborg should approve any changes touching the debugserver.
https://reviews.llvm.org/D23070
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
Author: labath
Date: Mon Aug 8 07:26:57 2016
New Revision: 277997
URL: http://llvm.org/viewvc/llvm-project?rev=277997&view=rev
Log:
Remove _isatty from Android.h
it is just #defined to isatty anyway, which lldb already knows how to use.
Modified:
lldb/trunk/include/lldb/Host/android/Android
Author: labath
Date: Mon Aug 8 07:40:11 2016
New Revision: 277999
URL: http://llvm.org/viewvc/llvm-project?rev=277999&view=rev
Log:
Remove SYS_tgkill from Android.h
instead, use __NR_tgkill directly, which seems to be the preferred form in the
codebase anyway.
Modified:
lldb/trunk/include/
Author: labath
Date: Mon Aug 8 07:54:36 2016
New Revision: 278000
URL: http://llvm.org/viewvc/llvm-project?rev=278000&view=rev
Log:
Remove Android.h
It only contained a reimplementation of std::to_string, which I have replaced
with usages of
pre-existing llvm::to_string (also, injecting members
Author: labath
Date: Mon Aug 8 08:13:03 2016
New Revision: 278001
URL: http://llvm.org/viewvc/llvm-project?rev=278001&view=rev
Log:
Clean up linux/Ptrace.h
This removes references to PT_XXX macros from the file, as they were not used
anyway. It also
changes the macro used to check for the defin
Author: labath
Date: Mon Aug 8 08:38:33 2016
New Revision: 278005
URL: http://llvm.org/viewvc/llvm-project?rev=278005&view=rev
Log:
Fix uninitialized field warnings in GDBRemoteRegisterContext
also take the opportunity to replace NULL with nullptr and add clang-format
guards to prevent it
from
labath added a comment.
Any thoughts on this, Greg?
https://reviews.llvm.org/D22914
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Sean, if you don't object, I am going to put this in next week.
pl
https://reviews.llvm.org/D17856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Greg, what do you think about this?
https://reviews.llvm.org/D22369
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I agree with Tamas that this should somehow be handled in a different way. llvm
already installs a bunch of cmake files. I think we should figure out a way to
get the things we need
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
This will break a several use cases we are relying on. More details inline.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:288
@@ -289,3 +287,3 @@
#
labath abandoned this revision.
labath added a comment.
Ok, thanks for the explanation. It'll take some time for me to parse all the
information there, but this is not a priority for us now. Maybe I'll come back
to this later, but I'm fine with leaving it like this for now.
https://reviews.llv
labath added a comment.
These are the results before and after applying this change (on linux):
Before:
(lldb) process plugin packet speed-test
Testing sending 1000 packets of various sizes:
qSpeedTest(send=0 , recv=0 ) in 0.057456000 sec for 17404.62
packets/sec ( 0.057456 ms
labath added a comment.
I would implement this logic slightly differently: Have a ternary setting,
let's call it `debugger.interactive`, whose values are `never, always, auto`,
with `auto` (the current behavior) being the default. I think that makes it the
behavior of the debugger more predicti
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:304
@@ +303,3 @@
+ $(subst $(3),$(1),$(2)), \
+ $(if $(findstring ar,$(1)), \
+$(if $(findstring gcc,$(3)), \
--
Zach, it looks like you have a `#define LLVM_PRETTY_FUNCTION
LLVM_PRETTY_FUNCTION` in the non-windows path in test_common.h, which
makes it a no-op. If you change the definition to __PRETTY_FUNCTION__
then it should work.
pl
On 10 August 2016 at 05:21, Todd Fiala via lldb-commits
wrote:
> That s
labath added a comment.
In https://reviews.llvm.org/D22914#510084, @clayborg wrote:
> Let me know how things look on Mac. Our lock primitives are not as fast as
> linux. If all looks good on Mac speed wise, we should be good to go.
These are the results on Mac. Before:
Testing sending 1000
labath updated this revision to Diff 67507.
labath added a comment.
The patch I used to run the tests. Still very much WIP.
https://reviews.llvm.org/D22914
Files:
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
source/Plugi
Author: labath
Date: Wed Aug 10 08:30:20 2016
New Revision: 278222
URL: http://llvm.org/viewvc/llvm-project?rev=278222&view=rev
Log:
Make sure files include what they use (part 1/N)
preparation for the big clang-format.
Modified:
lldb/trunk/include/lldb/Core/Flags.h
lldb/trunk/include/ll
labath added a subscriber: zturner.
labath added a comment.
I think I have understood the situation a bit more now, so let me try to
explain what is going on.
In https://reviews.llvm.org/D23290#511683, @clayborg wrote:
> Is this something the user is typing in your IDE that you are forwarding t
On 11 August 2016 at 00:41, Zachary Turner via lldb-commits
wrote:
> Couple of random style comments below. You don't have to fix these, just
> something to think about in the future.
>
>
>
> On Wed, Aug 10, 2016 at 4:33 PM Greg Clayton via lldb-commits
> wrote:
>>
>> +
>> +TEST_F(PythonDataObje
Author: labath
Date: Thu Aug 11 04:22:22 2016
New Revision: 278325
URL: http://llvm.org/viewvc/llvm-project?rev=278325&view=rev
Log:
Remove a double send of eRunPacketSent event
I accidentaly added the send both to the base class and the derived class in my
refactor. Fix
that.
Modified:
ll
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added subscribers: lldb-commits, tberghammer.
The following problem was occuring:
- broadcaster B had two listeners: L1 and L2 (thread T1)
- (T1) B has started to broadcast an event, it has locked a shared_ptr to L1 (i
Author: labath
Date: Thu Aug 11 09:12:10 2016
New Revision: 278335
URL: http://llvm.org/viewvc/llvm-project?rev=278335&view=rev
Log:
Make sure files include what they use (part 2/2)
This makes lldb still compile on linux after a project-wide clang-format
Modified:
lldb/trunk/source/Plugins/P
labath added a comment.
Looks great, just give me a while to prepare the new paths on the buildbots.
Should be done by tomorrow.
https://reviews.llvm.org/D20386
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: labath
Date: Thu Aug 11 10:31:30 2016
New Revision: 278345
URL: http://llvm.org/viewvc/llvm-project?rev=278345&view=rev
Log:
Fix unit tests on windows
Python headers need to be included before PosixApi.h
Modified:
lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.c
labath added a comment.
Hm... there is one more problem here.. when we run the tests against a
top-of-tree clang that we have just built, we will compute AR and OBJCOPY to be
in the build directory. They will obviously not be there, and we cannot just
create the symlinks there by hand because t
labath added a comment.
Ok. After some though I have come up with this:
- leave the tool computation logic as it is in the last version of your patch
- add the ability to override the tool values via environment variables.
Basically this would mean using `TOOL ?= value` instead of `TOOL = value`
Author: labath
Date: Fri Aug 12 04:39:22 2016
New Revision: 278490
URL: http://llvm.org/viewvc/llvm-project?rev=278490&view=rev
Log:
Make TestCallStopAndContinue clang-format-resilient
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinu
Author: labath
Date: Fri Aug 12 04:52:14 2016
New Revision: 278491
URL: http://llvm.org/viewvc/llvm-project?rev=278491&view=rev
Log:
XFAIL TestNamespaceDefinitions on gcc-4.8 and below
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace_definitions/TestNamespaceDefinitions
Author: labath
Date: Fri Aug 12 06:20:21 2016
New Revision: 278500
URL: http://llvm.org/viewvc/llvm-project?rev=278500&view=rev
Log:
Fix-up r278299 for windows
FD_SETSIZE on windows limits the number of file descriptors, rather than their
individual
magnitude (the underlying implementation uses
Fyi. Please check if I got that right.
-- Forwarded message --
From: Pavel Labath via lldb-commits
Date: 12 August 2016 at 12:20
Subject: [Lldb-commits] [lldb] r278500 - Fix-up r278299 for windows
To: lldb-commits@lists.llvm.org
Author: labath
Date: Fri Aug 12 06:20:21 2016
New
labath added a comment.
Jim, just to double-check. Was that an "approve" then?
My feeling is that the lack of visibility into the SmallVector, means more that
we should resurrect the formatter than that we should stop using it. Especially
considering the whole "let's integrate closer with llvm"
Author: labath
Date: Mon Aug 15 04:17:13 2016
New Revision: 278662
URL: http://llvm.org/viewvc/llvm-project?rev=278662&view=rev
Log:
Fixup r278524 for non-apple targets
The commit started passing a nullptr port into
GDBRemoteCommunication::StartDebugserverProcess.
The function was mostly handlin
labath added a comment.
In https://reviews.llvm.org/D23406#513927, @jingham wrote:
> Yes, sorry. I seem to have trouble with remembering the Action dropdown...
> Thanks for figuring this out - and apologies for any hair loss we
> inadvertently caused you!
No worries.
> I doubt it is import
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278664: Fix a race in Broadcaster/Listener interaction
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23406?vs=67686&id=68007#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: labath
Date: Mon Aug 15 04:53:08 2016
New Revision: 278664
URL: http://llvm.org/viewvc/llvm-project?rev=278664&view=rev
Log:
Fix a race in Broadcaster/Listener interaction
Summary:
The following problem was occuring:
- broadcaster B had two listeners: L1 and L2 (thread T1)
- (T1) B has st
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278670: Fix expression evaluation with operator new
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D17856?vs=56252&id=68036#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: labath
Date: Mon Aug 15 09:32:32 2016
New Revision: 278670
URL: http://llvm.org/viewvc/llvm-project?rev=278670&view=rev
Log:
Fix expression evaluation with operator new
Summary:
referencing a user-defined operator new was triggering an assert in clang
because we were
registering the func
Author: labath
Date: Tue Aug 16 04:36:29 2016
New Revision: 278785
URL: http://llvm.org/viewvc/llvm-project?rev=278785&view=rev
Log:
Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class
Despite its comment, the function is only used in the Client class, and its
presence was
labath added a comment.
The implementation looks nice and clean. I have only some stylistic comments
giving it finishing touches..
Comment at: source/Plugins/Process/minidump/CMakeLists.txt:6
@@ +5,3 @@
+ MinidumpParser.cpp
+ #ProcessMinidump.cpp
+ #ThreadMinidump.cpp
--
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
When saving/restoring registers the GDBRemoteRegisterContext class was manually
constructing
the register save/restore packets. This creates appropriate helper functions in
GDBRemoteCommunica
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:601
@@ -600,3 @@
-
-if (gdb_comm.SendPacketAndWaitForResponse(packet, packet_len,
response, false) == GDBRemoteCommunication::PacketResult::Success)
-
labath updated this revision to Diff 68171.
labath added a comment.
Fix indentation
https://reviews.llvm.org/D23553
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
source/Plugins/Process/gdb-remote/
labath added a comment.
In https://reviews.llvm.org/D22914#511294, @clayborg wrote:
> OK. I can't complain if it doesn't affect performance and could allow
> multiple packets to be in flight with threading, though I think solving this
> issue with threading is a bit of a hack, but it should wor
labath created this revision.
labath added a reviewer: zturner.
labath added a subscriber: lldb-commits.
Cmake 2.8 support is gone and not coming back. We can remove a bit of legacy
code now.
https://reviews.llvm.org/D23554
Files:
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBConfig.cmake
labath added a comment.
Sounds that we're agreed then. Can you please update the patch to use `?=` as
appropriate? I will update the buildbots to set these variables explicitly as
needed, and then we can get this in.
https://reviews.llvm.org/D20386
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278915: Move packet construction from
GDBRemoteRegisterContext go the communication… (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23553?vs=68171&id=68323#toc
Repository:
r
Author: labath
Date: Wed Aug 17 03:53:31 2016
New Revision: 278915
URL: http://llvm.org/viewvc/llvm-project?rev=278915&view=rev
Log:
Move packet construction from GDBRemoteRegisterContext go the communication
class
Summary:
When saving/restoring registers the GDBRemoteRegisterContext class was m
Author: labath
Date: Wed Aug 17 04:12:21 2016
New Revision: 278916
URL: http://llvm.org/viewvc/llvm-project?rev=278916&view=rev
Log:
Remove manual packet construction from
GDBRemoteRegisterContext::SetPrimordialRegister
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegister
Author: labath
Date: Wed Aug 17 04:17:08 2016
New Revision: 278918
URL: http://llvm.org/viewvc/llvm-project?rev=278918&view=rev
Log:
Fix unittest compilation error in r278915
Modified:
lldb/trunk/unittests/Process/gdb-remote/GDBRemoteTestUtils.cpp
lldb/trunk/unittests/Process/gdb-remote/G
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Before this, each function had a copy of the code which handled appending of
the thread suffix to
the packet (or using $Hg instead). I have moved that code into a single
function and made
ev
Author: labath
Date: Wed Aug 17 06:55:50 2016
New Revision: 278924
URL: http://llvm.org/viewvc/llvm-project?rev=278924&view=rev
Log:
Remove cmake legacy code
Summary: Cmake 2.8 support is gone and not coming back. We can remove a bit of
legacy code now.
Reviewers: zturner
Subscribers: lldb-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278924: Remove cmake legacy code (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23554?vs=68172&id=68338#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23554
Files:
lld
Author: labath
Date: Wed Aug 17 07:00:19 2016
New Revision: 278925
URL: http://llvm.org/viewvc/llvm-project?rev=278925&view=rev
Log:
Fix unittests on windows after r278915
Apparently clang will happily capture a const variable in a lambda without it
being specified in
the capture clause. MSVC do
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
CPlusPlusLanguage::MethodName was not correctly parsing templated functions
whose demangled name
included the return type -- the space before the function name was included in
the "context"
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I have updated the buildbots to appropriately set these variables. Hopefully we
will have a smooth transition.
Thanks for your patience.
https://reviews.llvm.org/D20386
__
Author: labath
Date: Thu Aug 18 03:21:42 2016
New Revision: 279039
URL: http://llvm.org/viewvc/llvm-project?rev=279039&view=rev
Log:
Fix tests for the gdb-remote memory read packets
Part of TestGDBRemoteMemoryRead has been disabled since r259379 because it was
incompatible with
python3. This cha
Author: labath
Date: Thu Aug 18 03:21:38 2016
New Revision: 279038
URL: http://llvm.org/viewvc/llvm-project?rev=279038&view=rev
Log:
Fix parsing of complicated C++ names
Summary:
CPlusPlusLanguage::MethodName was not correctly parsing templated functions
whose demangled name
included the return
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279038: Fix parsing of complicated C++ names (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D23608?vs=68344&id=68493#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23608
Author: labath
Date: Thu Aug 18 03:30:03 2016
New Revision: 279040
URL: http://llvm.org/viewvc/llvm-project?rev=279040&view=rev
Log:
gdb-remote: Centralize thread specific packet handling
Summary:
Before this, each function had a copy of the code which handled appending of
the thread suffix to
t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279040: gdb-remote: Centralize thread specific packet
handling (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23604?vs=68337&id=68495#toc
Repository:
rL LLVM
https://review
Author: labath
Date: Thu Aug 18 07:32:41 2016
New Revision: 279057
URL: http://llvm.org/viewvc/llvm-project?rev=279057&view=rev
Log:
Move QSyncThreadState packet generation to the gdb-remote client
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
ll
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
The tricky part here was that the exisiting implementation of WriteAllRegisters
was expecting
hex-encoded data (as that was what the first implementation I replaced was
using, but here we ha
Author: labath
Date: Thu Aug 18 09:33:55 2016
New Revision: 279070
URL: http://llvm.org/viewvc/llvm-project?rev=279070&view=rev
Log:
gdb-remote: Remove manual locking from GetShlibInfoAddr
The function can simply call the non-NoLock version of the SendPacket function
and let it do the
locking.
labath added a comment.
> > Do you have a suggestion where the parsing code to be, if not in the same
> > directory?
>
>
> The parsing code will end up being used by multiple plugins--the new one
> you're building for Linux and the existing one that's Windows-specific.
I was hoping that w
You added LLDB as a subsriber. I don't know what that is, but the
correct name for the list is "lldb-commits".
pl
On 19 August 2016 at 04:54, Todd Fiala via lldb-commits
wrote:
> Huh, that is totally weird. I wonder what happened there?
>
> On Thu, Aug 18, 2016 at 8:12 PM, Zachary Turner wrote
Author: labath
Date: Fri Aug 19 07:31:49 2016
New Revision: 279232
URL: http://llvm.org/viewvc/llvm-project?rev=279232&view=rev
Log:
Remove the last manually constructed packet from gdb-remote register context +
small refactor
Summary:
The tricky part here was that the exisiting implementation o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279232: Remove the last manually constructed packet from
gdb-remote register context… (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23659?vs=68525&id=68676#toc
Repository:
labath added a comment.
Looks good as far as I am concerned. You might want to add a test or two that
makes sure we handle invalid data reasonably. E.g., load only the first X kb of
the minidump (so that the thread list is not present in the loaded block), and
make sure getting a thread list fa
Author: labath
Date: Fri Aug 19 08:14:13 2016
New Revision: 279238
URL: http://llvm.org/viewvc/llvm-project?rev=279238&view=rev
Log:
Fix 32-bit builds after r279232
GetByteSize() of a DataBuffer returns a uint64_t (it probably shouldn't), which
isn't implicitly
convertible to size_t.
Modified:
Author: labath
Date: Tue Aug 23 07:10:03 2016
New Revision: 279512
URL: http://llvm.org/viewvc/llvm-project?rev=279512&view=rev
Log:
Fix API usage in TestMultithreaded.test_sb_api_listener_event_process_state
The test was attempting to backtrace a process after every state change event
(includin
Author: labath
Date: Tue Aug 23 07:10:09 2016
New Revision: 279513
URL: http://llvm.org/viewvc/llvm-project?rev=279513&view=rev
Log:
Fix a crash in GDBRemoteCommunicationClient::GetSupportedStructuredDataPlugins
The function was attempting to write the reply to the log even if the reply was
empt
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
This is a preparatory commit for D22914, where I'd like to replace this mutex
by an R/W lock
(which is also not recursive). This required a couple of changes:
- Read/WriteRegister expect the
labath added a comment.
In https://reviews.llvm.org/D23802#523244, @clayborg wrote:
> The old mutex was there so that you could send a packet and get a result
> without worrying about other threads getting your response. It was recursive
> for the case where we needed to send two packets as one
labath updated this revision to Diff 69088.
labath added a comment.
Sounds good. I like that this enables us to get rid of the NoLock suffix.
Maybe eventually we could event replace the runtime assert with some sort of a
static lock
discipline checking framework, where you annotate functions wit
labath created this revision.
labath added reviewers: zturner, emaste, krytarowski.
labath added subscribers: lldb-commits, clayborg.
Herald added a subscriber: emaste.
Previously the builting demangler was on for platforms that explicitly set a
flag by modifying
Mangled.cpp (windows, freebsd). T
1601 - 1700 of 6833 matches
Mail list logo
