[Lldb-commits] [PATCH] D60271: PDBFPO: Use references instead of pointers, where possible

labath created this revision. labath added reviewers: aleksandr.urakov, amccarth. The code was passing pointers around, expecting they would be not null. In c++ it is possible to convey this notion explicitly by using a reference instead. Not all uses of pointers could be converted to references

[Lldb-commits] [PATCH] D60300: [testsuite] Split Objective-C data formatter

labath added a comment. Looks fine to me, with some inline ideas you can implement if you think they're worthwhile. Also, since you're looking at reducing test time, the question you can ask yourself is: is it really worth it running separate dwarf+dsym flavours of these tests? I'm of the view

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

labath added a comment. In D60172#1455767 , @jasonmolenda wrote: > Thanks Pavel, I'll convert this to use Expected<> while I'm working on it. > I'm writing a test case right now, and looking at how DynamicPluginDarwin > works more closely for adding &

[Lldb-commits] [PATCH] D60271: PDBFPO: Use references instead of pointers, where possible

labath added a comment. In D60271#1455106 , @amccarth wrote: > I noticed this also deleted two overloads of Visit from > FPOProgramASTVisitorDWARFCodegen, but that appears to be harmless (the base > class overloads were also no-ops). Yep, that was a dr

[Lldb-commits] [PATCH] D60271: PDBFPO: Use references instead of pointers, where possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL357744: PDBFPO: Use references instead of pointers, where possible (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGE

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. You might be interested to know that I've just seen TestVSCode_step flake (so far just once out of ~dozen runs) locally. I've committed r357747 to get a better error message if it happens again. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL357749: Minidump: Add support for reading/writing strings (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D59775?vs=193698&id=193842#toc Repository: rL LLVM CH

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath marked 3 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h:173 + llvm::DenseMap UnwindRules; +}; + amccarth wrote: > I'm not a fan of deep class hierarchies, but given that StackCFIReco

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath updated this revision to Diff 193849. labath added a comment. merge StackCFI and StackCFIInit records add some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60268/new/ https://reviews.llvm.org/D60268 Files: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp source/

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

labath added a comment. I really like how you've approached testing this. There's just one thing that bothers me. Using a .s file means it's going to be hard to make this test work on other OSs (and we should be able to test something like this in a cross-OS manner). All elf targets should prob

[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

labath added a comment. In D60180#1456263 , @sgraenitz wrote: > > No, everything is being built for android. Cross-compiling lldb-server > > involves cross-compiling llvm libraries, clang libraries, and if you've got > > swift in the picture, swift host

[Lldb-commits] [PATCH] D60400: Remove unneeded #ifdef SWIGs

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. Some of these were present in files which should never be read by swig (and we also had one in the interface file, which is only read by swig). They are probably leftovers from the time when we were running swig

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath marked 5 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:393 + llvm::StringRef LHS, RHS; + while (std::tie(Str, Line) = getToken(Line), !Str.empty()) { +if (Str.back() == ':') { // regN ---

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath updated this revision to Diff 194108. labath marked 2 inline comments as done. labath added a comment. Remove the fancy parsing of register expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60268/new/ https://reviews.llvm.org/D60268 Files: source/Plugins/ObjectFile/Br

[Lldb-commits] [PATCH] D60121: Object/Minidump: Add support for reading the ModuleList stream

This revision was automatically updated to reflect the committed changes. Closed by commit rL357897: Object/Minidump: Add support for reading the ModuleList stream (authored by labath, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60121/new/ https:/

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg, zturner. Herald added a project: LLVM. This patch adds support for yaml (de)serialization of the minidump ModuleList stream. It's a fairly straight forward-application of the existing patterns to the ModuleList s

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath created this revision. labath added reviewers: aleksandr.urakov, amccarth. This patch attempts to solve two issues made this code hard to follow for me. The first issue was that a lot of what these visitors do is mutate the AST. The visitor pattern is not particularly good for that because

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath added a comment. I find this version easier to follow than the old one, but that could be simply because I didn't write it. :P So if you believe the old one is better, I am happy to just drop this and carry on with the old one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60410

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath updated this revision to Diff 194160. labath added a comment. Fix a bug which meant we weren't replacing the root node correctly (I somehow forgot to run tests before uploading). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60410/new/ https://reviews.llvm.org/D60410 Files: so

[Lldb-commits] [PATCH] D60440: [lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket setup

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you for doing this. We probably should have done something like this a long time ago. I have a couple of inline comments, but they're all very trivial. Feel free to commit, if you agree

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

labath added a subscriber: zturner. labath added inline comments. Comment at: lldb/lit/Register/x86-mm-xmm-read.test:1 +# REQUIRES: x86 +# RUN: %clang %p/Inputs/x86-mm-xmm-read.s -o %t mgorny wrote: > labath wrote: > > Does this mean "the host is an x86 system",

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

labath marked an inline comment as done. labath added inline comments. Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91 + size_t BlobAllocator::allocateString(StringRef Str) { SmallVector WStr; clayborg wrote: > Might be nice to unique the strings in here? Yeah

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

This revision was automatically updated to reflect the committed changes. Closed by commit rL357975: Breakpad: Parse Stack CFI records (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D60400: Remove unneeded #ifdef SWIGs

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357984: Remove unneeded #ifdef SWIGs (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D60400?vs=1

[Lldb-commits] [PATCH] D60458: [zorg] Add lldb-x86_64-debian builder

labath created this revision. labath added reviewers: jankratochvil, stella.stamenova, zturner, gkistanova. Initially, the builder will be silent, because I expect noise from flaky tests. Once those have been dealt with, I'd like to switch on breakage notifications. https://reviews.llvm.org/D604

[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

labath added a comment. No opinion on the patch, but what is the reason for having settings that are shared between multiple Debugger instances? My expectation was that the debugger objects are completely independent, and I would be surprised if the value of some setting changed from under me b

[Lldb-commits] [PATCH] D60496: [lldb-server] Use std::thread/mutex for all platforms

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, with some inline comments about additional c++11 goodies we can use to clean up this file further. (Also, it might be good to mention in the patch title that this is about modifying the

[Lldb-commits] [PATCH] D60468: Lock accesses to OptionValueFileSpecList objects

labath added a comment. In D60468#1460212 , @friss wrote: > In D60468#1460065 , @labath wrote: > > > No opinion on the patch, but what is the reason for having settings that > > are shared between multiple Debugger

[Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for lldb-server on Windows

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:294 + + lldb_private::UUID m_uuid; }; asmith wrote: > labath wrote: > > Move UUID handling into a separate patch. > The UUID c

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added a comment. Herald added a project: LLDB. In D56229#1346941 , @zturner wrote: > Well, I guess I would ask what you want to do with the GUID? If you want to > match it to a debug information file, then the Debug Directory is the correct > way

[Lldb-commits] [PATCH] D60458: [zorg] Add lldb-x86_64-debian builder

This revision was automatically updated to reflect the committed changes. Closed by commit rL358054: [zorg] Add lldb-x86_64-debian builder (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D60501: Minidump: extend UUID byte-swapping to windows platform

labath created this revision. labath added reviewers: clayborg, amccarth, markmentovai, asmith. D59433 added code to swap bytes UUIDs coming from minidump files, but only enabled it for apple platforms. Based on my research, I believe this is the correct thing to

[Lldb-commits] [PATCH] D60508: [NFC] Remove ASCII lines from comments

labath added a comment. Let's ship it. :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60508/new/ https://reviews.llvm.org/D60508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D60498: Clean up docstrings in swig interface files

labath added a comment. This is purely a guess on my part, but I think this is an artefact of the process which was used to produce the swig interface files initially, though I don't know what that process actually was. I don't think doxygen ever reads these files, as it can parse the real c++

[Lldb-commits] [PATCH] D60501: Minidump: extend UUID byte-swapping to windows platform

This revision was automatically updated to reflect the committed changes. Closed by commit rL358169: Minidump: extend UUID byte-swapping to windows platform (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES S

[Lldb-commits] [PATCH] D60566: [test] Convert CommandScriptImmediateOutput from pexpect to lit

labath added inline comments. Comment at: lldb/lit/Commands/CommandScriptImmediateOutput/CommandScriptImmediateOutputFile.test:4-5 + +# RUN: echo "READ" > %t.read.txt +# RUN: echo "READ PLUS" > %t.read_plus.txt + The original test writes to all files it checks.

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

labath accepted this revision. labath added a comment. The new version looks really great. Thank you. As I mentioned previously, I think this will probably fail on windows, so I suggest you look out for the bot and be prepared to add an XFAIL here. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath updated this revision to Diff 194705. labath added a comment. After trying to use this in new code, I realized that the CRTP is not really needed for what I am trying to achieve here. The same can be achieved through more standard virtual functions. This updates the patch to use virtual fu

[Lldb-commits] [PATCH] D60496: [lldb-server] Update tests to use std::thread/mutex for all platforms

labath accepted this revision. labath added a comment. LGTM. The ifdefs for the getpid() code and stuff are unfortunate, but I am not sure if using llvm libraries for that is a good idea. Right now we have the ability to compile the tests for a different architecture than the one lldb is built

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358261: PDBFPO: Improvements to the AST visitor (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

labath created this revision. labath added reviewers: jasonmolenda, amccarth, clayborg, JDevlieghere, aleksandr.urakov. Herald added a subscriber: aprantl. The NativePDB plugin contains code to convert "programs" describing the layout of function frames into dwarf (for easier interaction with the

[Lldb-commits] [PATCH] D60608: Make TestVSCode_step pass reliably

labath created this revision. labath added reviewers: clayborg, jgorbe. Herald added a subscriber: jfb. The test was failing occasionally (1% of runs or so), because of unpredictable timings between the two threads spawned by the test. If the second thread hit the breakpoint right as we were stepp

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath added a comment. In D60410#1464214 , @teemperor wrote: > I believe this revision introduced a warning when compiling with Clang: > >98% [4004/4047] Building CXX object > tooldir/PdbFPOProgramToDWARFExpression.cpp.o > > /home/teemperor/ll

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

labath added a comment. A test case? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60737/new/ https://reviews.llvm.org/D60737 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath edited reviewers, added: amccarth, labath; removed: zturner, llvm-commits. labath added a subscriber: amccarth. labath added a comment. s/@zturner/@amccarth, as Zach probably won't have time to review this Comment at: lit/Modules/PECOFF/export-dllfunc.yaml:11-12 + +# ti

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:61 + if (!COFFObj->getDebugPDBInfo(pdb_info, pdb_file) && pdb_info) +return UUID::fromOptionalData(pdb_info->PDB70.Signature); + Is there a specific reason you us

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:60 + llvm::StringRef pdb_file; + if (!COFFObj->getDebugPDBInfo(pdb_info, pdb_file) && pdb_info) +return UUID::fromOptionalData(pdb_info->PDB70.Signature); Hui wr

[Lldb-commits] [PATCH] D60780: [tools] Only build lldb-instr and lldb-vscode if asked.

labath added a comment. LLDB_TOOL_$TOOL_BUILD would be a better name for consistency with llvm. In fact, if we started using the llvm cmake macros like `add_llvm_subdirectory`, it would handle this automatically, including creating the cache variable. The only difference would be that the varia

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added a comment. Thanks. I have a couple of small comments, but I think this is basically done. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:43 +namespace { +using namespace llvm; llvm style is to only use the anonymous namespaces

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. In D60153#1469397 , @jgorbe wrote: > Thanks! Please let me know if it happens again and I'll try my best to debug > it. It is still happening (e.g. http://lab.llvm.org:8014/builders/lldb-x86_64-debian/builds/141), but I already

[Lldb-commits] [PATCH] D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables

labath added a comment. Thanks for adding the test. I guess I've touched this bit when I was working on the dwarf5 index thingy, but all my memory of this function has already been swapped out (and I'm not sure I ever fully understood all the nuances of how it was supposed to work). So yeah, I

[Lldb-commits] [PATCH] D56229: [PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()

labath added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:891-892 + + if (!CreateBinary()) +return UUID(); + auto COFFObj = Hui wrote: > labath wrote: > > I don't think this is necessary as `CreateInstance` will refuse

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

labath created this revision. labath added reviewers: jasonmolenda, clayborg. This argument was added back in 2010 (r118882) to support the ability to unwind from functions whose eh_frame entry does not cover the entire range of the function. However, due to the caching happening in FuncUnwinders

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

labath added a comment. Sure, that's no problem. Thanks for letting me know. BTW, I have a couple more patches in the general unwinding area (part of the breakpad unwinding thing), but I still need to clean those up before they can be put up for review. CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

This revision was automatically updated to reflect the committed changes. labath marked 4 inline comments as done. Closed by commit rL358672: MinidumpYAML: Add support for ModuleList stream (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D60405?vs=194130&i

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

labath added a reviewer: amccarth. labath added a comment. Don't know much about PDBs, but the change seems pretty straight-forward to me. Zach would be the best person to review this, but he's probably busy with other things now. Maybe Adrian could take a look? Repository: rLLDB LLDB CHANG

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

labath added inline comments. Comment at: lib/ObjectYAML/MinidumpYAML.cpp:21 +/// methods, while the final minidump file is written by calling the writeTo +/// method. The plan versions of allocation functions take a reference to the +/// data which is to be written (and hence th

[Lldb-commits] [PATCH] D60608: Make TestVSCode_step pass reliably

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL358847: Make TestVSCode_step pass reliably (authored by labath, committed by ). Herald added a project: LLVM. Herald added

[Lldb-commits] [PATCH] D60948: yamlify TestMiniDumpUUID binaries

labath created this revision. labath added a reviewer: clayborg. Herald added a subscriber: javed.absar. labath marked an inline comment as done. labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids

[Lldb-commits] [PATCH] D60948: yamlify TestMiniDumpUUID binaries

labath marked an inline comment as done. labath added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids.yaml:5 +Processor Arch: AMD64 +Platform ID: MacOSX +CSD Version: '15E216' -

[Lldb-commits] [PATCH] D60949: UnwindPlan: pretty-print dwarf expressions

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added a subscriber: aprantl. Previously we were printing the dwarf expressions in unwind rules simply as "dwarf-expr". This patch uses the existing dwarf-printing capabilities in lldb to enhance this dump output,

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

labath resigned from this revision. labath added a comment. I don't have any opinions on os plugins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___ lldb-co

[Lldb-commits] [PATCH] D60948: yamlify TestMiniDumpUUID binaries

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358957: yamlify TestMiniDumpUUID binaries (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D60948

[Lldb-commits] [PATCH] D60984: [Reproducers] Limit logging to calls that cross the API boundary.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Logging only external calls makes sense to me. The one thing I was not sure about is the name of the `Recorder` class, since it's responsibility was now extended to include logging (and that h

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

labath added a comment. Thanks for the review. Don't worry about the delay -- it has actually coincided with the public holidays on this side of the globe, so I was not working anyway. (but the delay wasn't long even if I had worked) :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D608

[Lldb-commits] [PATCH] D60949: UnwindPlan: pretty-print dwarf expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358959: UnwindPlan: pretty-print dwarf expressions (authored by labath, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL358964: FuncUnwinders: remove "current_offset" from function arguments (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CH

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

labath created this revision. labath added reviewers: amccarth, jingham, clayborg. Herald added a subscriber: mgorny. After the last round of cleanups, this script was almost a no-op. The only piece of functionality that remained was the one which tried to make the swig-generated function signatur

[Lldb-commits] [PATCH] D60599: Move postfix expression code out of the NativePDB plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358976: Move postfix expression code out of the NativePDB plugin (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

labath created this revision. labath added reviewers: amccarth, clayborg, JDevlieghere, aleksandr.urakov. Herald added a subscriber: mgorny. The postfix expressions in PDB and breakpad symbol files are similar enough that they can be parsed by the same parser. This patch generalizes the parser in

[Lldb-commits] [PATCH] D61004: FuncUnwinders: Factor out address validity check

labath created this revision. labath added reviewers: jasonmolenda, aprantl. Some (but not all) of the unwind plan creation functions were checking the validity of their address range before they attempted to create the unwind plan. Since a FuncUnwinders object cannot do anything reasonable with

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added a subscriber: aprantl. This behavior is specified in the Section 6.4.2.3 (Register Rule instructions) of the DWARF4 spec. We were not doing that, which meant that any register rule which was relying on the c

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. In D61018#1475553 , @clayborg wrote: > Got errors trying to compile this .s file on mac: > > $ ~/Documents/src/lldb/svn/lldb/llvm-build/Release+Asserts/x86_64/bin/clang > foo.s -o foo.o > foo.s:3:9: error: unknown directive >

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. Actually, it seems it may be possible to tweak this asm so that it can run on a mac too (windows support unlikely). I'll try to post an updated version soon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018/new/ https://reviews.llvm.org/D61018

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

labath added a comment. Sure. This is the diff: F8747706: modify.diff . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61000/new/ https://reviews.llvm.org/D61000 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath updated this revision to Diff 196253. labath added a comment. This is the version that should at least compile on a mac (it turns out asm is more portable than I expected). I am still building lldb to see if the test will pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018

[Lldb-commits] [PATCH] D61018: RegisterContextLLDB: Push CFA value on DWARF stack when evaluating register expressions

labath added a comment. Indeed the test passes on a mac with just a single linker warning saying it could not create compact unwind info because the %rip save address is weird, but that is not surprising. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61018/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

labath added a comment. gcc-5.4 technically supported, so we can try to make things work for you. I'd be best if you can create a patch that will make things work for you (since it's kinda hard for me to test that). Or at least, can you paste the contents of your cpuid.h somewhere? Repository

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

labath added a comment. In D59991#1475709 , @JosephTremoulet wrote: > In D59991#1475694 , @labath wrote: > > > gcc-5.4 technically supported, so we can try to make things work for you. > > I'd be best if you can c

[Lldb-commits] [PATCH] D27134: Remove ConnectionMachPort

labath created this revision. labath added reviewers: clayborg, jingham. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This class is unused, and since the StringRef refactor, it does not even implement the Connection interface. https://reviews.llvm.org/D27134 Files

[Lldb-commits] [PATCH] D27136: Use Timeout<> in the Listener class

labath created this revision. labath added reviewers: jingham, clayborg, zturner. labath added a subscriber: lldb-commits. Communication classes use the Timeout<> class to specify the timeout. Listener class was converted to chrono some time ago, but it used a different meaning for a timeout of ze

[Lldb-commits] [PATCH] D27161: Fix floating point register reads x86_64 linux on targets with no AVX support

labath created this revision. labath added reviewers: tberghammer, valentinagiusti. labath added a subscriber: lldb-commits. On for 64-bit targets, the correct register set to read the fxsave are is NT_PRFPREG (only 32-bit targets need NT_PRXFPREG, presumably for historic reasons). Reference: http

[Lldb-commits] [PATCH] D27161: Fix floating point register reads x86_64 linux on targets with no AVX support

This revision was automatically updated to reflect the committed changes. Closed by commit rL288038: Fix floating point register reads x86_64 linux on targets with no AVX support (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27161?vs=79388&id=79405#toc Repository:

[Lldb-commits] [PATCH] D27134: Remove ConnectionMachPort

This revision was automatically updated to reflect the committed changes. Closed by commit rL288117: Remove ConnectionMachPort (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27134?vs=79310&id=79518#toc Repository: rL LLVM https://reviews.llvm.org/D27134 Files: ll

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

labath added a comment. Any thoughts on this? https://reviews.llvm.org/D26975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26975: Specify the dependencies of lldb-server manually

This revision was automatically updated to reflect the committed changes. Closed by commit rL288159: Specify the dependencies of lldb-server manually (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26975?vs=78880&id=79584#toc Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D27222: Remove an x86-ism from RegisterInfoInterface

labath created this revision. labath added reviewers: clayborg, dvlahovski. labath added a subscriber: lldb-commits. While adding FPR support to x86 elf core files (https://reviews.llvm.org/D26300), we ended up adding a very x86-specific function to the general RegisterInfoInterface class, which

[Lldb-commits] [PATCH] D27222: Remove an x86-ism from RegisterInfoInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rL288236: Remove an x86-ism from RegisterInfoInterface (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27222?vs=79618&id=79713#toc Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D27136: Use Timeout<> in the Listener class

This revision was automatically updated to reflect the committed changes. Closed by commit rL288238: Use Timeout<> in the Listener class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27136?vs=79313&id=79714#toc Repository: rL LLVM https://reviews.llvm.org/D27136

[Lldb-commits] [PATCH] D27258: Use Timeout<> in Process::RunThreadPlan

labath created this revision. labath added a reviewer: jingham. labath added a subscriber: lldb-commits. Since the function is way too big already, I tried at least to factor out the timeout computation stuff into a separate function. I've tried to make the new code semantically equivalent, and it

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

labath added a comment. In https://reviews.llvm.org/D27126#607057, @dmikulin wrote: > I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software single > step not a lot of tests pass on ARM FreeBSD ;) > Can we get https://reviews.llvm.org/D25756 committed? I'll leave that decision

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath added a comment. Looks like a good starting point. Apart from some style nits, I'd like us to remove sending of the `registers` field in the `jstopinfo`, as it is not necessary anymore. Also, we should add an lldb-server style test for this. @jasonmolenda, we already have jThreadsInfo su

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, after you consider my comment below. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:30 +# Indicating SR.FR bit status +fr_fl

[Lldb-commits] [PATCH] D27258: Use Timeout<> in Process::RunThreadPlan

This revision was automatically updated to reflect the committed changes. Closed by commit rL288326: Use Timeout<> in Process::RunThreadPlan (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27258?vs=79737&id=79886#toc Repository: rL LLVM https://reviews.llvm.org/D272

[Lldb-commits] [PATCH] D26505: Remove a hack from the Android toolchain file

This revision was automatically updated to reflect the committed changes. Closed by commit rL288331: Remove a hack from the Android toolchain file (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26505?vs=77484&id=79889#toc Repository: rL LLVM https://reviews.llvm.or

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath created this revision. labath added reviewers: tberghammer, zturner. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, srhines, danalbert. This replaces all the uses of the __ANDROID_NDK__ define with ANDROID. This is a preparatory step to remove our custom android

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath planned changes to this revision. labath added a comment. Thanks for the suggestion. I'll try using `__ANDROID__` instead. Comment at: cmake/platforms/Android.cmake:36 # flags and definitions remove_definitions( -DANDROID -D__ANDROID__ ) +add_definitions( -DANDROID -DL

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath added a comment. In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > @labath ah I see I hadn't looked at the lldb-server packets so I didn't know > you had jThreadsInfo, good to hear. Yes, if your target is built mostly > -fomit-frame-pointer, lldb-server won't be able to

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath updated this revision to Diff 80043. labath added a comment. Update to use __ANDROID__ https://reviews.llvm.org/D27305 Files: cmake/platforms/Android.cmake include/lldb/Core/RegularExpression.h include/lldb/Host/Config.h include/lldb/Host/Editline.h include/lldb/Host/Host.h i

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath added a comment. I've tried to unify this slightly, but sometimes further unification would make things inconsistent with surrounding preprocessor directives. I was suprised by the presence of some of these ifdefs as well -- some of them seem completely unnecessary. I think that at some

<    14   15   16   17   18   19   20   21   22   23   >