kpdev wrote:
@jimingham Please take a look:
https://github.com/llvm/llvm-project/pull/67782#issuecomment-2047369473
https://github.com/llvm/llvm-project/pull/67782
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
Author: Pavel Kosov
Date: 2023-08-16T11:10:00+03:00
New Revision: 83695d45d62121ab306d0dc108b549d9056a2f28
URL:
https://github.com/llvm/llvm-project/commit/83695d45d62121ab306d0dc108b549d9056a2f28
DIFF:
https://github.com/llvm/llvm-project/commit/83695d45d62121ab306d0dc108b549d9056a2f28.diff
L
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67309
It is a first of three patches neded for adding an ability to update
std::string/wstring/etc during debug process. This patch adds to the synthetic
child interface a “change value” method which goes back to the syn
@@ -75,6 +77,10 @@ class SyntheticChildrenFrontEnd {
// display purposes
virtual ConstString GetSyntheticTypeName() { return ConstString(); }
+ virtual bool SetValueFromCString(const char *value_str, Status &error) {
+return false;
+ }
+
kpdev wrote:
https://github.com/kpdev edited https://github.com/llvm/llvm-project/pull/67309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kpdev wrote:
> This part of the change seems straightforward, if the synthetic child
> provider can set a value it will have to have this API... But yes, if there
> are a bunch of patches that build on one another, if they aren't too big one
> patch that shows the functionality is easier to un
kpdev wrote:
> Getting the SyntheticFrontEnd to try updating the synthetic value is a good
> addition. But I'm not sure that ValueObject should be the one that should
> provide access directly to the FrontEnd? Why isn't it enough to have the
> ValueObjectSynthetic's SetValueFromCString do this
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67782
Before this update strings has only DataFormatters, and therefore the way they
were printed was slightly different (see comment here:
https://github.com/llvm/llvm-project/blob/main/lldb/source/DataFormatters/Format
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67784
When we trying to change not the whole string,
but single character in it - lldb's ValueObject fits in Scalar and therefore
lldb trying to update it as a Scalar value which is currently only support
numbers, so cha
kpdev wrote:
Patch 2: https://github.com/llvm/llvm-project/pull/67782
Patch 3: https://github.com/llvm/llvm-project/pull/67784
https://github.com/llvm/llvm-project/pull/67309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
kpdev wrote:
Depends on:
https://github.com/llvm/llvm-project/pull/67309#issuecomment-1740657973
https://github.com/llvm/llvm-project/pull/67782
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
kpdev wrote:
Depends on:
https://github.com/llvm/llvm-project/pull/67309#issuecomment-1740657973
https://github.com/llvm/llvm-project/pull/67784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
kpdev wrote:
@jimingham @bulbazord Please check patch with all supposed changes (without
breaking into different patches) https://github.com/llvm/llvm-project/pull/67784
https://github.com/llvm/llvm-project/pull/67309
___
lldb-commits mailing list
lld
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67782
>From ccc9fb6be2f390cd894e0632cfded98f329f3059 Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Wed, 10 Apr 2024 14:45:49 +0300
Subject: [PATCH] [LLDB] Add ability to update string during debugging
This is the last
kpdev wrote:
Hello, @jimingham , first of all - sorry for the long delay in reply.
I carefully read through all your messages once again and found, that I totally
misunderstood some places, i.e. "Why isn't it enough to have the
ValueObjectSynthetic's SetValueFromCString do this" - I think it s
Author: Pavel Kosov
Date: 2022-08-10T16:34:52+03:00
New Revision: f63e2cfb7f5235d4d5148988e8a0ef86004da66e
URL:
https://github.com/llvm/llvm-project/commit/f63e2cfb7f5235d4d5148988e8a0ef86004da66e
DIFF:
https://github.com/llvm/llvm-project/commit/f63e2cfb7f5235d4d5148988e8a0ef86004da66e.diff
L
Author: Pavel Kosov
Date: 2022-08-17T09:10:21+03:00
New Revision: ff9efe240c4711572d2892f9058fd94a8bd5336e
URL:
https://github.com/llvm/llvm-project/commit/ff9efe240c4711572d2892f9058fd94a8bd5336e
DIFF:
https://github.com/llvm/llvm-project/commit/ff9efe240c4711572d2892f9058fd94a8bd5336e.diff
L
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67309
>From a0aae1f59fcdc9f0266bdc6248544f674b298e85 Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Mon, 25 Sep 2023 13:41:03 +0300
Subject: [PATCH] [lldb] Add SetValueFromCString API to SyntheticFronend
It is a first
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67309
>From 94d31eabaea7edd2cb139a45fdc8b85d2768f29d Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Mon, 25 Sep 2023 13:41:03 +0300
Subject: [PATCH] [lldb] Add SetValueFromCString API to SyntheticFronend
It is a first
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67782
>From 374784cbaaffe9ca2bac716c996485783b959364 Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Tue, 23 Jan 2024 09:37:54 +0300
Subject: [PATCH] [LLDB] Add ability to update string during debugging
This is the last
Author: Pavel Kosov
Date: 2023-01-25T10:39:50+03:00
New Revision: ff9c31b23b7635f2c97c5f9c33fd4e032b717ad0
URL:
https://github.com/llvm/llvm-project/commit/ff9c31b23b7635f2c97c5f9c33fd4e032b717ad0
DIFF:
https://github.com/llvm/llvm-project/commit/ff9c31b23b7635f2c97c5f9c33fd4e032b717ad0.diff
L
Author: Pavel Kosov
Date: 2023-01-25T10:48:04+03:00
New Revision: 92f0e4ccafacb61f7de93e7ef5bd4beb02047086
URL:
https://github.com/llvm/llvm-project/commit/92f0e4ccafacb61f7de93e7ef5bd4beb02047086
DIFF:
https://github.com/llvm/llvm-project/commit/92f0e4ccafacb61f7de93e7ef5bd4beb02047086.diff
L
Author: Pavel Kosov
Date: 2023-01-25T11:06:07+03:00
New Revision: 2af0a478eaee5e6236e7e9fd9b1e3207228ce2ff
URL:
https://github.com/llvm/llvm-project/commit/2af0a478eaee5e6236e7e9fd9b1e3207228ce2ff
DIFF:
https://github.com/llvm/llvm-project/commit/2af0a478eaee5e6236e7e9fd9b1e3207228ce2ff.diff
L
Author: Pavel Kosov
Date: 2023-01-25T12:03:11+03:00
New Revision: 4ae221f5a4d1977f316b7d5f033763f876b471e7
URL:
https://github.com/llvm/llvm-project/commit/4ae221f5a4d1977f316b7d5f033763f876b471e7
DIFF:
https://github.com/llvm/llvm-project/commit/4ae221f5a4d1977f316b7d5f033763f876b471e7.diff
L
Author: Pavel Kosov
Date: 2021-11-25T21:27:02+03:00
New Revision: 1aab5e653d2cf8b147748d014c5fb513a4670418
URL:
https://github.com/llvm/llvm-project/commit/1aab5e653d2cf8b147748d014c5fb513a4670418
DIFF:
https://github.com/llvm/llvm-project/commit/1aab5e653d2cf8b147748d014c5fb513a4670418.diff
L
kpdev wrote:
> This seems like a somewhat limited way to poke a character into the value if
> the string has more than one character already in it.
>
> If you are trying to do more fancy setting of the contents of an SBValue,
> then it would be more straightforward to get the SBData for the va
kpdev wrote:
> What is it about this change that is defeating the ValueObject printer from
> compressing this output onto one line? It looks like the contents that get
> printed are the same, so there's something about switching from a Summary
> provider to a child provider that's causing prob
kpdev wrote:
> BTW, I have no problem with the general direction of this change. It makes a
> lot more sense to ask a synthetic child provider to change a value - since it
> does represent the value of the ValueObject - rather than the summary which
> is just some free-form text. And being abl
Author: Pavel Kosov
Date: 2022-09-14T11:32:07+03:00
New Revision: a0fb69d17b4d7501a85554010727837340e7b52f
URL:
https://github.com/llvm/llvm-project/commit/a0fb69d17b4d7501a85554010727837340e7b52f
DIFF:
https://github.com/llvm/llvm-project/commit/a0fb69d17b4d7501a85554010727837340e7b52f.diff
L
29 matches
Mail list logo
