[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

2022-05-13 Thread Paul Kirth via Phabricator via lldb-commits
paulkirth added a comment. Hi, Sorry for the late notification, but I think this change may not apply correctly to all configs. We're seeing a breakage in Fuchsia's Clang CI builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814329895908917697/overview

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

2022-05-13 Thread Paul Kirth via Phabricator via lldb-commits
paulkirth added a comment. It's probably fine to reland this after D125570 lands, since that should unblock us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-22 Thread Paul Kirth via Phabricator via lldb-commits
paulkirth added a comment. Hi, we're seeing some build failures after this change. Seems like the TargetParser isn't getting added to LLVMExports correctly. Can you take a look and address these? Failing bot https://ci.chromium.org/ui/p/fuchsia/builders/prod/llvm-linux-x64/b8794232527428765009

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-22 Thread Paul Kirth via Phabricator via lldb-commits
paulkirth added a comment. Sorry for the noise, I missed that that bot is setting a CMake flag that affects LLVM_EXPORTS. Please disregard my earlier message. I just need to update the CMake invocation to fix this, so I don't think there is anything required on your end. Repository: rG LLVM