[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, jaydeep. nitesh.jain added subscribers: bhushan, slthakur, lldb-commits. Herald added a subscriber: sdardis. This patch add fix for reading and writing floating point register based on SR.FR bit. https://reviews.l

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183 @@ +1182,3 @@ + case dwarf_config5_mips64: +return reg_info->byte_offset; + case dwarf_cause_mips: labath wrote: > Why do we need to do th

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 71505. nitesh.jain added a comment. Updated diff as per suggestion. https://reviews.llvm.org/D24603 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h Index: so

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-21 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183 @@ +1182,3 @@ + case dwarf_config5_mips64: +return reg_info->byte_offset; + case dwarf_cause_mips: Changing LLDB numbering scheme is not f

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-09-21 Thread Nitesh Jain via lldb-commits
nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 72024. https://reviews.llvm.org/D24124 Files: source/Core/RegisterValue.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp Index: source/Plugins/Process/Linux/NativeRegisterContextLinux.

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-09-21 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D24124#543823, @clayborg wrote: > A few things about a the RegisterContext class in case it would change and > thing that you are submitting here. The entire register context defines a > buffer of bytes that can contain all register value

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-27 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 72618. nitesh.jain added a comment. Herald added a subscriber: ki.stfu. Updated patch as per suggestion. https://reviews.llvm.org/D24603 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp source/Plugins/Process/Linux/NativeReg

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-09-27 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D24603#548902, @clayborg wrote: > So it seems like this can be fixed by doing a few things: > 1 - just set the RegisterInfo.offset to the actual offset in the buffer and > don't use the offset as the ptrace key used to grab the register >

[Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-09-28 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. In case of MIPS64, the pointer size depends on ELF abi. The MIPS64 currently supp

Re: [Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-09-28 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1218 @@ +1217,3 @@ +response.Printf("eflags:%" PRIx32 ";", proc_arch.GetFlags()); +if (proc_triple.isArch64Bit()) { + if (proc_arch.IsMIPS()) { --

[Lldb-commits] [PATCH] [Updated, 58 lines] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-09-30 Thread Nitesh Jain via lldb-commits
nitesh.jain removed rL LLVM as the repository for this revision. nitesh.jain updated this revision to Diff 73029. nitesh.jain added a comment. We just require ABI information so that auxv vector is parse when lldb try to attach a process via "attach -p pid" https://reviews.llvm.org/D25021 File

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-03 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 73278. nitesh.jain added a comment. These diff remove manually bit twiddling due to the size of the floating point register that can change. We use register offset to get floating point register data based on endianess and it's size. We have not remove b

[Lldb-commits] [PATCH] D15487: [LLDB][MIPS] Added support for MIPS1, MIPS2, MIPS3, MIPS4 and MIPS5 instruction sets

2015-12-14 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, clayborg. nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. This Patch will allowed LLDB to debug respective instruction sets binaries. R

[Lldb-commits] [PATCH] D15915: [LLDB][MIPS] Fix TestDisassembleRawData.py

2016-01-05 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovehakola, emaste. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. This patch adds check for the correctness of Disassembling

[Lldb-commits] [PATCH] D16132: [LLDB][MIPS] Fix TestExprsChar.py

2016-01-12 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. When incorrect type used for 'char' then (at least) one of the expre

[Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-02 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added a reviewer: jaydeep. nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. For mips there are more subarchs like mips32r2, mips32r6. This patch uses re.match("mi

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-02 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Thanks zturner. The triple is match using re.match(triple, lldb.DBG.GetSelectedPlatform().GetTriple()). I will update diff with the suggested changes. Repository: rL LLVM http://reviews.llvm.org/D16840 ___ lldb-co

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-02 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 46750. nitesh.jain added a comment. Update the diff with suggested changes Repository: rL LLVM http://reviews.llvm.org/D16840 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py packages/Python/

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-04 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. Comment at: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py:24 @@ -23,3 +23,3 @@ @expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64']) -@expectedFailureAll(archs=

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-04 Thread Nitesh Jain via lldb-commits
nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 46913. nitesh.jain added a comment. Updated as per the suggestion. Repository: rL LLVM http://reviews.llvm.org/D16840 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-04 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 46919. nitesh.jain added a comment. updates diff with triple =re.compile('^mips') to check if architecture string starts with mips. Repository: rL LLVM http://reviews.llvm.org/D16840 Files: packages/Python/lldbsuite/test/functionalities/thread/cr

[Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The debug version of libc.so is require for backtracing which may n

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-11 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 47767. nitesh.jain added a comment. Updated as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py Index: packages/Python/lldbsuite/test/f

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-12 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. Thanks zturner. Will update the diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

Re: [Lldb-commits] [PATCH] D17131: [LLDB][MIPS] Fix TestInferiorAssert.py for MIPS

2016-02-12 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 47776. nitesh.jain added a comment. Update the diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D17131 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py Index: packages/Python/lldbsuit

[Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

2016-02-25 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added a reviewer: clayborg. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The MIPS/MICROMIPS architecture will generate different jump instruction.

[Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-11 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, tberghammer, labath. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The patch http://reviews.llvm.org/D14952 which modifies

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-13 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 50569. nitesh.jain added a comment. Herald added subscribers: srhines, danalbert, tberghammer. Updated diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D18082 Files: source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.

Re: [Lldb-commits] [PATCH] D18082: [LLDB]{MIPS] Fix TestPlatformProcessConnect.py

2016-03-14 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Hi Tamas Berghammer, Is it ok to commit? Repository: rL LLVM http://reviews.llvm.org/D18082 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-03-30 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. These patch will set clang::TargetOptions::ABI and accordingly code will be generated For MIPS target. http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-03-31 Thread Nitesh Jain via lldb-commits
nitesh.jain set the repository for this revision to rL LLVM. nitesh.jain updated this revision to Diff 52177. nitesh.jain added a comment. Corrected formatting issue Repository: rL LLVM http://reviews.llvm.org/D18638 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp source/P

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-03-31 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Yes this function is clang specific(even GetClangTargetCPU) .Will update the diff as per suggestion. Thanks Repository: rL LLVM http://reviews.llvm.org/D18638 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-04-06 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 52886. nitesh.jain added a comment. The diff is updated as per suggestion Repository: rL LLVM http://reviews.llvm.org/D18638 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp source/Plugins/ExpressionParser/Clang/ClangExpress

[Lldb-commits] [PATCH] D18853: [LLDB][MIPS] Fix Floating point Registers Encoding

2016-04-07 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, sagar. nitesh.jain added subscribers: jaydeep, bhushan, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Herald added a subscriber: sdardis. Currently floating point regsiters has "eE

[Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

2016-04-07 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The ArchSpec::m_flags will be set based on ELF flag ABI. Repository

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

2016-04-13 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1625-1626 @@ -1624,4 +1624,4 @@ if (arch_spec.GetMachine() == llvm::Triple::mips || arch_spec.GetMachine() == llvm::Triple::mipsel || arch_spec.G

[Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

2015-09-07 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D12671 Files: sour

Re: [Lldb-commits] [PATCH] D12671: [LLDB][MIPS] Added support for the debugging of N32/O32 applications on MIPS64 target.

2015-09-07 Thread Nitesh Jain via lldb-commits
nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 34146. nitesh.jain added a comment. Added include/lldb/Core/ArchSpec.h diff Repository: rL LLVM http://reviews.llvm.org/D12671 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp sourc

<    1   2