[Lldb-commits] [lldb] r299196 - [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module.

2017-03-31 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Mar 31 05:55:55 2017 New Revision: 299196 URL: http://llvm.org/viewvc/llvm-project?rev=299196&view=rev Log: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module. Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-com

[Lldb-commits] [lldb] r299199 - [LLDB][MIPS] Fix Core file Architecture and OS information.

2017-03-31 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Mar 31 06:06:25 2017 New Revision: 299199 URL: http://llvm.org/viewvc/llvm-project?rev=299199&view=rev Log: [LLDB][MIPS] Fix Core file Architecture and OS information. Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Re

[Lldb-commits] [lldb] r299200 - [LLDB][MIPS] Core Dump Support.

2017-03-31 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Mar 31 06:14:02 2017 New Revision: 299200 URL: http://llvm.org/viewvc/llvm-project?rev=299200&view=rev Log: [LLDB][MIPS] Core Dump Support. Reviewers: labath, emaste Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision: https://reviews.llvm.o

[Lldb-commits] [lldb] r299527 - Fix a typo introduce in r299200.

2017-04-05 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Apr 5 04:31:43 2017 New Revision: 299527 URL: http://llvm.org/viewvc/llvm-project?rev=299527&view=rev Log: Fix a typo introduce in r299200. Modified: lldb/trunk/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h Modified: lldb/trunk/so

[Lldb-commits] [lldb] r301172 - [LLDB][MIPS] Move it into HandleLLVMOptions.cmake.

2017-04-24 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Apr 24 05:56:01 2017 New Revision: 301172 URL: http://llvm.org/viewvc/llvm-project?rev=301172&view=rev Log: [LLDB][MIPS] Move it into HandleLLVMOptions.cmake. The revison https://reviews.llvm.org/D32125 will fixed the off_t for GNU specific 32 bit platform. This fix

[Lldb-commits] [lldb] r301295 - [LLDB][MIPS] Fix typo in TestStepOverWatchpoint.py.

2017-04-24 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Tue Apr 25 01:12:59 2017 New Revision: 301295 URL: http://llvm.org/viewvc/llvm-project?rev=301295&view=rev Log: [LLDB][MIPS] Fix typo in TestStepOverWatchpoint.py. Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [lldb] r301530 - [LLDB][MIPS] Fix TestMiExec.py failure.

2017-04-27 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Thu Apr 27 05:21:46 2017 New Revision: 301530 URL: http://llvm.org/viewvc/llvm-project?rev=301530&view=rev Log: [LLDB][MIPS] Fix TestMiExec.py failure. Reviewers: ki.stfu, labath Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision: https://revie

[Lldb-commits] [lldb] r301537 - [LLDB][MIPS] Forgot to add check in commit rl301530

2017-04-27 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Thu Apr 27 07:27:42 2017 New Revision: 301537 URL: http://llvm.org/viewvc/llvm-project?rev=301537&view=rev Log: [LLDB][MIPS] Forgot to add check in commit rl301530 Reviewers: ki.stfu, labath Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified: lldb/trunk/

[Lldb-commits] [lldb] r302139 - [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure.

2017-05-04 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Thu May 4 06:34:42 2017 New Revision: 302139 URL: http://llvm.org/viewvc/llvm-project?rev=302139&view=rev Log: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure. Reviewers: jingham, labath Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision: h

[Lldb-commits] [lldb] r305378 - [LLDB][MIPS] Fix TestRegisterVariables.py.

2017-06-14 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Jun 14 05:02:56 2017 New Revision: 305378 URL: http://llvm.org/viewvc/llvm-project?rev=305378&view=rev Log: [LLDB][MIPS] Fix TestRegisterVariables.py. Clang does not accept regparm attribute on these platforms. Fortunately, the default calling convention passes argum

[Lldb-commits] [lldb] r305380 - [LLDB][MIPS] Fix TestNoreturnUnwind.py.

2017-06-14 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Jun 14 05:47:25 2017 New Revision: 305380 URL: http://llvm.org/viewvc/llvm-project?rev=305380&view=rev Log: [LLDB][MIPS] Fix TestNoreturnUnwind.py. bugnumber=llvm.org/pr33452 Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified: lldb/trunk/packages/P

[Lldb-commits] [lldb] r305383 - [LLDB][MIPS] Skip TestGdbRemoteSingleStep and TestGdbRemote_vCont.py.

2017-06-14 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Jun 14 07:21:26 2017 New Revision: 305383 URL: http://llvm.org/viewvc/llvm-project?rev=305383&view=rev Log: [LLDB][MIPS] Skip TestGdbRemoteSingleStep and TestGdbRemote_vCont.py. The step count depends on code generated by compiler (GCC/Clang). It will also vary for d

[Lldb-commits] [lldb] r309250 - [LLDB][MIPS] Fix emulation of Instruction for MIPS64R6 target.

2017-07-26 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Jul 26 22:34:33 2017 New Revision: 309250 URL: http://llvm.org/viewvc/llvm-project?rev=309250&view=rev Log: [LLDB][MIPS] Fix emulation of Instruction for MIPS64R6 target. Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified: lldb/trunk/source/Plugins/I

[Lldb-commits] [lldb] r310855 - [LLDB][MIPS] Set the Section's file address for

2017-08-14 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Aug 14 09:30:25 2017 New Revision: 310855 URL: http://llvm.org/viewvc/llvm-project?rev=310855&view=rev Log: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set. Reviewers: labath, clayborg Subscribers: jaydeep,

[Lldb-commits] [lldb] r310856 - [LLDB][MIPS] Fix process load/unload on android.

2017-08-14 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Aug 14 09:39:16 2017 New Revision: 310856 URL: http://llvm.org/viewvc/llvm-project?rev=310856&view=rev Log: [LLDB][MIPS] Fix process load/unload on android. To detect the correct function name based on the list of available symbols instead of the SDK version Review

[Lldb-commits] [lldb] r283728 - [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-10-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Oct 10 04:02:41 2016 New Revision: 283728 URL: http://llvm.org/viewvc/llvm-project?rev=283728&view=rev Log: [LLDB][MIPS] Fix register read/write for 32 bit big endian system Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, mohit.bhakkad, slthakur, llvm-com

[Lldb-commits] [lldb] r283729 - [LLDB][MIPS] Fix TestReturnValue failure for MIPS

2016-10-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Oct 10 04:16:20 2016 New Revision: 283729 URL: http://llvm.org/viewvc/llvm-project?rev=283729&view=rev Log: [LLDB][MIPS] Fix TestReturnValue failure for MIPS Reviewers: clayborg, labath, bhushan Subscribers: jaydeep, slthakur, llvm-commits Differential Revision: ht

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-10 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Hi Greg, The diff is update as per suggestion so should I commit this ? Thanks https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-10-10 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Hi Greg, Please could you find some time to review this ? Thanks https://reviews.llvm.org/D25021 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r283732 - [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

2016-10-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Oct 10 05:02:09 2016 New Revision: 283732 URL: http://llvm.org/viewvc/llvm-project?rev=283732&view=rev Log: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, slthakur, llvm-c

[Lldb-commits] [lldb] r283739 - [LLDB][MIPS] All tests get errors in dotest after this test.

2016-10-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Oct 10 05:47:53 2016 New Revision: 283739 URL: http://llvm.org/viewvc/llvm-project?rev=283739&view=rev Log: [LLDB][MIPS] All tests get errors in dotest after this test. Subscribers: jaydeep, bhushan, slthakur, llvm-commits Modified: lldb/trunk/packages/Python/l

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

2016-10-11 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283732: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite… (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24549?vs=71314&id=74204#toc Repositor

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-10-11 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283728: [LLDB][MIPS] Fix register read/write for 32 bit big endian system (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24124?vs=72024&id=74202#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

2016-10-11 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283729: [LLDB][MIPS] Fix TestReturnValue failure for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24498?vs=71131&id=74203#toc Repository: rL LLVM https://review

[Lldb-commits] [lldb] r284001 - [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-10-12 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Oct 12 05:21:09 2016 New Revision: 284001 URL: http://llvm.org/viewvc/llvm-project?rev=284001&view=rev Log: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, slthakur, lldb-commit

[Lldb-commits] [lldb] r284003 - [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-12 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Oct 12 05:53:57 2016 New Revision: 284003 URL: http://llvm.org/viewvc/llvm-project?rev=284003&view=rev Log: [LLDB][MIPS] fix Floating point register read/write for big endian Reviewers: clayborg, labath, jaydeep Subscribers: bhushan, slthakur, lldb-commits Differen

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-12 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D24603#566575, @clayborg wrote: > Commit anytime. Thanks https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-12 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284003: [LLDB][MIPS] fix Floating point register read/write for big endian (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24603?vs=73278&id=74357#toc Repository: rL LLV

[Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-10-12 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284001: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D25021?vs=73029&id=74356#toc Repositor

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

2016-11-11 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, bhushan, clayborg. nitesh.jain added subscribers: lldb-commits, slthakur. https://reviews.llvm.org/D26542 Files: packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py Index: packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

2016-11-11 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. The elf_abi field was introduced in qprocessInfo packet (commit https://reviews.llvm.org/rL284001) so that LLDB can set pointer size and parse aux vector accordingly. This patch fix some test cases failures by introducing this field in _KNOWN_PROCESS_INFO_KEYS. h

[Lldb-commits] [PATCH] D27085: [LLDB][MIPS] Fix TestMultipleHits for MIPS

2016-11-23 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: labath, clayborg, zturner. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. https://reviews.llvm.org/D27085 Files: packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_hits/main.cpp Index:

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2016-11-24 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, zturner. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. In case of MIPS, the floating point register size is based on FR bit of status register(SR) (https://reviews.llvm.org/rL277343). In t

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-24 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, jingham, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. In case of MIPS, the watchpoint exception occur before associated instruction is executed. When watchpoint hit , we first enable the

[Lldb-commits] [lldb] r289209 - [LLDB][MIPS] Fix some test case failures due to elf_abi field of qprocessInfo packet.

2016-12-09 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Dec 9 07:37:14 2016 New Revision: 289209 URL: http://llvm.org/viewvc/llvm-project?rev=289209&view=rev Log: [LLDB][MIPS] Fix some test case failures due to elf_abi field of qprocessInfo packet. Reviewers: jaydeep, bhushan, clayborg Subscribers: slthakur, lldb-commi

[Lldb-commits] [lldb] r289210 - [LLDB][MIPS] Fix TestMultipleHits for MIPS

2016-12-09 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Dec 9 07:44:15 2016 New Revision: 289210 URL: http://llvm.org/viewvc/llvm-project?rev=289210&view=rev Log: [LLDB][MIPS] Fix TestMultipleHits for MIPS Reviewers: clayborg, labath, zturner Subscribers: jaydeep, bhushan, slthakur, lldb-commits Differential Revision:

[Lldb-commits] [lldb] r289211 - [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-09 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Dec 9 07:54:47 2016 New Revision: 289211 URL: http://llvm.org/viewvc/llvm-project?rev=289211&view=rev Log: [LLDB][MIPS] Fix TestWatchpointIter failure Reviewers: jingham Subscribers: jaydeep, bhushan, slthakur, lldb-commits Differential Revision: https://reviews.l

[Lldb-commits] [lldb] r291549 - [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Tue Jan 10 02:20:01 2017 New Revision: 291549 URL: http://llvm.org/viewvc/llvm-project?rev=291549&view=rev Log: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision:

[Lldb-commits] [lldb] r291553 - [LLDB][MIPS] Revert TestLldbGdbServer failure for MIPS

2017-01-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Tue Jan 10 03:18:56 2017 New Revision: 291553 URL: http://llvm.org/viewvc/llvm-project?rev=291553&view=rev Log: [LLDB][MIPS] Revert TestLldbGdbServer failure for MIPS Removed: lldb/trunk/Python/ Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-serv

[Lldb-commits] [lldb] r291554 - [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-10 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Tue Jan 10 03:33:43 2017 New Revision: 291554 URL: http://llvm.org/viewvc/llvm-project?rev=291554&view=rev Log: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision:

[Lldb-commits] [lldb] r294415 - [LLDB][MIPS] Fix TestMiniDumpNew

2017-02-07 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Feb 8 01:29:24 2017 New Revision: 294415 URL: http://llvm.org/viewvc/llvm-project?rev=294415&view=rev Log: [LLDB][MIPS] Fix TestMiniDumpNew Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision: https://reviews.llv

[Lldb-commits] [lldb] r294418 - [LLDB][MIPS] Fix TestMiExec and TestMiData failures

2017-02-07 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Feb 8 01:42:56 2017 New Revision: 294418 URL: http://llvm.org/viewvc/llvm-project?rev=294418&view=rev Log: [LLDB][MIPS] Fix TestMiExec and TestMiData failures Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified: lldb/trunk/packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D14493: [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS

2015-11-09 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The self.getArchitecture() returns the architecture based on the val

[Lldb-commits] [PATCH] D14634: [LLDB][MIPS] Fix TestDisassembleBreakpoint.py for MIPS

2015-11-12 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov, jaydeep. nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. The "break" is opcode for breakpoint instruction. Repository: rL L

[Lldb-commits] [PATCH] D14635: [LLDB][MIPS] Fix lldbplatformutil.py Failure

2015-11-12 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, clayborg, ovyalov. nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. This patch check whether first register is readable. Repository: r

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

2016-05-11 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 56891. nitesh.jain added a comment. Added IsMIPS() method. Repository: rL LLVM http://reviews.llvm.org/D18858 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Index: source/Plugins/Ob

Re: [Lldb-commits] [PATCH] D18858: [LLDB][MIPS] Setting appropriate ArchSpec::m_flags based on ABI

2016-05-11 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. Commited in revision 269181 Repository: rL LLVM http://reviews.llvm.org/D18858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D18638: [LLDB][MIPS] Provide ABI string to compiler for appropriate code generation for MIPS

2016-05-13 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. Committed in revision 269407 Repository: rL LLVM http://reviews.llvm.org/D18638 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-19 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Let me check and get back to you. Thanks. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:39 @@ +38,3 @@ +int regset = NT_PRSTATUS; +Error error = NativeProcessLinux::PtraceWrapper(PTRACE_GETREGSET, tid, ®set, &ioVec, sizeof_native_regs_struct); +Host

Re: [Lldb-commits] [PATCH] D18853: [LLDB][MIPS] Fix Floating point Registers Encoding

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. Committed in revision 270208. Repository: rL LLVM http://reviews.llvm.org/D18853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [Lldb-commits] [PATCH] D20416: [LLDB][MIPS] Fix floating point handling in case of thread step-out

2016-05-20 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. committed in revision 270207 Repository: rL LLVM http://reviews.llvm.org/D20416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-24 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol &native_thread, u

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-05-24 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In case of MIPS, ptrace always return 64 bit data irrespetive of Arch. http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-07 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, bhushan, jaydeep. nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Herald added subscribers: sdardis, dsanders. This patch contains 2 changes:

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-06-09 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. I will check it and let you know asap. Thanks http://reviews.llvm.org/D20368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-06-10 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture tha

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-06-13 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture tha

Re: [Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-23 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D21064#465410, @sdardis wrote: > You also need to emulate dsubu and subu as the MIPS LLVM backend will > generate them in certain cases. Thanks will emulate them too. Repository: rL LLVM http://reviews.llvm.org/D21064

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-06-27 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 61940. nitesh.jain added a comment. Thanks Labath. Updated diff as per suggestion. Repository: rL LLVM http://reviews.llvm.org/D20464 Files: cmake/LLDBDependencies.cmake Index: cmake/LLDBDependencies.cmake =

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-06-30 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D20464#470527, @Eugene.Zelenko wrote: > This change broke standalone build. Looks like check which should set > HAVE_CXX_ATOMICS64_WITHOUT_LIB was not performed. > > I build LLDB with LLVM STL which doesn't have libatomic. The CheckAtomi

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-07-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D20464#471803, @Eugene.Zelenko wrote: > I see HAVE_CXX_ATOMICS64_WITHOUT_LIB messages during LLVM Cmake run, but I > don't see such message during LLDB CMake run. > > Is this value is supposed to be read form LLVM CMake cache? Yes. Repo

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit

2016-07-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:497-505 @@ +496,11 @@ + { +bool fre; +bool fr1; +IsFR1_FRE (fr1, fre); + +// fr1 fre fpu_reg_size +

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-07-04 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D20464#472733, @Eugene.Zelenko wrote: > I run CMake with --trace and is mentioned only in condition added there. I have attach log of CMake with --trace. F2135359: log Repository: rL LLVM http://rev

Re: [Lldb-commits] [PATCH] D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly.

2016-07-07 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In http://reviews.llvm.org/D20464#473884, @Eugene.Zelenko wrote: > As fas as I could judge from log, you built LLDB with LLVM/Clang. But problem > happens when it's necessary to build LLDB separately from LLVM/Clang > (standalone build). Then we need to introduce

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-08 Thread Nitesh Jain via lldb-commits
nitesh.jain retitled this revision from "[LLDB][MIPS] Fix FPU Size Based on Dynamic FR/FRE bit" to "[LLDB][MIPS] Fix FPU Size Based on Dynamic FR". nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 63201. nitesh.jain added a comment. Update diff as per s

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-08 Thread Nitesh Jain via lldb-commits
nitesh.jain marked 6 inline comments as done. nitesh.jain added a comment. Repository: rL LLVM http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-08 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. Repository: rL LLVM http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-08 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:98 @@ +97,3 @@ +const ArchSpec &arch = m_thread.GetProcess()->GetTarget().GetArchitecture(); +RegisterInfo* reg_info = const_cast(m_reg_info.GetRegisterInfoAtInde

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-08 Thread Nitesh Jain via lldb-commits
nitesh.jain removed rL LLVM as the repository for this revision. nitesh.jain updated this revision to Diff 63224. nitesh.jain added a comment. Added lldb_private::RegisterInfo * DynamicRegisterInfo::GetRegisterInfoAtIndex (uint32_t i) http://reviews.llvm.org/D20357 Files: include/lldb/lldb-

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-08 Thread Nitesh Jain via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-11 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Hi Greg, Please could you find some time to review this ? Thanks http://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

2016-07-14 Thread Nitesh Jain via lldb-commits
nitesh.jain accepted this revision. nitesh.jain added a comment. LGTM. Thanks Repository: rL LLVM http://reviews.llvm.org/D22322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r275785 - [LLVM][MIPS] Revert support for FRE.

2016-07-18 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Mon Jul 18 07:37:44 2016 New Revision: 275785 URL: http://llvm.org/viewvc/llvm-project?rev=275785&view=rev Log: [LLVM][MIPS] Revert support for FRE. Reviewers: jaydeep Subscribers: bhushan, mohit.bhakkad, slthakur, llvm-commits Modified: lldb/trunk/source/Plugins/

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-20 Thread Nitesh Jain via lldb-commits
nitesh.jain updated this revision to Diff 64693. nitesh.jain added a comment. Removed dynamic_size_dwarf_len field from RegisterInfo struct. https://reviews.llvm.org/D20357 Files: include/lldb/Host/common/NativeRegisterContext.h include/lldb/Host/common/NativeRegisterContextRegisterInfo.h

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-20 Thread Nitesh Jain via lldb-commits
nitesh.jain marked 8 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-07-27 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: jaydeep, bhushan, clayborg. nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits, sdardis. Herald added a subscriber: dsanders. To handle the immediate size greater than 2^16 - 1 , the clang compiler generate LUI, (D)

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-07-28 Thread Nitesh Jain via lldb-commits
nitesh.jain marked 9 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR

2016-08-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Thanks Greg for all your help. Repository: rL LLVM https://reviews.llvm.org/D20357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r277426 - [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-08-02 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Tue Aug 2 02:18:07 2016 New Revision: 277426 URL: http://llvm.org/viewvc/llvm-project?rev=277426&view=rev Log: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions Reviewers: clayborg, jaydeep, bhushan

Re: [Lldb-commits] [PATCH] D22851: [LLDB][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation for (D)ADDIU, SD/SW and LW/LD instructions

2016-08-02 Thread Nitesh Jain via lldb-commits
nitesh.jain closed this revision. nitesh.jain added a comment. committed in revision https://reviews.llvm.org/rL277426, https://reviews.llvm.org/D22851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

2016-08-08 Thread Nitesh Jain via lldb-commits
Thanks Hans. -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:58 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [PATCH] D20357: [LLDB][MIPS] Fix FPU Si

Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

2016-08-08 Thread Nitesh Jain via lldb-commits
Thanks Hans -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 09 August 2016 01:59 To: Greg Clayton Cc: Nitesh Jain; Jaydeep Patil; Bhushan Attarde; lldb-commits@lists.llvm.org Subject: Re: [Diffusion] rL277426: [LLVM][MIPS] Add (

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-30 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:131 @@ +130,3 @@ + +GDBRemoteClientBase::Lock lock(gdb_comm, false); +if (!lock) Hi labath, This patch cause deadlock when we try to

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-30 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Forgot to mention that this case has been observed for MIPS architecture. Since for MIPS, the floating point register size is calculated at runtime. -NJ Repository: rL LLVM https://reviews.llvm.org/D23802 ___ lldb-c

Re: [Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-08-30 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D23802#528804, @labath wrote: > Thanks for the heads up. I'll need to give this some thought. I've pulled the > change out until I can figure out what to do. > > BTW, have you guys considered putting up a mips buildbot to detect these > k

[Lldb-commits] [PATCH] D24122: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

2016-09-01 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. This patch will fix TestEhFrameUnwind.py failure for MIPS https://reviews.llvm.org/D24122 Files: packages/Python/lldbsuite/test/functionali

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. Herald added a subscriber: sdardis. The RegisterValue.SetBytes for 4 byte data followed by GetAsUInt64 for 32 bit big endian system will produ

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1844 @@ +1843,3 @@ + +uint64_t value; +value = reg_size == 4 ? *(uint32_t *)reg_bytes : *(uint64_t *)reg_bytes; labath wrote: > This

[Lldb-commits] [lldb] r281026 - [LLDB][MIPS] Fix TestLldbGdbServer.py failure

2016-09-09 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Sep 9 04:50:33 2016 New Revision: 281026 URL: http://llvm.org/viewvc/llvm-project?rev=281026&view=rev Log: [LLDB][MIPS] Fix TestLldbGdbServer.py failure Subscribers: jaydeep, bhushan, slthakur, lldb-commits Modified: lldb/trunk/packages/Python/lldbsuite/test/t

[Lldb-commits] [lldb] r281031 - [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

2016-09-09 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Sep 9 05:20:08 2016 New Revision: 281031 URL: http://llvm.org/viewvc/llvm-project?rev=281031&view=rev Log: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, slthakur, lldb-commits Differential Revision: https

Re: [Lldb-commits] [PATCH] D24122: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

2016-09-09 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281031: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24122?vs=69974&id=70807#toc Repository: rL LLVM https://reviews.l

[Lldb-commits] [lldb] r281032 - [LLDB][MIPS] Fix Emulation for JALR64 Instruction

2016-09-09 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Fri Sep 9 05:46:25 2016 New Revision: 281032 URL: http://llvm.org/viewvc/llvm-project?rev=281032&view=rev Log: [LLDB][MIPS] Fix Emulation for JALR64 Instruction Subscribers: jaydeep, bhushan, slthakur, sdardis, lldb-commits Modified: lldb/trunk/source/Plugins/Instr

[Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

2016-09-13 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, bhushan. nitesh.jain added subscribers: jaydeep, slthakur, lldb-commits. Herald added a subscriber: sdardis. https://reviews.llvm.org/D24498 Files: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp Index: source/

Re: [Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

2016-09-13 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:972 @@ -968,4 +971,3 @@ f0_value.GetData(f0_data); The issued was while setting f0_data and f2_data successively via RegisterValue.GetData. Since Regis

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

2016-09-14 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. These test cases tries to insert breakpoint in atomic sequence and cause atomic sequence to restart when breakpoint is hit . https://reviews

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain retitled this revision from "[LLDB][MIPS] Fix register read/write for big endian" to "[LLDB][MIPS] Fix register read/write for 32 bit big endian system". nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 71360. https://reviews.llvm.org/D2412

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1940 @@ +1939,3 @@ + uint64_t dst_value; + RegisterValue reg_value; + lldb::ByteOrder byte_order = lldb::eByteOrderInvalid; The GetAsUint64 wo

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain marked 2 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-09-15 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. Will submit separate patch for Floating point register read/write and ptrace changes. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

  1   2   >