[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread Nikita Popov via lldb-commits
@@ -20,16 +20,15 @@ using namespace llvm; int main(int argc, char **argv) { #if defined(__i386__) || defined(_M_IX86) || \ defined(__x86_64__) || defined(_M_X64) - StringMap features; - - if (!sys::getHostCPUFeatures(features)) + const < StringMap features = sys::getHost

[Lldb-commits] [lldb] [llvm] [DRAFT][llvm]Added lib/Telemetry (PR #98528)

2024-07-11 Thread Nikita Popov via lldb-commits
nikic wrote: Why does any part of this need to be in llvm/ at all? https://github.com/llvm/llvm-project/pull/98528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-23 Thread Nikita Popov via lldb-commits
nikic wrote: FYI this causes a minor compile-time improvement in stage1 builds using gcc: https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u While that's nice, it does suggest that the f

[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-28 Thread Nikita Popov via lldb-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/93548 If a weak function is missing, still return it's address (zero) rather than failing interpretation. Otherwise we have a mismatch between Interpret() and CanInterpret() resulting in failures that would not occur wit

[Lldb-commits] [clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-28 Thread Nikita Popov via lldb-commits
nikic wrote: > > FYI this causes a minor compile-time improvement in stage1 builds using > > gcc: > > https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u > > While that's nice, it does s

[Lldb-commits] [lldb] [IRInterpreter] Return zero address for missing weak function (PR #93548)

2024-05-30 Thread Nikita Popov via lldb-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/93548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

2024-06-14 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9c49440 - [lldb] Add missing includes (NFC)

2024-06-21 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2024-06-21T14:05:36+02:00 New Revision: 9c4944095db919580bdc698273065d1c91a98ed8 URL: https://github.com/llvm/llvm-project/commit/9c4944095db919580bdc698273065d1c91a98ed8 DIFF: https://github.com/llvm/llvm-project/commit/9c4944095db919580bdc698273065d1c91a98ed8.diff

[Lldb-commits] [lldb] c399aea - [lldb] Remove YAMLTraits.h include (NFC)

2024-06-21 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2024-06-21T14:56:26+02:00 New Revision: c399aeacf67e517bcfa9c4d7e5cc709a3fbe5d09 URL: https://github.com/llvm/llvm-project/commit/c399aeacf67e517bcfa9c4d7e5cc709a3fbe5d09 DIFF: https://github.com/llvm/llvm-project/commit/c399aeacf67e517bcfa9c4d7e5cc709a3fbe5d09.diff

[Lldb-commits] [lldb] 30299b8 - [CommandLine] Avoid ManagedStatic.h include (NFC)

2024-06-21 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2024-06-21T15:45:17+02:00 New Revision: 30299b87171cbad2dacb8b1ec0e75801785f16d9 URL: https://github.com/llvm/llvm-project/commit/30299b87171cbad2dacb8b1ec0e75801785f16d9 DIFF: https://github.com/llvm/llvm-project/commit/30299b87171cbad2dacb8b1ec0e75801785f16d9.diff

[Lldb-commits] [lldb] [lldb] Avoid calling DataLayout constructor accepting Module pointer (NFC) (PR #102839)

2024-08-12 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][WIP] memory find speedup+bugfix (PR #104193)

2024-08-15 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/104193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [flang] [lldb] [llvm] [mlir] [APInt] Assert correct values in APInt constructor (PR #80309)

2024-08-21 Thread Nikita Popov via lldb-commits
nikic wrote: Okay, looks like I tracked down all the assertion failures in tests. My plan would now be to land this in three phases, first to add the new assertions and implicitTrunc parameter, but with implicitTrunc=true by default. Then to land fixes (possibly split up further), and finally

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Assert correct values in APInt constructor (PR #80309)

2024-09-05 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From f6002ad249359131be6d668036b4f17ff43e67c7 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 13 Aug 2024 15:11:18 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6

[Lldb-commits] [lldb] [LLDB] Respect the DW_AT_alignment attribute. (PR #73307)

2023-11-28 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/73307 >From 5fb8fd532fe767feb2d361f9552ff31ea7770663 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 24 Nov 2023 10:46:03 +0100 Subject: [PATCH 1/3] [LLDB] Respect the DW_AT_alignment attribute. Part of fixes for #7

[Lldb-commits] [compiler-rt] [llvm] [mlir] [polly] [clang] [libc] [libcxx] [openmp] [lldb] [C API] Add support for setting/getting new nneg flag on zext instructions (PR #73592)

2023-11-29 Thread Nikita Popov via lldb-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/73592 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [clang] [lldb] [clang-tools-extra] [compiler-rt] [libcxx] [llvm] [libc] [RegAllocFast] Refactor dominates algorithm for large basic block (PR #72250)

2023-12-22 Thread Nikita Popov via lldb-commits
@@ -62,6 +62,107 @@ static RegisterRegAlloc fastRegAlloc("fast", "fast register allocator", namespace { +/// Assign ascending index for instructions in machine basic block. The index +/// can be used to determine dominance between instructions in same MBB. +class InstrPosInd

[Lldb-commits] [lldb] [libc] [llvm] [clang] [mlir] [NFC][ObjectSizeOffset] Use classes instead of std::pair (PR #76882)

2024-01-04 Thread Nikita Popov via lldb-commits
@@ -187,80 +187,124 @@ Value *lowerObjectSizeCall( const TargetLibraryInfo *TLI, AAResults *AA, bool MustSucceed, SmallVectorImpl *InsertedInstructions = nullptr); -using SizeOffsetType = std::pair; +/// SizeOffsetType - A base template class for the object size visito

[Lldb-commits] [lldb] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-19 Thread Nikita Popov via lldb-commits
nikic wrote: I think this is the right canonicalization at the IR level, as select allows better analysis than zext(icmp). However, this seems to be universally worse for the backend: https://llvm.godbolt.org/z/Yh7brfc8b So I think we would need an SDAG undo transform. Interestingly, this alre

[Lldb-commits] [lldb] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-24 Thread Nikita Popov via lldb-commits
@@ -6380,7 +6380,69 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst &I) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X,

[Lldb-commits] [lldb] [lldb] Implement thread local storage for linux (PR #67470)

2023-09-26 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/67470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2df9430 - [lldb] Remove uses of PointerType::getElementType()

2022-02-14 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2022-02-14T09:34:24+01:00 New Revision: 2df9430fbfaf40ecce5f902651e2725aaa4c275b URL: https://github.com/llvm/llvm-project/commit/2df9430fbfaf40ecce5f902651e2725aaa4c275b DIFF: https://github.com/llvm/llvm-project/commit/2df9430fbfaf40ecce5f902651e2725aaa4c275b.diff

[Lldb-commits] [lldb] ad1feef - [lldb] Remove some uses of getPointerElementType()

2022-02-14 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2022-02-14T09:44:37+01:00 New Revision: ad1feef7b2097090df0d41ad4c35c688dbe1c34a URL: https://github.com/llvm/llvm-project/commit/ad1feef7b2097090df0d41ad4c35c688dbe1c34a DIFF: https://github.com/llvm/llvm-project/commit/ad1feef7b2097090df0d41ad4c35c688dbe1c34a.diff

[Lldb-commits] [lldb] 00fb050 - [lldb] Remove unused Module argument (NFC)

2022-03-24 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2022-03-24T12:53:02+01:00 New Revision: 00fb0504082ea0b4b0c25d1ae773b39874d88e95 URL: https://github.com/llvm/llvm-project/commit/00fb0504082ea0b4b0c25d1ae773b39874d88e95 DIFF: https://github.com/llvm/llvm-project/commit/00fb0504082ea0b4b0c25d1ae773b39874d88e95.diff

[Lldb-commits] [lldb] b3fbbab - [lldb] Use byval type

2022-03-24 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2022-03-24T12:55:42+01:00 New Revision: b3fbbabdc1f7a52c0cc2756036a132b9aaab5742 URL: https://github.com/llvm/llvm-project/commit/b3fbbabdc1f7a52c0cc2756036a132b9aaab5742 DIFF: https://github.com/llvm/llvm-project/commit/b3fbbabdc1f7a52c0cc2756036a132b9aaab5742.diff

[Lldb-commits] [lldb] 840bb72 - [lldb] Avoid pointer element type accesses

2022-03-24 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2022-03-24T13:09:23+01:00 New Revision: 840bb725435c729f47458c48723d434ce45d57ee URL: https://github.com/llvm/llvm-project/commit/840bb725435c729f47458c48723d434ce45d57ee DIFF: https://github.com/llvm/llvm-project/commit/840bb725435c729f47458c48723d434ce45d57ee.diff

[Lldb-commits] [lldb] 49f9af1 - [LLDB] Remove some typed pointer code (NFCI)

2023-03-17 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2023-03-17T15:25:58+01:00 New Revision: 49f9af1864d918a0561e455d2ec403f32135c108 URL: https://github.com/llvm/llvm-project/commit/49f9af1864d918a0561e455d2ec403f32135c108 DIFF: https://github.com/llvm/llvm-project/commit/49f9af1864d918a0561e455d2ec403f32135c108.diff

[Lldb-commits] [lldb] [Support] Add KnownBits::computeForSubBorrow (PR #67788)

2023-10-01 Thread Nikita Popov via lldb-commits
@@ -3732,14 +3732,18 @@ KnownBits SelectionDAG::computeKnownBits(SDValue Op, const APInt &DemandedElts, assert(Op.getResNo() == 0 && "We only compute knownbits for the difference here."); -// TODO: Compute influence of the carry operand. -if (Opcode ==

[Lldb-commits] [lldb] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-05 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. Basically LGTM, but I think this is still missing negative tests for non-equality pred1/pred2? https://github.com/llvm/llvm-project/pull/65852 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Nikita Popov via lldb-commits
nikic wrote: Looks like incorrect conflict resolution in the last merge. https://github.com/llvm/llvm-project/pull/65852 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. Yeah, it looks correct now. https://github.com/llvm/llvm-project/pull/65852 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

2023-10-12 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67915 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-16 Thread Nikita Popov via lldb-commits
@@ -3083,6 +3083,19 @@ ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr( E->getTypeOfArgument()->getPointeeType())) .getQuantity(); return llvm::ConstantInt::get(CGF.SizeTy, Alignment); + } else if (E->getKind() == UETT_VectorElements) { +//

[Lldb-commits] [lldb] 6f59f30 - [lldb] Fix m_hwp_regs size for ppc64le (PR54520)

2022-10-18 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2022-10-18T15:11:21+02:00 New Revision: 6f59f302e4358b4dc869bc298c2b9c06aa716b60 URL: https://github.com/llvm/llvm-project/commit/6f59f302e4358b4dc869bc298c2b9c06aa716b60 DIFF: https://github.com/llvm/llvm-project/commit/6f59f302e4358b4dc869bc298c2b9c06aa716b60.diff

[Lldb-commits] [lldb] c476566 - [IRForTarget] Don't pass nullptr to GetElementPtrInst::Create() (NFC)

2021-07-09 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2021-07-09T21:14:41+02:00 New Revision: c476566be5d025a3f122392af481a74f887911e6 URL: https://github.com/llvm/llvm-project/commit/c476566be5d025a3f122392af481a74f887911e6 DIFF: https://github.com/llvm/llvm-project/commit/c476566be5d025a3f122392af481a74f887911e6.diff

[Lldb-commits] [lldb] 2e3f469 - [IR] Add GEPOperator::indices() (NFC)

2021-07-09 Thread Nikita Popov via lldb-commits
Author: Nikita Popov Date: 2021-07-09T21:41:20+02:00 New Revision: 2e3f4694d61dd50c8ec1278331edee84a60555f8 URL: https://github.com/llvm/llvm-project/commit/2e3f4694d61dd50c8ec1278331edee84a60555f8 DIFF: https://github.com/llvm/llvm-project/commit/2e3f4694d61dd50c8ec1278331edee84a60555f8.diff

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
@@ -171,7 +171,7 @@ bool HexagonGenExtract::convert(Instruction *In) { // this value. if (!LogicalSR && (SR > SL)) return false; -APInt A = APInt(BW, ~0ULL).lshr(SR).shl(SL); +APInt A = APInt(BW, ~0ULL, true).lshr(SR).shl(SL); nikic wrote:

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
nikic wrote: > `APInt::getAllOnes` will assert if `BitWidth == 0`. > > [snip] For the record, this is fixed by https://github.com/llvm/llvm-project/pull/112227. https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 96795194fc79359363bac0423516da2a06733047 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH 1/2] apint only --- clang/lib/AST/ByteCode/IntegralAP.h |

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-15 Thread Nikita Popov via lldb-commits
@@ -1159,7 +1159,9 @@ class ARMOperand : public MCParsedAsmOperand { if (!isImm()) return false; const MCConstantExpr *CE = dyn_cast(getImm()); if (!CE) return false; nikic wrote: Not quite, but this put me on the right path. I added a check for `i

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via lldb-commits
@@ -437,7 +437,9 @@ ExprResult Parser::createEmbedExpr() { SourceLocation StartLoc = ConsumeAnnotationToken(); if (Data->BinaryData.size() == 1) { Res = IntegerLiteral::Create(Context, - llvm::APInt(CHAR_BIT, Data->BinaryData.back()), +

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via lldb-commits
@@ -3600,8 +3600,11 @@ ExprResult Sema::ActOnCharacterConstant(const Token &Tok, Scope *UDLScope) { ExprResult Sema::ActOnIntegerConstant(SourceLocation Loc, uint64_t Val) { unsigned IntSize = Context.getTargetInfo().getIntWidth(); - return IntegerLiteral::Create(Context,

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 96795194fc79359363bac0423516da2a06733047 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH 1/5] apint only --- clang/lib/AST/ByteCode/IntegralAP.h |

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 96795194fc79359363bac0423516da2a06733047 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH 1/6] apint only --- clang/lib/AST/ByteCode/IntegralAP.h |

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #113024)

2024-10-19 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113024 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #113073)

2024-10-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #113121)

2024-10-21 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via lldb-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-14 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From ab1d3f23ee1a8402403a61038effb9bb15c91a13 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-14 Thread Nikita Popov via lldb-commits
nikic wrote: Ping. The PR no longer contains MLIR changes now. https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #113248)

2024-10-22 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use heterogenous lookups with std::map (NFC) (PR #115590)

2024-11-09 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/115590 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use heterogenous lookups with std::map (NFC) (#115590) (PR #115634)

2024-11-10 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/115634 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-23 Thread Nikita Popov via lldb-commits
nikic wrote: @dtcxzyw Thanks for pointing that out! I think truncation here is the semantically wrong thing to do. I added a check that we fit the bit width instead in https://github.com/llvm/llvm-project/commit/6f194a6dea4b4067336431e699ea3588417d4b96. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Assert correct values in APInt constructor (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 7467ecf67c706ffdfa79eaebdc9528002b74c5af Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fix bitwidth (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
nikic wrote: I think this is ready for review now. I've landed many parts of this PR separately already, and am happy to land this in parts (or split as needed). https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 511445e35376c904be454ed987786cb6faa70a81 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
@@ -1806,7 +1806,7 @@ bool AMDGPUDAGToDAGISel::SelectGlobalSAddr(SDNode *N, // instructions to perform VALU adds with immediates or inline literals. unsigned NumLiterals = !TII->isInlineConstant(APInt(32, COffsetVal & 0x)) + - !TII->isInli

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 17ba7e8538a2a4cc7b17322d26e8ea83ce27d617 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fix bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic ready_for_review https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Assert correct values in APInt constructor (PR #80309)

2024-09-19 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From f47b38cd26107108f082df437196832fbe9ad78d Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6

[Lldb-commits] [clang] [lldb] [Clang] Improve Sema diagnostic performance for __builtin_counted_by_ref (PR #116719)

2024-11-26 Thread Nikita Popov via lldb-commits
nikic wrote: > Is there a branch up for this on https://llvm-compile-time-tracker.com/ so > that we've verified that this actually improves performance? Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=105b7803ea22823a2fca2a82ee843d0884e9cbf3&to=dcb3e2b6b4333556fbfa3d7a5a45

[Lldb-commits] [lldb] [lldb] Migrate away from PointerUnion::{is, get} (NFC) (PR #122420)

2025-01-10 Thread Nikita Popov via lldb-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-16 Thread Nikita Popov via lldb-commits
nikic wrote: Compile-time looks fine on this one: https://llvm-compile-time-tracker.com/compare.php?from=8fb29ba287d72392bd7900c33d2a8d2149126dbe&to=fd734a392a094a573ee7fe587b9fc5f616f92a9a&stat=instructions:u https://github.com/llvm/llvm-project/pull/123152

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-16 Thread Nikita Popov via lldb-commits
nikic wrote: Thanks for the context! "I'm landing this without approval because I'm the maintainer for this component" is a lot less scary than "I'm landing this without approval because there's no time to wait on a review". https://github.com/llvm/llvm-project/pull/122887

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-15 Thread Nikita Popov via lldb-commits
nikic wrote: Looks like this change has some compile-time impact even if modules are not used: https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u It seems to add about 0.5% to C++ compi

[Lldb-commits] [clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-06 Thread Nikita Popov via lldb-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/129868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits