[Lldb-commits] [PATCH] D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346171: Add a relocation to ObjectFileELF::ApplyRelocations and a test (authored by lanza, committed by ). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D52672: Set stdout/stdin to binary mode on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346174: Set stdout/stdin to binary mode on Windows (authored by lanza, committed by ). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D52672?vs=168705&id=1

[Lldb-commits] [PATCH] D51566: Add a relocation to ObjectFileELF::ApplyRelocations and a test

lanza added a comment. LGTM and the test case passes. Thanks a lot, Davide! Repository: rLLDB LLDB https://reviews.llvm.org/D51566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D53959: Remove working directory for debugserver code signing target

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346281: Remove working directory for debugserver code signing target (authored by lanza, committed by ). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D53

[Lldb-commits] [PATCH] D53008: Add a check whether or not a str is utf8 prior to emplacing

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346988: Add a check whether or not a str is utf8 prior to emplacing (authored by lanza, committed by ). Herald added subscribers: lldb-commits, abidh. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D54510: Force SHELL to be cmd.exe on Windows for the test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346993: Force SHELL to be cmd.exe on Windows for the test suite (authored by lanza, committed by ). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D54510?v

[Lldb-commits] [PATCH] D54544: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346994: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD (authored by lanza, committed by ). Herald added subscribers: lldb-commits, abidh. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348526: Implement WindowsDYLD::DidAttach for use with gdb-server attach (authored by lanza, committed by ). Herald adde

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

lanza added a comment. @zturner and I spoke about it before landing @labath - correct. Dll loading needs handled. This was to upstream hello world functionality without DLLs. I need to figure out where and when to synchronize between ds2 and lldb for the `LOAD_DLL_DEBUG_EVENT`. I'll probably ge

[Lldb-commits] [PATCH] D59230: Add a case in SymbolFile{Native, }PDB::TranslateLanguage for Swift

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355883: Add a case in SymbolFile{Native,}PDB::TranslateLanguage for Swift (authored by lanza, committed by ). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to co

[Lldb-commits] [PATCH] D59804: Kill unused variable m_tu_decl_up in SymbolFilePDB

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357113: Kill unused variable m_tu_decl_up in SymbolFilePDB (authored by lanza, committed by ). Herald added subscribers: lldb-commits, teemperor. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

lanza accepted this revision. lanza added a comment. Yay, thanks Jonas! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124429/new/ https://reviews.llvm.org/D124429 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D114491: WIP -- add CLI to lldb-vscode

lanza abandoned this revision. lanza added a comment. Herald added a project: All. 😢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114491/new/ https://reviews.llvm.org/D114491 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152494/new/ https://reviews.llvm.org/D152494

[Lldb-commits] [PATCH] D114491: lldb-vscode plugin

lanza created this revision. lanza requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Just uploading this incase I want to look at it again at some point in the future. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114491

[Lldb-commits] [PATCH] D84269: [lldb] Add some example type anotations to python.swig

lanza created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Python3.5 (3.4?) added type annotations to the python language. This lets tools such as LSPs provide useful IDE-like completion when writing python. Add type annotations throughout the python swig

[Lldb-commits] [PATCH] D84269: [lldb] Add some example type anotations to python.swig

lanza added a comment. Herald added a subscriber: JDevlieghere. Sounds good, just sent out a message to the mailing list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84269/new/ https://reviews.llvm.org/D84269

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

lanza accepted this revision. lanza added a comment. utils/sync-source misc/grep-svn-log.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65155/new/ https://reviews.llvm.org/D65155 ___ lldb-commits mai

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

lanza added a comment. Herald added a project: LLVM. @aleksandr.urakov Microsoft's docs state > The first four integer arguments are passed in registers. Integer values are > passed in left-to-right order in RCX, RDX, R8 > , and R9 >

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

lanza added a comment. So the ABI plugin for Windows x64 seems to be necessary for proper unwinding. (Also, proper parsing of xdata and pdata sections might be necessary, too.) I suspect that this could be related to https://bugs.llvm.org/show_bug.cgi?id=32343, but would need to look more into

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

lanza added a comment. Any reason why the backtick method is insufficient? I don't like the idea of the behavior of typing `q` or `c` being dependent upon the frame you're in. On a similar note, I'm arguing for a better command prompt implementation in the DAP & VSCode. I'm trying to get a pty

[Lldb-commits] [PATCH] D62547: (lldb-vscode) Evaluate expressions as LLDB commands when in REPL mode.

lanza added a comment. Yup, clayborg and I talked about the solution I discuss in that request. The hopeful eventual goal is for this communication: - DAP host: can you support attaching to a pty? - lldb-vscode: yes - DAP host: okay, use `/dev/pty123` - lldb-vscode: `Debugger:RunCommandInterpre

[Lldb-commits] [PATCH] D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

lanza added a comment. @clayborg Seems like this still steps into the `call` if the call is the last instruction in the range. `ThreadPlanStepRange::SetNextBranchBreakpoint` checks `if (last_index - pc_index > 1)` before setting the breakpoint. So if `last_index == pc_index` and `pc` points to

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

lanza added inline comments. Comment at: lldb/utils/xcode.py:1 +#!/usr/bin/env python + This could probably be just a 10 line `make` file that you just `make -f lldb/utils/xcode.mk`. Not sure if you guys are a fan of this method, but we tend to find it to be mu

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

This revision was automatically updated to reflect the committed changes. Closed by commit rG137ff7331705: [lldb] add a missing dependency on intrinsics_gen (authored by rmaz, committed by lanza). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza created this revision. lanza requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The debugger itself doesn't get stale between script prompt usages. Setting this to `None` also breaks users of the scripting API that used this property in

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza updated this revision to Diff 314037. lanza added a comment. Herald added a subscriber: JDevlieghere. did it backwards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93926/new/ https://reviews.llvm.org/D93926 Files: lldb/source/Plugins/Scri

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza added a comment. What's the boundaries of the stable API, then? This was a public API that was removed and broke a plugin I used for vim (and I'll be this isn't the only case, just I'm maybe the only one who has worked on lldb before whose tool broke). The author used `threading.Thread(so

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza added a comment. I guess if the intention of that is maintain the debugger instance around it should work, but at the moment it segfaults pretty quick with Xcode's lldb using: import threading import lldb import time def background(debugger: lldb.SBDebugger): while True:

[Lldb-commits] [PATCH] D93926: [lldb] Don't remove the lldb.debugger var after exiting the interpreter

lanza abandoned this revision. lanza added a comment. Great, that does indeed seem to work properly. Thanks, Jonas! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93926/new/ https://reviews.llvm.org/D93926 __

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

lanza accepted this revision. lanza added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM, I had to do this to fix it locally and can confirm it works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

lanza added a comment. Thanks, Jonas! What's the status for your downstream repos? This generates bindings but they aren't entirely functional as it generates type annotations like `"lldb::SBDebugger"` which Python LSPs can't figure out. I ended up adding `-py3` and then running some sed post-p

[Lldb-commits] [PATCH] D70885: [lldb] Use explicit lldb commands on tests

lanza added a comment. Sorry for bump to this old diff, but I agree with both Jim and Greg -- we shouldn't be importing your `~/.lldbinit`, but tests shouldn't depend on there never being another `br s`. This change should land as `breakpoint set`. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

lanza created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DAP is usually communicated over STDIN and STDOUT and thus lldb's Debugger instance printing and reading from these files can cause conflicts. However, if the DAP communication was set up to be

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

lanza added a comment. Great point! Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71633/new/ https://reviews.llvm.org/D71633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D71633: [lldb-vscode] Only close the debuggers in/out when DAP is over stdin/out

lanza updated this revision to Diff 234586. lanza added a comment. fixup according to Greg's requests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71633/new/ https://reviews.llvm.org/D71633 Files: lldb/tools/lldb-vscode/lldb-vscode.cpp Index: