[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman, klimek, alexfh. Herald added subscribers: lldb-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLDB. njames93 requested review of this revision. Herald added a subscriber: JDevlieghere. Implementing a

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added a comment. In D91103#2384048 , @jingham wrote: > IIUC, the expression parser part of this change suppresses any Fixits that > are clang-tidy type rewrites, is that right? If so that is indeed the > correct behavior. But the fact that thi

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304126. njames93 added a comment. Add `isReformatFixit` method to `FixItHint` to better express intent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 Files: clang-

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added a comment. An example of this in action is D91149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 ___ lldb-commit

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304198. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Teach clangd to ignore these fix-its. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:636 +// Filter out any reformat fixits, we don't handle these. +// FIXME: Can we? +llvm::erase_if(FixIts, kadircet wrote: > in theory yes, as we have access to source

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304477. njames93 marked 2 inline comments as done. njames93 added a comment. Removed the first loop for clangd diagnostic, turns out it didnt make the following code that much messier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304574. njames93 marked an inline comment as done. njames93 added a comment. Address nit by replacing optional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 Files:

[Lldb-commits] [PATCH] D93733: [NFC] replace resize calls with resize_for_overwrite

njames93 created this revision. Herald added subscribers: dexonsmith, asbirlea, hiraditya. njames93 published this revision for review. Herald added projects: clang, LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits. Also replace a few calls to resize followed by zeroin