@@ -174,6 +177,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
@@ -174,6 +177,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
mbucko wrote:
Let me know if you guys don't want this patch in. I will closed it and apply it
to our local branch.
https://github.com/llvm/llvm-project/pull/102536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -691,6 +691,19 @@ def request_disassemble(
for inst in instructions:
self.disassembled_instructions[inst["address"]] = inst
+def request_read_memory(self, memoryReference, offset, count):
mbucko wrote:
for consistency this should be
@@ -4028,6 +4046,161 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
@@ -449,6 +449,10 @@ class RangeDataVector {
~RangeDataVector() = default;
void Append(const Entry &entry) { m_entries.emplace_back(entry); }
+
+ void Append(const B&& b, const S&& s, const T&& t) {
mbucko wrote:
Cannot have const rvalue reference. You
@@ -80,6 +80,17 @@ class LLDB_API SBSaveCoreOptions {
/// \return True if the thread was removed, false if it was not in the list.
bool RemoveThread(lldb::SBThread thread);
+ /// Add a memory region to save in the core file.
+ ///
+ /// \param region The memory region t
mbucko wrote:
> Let me know if you guys don't want this patch in. I will closed it and apply
> it to our local branch. @jasonmolenda @labath
@labath just a friendly ping
https://github.com/llvm/llvm-project/pull/102536
___
lldb-commits mailing list
l
https://github.com/mbucko closed
https://github.com/llvm/llvm-project/pull/102536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mbucko wrote:
Closing this PR in favor of #104193
https://github.com/llvm/llvm-project/pull/102536
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -450,6 +450,8 @@ class RangeDataVector {
void Append(const Entry &entry) { m_entries.emplace_back(entry); }
+ void Append(B &&b, S &&s, T &&t) { m_entries.emplace_back(Entry(b, s, t)); }
mbucko wrote:
why not just name then base, size, data? Then the r
@@ -0,0 +1,86 @@
+//===-- CoreFileMemoryRanges.cpp *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,50 @@
+//===-- CoreFileMemoryRanges.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,86 @@
+//===-- CoreFileMemoryRanges.cpp *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,86 @@
+//===-- CoreFileMemoryRanges.cpp *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/88543
Summary:
AddMemoryList() was returning the last error status returned by ReadMemory().
So if an invalid memory region was read last, the function would return an
error.
Test Plan:
./bin/llvm-lit -sv
~/src/llvm-
https://github.com/mbucko closed https://github.com/llvm/llvm-project/pull/88543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/88564
Summary:
AddMemoryList() was returning the last error status returned by ReadMemory().
So if an invalid memory region was read last, the function would return an
error.
Test Plan:
./bin/llvm-lit -sv
~/src/llvm-
@@ -655,9 +655,10 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
&process_sp,
const addr_t addr = core_range.range.start();
const addr_t size = core_range.range.size();
auto data_up = std::make_unique(size, 0);
+Status read_error;
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From c588870cc8ff14806165f454d242f862ef19e89c Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From cfb233c0fb13c269e6431ceef4910d8c3cabb014 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From 27f7d03cfda9c6eea67973b9d8c3089abde8b732 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From 8877be23ad4d342e7f9b61896581707005f76d4e Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/89405
Summary:
When the target inferior process that is being debugged exits in lldb command
line, it emits following message:
`Process 4049526 exited with status = -1 (0x) debugserver died with
signal SIGTERM`
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From 31d688e70beec442cf731986ff8e4c8e9b5a9f0c Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/mbucko edited https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/88564
>From 3a69226e9ca90bb7ae220b9c3a71a0c2371e52fc Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 12 Apr 2024 09:55:46 -0700
Subject: [PATCH] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam
Summary
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From 91a4fa40c9fdaee1794fedb3c49707130c22a06b Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From 5e270c26adbb1e8febb72fc74d348d4f9619c7bf Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From b20ef7c68e23835ebf2c31f836407a0fb9f875a0 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
@@ -4,10 +4,30 @@
import dap_server
import lldbdap_testcase
+import psutil
+from collections import deque
from lldbsuite.test import lldbutil
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
+def get_subprocess_pid(process_name):
+queue =
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From 4c22c237dae73f3fbac22c0d725ae4fa449170df Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From d0ed0c618aeaf81dd471fc31c9f14d4b207effaa Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/89405
>From edefccebc44296d9be29ddde2c48174feb5d2911 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 19 Apr 2024 08:08:02 -0700
Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli
Summary:
Wh
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/90223
Summary:
'test_exit_status_message_sigterm' is failing due to 'psutil' dependency
introduced in PR #89405. This fix removes 'deque' dependency and checks if
'psutil' can be imported before running the test. If 'p
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/90223
>From 6e1ef0f3fd733e75a3453e8e83994e0c921c09a0 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 26 Apr 2024 08:17:26 -0700
Subject: [PATCH] [lldb-dap] Fix test_exit_status_message_sigterm test.
Summary:
'test
mbucko wrote:
> What about trying to use a python builtin like
> https://docs.python.org/3/library/multiprocessing.html#multiprocessing.active_children?
Nice, I will look into it
https://github.com/llvm/llvm-project/pull/90223
___
lldb-commits mailin
mbucko wrote:
> What about trying to use a python builtin like
> https://docs.python.org/3/library/multiprocessing.html#multiprocessing.active_children?
It seems that multiprocessing doesn't provide a way to iteratively list the
subprocesses and there is no other built in python library afaik.
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/90223
>From bb166a95bafc74860d78da0dedb5760c579cae48 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 26 Apr 2024 08:17:26 -0700
Subject: [PATCH] [lldb-dap] Fix test_exit_status_message_sigterm test.
Summary:
'test
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/90223
>From c699eff1500a431225d4b292a51a467bd2c74e5d Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Fri, 26 Apr 2024 08:17:26 -0700
Subject: [PATCH] [lldb-dap] Fix test_exit_status_message_sigterm test.
Summary:
'test
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/114120
None
>From 3c831942c752004a6e46c1f5ddd5e783ee2176e0 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 29 Oct 2024 13:02:21 -0700
Subject: [PATCH] Fix return value of 'PluginManager::RegisterPlugin()'.
---
l
https://github.com/mbucko approved this pull request.
https://github.com/llvm/llvm-project/pull/111951
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/114120
>From 362d6f52709ddf303d9d9fa256526182ba60fa53 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 29 Oct 2024 13:02:21 -0700
Subject: [PATCH] Fix return value of 'PluginManager::RegisterPlugin()'.
---
lldb/so
mbucko wrote:
> We obviously aren't checking this return anywhere. The only way it can return
> false that I can see is if you call RegisterPlugin with no callback pointer -
> which seems more like a programming error than a run-time check. Do we
> actually need this bool return?
It is indeed
https://github.com/mbucko closed
https://github.com/llvm/llvm-project/pull/114120
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko updated
https://github.com/llvm/llvm-project/pull/11
>From 4ba15cd7e64f8f4a2a5d804a1f986aafff9f6d17 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 26 Nov 2024 12:07:57 -0800
Subject: [PATCH] Add 'FindFirstSymbolWithNameAndType()' to ModuleList.
---
lldb/inc
mbucko wrote:
> Do you have a link to a PR that exercises this new API?
I'm only using it in an internal branch
https://github.com/llvm/llvm-project/pull/11
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/mbucko closed
https://github.com/llvm/llvm-project/pull/114120
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/11
None
>From 7f36a8b8672c9a75aa7dfe6a123401ae6d789a11 Mon Sep 17 00:00:00 2001
From: Miro Bucko
Date: Tue, 26 Nov 2024 12:07:57 -0800
Subject: [PATCH] Add 'FindFirstSymbolWithNameAndType()' to ModuleList.
---
ll
https://github.com/mbucko reopened
https://github.com/llvm/llvm-project/pull/114120
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -429,62 +429,64 @@ MinidumpParser::GetExceptionStreams() {
std::optional
MinidumpParser::FindMemoryRange(lldb::addr_t addr) {
- Log *log = GetLog(LLDBLog::Modules);
+ if (m_memory_ranges.IsEmpty())
+PopulateMemoryRanges();
+
+ MemoryRangeVector::Entry *entry =
m_mem
@@ -35,6 +36,9 @@ namespace minidump {
// Describes a range of memory captured in the Minidump
struct Range {
+ // Default constructor required for range data vector
+ // but unusued.
+ Range() {}
mbucko wrote:
Range() = default;
https://github.com/llvm/l
@@ -429,62 +429,64 @@ MinidumpParser::GetExceptionStreams() {
std::optional
MinidumpParser::FindMemoryRange(lldb::addr_t addr) {
- Log *log = GetLog(LLDBLog::Modules);
+ if (m_memory_ranges.IsEmpty())
+PopulateMemoryRanges();
+
+ MemoryRangeVector::Entry *entry =
m_mem
101 - 153 of 153 matches
Mail list logo
