[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot created this revision. zloyrobot added reviewers: amccarth, asmith, stella.stamenova. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This patch adds ability to find .pdb files in NT_SYMBOL_PATH folders and in .exe file folder Repository: rLLDB LL

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot created this revision. zloyrobot added reviewers: amccarth, thakis. zloyrobot added a project: LLDB. Herald added subscribers: llvm-commits, lldb-commits, erik.pilkington, hiraditya. Herald added a project: LLVM. All callers of Demangler::parseTagUniqueName check 'Demangler.Error' and a

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added inline comments. Comment at: lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp:4 + +// Test that we can find .pdb file in folder containing .exe file. +// RUN: %build --compiler=clang-cl --nodefaultlib -o %t.exe -- %s stella.stamenova wrote: > Is

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196226. zloyrobot added a comment. Add test case for searching .pdb file in the same folder as .exe file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/pdb-file-look

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196232. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/Inputs/pdb-file-lookup.lldbinit lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot added a comment. In D60963#1474783 , @thakis wrote: > test? Would you please advise me on what kind of test I should add for such fix? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot marked 2 inline comments as done. zloyrobot added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196614. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/Inputs/pdb-file-lookup.lldbinit lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot marked 2 inline comments as done. zloyrobot added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic

[Lldb-commits] [PATCH] D61128: Fix stack unwinding for struct methods

zloyrobot created this revision. zloyrobot added reviewers: amccarth, aleksandr.urakov. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. Repository: rLLDB LLDB https://reviews.llvm.org/D61128 Files: lldb/lit/SymbolFile/NativePDB/Inputs/stack_unwinding01.lld

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

zloyrobot added a comment. In D61128#1482765 , @amccarth wrote: > Thanks for the improved commit message. Again, sorry about the delay. No problem, thanks for review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6112

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

zloyrobot added a comment. In D61128#1483663 , @zloyrobot wrote: > In D61128#1482765 , @amccarth wrote: > > > Thanks for the improved commit message. Again, sorry about the delay. > > > No problem, thanks for revie

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

zloyrobot added a comment. kind reminder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews.llvm.org/D60963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added a comment. In D60962#1477160 , @amccarth wrote: > Thanks Pavel! > > Please address Pavel's inline comments, and I'll accept this. Kind reminder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/

[Lldb-commits] [PATCH] D61128: Support member function types in PdbAstBuilder

zloyrobot added a comment. In D61128#1499934 , @labath wrote: > Looks like this is failing on the windows bot > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/4635/steps/test/logs/stdio. > > Looking at the test, it seems that you are asse

[Lldb-commits] [PATCH] D61886: Support member functions construction and lookup in PdbAstBuilder

zloyrobot created this revision. zloyrobot added reviewers: amccarth, aleksandr.urakov, stella.stamenova. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This path implements member function support in PdbAstBuilder::GetOrCreateFunctionDecl. It allows to lookup

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot added a comment. In D60962#1504921 , @labath wrote: > Adrian is on vacation now, but given that he was just waiting until you > resolve my comments (which you have), I think we don't have to wait for him. Thank you for one more review. Repos