aizatsky added a comment.
In https://reviews.llvm.org/D24369#538213, @zturner wrote:
> Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid the
> JSON parser that currently exists in LLDB won't do. As Pavel mentioned, the
> code has a definite LLDB feel to it, but more imp
aizatsky updated this revision to Diff 70877.
aizatsky added a comment.
- getting rid of StringExtractor
- renaming methods to lowerCase.
https://reviews.llvm.org/D24369
Files:
.clang-tidy
include/llvm/Support/JSON.h
lib/Support/CMakeLists.txt
lib/Support/JSON.cpp
unittests/Support/CM
aizatsky added a comment.
In https://reviews.llvm.org/D24369#538472, @zturner wrote:
> In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
>
> > In https://reviews.llvm.org/D24369#538213, @zturner wrote:
> >
> > > Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid
aizatsky updated this revision to Diff 70879.
aizatsky added a comment.
remove .clang-tidy
https://reviews.llvm.org/D24369
Files:
include/llvm/Support/JSON.h
lib/Support/CMakeLists.txt
lib/Support/JSON.cpp
unittests/Support/CMakeLists.txt
unittests/Support/JSONTest.cpp
Index: unittes
aizatsky updated this revision to Diff 70946.
aizatsky marked 10 inline comments as done.
aizatsky added a comment.
cleanup
https://reviews.llvm.org/D24369
Files:
include/llvm/Support/JSON.h
lib/Support/CMakeLists.txt
lib/Support/JSON.cpp
unittests/Support/CMakeLists.txt
unittests/Sup
Oh, that's great! Thanks for pointing this out. I'll just upload the
cleaned up version in case lldb/ folks would like it. I'll figure out how
to use our YAML library.
On Fri, Sep 9, 2016 at 6:48 PM Chandler Carruth wrote:
> chandlerc added a comment.
>
> In https://reviews.llvm.org/D24369#53847
aizatsky abandoned this revision.
Comment at: include/llvm/Support/JSON.h:207
@@ +206,3 @@
+private:
+ typedef std::map Map;
+ typedef Map::iterator Iterator;
zturner wrote:
> `DenseMap` seems like a better choice here.
DenseMap doesn't seem to be defined for st
