https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,43 @@
+"""
+Test SBTarget::FindGlobalVariables API.
+"""
Michael137 wrote:
Could we re-use `TestConstStaticIntegralMember.py`? Surprised it doesn't
already have the tests added here XFAILed
https://github.com/llvm/llvm-project/pull/111859
___
@@ -434,6 +442,19 @@ static void GetTypeLookupContextImpl(DWARFDIE die,
auto push_ctx = [&](CompilerContextKind kind, llvm::StringRef name) {
context.push_back({kind, ConstString(name)});
};
+
+// Since mangled names are unique there's no need to build an enti
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/97443
>From 38b7837bcc5da9e89778191654f9552ebccacbd5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Jul 2024 18:43:34 +0200
Subject: [PATCH 1/3] [clang][RecordLayoutBuilder] Be stricter about inferring
pa
https://github.com/Michael137 commented:
gentle ping
@efriedma-quic mind taking another look? Latest iteration skips over empty
fields that overlap.
https://github.com/llvm/llvm-project/pull/97443
___
lldb-commits mailing list
lldb-commits@lists.llvm
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/113166
Currently all the headings marked as `#` show up
as a top-level entry in the `Developing LLDB`
toctree. This patch marks these as `##` so only
`Adding Programming Language Support` is displayed
in the table of
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/113166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
I believe we need to just remove all the USE_ variables. The PR that broke your
bots was itself motivated by a breakage due to USE_SYSTEM_STDLIB
https://github.com/llvm/llvm-project/pull/112598
___
lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM thx!
https://github.com/llvm/llvm-project/pull/112598
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> I think this is one of those tests that should really be an API test. As far
> as I can tell, there's nothing darwin-specific about this bug -- except for
> the fact that building shared libraries in a cross-platform manner is hard.
> But the API tests have wrappers that le
@@ -13,6 +13,13 @@
# the building of the a.out executable program. For example,
# DYLIB_ONLY := YES
#
+# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
+# controls the name of the produced dylib. E.g., if set to "foo",
+# the generated dylib will be called "f
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112735
>From 6da0d2a549418d86e8877564ba7c6ff7c56db2eb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 17 Oct 2024 16:52:48 +0100
Subject: [PATCH 1/2] [lldb][test][NFC] Document DYLIB_NAME Makefile variable
-
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112748
>From 247f2638be2decf0f806050e90c25c4b664b2f97 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 17 Oct 2024 17:40:35 +0100
Subject: [PATCH 1/6] [lldb][ClangASTImporter][NFC] Emit a log message when we
@@ -13,6 +13,13 @@
# the building of the a.out executable program. For example,
# DYLIB_ONLY := YES
#
+# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
+# controls the name of the produced dylib. E.g., if set to "foo",
+# the generated dylib will be called "f
Michael137 wrote:
Just to circle back on this. Managed to reduce the crash I was seeing to
something pretty simple. The gist of the issue is that we silently create ODR
violations in LLDB's scratch context (and LLDB uses `ODRHandlingType::Liberal`,
so we try to continue `ASTImport`ing despite
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/2] [lldb][CMake] Add single target that runs libc++ tests
---
@@ -267,6 +267,21 @@ add_lit_testsuite(check-lldb "Running lldb lit test suite"
lldb-shell-test-deps
lldb-unit-test-deps)
+# This target covers all targets that are tied to implementation details
+# of libc++, intended to be run by the libc++ pre-merge CI.
+add_lit_tes
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From ee28f91822ca449b7b4bb84293cae2aee6803da4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/3] [lldb][CMake] Add single target that runs libc++ tests
---
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/8] [lldb][CMake] Add single target that runs libc++ tests
---
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/23
Relands https://github.com/llvm/llvm-project/pull/108375 which had to be
reverted because it was failing on the Windows buildbot. Trying to reland this
with `msvc::no_unique_address` on Windows.
>From 27ff1
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/6] [lldb][CMake] Add single target that runs libc++ tests
---
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 commented:
`TypeSystemClang.cpp` change LGTM. Though It'd be nice if we added the same
test-coverage also for non-MSVC (only found shell tests for PDB, and 1 API test
that didn't enumerate all the cases).
I gu
Michael137 wrote:
Confirmed the libc++ tests pass. Removing them from this PR
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/113891
>From 40bbe1d8f72f697c0c4759fa68f2bd64a50d742c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 28 Oct 2024 10:07:36 +
Subject: [PATCH 1/3] Init
---
.github/workflows/libcxx-build-and-test.yaml |
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -2771,6 +2771,9 @@ static bool GetCompleteQualType(clang::ASTContext *ast,
ast, llvm::cast(qual_type)->getModifiedType(),
allow_completion);
+ case clang::Type::MemberPointer:
+return !qual_type.get
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
Michael137 wrote:
> > I guess a follow-up question is how to set the MSInheritanceAttr. Infer it
> > from the class DIE? Or add a new DWARF attribute?
> > Well, maybe, but not sure. I believe it has a set of attributes that convey
> > the i
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN: lld-link /out:%t_win.exe %t
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 approved this pull request.
lgtm (modulo test comment)
https://github.com/llvm/llvm-project/pull/112928
__
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -614,7 +614,7 @@ DWARFDebugInfoEntry::GetAbbreviationDeclarationPtr(const
DWARFUnit *cu) const {
}
bool DWARFDebugInfoEntry::IsGlobalOrStaticScopeVariable() const {
- if (Tag() != DW_TAG_variable)
+ if (Tag() != DW_TAG_variable && Tag() != DW_TAG_member)
Michael137 wrote:
Hmm am I reading this right that the latest run still failed, despite the
cherry-pick?
https://github.com/llvm/llvm-project/pull/110303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/113593
When running in constrained environments like docker, disable ASLR might fail
with errors like:
```
AssertionError: False is not true : launch failed (Cannot launch
'/__w/.../lldb-dap/stackTrace/subtleFrames/
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Yea using the new `TypeQuery` option in `lldb-test` seems doable. Whether
`obj2yaml`/`yaml2obj` supports `.debug_names`, i'm not sure, haven't tried
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Sorry to clarify. I think based on @felipepiovezan comment here:
https://github.com/llvm/llvm-project/pull/108870#issuecomment-281588
On Clang 17 we compile fine, just the assertion fails to find the expected
function name (because of the `std::__1` inline namespace):
```
Michael137 wrote:
If we don't always want forward `disableASLR` we could instead flip the
condition to:
```
if not disableASLR:
args_dict["disableASLR"] = disableASLR
```
Any thoughts?
https://github.com/llvm/llvm-project/pull/113891
___
lldb-com
Michael137 wrote:
Note that for the clang-15 failure you'll have to make sure we account for
inline namespaces in the test assertion
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> @Michael137 I wasn't able to run `yaml2obj` to convert back an object file
> that contains debug info, I'm not sure if the issue is that `yaml2obj`
> doesn't support something that's encoded in the debug info, or some bug with
> MachO.
>
> This is the error:
>
> ```
> err
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/114160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2758,6 +2758,20 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
return true; // Keep iterating over index types, language mismatch.
}
+// Since mangled names are unique, we only need to check if the names are
+// the
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/114529
>From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 20 Oct 2024 11:35:15 +0100
Subject: [PATCH 1/2] [WIP][lldb][Expression] More reliable function call
resol
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/114529
>From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 20 Oct 2024 11:35:15 +0100
Subject: [PATCH 1/2] [WIP][lldb][Expression] More reliable function call
resol
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM too, thanks!
Given the pre-DWARFv4 spec isn't very specific about how to differentiate
static vs non-static members, leaving out the check/assert for
`DW_TAG_data_member_location` as Pavel suggested seems correct.
https://github.c
@@ -362,6 +369,18 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
Michael137 wrote:
I haven't done an in-depth review of the patch yet but my first instinct here
is that this looks like a lot of work for LLDB which the compiler has already
done, so we ideally don't want to repeat. Where is this actually an issue from
a user perspective? In the example you ga
Author: Michael Buch
Date: 2024-11-04T11:23:11Z
New Revision: eee8718e26b4ce8972abefc35d2beae96521075f
URL:
https://github.com/llvm/llvm-project/commit/eee8718e26b4ce8972abefc35d2beae96521075f
DIFF:
https://github.com/llvm/llvm-project/commit/eee8718e26b4ce8972abefc35d2beae96521075f.diff
LOG:
@@ -362,6 +369,18 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
https://github.com/Michael137 approved this pull request.
Think the intention was to originally make sure that we're debugging libc++.
Checking this here is unnecessary (and should really be asserted at the
Makefile layer, which do on Apple platforms)
https://github.com/llvm/llvm-project/pull/
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/114251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> It's interesting that the 17.0 bot is still not happy:
>
>
>
> ```
>
> File
> "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-matrix/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py",
> line 321, in check_value
>
> test_base.assertEqual(
>
> As
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/114529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/114529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Example constructor decl would look like the following:
```
| `-CXXConstructorDecl 0x246e6f8 <> Bar 'void ()'
| `-StructorMangledNamesAttr 0x246e7c0 <> Implicit
2:$__lldb_func_0x014B6560:257 1:$__lldb_func_0x014B6560:294
```
https://github.com/llvm/llvm-proj
https://github.com/Michael137 approved this pull request.
Seems reasonable to me
Yea not entirely sure how to test this either. As Greg points out, type
mangling isn't really a thing LLDB cared about for C++. Maybe if we had this
option exposed somehow (e.g., through `lldb-test`) we could come
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/113593
>From 135092caf94e69c0aac25bcb73190ea69776d60e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 24 Oct 2024 17:50:02 +0100
Subject: [PATCH 1/2] [lldb-dap][test] Set disableASLR to False for tests
When
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/113891
>From 5da7c345986693a4156ccc2f3ea6de3877e4330d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 28 Oct 2024 17:07:38 +
Subject: [PATCH] [lldb-dap] Always pass disableASLR to the DAP executable
More
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/113891
>From 0c676a6001ac38cab2eacb54a6cce57df178007a Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 28 Oct 2024 10:07:36 +
Subject: [PATCH 1/2] [DO-NOT-MERGE] libc++ CI change for testing
---
.github/
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/113891
>From 40bbe1d8f72f697c0c4759fa68f2bd64a50d742c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 28 Oct 2024 10:07:36 +
Subject: [PATCH 1/2] Init
---
.github/workflows/libcxx-build-and-test.yaml |
Michael137 wrote:
Btw @weliveindetail , the `TestDAP_evaluate.py` test failure happens on other
PRs too. So I think this is safe to merge.
https://github.com/llvm/llvm-project/pull/115177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
Author: Michael Buch
Date: 2024-11-11T13:30:06Z
New Revision: bc368e4b578730bf0b10acd5412e476ccf7a5807
URL:
https://github.com/llvm/llvm-project/commit/bc368e4b578730bf0b10acd5412e476ccf7a5807
DIFF:
https://github.com/llvm/llvm-project/commit/bc368e4b578730bf0b10acd5412e476ccf7a5807.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/115571
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1032,11 +1032,17 @@ void SymbolFileCTF::FindTypes(const
lldb_private::TypeQuery &match,
ConstString name = match.GetTypeBasename();
for (TypeSP type_sp : GetTypeList().Types()) {
-if (type_sp && type_sp->GetName() == name) {
- results.InsertUnique(type_sp);
-
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/113593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,8 @@
+#include "artificial_location.h"
+
+int A::foo() {
+#line 0
Michael137 wrote:
FYI there's some discussion about this test going on in
https://github.com/llvm/llvm-project/pull/107849, in case you had some thoughts
on Jeremy's points
https://gi
@@ -101,9 +101,9 @@ def run_test_evaluate_expressions(
if context == "repl":
# In the repl context expressions may be interpreted as lldb
# commands since no variables have the same name as the command.
-self.assertEvaluate("var", r"\
Michael137 wrote:
LLDB changes LGTM, thanks!
The `tools/lldb-dap/evaluate/TestDAP_evaluate.py` is unrelated to this PR and
has been failing on other PRs too. So feel free to merge if the libc++ changes
are good to go
https://github.com/llvm/llvm-project/pull/115517
___
https://github.com/Michael137 commented:
Thanks for the quick fix. I'll let @walter-erquinigo give the final approval
here as the original author of this test.
https://github.com/llvm/llvm-project/pull/116045
___
lldb-commits mailing list
lldb-commits
@@ -101,9 +101,9 @@ def run_test_evaluate_expressions(
if context == "repl":
# In the repl context expressions may be interpreted as lldb
# commands since no variables have the same name as the command.
-self.assertEvaluate("var", r"\
@@ -101,9 +101,9 @@ def run_test_evaluate_expressions(
if context == "repl":
# In the repl context expressions may be interpreted as lldb
# commands since no variables have the same name as the command.
-self.assertEvaluate("var", r"\
https://github.com/Michael137 approved this pull request.
LGTM thx!
https://github.com/llvm/llvm-project/pull/114122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Agree with Pavel.
> When libcxx is linked with a program as an archive of static libraries,
functions that aren't used in the program are omitted.
This really isn't the problem. The tests *want* those symbols to not be present
and make sure that we can find those in the `std`
Michael137 wrote:
> > Agree with Pavel.
>
> I'm not sure you do :P
>
> > > When libcxx is linked with a program as an archive of static libraries,
> > > functions that aren't used in the program are omitted.
> >
> >
> > This really isn't the problem. The tests _want_ those symbols to not be
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/114529
Naive implementation of all the parts of following RFC:
https://discourse.llvm.org/t/rfc-lldb-handling-abi-tagged-constructors-destructors-in-expression-evaluator/82816
Main changes:
1. Instead of relying on
@@ -140,6 +141,64 @@ void MangleContext::mangleName(GlobalDecl GD, raw_ostream
&Out) {
const ASTContext &ASTContext = getASTContext();
const NamedDecl *D = cast(GD.getDecl());
+ if (const StructorMangledNamesAttr *SMA =
+ D->getAttr()) {
+CXXConstructorDecl
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/114529
>From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 20 Oct 2024 11:35:15 +0100
Subject: [PATCH] [WIP][lldb][Expression] More reliable function call
resolutio
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/114529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/114529
>From 7f18d96b7117e83c4ed246ac498ee4c9a72064ff Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 20 Oct 2024 11:35:15 +0100
Subject: [PATCH] [WIP][lldb][Expression] More reliable function call
resolutio
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
@@ -346,6 +346,31 @@ Third-party Integrations
Libc++ provides integration with a few third-party tools.
+Debugging libc++ internals in LLDB
+--
+
+LLDB hides the implementation details of libc++ by default.
+
+E.g., when setting a breakpoint in
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
1301 - 1400 of 2354 matches
Mail list logo
