Author: Michael Buch
Date: 2022-09-16T12:38:49-04:00
New Revision: 3004a759bcdf7b0a2a3a4220ed216d20defbd081
URL:
https://github.com/llvm/llvm-project/commit/3004a759bcdf7b0a2a3a4220ed216d20defbd081
DIFF:
https://github.com/llvm/llvm-project/commit/3004a759bcdf7b0a2a3a4220ed216d20defbd081.diff
Author: Michael Buch
Date: 2022-09-16T12:38:50-04:00
New Revision: e456d2ba8bcadaa63386b339a4f2abcb39505502
URL:
https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502
DIFF:
https://github.com/llvm/llvm-project/commit/e456d2ba8bcadaa63386b339a4f2abcb39505502.diff
Author: Michael Buch
Date: 2022-09-23T12:27:08+02:00
New Revision: d5d90428500870107909fb8f90023ff608cd1ec2
URL:
https://github.com/llvm/llvm-project/commit/d5d90428500870107909fb8f90023ff608cd1ec2
DIFF:
https://github.com/llvm/llvm-project/commit/d5d90428500870107909fb8f90023ff608cd1ec2.diff
Author: Michael Buch
Date: 2022-09-26T19:54:24+01:00
New Revision: 12502ee551236375516b714cfdfb75d85b3b7e3e
URL:
https://github.com/llvm/llvm-project/commit/12502ee551236375516b714cfdfb75d85b3b7e3e
DIFF:
https://github.com/llvm/llvm-project/commit/12502ee551236375516b714cfdfb75d85b3b7e3e.diff
Author: Michael Buch
Date: 2022-09-26T19:54:24+01:00
New Revision: 1c6826e8fc6d5c47c3573efd8d080939a932
URL:
https://github.com/llvm/llvm-project/commit/1c6826e8fc6d5c47c3573efd8d080939a932
DIFF:
https://github.com/llvm/llvm-project/commit/1c6826e8fc6d5c47c3573efd8d080939a932.diff
Author: Michael Buch
Date: 2022-09-27T14:09:12+01:00
New Revision: c97e5adbf7c44ba5c46ec14712d3d8ee8b45aac9
URL:
https://github.com/llvm/llvm-project/commit/c97e5adbf7c44ba5c46ec14712d3d8ee8b45aac9
DIFF:
https://github.com/llvm/llvm-project/commit/c97e5adbf7c44ba5c46ec14712d3d8ee8b45aac9.diff
Author: Michael Buch
Date: 2022-09-27T14:11:02+01:00
New Revision: 7ccfaecba6b1aa80eea1903b2c5ee20d4f00374c
URL:
https://github.com/llvm/llvm-project/commit/7ccfaecba6b1aa80eea1903b2c5ee20d4f00374c
DIFF:
https://github.com/llvm/llvm-project/commit/7ccfaecba6b1aa80eea1903b2c5ee20d4f00374c.diff
Author: Michael Buch
Date: 2022-09-27T18:03:23+01:00
New Revision: 60eb06be6d23e3c5fd80113143784aac0d962965
URL:
https://github.com/llvm/llvm-project/commit/60eb06be6d23e3c5fd80113143784aac0d962965
DIFF:
https://github.com/llvm/llvm-project/commit/60eb06be6d23e3c5fd80113143784aac0d962965.diff
Author: Michael Buch
Date: 2022-10-04T18:38:47+01:00
New Revision: 9abeb0cbd983c7e32a729e333b033673546e5485
URL:
https://github.com/llvm/llvm-project/commit/9abeb0cbd983c7e32a729e333b033673546e5485
DIFF:
https://github.com/llvm/llvm-project/commit/9abeb0cbd983c7e32a729e333b033673546e5485.diff
Author: Michael Buch
Date: 2022-10-10T12:50:15+01:00
New Revision: a4561d934877fbba5cfb3cac3195a41707ba6043
URL:
https://github.com/llvm/llvm-project/commit/a4561d934877fbba5cfb3cac3195a41707ba6043
DIFF:
https://github.com/llvm/llvm-project/commit/a4561d934877fbba5cfb3cac3195a41707ba6043.diff
Author: Michael Buch
Date: 2022-10-10T17:07:52+01:00
New Revision: fd91e8f5016626328093aedc8419f12af20ff554
URL:
https://github.com/llvm/llvm-project/commit/fd91e8f5016626328093aedc8419f12af20ff554
DIFF:
https://github.com/llvm/llvm-project/commit/fd91e8f5016626328093aedc8419f12af20ff554.diff
Author: Michael Buch
Date: 2022-10-14T23:51:00+01:00
New Revision: d4a55ad346514b2478762cbc198942c72347e81e
URL:
https://github.com/llvm/llvm-project/commit/d4a55ad346514b2478762cbc198942c72347e81e
DIFF:
https://github.com/llvm/llvm-project/commit/d4a55ad346514b2478762cbc198942c72347e81e.diff
Author: Michael Buch
Date: 2022-10-21T14:00:50+01:00
New Revision: 3cc9884500ad53e878045bc1d119d8a6b326f274
URL:
https://github.com/llvm/llvm-project/commit/3cc9884500ad53e878045bc1d119d8a6b326f274
DIFF:
https://github.com/llvm/llvm-project/commit/3cc9884500ad53e878045bc1d119d8a6b326f274.diff
Author: Michael Buch
Date: 2022-10-22T12:16:07+01:00
New Revision: 46d8428680317d2d3f8555d145c447381129cfe7
URL:
https://github.com/llvm/llvm-project/commit/46d8428680317d2d3f8555d145c447381129cfe7
DIFF:
https://github.com/llvm/llvm-project/commit/46d8428680317d2d3f8555d145c447381129cfe7.diff
Author: Michael Buch
Date: 2022-10-24T07:45:37+01:00
New Revision: 38389f3109e8c862debdec769026f12cadc85e7b
URL:
https://github.com/llvm/llvm-project/commit/38389f3109e8c862debdec769026f12cadc85e7b
DIFF:
https://github.com/llvm/llvm-project/commit/38389f3109e8c862debdec769026f12cadc85e7b.diff
Author: Michael Buch
Date: 2022-10-25T12:34:00+01:00
New Revision: 891eb20104b6b77c7ff85f532bbce2a28ee9eeb0
URL:
https://github.com/llvm/llvm-project/commit/891eb20104b6b77c7ff85f532bbce2a28ee9eeb0
DIFF:
https://github.com/llvm/llvm-project/commit/891eb20104b6b77c7ff85f532bbce2a28ee9eeb0.diff
Author: Michael Buch
Date: 2022-10-28T11:31:15+01:00
New Revision: 2a812bdc70c6153f41907db056e348d9b322f01c
URL:
https://github.com/llvm/llvm-project/commit/2a812bdc70c6153f41907db056e348d9b322f01c
DIFF:
https://github.com/llvm/llvm-project/commit/2a812bdc70c6153f41907db056e348d9b322f01c.diff
Author: Michael Buch
Date: 2022-10-31T12:25:18Z
New Revision: d0bf48c7b179027d978c479167e23825b8d0c4f6
URL:
https://github.com/llvm/llvm-project/commit/d0bf48c7b179027d978c479167e23825b8d0c4f6
DIFF:
https://github.com/llvm/llvm-project/commit/d0bf48c7b179027d978c479167e23825b8d0c4f6.diff
LOG:
Author: Michael Buch
Date: 2022-10-31T12:25:19Z
New Revision: 031096d04d09ac4a93859d161fb42d1a1b308253
URL:
https://github.com/llvm/llvm-project/commit/031096d04d09ac4a93859d161fb42d1a1b308253
DIFF:
https://github.com/llvm/llvm-project/commit/031096d04d09ac4a93859d161fb42d1a1b308253.diff
LOG:
Author: Michael Buch
Date: 2022-10-31T12:25:18Z
New Revision: 76f34ed2837880c1865202f28988b01c93ac4f89
URL:
https://github.com/llvm/llvm-project/commit/76f34ed2837880c1865202f28988b01c93ac4f89
DIFF:
https://github.com/llvm/llvm-project/commit/76f34ed2837880c1865202f28988b01c93ac4f89.diff
LOG:
Author: Michael Buch
Date: 2022-10-31T14:35:37Z
New Revision: 9dd413a1be61f8fd84e67d255a245260755d8230
URL:
https://github.com/llvm/llvm-project/commit/9dd413a1be61f8fd84e67d255a245260755d8230
DIFF:
https://github.com/llvm/llvm-project/commit/9dd413a1be61f8fd84e67d255a245260755d8230.diff
LOG:
Author: Michael Buch
Date: 2022-10-31T22:59:16-07:00
New Revision: 3e03873e363b5aa90e4488da63a6de0648d11aba
URL:
https://github.com/llvm/llvm-project/commit/3e03873e363b5aa90e4488da63a6de0648d11aba
DIFF:
https://github.com/llvm/llvm-project/commit/3e03873e363b5aa90e4488da63a6de0648d11aba.diff
Author: Michael Buch
Date: 2022-11-03T06:30:14-07:00
New Revision: c188910694ab821aabc0ca11f4636b69f5f7b4f1
URL:
https://github.com/llvm/llvm-project/commit/c188910694ab821aabc0ca11f4636b69f5f7b4f1
DIFF:
https://github.com/llvm/llvm-project/commit/c188910694ab821aabc0ca11f4636b69f5f7b4f1.diff
Author: Michael Buch
Date: 2022-11-10T14:09:10-08:00
New Revision: 9dcaca706841fa38683eee341f24aafb58e6e3e9
URL:
https://github.com/llvm/llvm-project/commit/9dcaca706841fa38683eee341f24aafb58e6e3e9
DIFF:
https://github.com/llvm/llvm-project/commit/9dcaca706841fa38683eee341f24aafb58e6e3e9.diff
Author: Michael Buch
Date: 2022-11-30T14:39:39Z
New Revision: 77b220524541a9c29a6b50caa9f65addffeb37ba
URL:
https://github.com/llvm/llvm-project/commit/77b220524541a9c29a6b50caa9f65addffeb37ba
DIFF:
https://github.com/llvm/llvm-project/commit/77b220524541a9c29a6b50caa9f65addffeb37ba.diff
LOG:
Author: Michael Buch
Date: 2022-12-02T10:52:39Z
New Revision: 83599000e1f4b30d93b8f4509011b9b68d722835
URL:
https://github.com/llvm/llvm-project/commit/83599000e1f4b30d93b8f4509011b9b68d722835
DIFF:
https://github.com/llvm/llvm-project/commit/83599000e1f4b30d93b8f4509011b9b68d722835.diff
LOG:
Author: Michael Buch
Date: 2022-12-02T10:52:41Z
New Revision: 4df11394a10b3b15d2fb9bde8b831cf68785aa45
URL:
https://github.com/llvm/llvm-project/commit/4df11394a10b3b15d2fb9bde8b831cf68785aa45
DIFF:
https://github.com/llvm/llvm-project/commit/4df11394a10b3b15d2fb9bde8b831cf68785aa45.diff
LOG:
Author: Michael Buch
Date: 2022-12-02T10:52:40Z
New Revision: 5941858efdca72425c29bf043d3ec84e7fec6f62
URL:
https://github.com/llvm/llvm-project/commit/5941858efdca72425c29bf043d3ec84e7fec6f62
DIFF:
https://github.com/llvm/llvm-project/commit/5941858efdca72425c29bf043d3ec84e7fec6f62.diff
LOG:
Author: Michael Buch
Date: 2022-12-02T14:12:41Z
New Revision: 71f3cac7895ad516ec25438f803ed3c9916c215a
URL:
https://github.com/llvm/llvm-project/commit/71f3cac7895ad516ec25438f803ed3c9916c215a
DIFF:
https://github.com/llvm/llvm-project/commit/71f3cac7895ad516ec25438f803ed3c9916c215a.diff
LOG:
Author: Michael Buch
Date: 2022-12-05T10:50:16Z
New Revision: 811ad246ac7b46d85171577333be3fa4a9f04dbd
URL:
https://github.com/llvm/llvm-project/commit/811ad246ac7b46d85171577333be3fa4a9f04dbd
DIFF:
https://github.com/llvm/llvm-project/commit/811ad246ac7b46d85171577333be3fa4a9f04dbd.diff
LOG:
Author: Michael Buch
Date: 2022-12-05T16:57:42Z
New Revision: e1edcf7d14c126b9ebd2a77fcd9041d056cce64a
URL:
https://github.com/llvm/llvm-project/commit/e1edcf7d14c126b9ebd2a77fcd9041d056cce64a
DIFF:
https://github.com/llvm/llvm-project/commit/e1edcf7d14c126b9ebd2a77fcd9041d056cce64a.diff
LOG:
Author: Michael Buch
Date: 2022-12-05T18:14:26Z
New Revision: e31160155e484414db9177806ae9f0840c985b49
URL:
https://github.com/llvm/llvm-project/commit/e31160155e484414db9177806ae9f0840c985b49
DIFF:
https://github.com/llvm/llvm-project/commit/e31160155e484414db9177806ae9f0840c985b49.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Doing both seems fine, thanks!
Can we change the Darwin case to `USE_LIBCPP` though? The less reliance on the
system stdlib the better i think.
Also lets check that the PR CI actually does run the test (aka doesn't trigger
the skip add
Michael137 wrote:
Can you add in the PR description why the `--whole-archive and
--allow-multiple-definition` fixes the issue? And paste the log of the CI test
that's failing?
https://github.com/llvm/llvm-project/pull/98701
___
lldb-commits mailing l
Michael137 wrote:
So the problem is that because we statically link we fail to find a
`libstdc++.so`? Won't setting `USE_LIBSTDCPP` be an issue on Darwin?
Generally, why is this test trying to do disassembly on every STL symbol? Can't
really tell if this was actually STL specific from the git
Michael137 wrote:
> > maybe we could just skip the test if we can't locate the module?
>
> Can you suggest how to do that (locate the module)?
Instead of,
```
self.expect(
lib_stdcxx, "Libraray StdC++ is located", exe=False, substr
Michael137 wrote:
ping
(btw, @labath is the alignment miscalculation still causing issues for you
internally? or did you find a workaround?)
https://github.com/llvm/llvm-project/pull/97443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -191,14 +191,6 @@ llvm::Error
ItaniumABILanguageRuntime::TypeHasVTable(CompilerType type) {
type = pointee_type;
}
- // Make sure this is a class or a struct first by checking the type class
- // bitfield that gets returned.
- if ((type.GetTypeClass() & (eTypeCl
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
https://github.com/Michael137 commented:
Thanks for putting this together! Looks like non-trivial amount of
investigation.
On the first pass, I think this seems like a reasonable (and more maintainable)
alternative to what we're currently doing.
Using the `TypeSystem` to fish out the various
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/111892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/111892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> So does that mean that the `strip` coming with xcode is not `llvm-strip` ? I
> did not expect that..
>
> I don't suppose anyone has any background on this that they can share? :)
Yea pretty sure it's not. Just based on the options it accepts, etc.
Someone else might have mo
Michael137 wrote:
Can we do this for all the `no_unique_address-...` tests? Would be nice if they
were all in the same place. I'm not sure I added `--target` in all of them, but
probably should?
https://github.com/llvm/llvm-project/pull/111902
___
ll
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/111816
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
could you mention that this is a`Darwin`-only change in the commit/PR title?
Otherwise, LGTM. Will help with the situation i ran into a while ago:
https://reviews.llvm.org/D143842
https://github.com/llvm/llvm-project/pull/111816
___
Author: Michael Buch
Date: 2024-10-07T11:12:01+01:00
New Revision: a1c0ba1646f5a80dadd34f55e4a36d5409c2675a
URL:
https://github.com/llvm/llvm-project/commit/a1c0ba1646f5a80dadd34f55e4a36d5409c2675a
DIFF:
https://github.com/llvm/llvm-project/commit/a1c0ba1646f5a80dadd34f55e4a36d5409c2675a.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/33
>From d4e8921f4e00351c2906b08d2c2a1e9a4191c40e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 3 Oct 2024 13:31:07 +0100
Subject: [PATCH 1/3] [lldb][test] Add libcxx-simulators test for std::optional
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/23
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/33
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Nice! thanks!
https://github.com/llvm/llvm-project/pull/111353
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/33
Follow-up to the LLDB std::optional data-formatter test failure caused by
https://github.com/llvm/llvm-project/pull/110355.
Two formats are supported:
1. `__val_` has type `value_type`
2. `__val_`'s type is
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/23
>From 453d33171be0550737e2f6e5d7e182ef43c71c51 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 4 Oct 2024 10:16:18 +0100
Subject: [PATCH] Reland "[lldb][test]
TestDataFormatterLibcxxStringSimulator.py
Michael137 wrote:
Didn't manage to build LLDB on my Windows machine (and AFAICT we don't have
Windows PR testing). So hoping this will fix it.
https://github.com/llvm/llvm-project/pull/23
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/23
>From 453d33171be0550737e2f6e5d7e182ef43c71c51 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 4 Oct 2024 10:16:18 +0100
Subject: [PATCH] Reland "[lldb][test]
TestDataFormatterLibcxxStringSimulator.py
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/23
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/23
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/23
>From 27ff173e19c5391fe175a144f5bb6909a98289f9 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 4 Oct 2024 10:16:18 +0100
Subject: [PATCH 1/3] Reland "[lldb][test]
TestDataFormatterLibcxxStringSimulato
Michael137 wrote:
Hmm getting
```
Exit Code: 255
Command Output (stderr):
--
ERROR:root:"/home/runner/_work/llvm-project/llvm-project/build/bootstrapping-build/./bin/clang"
is not a valid compiler executable; aborting...
```
In the `[stage3 (bootstrapping-build,
libcxx-runners-8-set)](https://
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/33
>From d4e8921f4e00351c2906b08d2c2a1e9a4191c40e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 3 Oct 2024 13:31:07 +0100
Subject: [PATCH 1/2] [lldb][test] Add libcxx-simulators test for std::optional
https://github.com/Michael137 approved this pull request.
Given the discussion so far this seems like a good enough perf. improvement
without having to revamp the `FindFunctions` API. So lgtm, thanks for the
patience.
Please give it a couple of days before merging in case Greg (or someone else
Michael137 wrote:
Yea i think we need to run make sure the `check-lldb-api-deps` target gets run.
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From 288acdfef1126c5652bac126c80f4d36df5e40b2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/7] [lldb][CMake] Add single target that runs libc++ tests
---
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/110481
As this comment around target initialization implies:
```
// This can be NULL if we don't know anything about the architecture or if
// the target for an architecture isn't enabled in the llvm/clang that w
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110481
>From 0669f9fbeddaf81edfca7e81f4883a1b95a780f6 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 30 Sep 2024 10:53:47 +0100
Subject: [PATCH 1/3] [lldb][TypeSystemClang] Add warning and defensive checks
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110481
>From 0669f9fbeddaf81edfca7e81f4883a1b95a780f6 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 30 Sep 2024 10:53:47 +0100
Subject: [PATCH 1/2] [lldb][TypeSystemClang] Add warning and defensive checks
Michael137 wrote:
There's a couple more places we use these types unconditionally that I haven't
added checks to.
Should be testable by creating a `TypeSystemClang` with an empty triple and
calling one of these APIs on it.
https://github.com/llvm/llvm-project/pull/110481
_
Michael137 wrote:
Hmm seems like we can't currently run `dotest-param='--category'` on the API
test suite because of the simulator tests:
```
File
"/home/runner/_work/llvm-project/llvm-project/lldb/packages/Python/lldbsuite/test/test_result.py",
line 183, in startTest
self.hardMarkAsSkipp
Michael137 wrote:
looks like we dont deal with `__builtin_printf` on Windows very well. Will fix
https://github.com/llvm/llvm-project/pull/33
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: Michael Buch
Date: 2024-10-07T17:38:14+02:00
New Revision: 5e7cc374225e1704d0694da05e02f327cc0cf024
URL:
https://github.com/llvm/llvm-project/commit/5e7cc374225e1704d0694da05e02f327cc0cf024
DIFF:
https://github.com/llvm/llvm-project/commit/5e7cc374225e1704d0694da05e02f327cc0cf024.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/110856
>From 344819ad0ad1949aaf0469bfba4450674d8ec8cf Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 2 Oct 2024 15:44:28 +0100
Subject: [PATCH 1/8] [lldb][CMake] Add single target that runs libc++ tests
---
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/110856
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> > Skipping empty fields does seem like a better heuristic here
>
> FWIW, I (independently) came to the same conclusion when investigating the
> fallout of #76756, though it's not fully clear to me whether the PR has been
> updated to do that.
Not yet, but will have a look
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/112523
Follow up to https://github.com/llvm/llvm-project/pull/111902.
Makes sure all the `no_unique_address` tests are in the same place and we don't
rely on the host compiler.
Now that we don't compile with the h
Michael137 wrote:
> I would recommend that -- then you wouldn't need to worry about how to spell
> [[no_unique_address]] on windows.
https://github.com/llvm/llvm-project/pull/112523
https://github.com/llvm/llvm-project/pull/111902
___
lldb-commits ma
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> I guess it will with clang+lld (which is the only way we can run the test
> suite now), though I still find this suboptimal -- in particular, I think the
> multiple definition thingy plants us firmly into undefined behavior territory.
>
> Did you check that `at(0)` actually
Michael137 wrote:
As mentioned in
https://github.com/llvm/llvm-project/pull/98701#issuecomment-2416223393, the
test deliberately omits `at` from debug-info.
https://github.com/llvm/llvm-project/pull/112485
___
lldb-commits mailing list
lldb-commits@l
Michael137 wrote:
> We are seeing test failures on `lldb-api :: lang/cpp/stl/TestSTL.py` after
> this patch is landed.
>
> ```
> Error when building test subject.
>
> Build Command:
> /b/s/w/ir/x/w/cipd/bin/make
> VPATH=/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/lang/cpp/stl -C
> /b/s/w/i
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -453,7 +474,7 @@ static void GetTypeLookupContextImpl(DWARFDIE die,
break;
case DW_TAG_typedef:
push_ctx(CompilerContextKind::Typedef, die.GetName());
- break;
+ break;
Michael137 wrote:
something weird happened to the format here
ht
@@ -1032,10 +1032,16 @@ void SymbolFileCTF::FindTypes(const
lldb_private::TypeQuery &match,
ConstString name = match.GetTypeBasename();
for (TypeSP type_sp : GetTypeList().Types()) {
-if (type_sp && type_sp->GetName() == name) {
- results.InsertUnique(type_sp);
-
@@ -434,6 +442,19 @@ static void GetTypeLookupContextImpl(DWARFDIE die,
auto push_ctx = [&](CompilerContextKind kind, llvm::StringRef name) {
context.push_back({kind, ConstString(name)});
};
+
+// Since mangled names are unique there's no need to build an enti
@@ -2762,7 +2762,7 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
if (query.GetModuleSearch())
die_context = die.GetDeclContext();
else
- die_context = die.GetTypeLookupContext();
+ die_context = die.GetTypeLookupCont
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/112735
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/112748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Not sure how to best XFAIL this atm (really want to avoid just skipping it).
This currently crashes LLDB. Maybe we could make use of the AST dump, or the
expression log..
https://github.com/llvm/llvm-project/pull/112566
___
lldb-com
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/112566
This is a reduced test case from a crash we've observed in the past. The
assertion that this test triggers is:
```
Assertion failed: ((Pos == ImportedDecls.end() || Pos->second == To) && "Try to
import an al
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/112566
>From d8369837a10f0e4750dd6c0f6c6b4467931b5012 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 16 Oct 2024 15:48:47 +0100
Subject: [PATCH 1/2] [lldb][test] Add test for ASTImporter's name conflict
res
Michael137 wrote:
> I'll just note that `%clang_host` is not the host compiler (in the way that I
> understand the term). It's the clang we've just built, _configured_ to build
> for the (current) host.
Ooh I see, I didn't realize that. When would we not want to use `clangxx_host`
then? I gue
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,20 @@
+#ifndef SERVICE_H_IN
+#define SERVICE_H_IN
+
+struct ServiceAux;
+
+struct Service {
+ struct State;
+ bool start(State *) { return true; }
+
+#ifdef HIDE_FROM_PLUGIN
Michael137 wrote:
Yea unfortunately this is what the internal users are doin
1201 - 1300 of 2354 matches
Mail list logo