https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/105449
This patch introduces new `ScriptedStopHook{,Python}Interface` classes that
make use of the Scripted Interface infrastructure and makes use of it in
`StopHookScripted`.
It also relax the requirement on th
@@ -102,7 +102,7 @@ let Definition = "target" in {
DefaultUnsignedValue<1024>,
Desc<"Maximum number of characters to show when using %s in summary
strings.">;
def MaxMemReadSize: Property<"max-memory-read-size", "UInt64">,
-DefaultUnsignedValue<1024>,
+Defaul
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/105765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I could
> have sworn the only test failure I had before was in
> TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test case.
> Hmm.
I believe that failure is unrelated to your PR since
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Requires myst_parser 0.19.0 (specifically
> [executablebooks/MyST-Parser#696](https://github.com/executablebooks/MyST-Parser/pull/696))
> which is over a year old by now. Do we mandate any minimum version for these
> dependencies?
Kinda:
[llvm/docs/requirements.txt](htt
medismailben wrote:
Nice! Please make sure to run the python formatter (`darker`) before landing
this.
https://github.com/llvm/llvm-project/pull/105990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben commented:
Cool stuff! I think this is fine except for the python files.
https://github.com/llvm/llvm-project/pull/106163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -15,7 +15,7 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args:
lldb.SBStructuredData
def read_memory_at_address(
self, addr: int, size: int, error: lldb.SBError
) -> lldb.SBData:
-error.SetErrorString("This is an invalid scripted process!"
@@ -56,19 +56,41 @@ class Status {
///
/// \param[in] type
/// The type for \a err.
- explicit Status(ValueType err,
- lldb::ErrorType type = lldb::eErrorTypeGeneric);
+ explicit Status(ValueType err, lldb::ErrorType type =
lldb::eErrorTypeGeneric,
medismailben wrote:
It looks like this broke lldb macOS bots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10450/
@Jlalond can you take a look ? Thanks.
https://github.com/llvm/llvm-project/pull/105442
___
lldb-commits mailing
@@ -130,13 +120,17 @@ class DiagnosticManager {
m_diagnostics.back()->AppendMessage(str);
}
- // Returns a string containing errors in this format:
- //
- // "error: error text\n
- // warning: warning text\n
- // remark text\n"
+ /// Returns a string containing e
@@ -47,7 +48,34 @@ class Status {
/// into ValueType.
typedef uint32_t ValueType;
- Status();
+ /// A customizable "detail" for an error. For example, expression
+ /// evaluation failures often have more than one diagnostic that the
+ /// UI layer might want to render
@@ -65,6 +65,23 @@ std::string DiagnosticManager::GetString(char separator) {
return ret;
}
+Status DiagnosticManager::GetAsStatus(lldb::ExpressionResults result) {
+ llvm::SmallVector details;
+ details.reserve(m_diagnostics.size());
+ for (const auto &diagnostic : m_dia
@@ -328,18 +328,19 @@ UserExpression::Evaluate(ExecutionContext &exe_ctx,
}
if (!parse_success) {
- std::string msg;
- {
-llvm::raw_string_ostream os(msg);
-if (!diagnostic_manager.Diagnostics().empty())
- os << diagnostic_manager.Get
https://github.com/medismailben requested changes to this pull request.
Let's make `std::optional offset_in_command` a default member of the
`CommandObject` base class to avoid changing all the `DoExecute`
implementations, even when not needed.
https://github.com/llvm/llvm-project/pull/106470
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
@@ -33,16 +33,16 @@ class RemoteAwarePlatformTester : public
RemoteAwarePlatform {
MOCK_METHOD0(CalculateTrapHandlerSymbolNames, void());
MOCK_METHOD2(ResolveExecutable,
- std::pair(const ModuleSpec &,
- const FileSp
@@ -97,7 +97,7 @@ class LLDB_API SBError {
friend class lldb_private::ScriptInterpreter;
friend class lldb_private::python::SWIGBridge;
- SBError(const lldb_private::Status &error);
+ SBError(lldb_private::Status &&error);
medismailben wrote:
+1
https:
@@ -96,16 +128,49 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
+Status Status::FromExpressionError(lldb::ExpressionResults result,
+
@@ -27,15 +27,15 @@ TEST(StatusTest, Formatv) {
}
TEST(StatusTest, ErrorConstructor) {
- EXPECT_TRUE(Status(llvm::Error::success()).Success());
+ EXPECT_TRUE(Status::FromError(llvm::Error::success()).Success());
- Status eagain(
+ Status eagain = Status::FromError(
@@ -133,36 +198,30 @@ static std::string RetrieveWin32ErrorString(uint32_t
error_code) {
}
#endif
+std::string MachKernelError::message() const {
+#if defined(__APPLE__)
+ if (const char *s = ::mach_error_string(convertToErrorCode().value()))
+return s;
+#endif
+ return
https://github.com/medismailben approved this pull request.
This is great! LGTM with comments.
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM for lldb's part
https://github.com/llvm/llvm-project/pull/106505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/107968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/108462
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
medismailben wrote:
Guys, this sounds very cool, but I don't think I've seen any screenshot of what
medismailben wrote:
Seems to have been resolved in #72669
https://github.com/llvm/llvm-project/pull/72579
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/72579
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/73605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with comment.
https://github.com/llvm/llvm-project/pull/73605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,8 +32,8 @@ Progress::~Progress() {
std::lock_guard guard(m_mutex);
if (!m_completed) {
m_completed = m_total;
-ReportProgress();
}
medismailben wrote:
Remove the braces:
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simp
@@ -1402,22 +1402,24 @@ void Debugger::SetDestroyCallback(
static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id,
std::string title, std::string details,
uint64_t completed, uint64_t total,
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -55,6 +55,11 @@ namespace lldb_private {
class Progress {
public:
+ /// Enum that indicates the type of progress report
+ enum ProgressReportType {
medismailben wrote:
`enum class` ?
https://github.com/llvm/llvm-project/pull/69516
__
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/74687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
Author: Med Ismail Bennani
Date: 2023-07-06T14:33:52-07:00
New Revision: 1f5f4169c427c51c6919e0013c89a191dba564e8
URL:
https://github.com/llvm/llvm-project/commit/1f5f4169c427c51c6919e0013c89a191dba564e8
DIFF:
https://github.com/llvm/llvm-project/commit/1f5f4169c427c51c6919e0013c89a191dba564e8.
Author: Med Ismail Bennani
Date: 2023-07-21T18:47:46-07:00
New Revision: 57bd882343f8e4cca598b6ad47da93476cffb987
URL:
https://github.com/llvm/llvm-project/commit/57bd882343f8e4cca598b6ad47da93476cffb987
DIFF:
https://github.com/llvm/llvm-project/commit/57bd882343f8e4cca598b6ad47da93476cffb987.
Author: Med Ismail Bennani
Date: 2023-08-11T23:59:41-07:00
New Revision: f043e66e98836e3acf3c978fd0dc429f74b228da
URL:
https://github.com/llvm/llvm-project/commit/f043e66e98836e3acf3c978fd0dc429f74b228da
DIFF:
https://github.com/llvm/llvm-project/commit/f043e66e98836e3acf3c978fd0dc429f74b228da.
Author: Med Ismail Bennani
Date: 2023-08-11T23:59:42-07:00
New Revision: 8f75c4d01eff3c65d7ae40bfd05582de7dffa590
URL:
https://github.com/llvm/llvm-project/commit/8f75c4d01eff3c65d7ae40bfd05582de7dffa590
DIFF:
https://github.com/llvm/llvm-project/commit/8f75c4d01eff3c65d7ae40bfd05582de7dffa590.
Author: Med Ismail Bennani
Date: 2023-08-11T23:59:42-07:00
New Revision: 4677041d61dbe929e886649a97e4d3f49572b0ca
URL:
https://github.com/llvm/llvm-project/commit/4677041d61dbe929e886649a97e4d3f49572b0ca
DIFF:
https://github.com/llvm/llvm-project/commit/4677041d61dbe929e886649a97e4d3f49572b0ca.
Author: Med Ismail Bennani
Date: 2023-08-11T23:59:42-07:00
New Revision: 75bed9655a54c82e0485b28026605cb8e1f7c78a
URL:
https://github.com/llvm/llvm-project/commit/75bed9655a54c82e0485b28026605cb8e1f7c78a
DIFF:
https://github.com/llvm/llvm-project/commit/75bed9655a54c82e0485b28026605cb8e1f7c78a.
Author: Med Ismail Bennani
Date: 2023-08-11T23:59:42-07:00
New Revision: 706e875da3a21f2d6ba612ca991dbdbccb339327
URL:
https://github.com/llvm/llvm-project/commit/706e875da3a21f2d6ba612ca991dbdbccb339327
DIFF:
https://github.com/llvm/llvm-project/commit/706e875da3a21f2d6ba612ca991dbdbccb339327.
Author: Med Ismail Bennani
Date: 2023-08-18T20:50:39+01:00
New Revision: 7602641d7bf96b727e1739e2f68db1cadc27324a
URL:
https://github.com/llvm/llvm-project/commit/7602641d7bf96b727e1739e2f68db1cadc27324a
DIFF:
https://github.com/llvm/llvm-project/commit/7602641d7bf96b727e1739e2f68db1cadc27324a.
Author: Med Ismail Bennani
Date: 2023-08-18T20:50:39+01:00
New Revision: eef5eadbe617a9530d982a9ea3cfc284d2a52858
URL:
https://github.com/llvm/llvm-project/commit/eef5eadbe617a9530d982a9ea3cfc284d2a52858
DIFF:
https://github.com/llvm/llvm-project/commit/eef5eadbe617a9530d982a9ea3cfc284d2a52858.
Author: Med Ismail Bennani
Date: 2023-08-18T20:50:39+01:00
New Revision: 21a597c31cb8ad03e18a293c73ecd7c498387ef8
URL:
https://github.com/llvm/llvm-project/commit/21a597c31cb8ad03e18a293c73ecd7c498387ef8
DIFF:
https://github.com/llvm/llvm-project/commit/21a597c31cb8ad03e18a293c73ecd7c498387ef8.
Author: Med Ismail Bennani
Date: 2023-08-18T20:50:39+01:00
New Revision: 3054a0c4bc50856156f26b528895ddcfba4210fa
URL:
https://github.com/llvm/llvm-project/commit/3054a0c4bc50856156f26b528895ddcfba4210fa
DIFF:
https://github.com/llvm/llvm-project/commit/3054a0c4bc50856156f26b528895ddcfba4210fa.
Author: Med Ismail Bennani
Date: 2023-08-18T20:50:39+01:00
New Revision: 4c4f0d81f47cf9ad785dc2ea323ec2f0aedb72df
URL:
https://github.com/llvm/llvm-project/commit/4c4f0d81f47cf9ad785dc2ea323ec2f0aedb72df
DIFF:
https://github.com/llvm/llvm-project/commit/4c4f0d81f47cf9ad785dc2ea323ec2f0aedb72df.
Author: Med Ismail Bennani
Date: 2023-08-18T20:50:39+01:00
New Revision: 9a44eedb842d03b0e4d24f8dcc57a49e1a9cc1ac
URL:
https://github.com/llvm/llvm-project/commit/9a44eedb842d03b0e4d24f8dcc57a49e1a9cc1ac
DIFF:
https://github.com/llvm/llvm-project/commit/9a44eedb842d03b0e4d24f8dcc57a49e1a9cc1ac.
Author: Med Ismail Bennani
Date: 2023-08-18T23:29:40+01:00
New Revision: a3e6ac16ffc32e794da3f60150e903027f279f27
URL:
https://github.com/llvm/llvm-project/commit/a3e6ac16ffc32e794da3f60150e903027f279f27
DIFF:
https://github.com/llvm/llvm-project/commit/a3e6ac16ffc32e794da3f60150e903027f279f27.
Author: Med Ismail Bennani
Date: 2023-08-21T21:52:44+01:00
New Revision: 446abb5125f76423232e5d4d3ed116cccfbd8b99
URL:
https://github.com/llvm/llvm-project/commit/446abb5125f76423232e5d4d3ed116cccfbd8b99
DIFF:
https://github.com/llvm/llvm-project/commit/446abb5125f76423232e5d4d3ed116cccfbd8b99.
Author: Med Ismail Bennani
Date: 2023-08-23T07:32:35-07:00
New Revision: a6c97a1a308e413bda63cbeaa3bebe7b2e739902
URL:
https://github.com/llvm/llvm-project/commit/a6c97a1a308e413bda63cbeaa3bebe7b2e739902
DIFF:
https://github.com/llvm/llvm-project/commit/a6c97a1a308e413bda63cbeaa3bebe7b2e739902.
Author: Med Ismail Bennani
Date: 2023-08-24T15:41:16+01:00
New Revision: eea887406498d3a420ed0afbb654915a7e08e2ad
URL:
https://github.com/llvm/llvm-project/commit/eea887406498d3a420ed0afbb654915a7e08e2ad
DIFF:
https://github.com/llvm/llvm-project/commit/eea887406498d3a420ed0afbb654915a7e08e2ad.
Author: Med Ismail Bennani
Date: 2023-08-24T19:44:16+01:00
New Revision: dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7
URL:
https://github.com/llvm/llvm-project/commit/dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7
DIFF:
https://github.com/llvm/llvm-project/commit/dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7.
Author: Med Ismail Bennani
Date: 2023-08-26T09:54:56+01:00
New Revision: 6a2552a1419d674033c8d2f8bfeeb981a70a2e67
URL:
https://github.com/llvm/llvm-project/commit/6a2552a1419d674033c8d2f8bfeeb981a70a2e67
DIFF:
https://github.com/llvm/llvm-project/commit/6a2552a1419d674033c8d2f8bfeeb981a70a2e67.
Author: Med Ismail Bennani
Date: 2023-08-29T13:45:30+01:00
New Revision: 498b59e01133bed16c72dd939a9daa8ae1f359e4
URL:
https://github.com/llvm/llvm-project/commit/498b59e01133bed16c72dd939a9daa8ae1f359e4
DIFF:
https://github.com/llvm/llvm-project/commit/498b59e01133bed16c72dd939a9daa8ae1f359e4.
Author: Med Ismail Bennani
Date: 2023-08-29T13:57:35+01:00
New Revision: 18f1c1ace7a6099f3e8e56cf4b81aa0f64a7dd23
URL:
https://github.com/llvm/llvm-project/commit/18f1c1ace7a6099f3e8e56cf4b81aa0f64a7dd23
DIFF:
https://github.com/llvm/llvm-project/commit/18f1c1ace7a6099f3e8e56cf4b81aa0f64a7dd23.
Author: Med Ismail Bennani
Date: 2023-08-29T16:24:33+01:00
New Revision: f0731d5b61ba798e6d5a63a92d9228010e5a3b50
URL:
https://github.com/llvm/llvm-project/commit/f0731d5b61ba798e6d5a63a92d9228010e5a3b50
DIFF:
https://github.com/llvm/llvm-project/commit/f0731d5b61ba798e6d5a63a92d9228010e5a3b50.
Author: Med Ismail Bennani
Date: 2023-08-29T16:34:56+01:00
New Revision: 8e0a087571a31057bb98939e3ada73227bed83c7
URL:
https://github.com/llvm/llvm-project/commit/8e0a087571a31057bb98939e3ada73227bed83c7
DIFF:
https://github.com/llvm/llvm-project/commit/8e0a087571a31057bb98939e3ada73227bed83c7.
Author: Med Ismail Bennani
Date: 2023-08-29T16:52:30+01:00
New Revision: f2f5d6fb8d53bc4bd93a3d4e110134ed017b636f
URL:
https://github.com/llvm/llvm-project/commit/f2f5d6fb8d53bc4bd93a3d4e110134ed017b636f
DIFF:
https://github.com/llvm/llvm-project/commit/f2f5d6fb8d53bc4bd93a3d4e110134ed017b636f.
Author: Med Ismail Bennani
Date: 2023-08-31T16:31:10+01:00
New Revision: 380c5da98efa62920e9fbf3aa9a4fa8add236fb9
URL:
https://github.com/llvm/llvm-project/commit/380c5da98efa62920e9fbf3aa9a4fa8add236fb9
DIFF:
https://github.com/llvm/llvm-project/commit/380c5da98efa62920e9fbf3aa9a4fa8add236fb9.
Author: Med Ismail Bennani
Date: 2023-08-31T20:35:10+01:00
New Revision: 6813ef37377e8d8fadf6efe01e1ed80cc53b9c86
URL:
https://github.com/llvm/llvm-project/commit/6813ef37377e8d8fadf6efe01e1ed80cc53b9c86
DIFF:
https://github.com/llvm/llvm-project/commit/6813ef37377e8d8fadf6efe01e1ed80cc53b9c86.
Author: Med Ismail Bennani
Date: 2023-08-31T22:19:02+01:00
New Revision: c9ecaf32f6aa92f79a054478df55b4b8c3e53697
URL:
https://github.com/llvm/llvm-project/commit/c9ecaf32f6aa92f79a054478df55b4b8c3e53697
DIFF:
https://github.com/llvm/llvm-project/commit/c9ecaf32f6aa92f79a054478df55b4b8c3e53697.
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/6
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +40,40 @
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/medismailben edited
https://github.com/llvm/llvm-
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -103,6 +103,8
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -160,6 +166,10
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -160,6 +166,10 @@ class Language : public PluginI
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -27,6 +27,8 @@ class ObjCPlusPlusLanguage : publi
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
@@ -127,6 +127,8
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
@@ -38,7 +40,40 @@ Status CommandOptionsProcessLaunc
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/medismailben ap
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
medismailben wrote:
@junior-jl I'm actually in favor of adding a `st
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
medismailben wrote:
> Hi, @medismailben. I changed the code with you
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,
=?utf-8?q?Jos=C3=A9?= L. Junior ,Leandro Lupori
,David Spick
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
This looks great! Left a comment.
https://github.com/llvm/llvm-project/pull/83097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -694,27 +712,32 @@ void CommandObject::GenerateHelpText(Stream &output_strm)
{
}
}
-void CommandObject::AddIDsArgumentData(CommandArgumentEntry &arg,
- CommandArgumentType ID,
- CommandArgumentTy
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/83097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Yeay 🥳
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Does it make sense to have an image multiple times in the shared cache ? If
not, instead of saying `{Y/N count}` what about printing `{location(shared
cache/module collection)} and only print it ref count if it's not in the shared
cache ?
https://github.com/llvm/llvm-proje
medismailben wrote:
> Does it make sense to have an image multiple times in the shared cache ? If
> not, instead of saying `{Y/N count}` what about printing `{location(shared
> cache/module collection)}` and only print it ref count if it's not in the
> shared cache ?
My bad, I thought you wer
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Thanks for fixing this think-o and adding a test
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/83861
This patch should address some register parsing issue in the legacy report
format.
rdar://107210149
>From b3ad739752a6e07eeeda47055d17a12fc960adcb Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: S
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/83895
This patch addresses an oversight in `ProcessEventDataTest::SetUp` unittest to
ensure the Debugger is initialized properly.
>From 1ed521f9de503fd48834a250fb2f071c2d86b1c9 Mon Sep 17 00:00:00 2001
From: Med
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/83895
>From 0b71b6aafe6a11875ebdb77ecafd63d1ad4556f4 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 4 Mar 2024 11:25:07 -0800
Subject: [PATCH] [lldb/Test] Fix oversight in ProcessEventDataTest::SetUp
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/83895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/83861
>From 5cc9da6d222ff39f2939cdb725477e94f8fb24f8 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 4 Mar 2024 15:41:45 -0800
Subject: [PATCH] [lldb/crashlog] Fix breaking changes in textual report f
301 - 400 of 1129 matches
Mail list logo
