https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/93714
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with @labath's command.
https://github.com/llvm/llvm-project/pull/93833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94259
This patch changes the crashlog image loading default behaviour to not only
load images from the crashed thread but also for the application specific
backtrace thread.
This patch also move the Application
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94262
By default, the crashlog script only loads images for the crashed thread as
well as the application specific thread.
Prior to using SymbolFileJSON and ObjectFileJSON, it didn't make sense to
create stackfr
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94262
>From ec250e197e73b5743566db884152bea9c17dd4b9 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 3 Jun 2024 10:28:43 -0700
Subject: [PATCH] [lldb/crashlog] Create stackframes for non-crashed threa
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94259
>From d7bd20eb22896ff43ed2c840b1ede23c0f36aff9 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 4 Jun 2024 23:41:26 -0700
Subject: [PATCH] [lldb/crashlog] Always load Application Specific Backtra
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94513
This patch adds the `--no-parallel-image-loading` to the crashlog command. By
default, image loading will happen in parallel in the crashlog script however,
sometimes, when running tests or debugging the cr
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94517
In lldb, users can change the `dsymForUUID` binary using the
`LLDB_APPLE_DSYMFORUUID_EXECUTABLE` environment variable.
This patch changes the crashlog to support the same behaviour as lldb and uses
this en
@@ -555,30 +555,44 @@ def load_images(self, options, loaded_images=None):
futures = []
with tempfile.TemporaryDirectory() as obj_dir:
-with concurrent.futures.ThreadPoolExecutor() as executor:
-def add_module(image, target, obj_dir
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94513
>From eb62de94ceaf3ee440046a2884210fb4f8774edf Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 5 Jun 2024 12:28:59 -0700
Subject: [PATCH] [lldb/crashlog] Add `--no-parallel-image-loading` hidden
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1099,6 +1099,19 @@ static void
LLDBSwigPythonCallPythonSBDebuggerTerminateCallback(lldb::user_id_t
}
}
+static bool
LLDBSwigPythonCallPythonSBCommandInterpreterSetCommandOverrideCallback(void
*baton, const char **argv) {
+ bool b = false;
+ if (baton != Py_None) {
+
@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double
&number, PyObject *obj) {
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) {
+ if (!($input == Py_None ||
+PyCallable_Chec
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94513
>From cc405078245b248b2102f2b24272bee17e5ec752 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 5 Jun 2024 13:12:01 -0700
Subject: [PATCH] [lldb/crashlog] Add `--no-parallel-image-loading` hidden
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94513
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94553
This PR removes the `target-aarch64` requirement on the crashlog tests to
exercice them on Intel bots and make image loading single-threaded temporarily
while implementing a fix for a deadlock issue when lo
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94575
This patch makes interactive mode as the default when using the crashlog
command. It replaces the existing `-i|--interactive` flag with a new
`-m|--mode` option, that can either be `interactive` or `batch`.
medismailben wrote:
FWIW, this was already approved in https://reviews.llvm.org/D141658 but I've
updated it slightly to match to current version of the crashlog script.
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94553
>From 46eb924da3dcee4b43f22f0002cc21d3c01fb2f3 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 4 Jun 2024 20:36:53 -0700
Subject: [PATCH 1/2] [lldb/crashlog] Remove aarch64 requirement on crashl
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94553
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with nit.
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/95015
This patch tightens the assert check for the ABISP object in
`StopInfoMachException::DeterminePtrauthFailure`.
This causes some failure when debugging on a system that doesn't have pointer
authentification
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/95015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From bc3292a4cecdff503d5123a8dffe4ff32aff814d Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 10 Jun 2024 14:53:29 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
https://github.com/medismailben reopened
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Closed this by mistake.
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From f00c33948310576668bc886415cf98dbd1ab97be Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 10 Jun 2024 14:54:36 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From fd69e8f2bb83443b381dd11ebddac33676d5fdf3 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 10 Jun 2024 15:11:25 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
@@ -1794,8 +1802,35 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
@@ -110,6 +108,9 @@ bool
StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
strm.Printf("Note: Possible pointer authentication failure detected.\n");
};
+ ABISP abi_sp = process.GetABI();
+ assert(abi_sp && "Missing ABI info");
---
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/95015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -110,6 +108,9 @@ bool
StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
strm.Printf("Note: Possible pointer authentication failure detected.\n");
};
+ ABISP abi_sp = process.GetABI();
+ assert(abi_sp && "Missing ABI info");
---
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,119 @@
+/*
+ Typemaps specific to callback functions in LLDB. If editing this file
+ use the Python C API to access Python objects instead of using
PythonDataObjects.
medismailben wrote:
nit: it would be nice to put the Python C API documentation link
@@ -0,0 +1,119 @@
+/*
+ Typemaps specific to callback functions in LLDB. If editing this file
+ use the Python C API to access Python objects instead of using
PythonDataObjects.
+*/
+
+// For Log::LogOutputCallback
+%typemap(in) (lldb::LogOutputCallback log_callback, void *baton)
@@ -0,0 +1,119 @@
+/*
+ Typemaps specific to callback functions in LLDB. If editing this file
+ use the Python C API to access Python objects instead of using
PythonDataObjects.
+*/
+
+// For Log::LogOutputCallback
+%typemap(in) (lldb::LogOutputCallback log_callback, void *baton)
medismailben wrote:
LGTM, may be we could also support this for the command line
```
(lldb) target modules lookup -F square
1 match found in /tmp/step:
Address: step[0x00013ee8] (step.__TEXT.__text + 0)
Summary: step`square at step.c:3
(lldb) target modules lookup -F Squa
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/95350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From 3b239e683362e8f9a1a9f9b9904ef4f77f4a4b3a Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 12 Jun 2024 22:11:12 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
https://github.com/medismailben approved this pull request.
LGTM but all the formatting changes are a bit distracting, would be nice to be
have them in a separate commit.
https://github.com/llvm/llvm-project/pull/95871
___
lldb-commits mailing list
ll
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
This is great! LGTM with nits :)
https://github.com/llvm/llvm-project/pull/95768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -43,8 +43,7 @@ CompilerType RegisterTypeBuilderClang::GetRegisterType(
ScratchTypeSystemClang::GetForTarget(m_target);
assert(type_system);
- std::string register_type_name = "__lldb_register_fields_";
- register_type_name += name;
+ std::string register_type_nam
@@ -67,8 +66,33 @@ CompilerType RegisterTypeBuilderClang::GetRegisterType(
// We assume that RegisterFlags has padded and sorted the fields
// already.
for (const RegisterFlags::Field &field : flags.GetFields()) {
+ CompilerType field_type = field_uint_type;
+
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben requested changes to this pull request.
This is a good start but still requires some work.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
medismailben wrote:
Do you still need this ?
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -99,10 +99,15 @@ typedef std::optional
(*SymbolLocatorLocateExecutableSymbolFile)(
typedef bool (*SymbolLocatorDownloadObjectAndSymbolFile)(
ModuleSpec &module_spec, Status &error, bool force_lookup,
bool copy_executable);
-typedef bool (*BreakpointHitCallback)(void
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -99,10 +99,15 @@ typedef std::optional
(*SymbolLocatorLocateExecutableSymbolFile)(
typedef bool (*SymbolLocatorDownloadObjectAndSymbolFile)(
ModuleSpec &module_spec, Status &error, bool force_lookup,
bool copy_executable);
-typedef bool (*BreakpointHitCallback)(void
@@ -0,0 +1,93 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
https://github.com/medismailben approved this pull request.
LGTM, with comments addressed.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -43,8 +43,7 @@ CompilerType RegisterTypeBuilderClang::GetRegisterType(
ScratchTypeSystemClang::GetForTarget(m_target);
assert(type_system);
- std::string register_type_name = "__lldb_register_fields_";
- register_type_name += name;
+ std::string register_type_nam
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/96263
Reverts llvm/llvm-project#94575 since introduces test failure:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6166/
>From b9af881866b3702be5d5bf55f694d4eb051e2872 Mon Sep 17 00:00:00 20
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/96263
>From b9af881866b3702be5d5bf55f694d4eb051e2872 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 20 Jun 2024 18:19:26 -0700
Subject: [PATCH] Revert "[lldb/crashlog] Make interactive mode the new d
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/96263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,89 @@
+//===-- TestBreakpointSetCallback.cpp
+//===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
https://github.com/medismailben approved this pull request.
LGTM with comment
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Awesome! 🚢 it!
https://github.com/llvm/llvm-project/pull/96001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/102590
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -979,6 +988,8 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t
first_frame,
++num_frames_displayed;
}
+ if (filtered)
+strm << "Note: Some frames were hidden by frame recognizers\n";
medismailben wrote:
There is a `frame recognizer` m
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1048,6 +1048,9 @@ let Command = "thread backtrace" in {
Arg<"FrameIndex">, Desc<"Frame in which to start the backtrace">;
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
+ def threa
@@ -91,7 +91,7 @@ class StackFrameList {
size_t GetStatus(Stream &strm, uint32_t first_frame, uint32_t num_frames,
bool show_frame_info, uint32_t num_frames_with_source,
- bool show_unique = false,
+ bool show_unique = f
https://github.com/medismailben commented:
I think this is a pretty cool idea but can we make sure it works using python
frame recognizers. I believe the user should also have the ability to hide
certain frames if they want, like it doesn't have to be system or language
runtime frames.
https:
medismailben wrote:
> `lldbPluginScriptInterpreterPythonScriptedThreadPlanPythonInterface` quite a
> mouthful for just a single cpp file. Maybe all of the interfaces could be a
> part of a single library?
>
> That would end up with something like:
>
> ```
> D:\build-lldb\tools\lldb\source\Plu
medismailben wrote:
Originally, they were built in a single library and I added a cmake variable to
make it work but @bulbazord & @JDevlieghere were not too happy with that
approach. I think their argument was that if they're each different plugins,
they need to be built into separate librarie
@@ -1048,6 +1048,9 @@ let Command = "thread backtrace" in {
Arg<"FrameIndex">, Desc<"Frame in which to start the backtrace">;
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
+ def threa
medismailben wrote:
> Okay, that sort of makes sense. However, unless you actually want to be able
> to disable each of these plugins independently (which it sounds like you
> don't), then this is a very.. baroque way to achieve the desired effect (to
> have multiple (plugin) classes registere
@@ -123,8 +126,12 @@ class StackFrameRecognizerManager {
lldb::StackFrameRecognizerSP GetRecognizerForFrame(lldb::StackFrameSP frame);
lldb::RecognizedStackFrameSP RecognizeFrame(lldb::StackFrameSP frame);
+ /// Quick way to determine whether the list of recognizers has b
https://github.com/medismailben approved this pull request.
LGTM modulo comment.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
201 - 300 of 1129 matches
Mail list logo
