[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

https://github.com/medismailben approved this pull request. Nice! LGTM! https://github.com/llvm/llvm-project/pull/118814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lookup by name to SBValue.child (PR #118814)

medismailben wrote: > or, should we allow base classes to be looked up by name as well? I'd prefer the latter so they can used interchangeably. I like the fact that the subscript can be either an int or a string. https://github.com/llvm/llvm-project/pull/118814 ___

[Lldb-commits] [lldb] [lldb] Improve isolation between Process plugins and OS plugins (PR #125302)

https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/125302 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a progress event for executing an expression (PR #119757)

@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager &diagnostic_manager, const EvaluateExpressionOptions &options, lldb::UserExpressionSP &shared_ptr_to_me, lldb::ExpressionVariableSP &result_va

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured errors in SBError (PR #120784)

medismailben wrote: LGTM. nit: I'd have called the API `SBError::GetStructuredError`. https://github.com/llvm/llvm-project/pull/120784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

@@ -473,6 +473,38 @@ class Platform : public PluginInterface { LLVM_PRETTY_FUNCTION, GetName())); } + /// Search CU for the SDK paths the CUs was compiled against. In the + /// presence of different SDKs, we try to pick the most appropriate + /// one

[Lldb-commits] [lldb] [lldb] Add a per-CU API to read the SDK (PR #119022)

@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module &module) { return path_or_err->str(); } + +llvm::Expected> +PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) { + ModuleSP module_sp = unit.CalculateSymbolContextModule(); + if (!module_sp)

[Lldb-commits] [lldb] [lldb] Implement ${target.file} format variable (PR #123431)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/123431 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb_assert -> _lldb_assert (NFC) (PR #123225)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/123225 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Fix typo in error message when creating a target (PR #122514)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/122514 This fixes a typo when creating a target from the crashlog script and that we were not able to find a valid architecture from the crash report. rdar://137344016 >From 4b25769382f81fd03553703624e8b8e48d83a

[Lldb-commits] [lldb] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue API (PR #126901)

https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/126901 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

@@ -46,22 +46,82 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args: lldb.SBStructuredData if len(self.threads) == 2: self.threads[len(self.threads) - 1].is_stopped = True -corefile_module = self.get_module_with_name( -self.co

[Lldb-commits] [lldb] [lldb] Document behavior in process launch help (PR #128215)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/128215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

@@ -453,22 +455,16 @@ ScriptedProcess::GetLoadedDynamicLibrariesInfos() { if (!dict->HasKey("load_addr")) return error_with_message("Dictionary is missing key 'load_addr'"); +llvm::StringRef path = ""; medismailben wrote: If you're using a new `

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/127153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

medismailben wrote: > @jimingham @medismailben Can you please let me know if you have more > questions regarding the problem and solution ? Right now, I have > conditionally ignored the modules which are not created and only loaded the > successful ones, if needed I can always load the success

[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)

@@ -76,6 +77,18 @@ bool ThreadPlanShouldStopHere::DefaultShouldStopHereCallback( } } + // Check whether the frame we are in is a language runtime thunk, only for + // step out: + if (operation == eFrameCompareOlder) { +Symbol *symbol = frame->GetSymbolContext(eSym

[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)

https://github.com/medismailben approved this pull request. Nice! LGTM with comment. https://github.com/llvm/llvm-project/pull/127419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

medismailben wrote: I'd like to get a better understanding of what you're trying to achieve: Does the child elf-core process doesn't have any module loaded ? Are they only described in the tombstone and require to be downloaded which could potentially fail ? https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb] Support stepping through C++ thunks (PR #127419)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/127419 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

medismailben wrote: I'm not convinced of that this change needs to be happen in ScriptedProcess ... May be we could have a setting to not discard all modules loaded in case 1 of them failed to load that would also work with other Process plugins. @jimingham what do you think ? https://github.

[Lldb-commits] [lldb] Control the "step out through thunk" logic explicitly when pushing thread plans (PR #129301)

medismailben wrote: Sorry for the delay, LGTM https://github.com/llvm/llvm-project/pull/129301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

@@ -79,34 +136,124 @@ class ThreadMemory : public lldb_private::Thread { } bool SetBackingThread(const lldb::ThreadSP &thread_sp) override { -// printf ("Thread 0x%llx is being backed by thread 0x%llx\n", GetID(), -// thread_sp->GetID()); m_backing_thread_sp =

[Lldb-commits] [lldb] [lldb] Fix missing overloads in ThreadMemory (PR #132734)

@@ -38,23 +38,82 @@ class ThreadMemory : public lldb_private::Thread { } const char *GetName() override { -if (!m_name.empty()) - return m_name.c_str(); if (m_backing_thread_sp) return m_backing_thread_sp->GetName(); return nullptr; } cons

[Lldb-commits] [lldb] Fix the managing of the session dictionary when you have nested wrappers (PR #132846)

https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/132846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

@@ -744,6 +744,10 @@ let Command = "process continue" in { Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to, temporarily " "ignoring other breakpoints. Can be specified more than once. " "The continue action will be done synchronously if this o

[Lldb-commits] [lldb] [lldb] Highlight basenames in backtraces (PR #137301)

medismailben wrote: > Not to derail this too much, but I'm also thinking if we should _stop_ > coloring the column number. Happy to open a patch if people think this is a > good idea? I don't have a strong opinion on this but I'm curious on why coloring the column number is bothering you spec

[Lldb-commits] [lldb] [lldb/Format] Make progress count show thousands separators (NFC) (PR #137446)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/137446 This patch changes the progress count formatting show thousands separator making it easier to read big numbers. >From a293b8b3cd50037998db82b4cd2298489b8b5499 Mon Sep 17 00:00:00 2001 From: Med Ismail Benn

<    7   8   9   10   11   12