[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 created this revision. n1tram1 added reviewers: k8stone, JDevlieghere, clayborg. n1tram1 added a project: LLDB. Herald added a subscriber: lldb-commits. n1tram1 added a reviewer: jasonmolenda. Currently lldb's SourceManager will check a source file for any updates each time it accesses it

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 updated this revision to Diff 258509. n1tram1 added a comment. Apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78421/new/ https://reviews.llvm.org/D78421 Files: lldb/include/lldb/Core/SourceManager.h lldb/source/Core/S

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 updated this revision to Diff 258527. n1tram1 added a comment. Check the modification time against the current selected module. (Previous patch was only checking against the current target's executable/main module) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 marked 3 inline comments as done. n1tram1 added a comment. Fixed in latest patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78421/new/ https://reviews.llvm.org/D78421 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 updated this revision to Diff 258705. n1tram1 added a comment. Fix the latest patch. (I hope I got it right this time, sorry it's my first time doing this) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78421/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 added a comment. In D78421#1993030 , @jingham wrote: > So you check the currently selected frame's module - which is libbar.dylib > and find that it was built before FileFromNotBar.c and would show me the old > version. > > Showing me the latest

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 updated this revision to Diff 261742. n1tram1 added a comment. Have the File first check if it is the current stack frame being displayed and check if it needs an update that way. Else, iteratively look for it's belonging module and check if it needs an update. Also fix the SourceCache:

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 added a comment. Passing a simple `Module &` sounds like an easy but I would also have to make `SourceManager::GetFile` take a `Module &`. There is one corner case, let's say file.c is being used by //Module A// and //Module B// (which are both shared libraries). If //file.c// is modif

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 added a comment. In D78421#2060327 , @labath wrote: > So, I'm not actually convinced that this is an improvement... This is exactly what is was worried about, I'm not sure either. The only thing I thought was a bug is the fact the lldb shows you