When trying to parse the -break-insert arguments as a named location,
the string parsing was not configured to allow directory paths. This
patch adds a constructor to allow the parsing of string as directory
path along with the other parameters.
This fixes https://llvm.org/bugs/show_bug.cgi?id=287
When trying to parse the -break-insert arguments as a named location,
the string parsing was not configured to allow directory paths. This
patch adds a constructor to allow the parsing of string as directory
path along with the other parameters.
This fixes https://llvm.org/bugs/show_bug.cgi?id=287
malaperle updated this revision to Diff 66055.
malaperle added a comment.
The test actually already existed but now it passed.
https://reviews.llvm.org/D22902
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
tools/lldb-mi/MICmdArgValString.cpp
tools/lldb-mi/MI
malaperle added a comment.
BTW, I had trouble running the lldb-mi tests. There seems to be a bug in
dotest.py.
lldbMiExec = lldbtest_config.lldbExec + "-mi"
I used 'python dotest.py --executable /path/to/llvm/build/bin/lldb
This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-
malaperle added a comment.
In https://reviews.llvm.org/D22902#500174, @malaperle wrote:
> This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-4.0.0-mi
> doesn't exist. I'm not sure if there either a way to not make it resolve the
> symlink or if the script should be changed.
B
malaperle added a comment.
Thanks! Newcomer silly question: now that the change is accepted, is there any
action required on my end?
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
malaperle added a comment.
Would it be possible to apply this fix to the release_39 branch?
Repository:
rL LLVM
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: malaperle
Date: Mon Oct 29 20:10:41 2018
New Revision: 345563
URL: http://llvm.org/viewvc/llvm-project?rev=345563&view=rev
Log:
[lldb-mi] Implement -gdb-set breakpoint pending on/off
Summary:
This allows creating pending breakpoint automatically when a location is not
found.
This is used
