[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. Gentle ping? Repository: rL LLVM https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1268810, @MaskRay wrote: > And there is no reviewers set :) I don't know who to add. Repository: rL LLVM https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 170301. malaperle added a comment. Clang-format it https://reviews.llvm.org/D52953 Files: packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py tools/lldb-mi/MICmdCmdBreak.cpp tools/lldb-mi/MICmdCmdGdbSet.cpp tools/lldb-mi/MICmdCm

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 171388. malaperle added a comment. Convert to lit test, convert some code to an early return, clang-format. https://reviews.llvm.org/D52953 Files: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test lit/tools/lldb-mi/breakpoint/inputs/break-

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 171415. malaperle added a comment. Fixes to lit test https://reviews.llvm.org/D52953 Files: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c tools/lldb-mi/MICmdCmdBreak.cpp to

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4 +# +# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g +# RUN: %lldbmi < %s | FileCheck %s apolyakov wrot

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1278331, @apolyakov wrote: > I ran the test and got a fail: Can you paste the full input of the failure? You can add "--dump-input-on-failure" arg to FileCheck in the test. The test passes for me but it might be that a regex needs

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4 +# +# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g +# RUN: %lldbmi < %s | FileCheck %s apolyakov wrote: > malaperle wrote: > > apolyakov wrote: >

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 171436. malaperle added a comment. Remove need for second -file-exec-and-symbols https://reviews.llvm.org/D52953 Files: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c tools/ll

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle updated this revision to Diff 171451. malaperle added a comment. Simply checks I think those =breakpoint-modified checks are a bit overzealous. The important check is whether of not we hit the breakpoint in a resolved location, i.e. not 0x. So, at the *stopped. The presence and

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1278491, @malaperle wrote: > Simply checks *Simplify https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

malaperle added a comment. In https://reviews.llvm.org/D52953#1278523, @apolyakov wrote: > LGTM. Thanks a lot! https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

This revision was automatically updated to reflect the committed changes. Closed by commit rL345563: [lldb-mi] Implement -gdb-set breakpoint pending on/off (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D52953?vs=171451&id=171629#toc Repository: rL